Commit graph

68 commits

Author SHA1 Message Date
Paolo Amadini
5558edcb22 Bug 1524787 - Part 5 - Optimize incremental filtering and work around bug 1480477 in the new "about:config" page. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19515

--HG--
extra : rebase_source : e20b2df0c323a8f94c108e0ca1eebcd042614deb
2019-02-12 14:15:13 +00:00
Paolo Amadini
0a96a73a97 Bug 1524787 - Part 4 - Sort the preferences list only when it changes. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19514

--HG--
extra : rebase_source : ce34955b1b8a20bbda31ac36a3c32f56712ea330
2019-02-12 14:08:04 +00:00
Paolo Amadini
80601b0867 Bug 1524787 - Part 3 - Only set the class name once when the state changes. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19513

--HG--
extra : rebase_source : 1234988743e9bb43c6f2fb69169393f88ad74b02
2019-02-12 14:09:25 +00:00
Paolo Amadini
aa70ae1696 Bug 1524787 - Part 2 - Use an expando property instead of a WeakMap. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19512

--HG--
extra : rebase_source : 05ba7c12d4e78e526cb01279e52293f198143714
2019-02-12 14:07:07 +00:00
Paolo Amadini
a64d4d9486 Bug 1524787 - Part 1 - Reduce calls to getElementById. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19511

--HG--
extra : rebase_source : 199318d2c94ba0b0a7928c0a9fc0c320c33862c5
2019-02-12 14:05:27 +00:00
Paolo Amadini
123c21759e Bug 1526426 - Fix name and value cell padding in the new "about:config" page. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D19184

--HG--
extra : rebase_source : 6b212520f81ed5db2001678e894580e1aab9e628
2019-02-11 16:01:30 +00:00
matthias
c3f36d17fb Bug 1524336 - Make about:config rows more compact. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D18818

--HG--
extra : moz-landing-system : lando
2019-02-06 11:37:20 +00:00
Dão Gottwald
c7be25c4b0 Bug 1525304 - Automatically apply "primary" style to buttons with autofocus. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18696

--HG--
extra : moz-landing-system : lando
2019-02-05 18:30:29 +00:00
Noemi Erli
a7e678bf3c Backed out changeset 1759b7e69caf (bug 1525304) for mochitest failures in browser_clipboard.js 2019-02-05 20:18:40 +02:00
Razvan Maries
f86459d5dc Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-02-05 18:59:13 +02:00
Dão Gottwald
500b02daa9 Bug 1525304 - Automatically apply "primary" style to buttons with autofocus. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18696

--HG--
extra : moz-landing-system : lando
2019-02-05 16:13:50 +00:00
Paolo Amadini
8a17e7e5de Bug 1524957 - Part 2 - Prevent autocomplete suggestions from other pages in the search field. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D18564

--HG--
extra : rebase_source : cb7b3f4165fab31d3d79ae17c47826ae2e0b160d
2019-02-04 15:58:47 +00:00
Paolo Amadini
44cd800596 Bug 1524957 - Part 1 - Move the main content to a template. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D18563

--HG--
extra : rebase_source : 52282ba2860920ea1fcbc0311687b2243909a01d
2019-02-04 15:15:52 +00:00
Paolo Amadini
6122083141 Bug 1524080 - Improve accessibility of the new "about:config" warning page. r=Jamie
The main section now has an "alertdialog" role, and the button is focused by default.

Differential Revision: https://phabricator.services.mozilla.com/D18502

--HG--
extra : rebase_source : b15e955b5bf7166f6661a2a731aaeaf8bd67d1dd
2019-02-03 14:02:46 +00:00
Paolo Amadini
5cad1ab7d9 Bug 1524372 - Localize the preference type in the new "about:config" page. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D18509

--HG--
extra : rebase_source : 1eb8e1978c7bd0f5eb3362a3338f9e2fba09ec3b
2019-02-04 15:13:14 +00:00
Paolo Amadini
2b8c933ad7 Bug 1522110 - Enable translation of the Desktop-specific "about:config" page. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D17360

--HG--
rename : browser/components/aboutconfig/content/aboutconfig.notftl => browser/locales/en-US/browser/aboutConfig.ftl
extra : rebase_source : d272b165d3ac6a11faa3f66ac6c093b726f318b9
2019-01-23 15:16:07 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Paolo Amadini
d5f7d8afde Bug 1522115 - Prevent the new "about:config" search field from moving slightly when the page is scrolled. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D17392

--HG--
extra : rebase_source : 9112bb0d5d5d353e91a8a828e4ff4f03aaaa213f
2019-01-24 18:58:26 +00:00
Paolo Amadini
8839f4e7b5 Bug 1521797 - Don't run the new "about:config" tests on debug builds for bug 1507747. r=bgrins
The search field is now focused by the test code as part of intialization, which may cause the intermittent leak in bug 1507747 to surface.

Differential Revision: https://phabricator.services.mozilla.com/D17506

--HG--
extra : rebase_source : dfcc023ab23948869bacee14dfc1a00d51b24c0a
2019-01-23 22:53:21 +00:00
Paolo Amadini
3848c7cbfb Bug 1522168 - Part 2 - Reduce the number of calls to the preferences service. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17505

--HG--
extra : rebase_source : c78591cc0e62daf606b8d63e5f993a420a966d6d
2019-01-24 18:34:13 +00:00
Paolo Amadini
4199aa476a Bug 1522168 - Part 1 - Lazify the creation of table row elements. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17504

--HG--
extra : rebase_source : 7f3cef5820bb7ef30e6a5864c3dce4312c841d85
2019-01-24 18:33:57 +00:00
Paolo Amadini
dcf226d693 Bug 1506382 - Make the new "about:config" page more easily navigable with accessibility technology. r=Jamie,flod
Differential Revision: https://phabricator.services.mozilla.com/D17125

--HG--
extra : rebase_source : ce4e4a18b019d825c9bd32e52c1109337503c5fa
2019-01-21 14:23:21 +00:00
Paolo Amadini
07b92644f8 Bug 1520743 - Request longer timeout for "about:config" tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D16821

--HG--
extra : rebase_source : 6ff0c06cfcf63883863366734a3329cb803e1917
2019-01-17 13:08:53 +00:00
Paolo Amadini
7a5bf28760 Bug 1520829 - Fix the sticky positioning of the search field. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D16865

--HG--
extra : rebase_source : fa1cf4d4d37f7fb56c622de100f95ca63a95ac4e
2019-01-17 16:26:38 +00:00
Paolo Amadini
4d0b0eb2bb Bug 1520484 - Don't observe preference changes before the first search. r=mak
This fixes an intermittent failure due to preferences being added in the background.

Differential Revision: https://phabricator.services.mozilla.com/D16703

--HG--
extra : rebase_source : 6ddd37a3c46758960184e0fac52d041bb4c3280c
2019-01-16 15:00:45 +00:00
Paolo Amadini
de5faa5148 Bug 1520398 - Disable the "about:config" tests on ASAN builds. r=mak
These tests are very resource intensive on instrumented builds because they open and close pages with many DOM nodes several times, and this may result in intermittent timeouts.

Differential Revision: https://phabricator.services.mozilla.com/D16682

--HG--
extra : rebase_source : 997a0d6e35f90dba2aaf4e1739a3889c51ad7c63
extra : amend_source : 25b25f8e92f3bfa027f3c26cbd2ed76186981c7b
2019-01-16 13:38:00 +00:00
Paolo Amadini
990242fc19 Bug 1503540 - Don't show all values until the list is filtered. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D16693

--HG--
extra : rebase_source : 9e2b07569804ce9fb0ac4e5ba65f619ecfd1e65b
2019-01-16 12:08:43 +00:00
Paolo Amadini
347205d643 Bug 1501417 - Part 2 - Don't wait for the Enter key in the new "about:config" search field. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16310

--HG--
extra : rebase_source : ac093624c1d7a02e56da4e567d6d33f502325a6e
2019-01-15 14:37:30 +00:00
Paolo Amadini
64e2c3597b Bug 1501417 - Part 1 - Use the search string set in previous sessions. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16309

--HG--
extra : rebase_source : c64b56a9013bdb6145b2c71c0d00400e53019cb1
2019-01-15 14:22:16 +00:00
Paolo Amadini
8df9d6843c Bug 1501411 - Make sure that copying preference values from the new "about:config" page preserves whitespace. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16056

--HG--
extra : rebase_source : de02625fed68f99e5daa6b3a9e783f9b985897eb
2019-01-15 14:21:07 +00:00
Paolo Amadini
eb32faadee Bug 1501410 - Part 4 - Make the filter case insensitive. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15947

--HG--
extra : rebase_source : b3a2788b0ac8444b2942aa6aeeacd4a5c954ec90
2019-01-08 15:08:04 +00:00
Paolo Amadini
9074b09f09 Bug 1501410 - Part 3 - Detect changes in preferences. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15946

--HG--
extra : rebase_source : ccaf6bfb2142a0e8cc35d8917c368d524f88648c
2019-01-08 15:26:11 +00:00
Paolo Amadini
1c6a8a588a Bug 1501410 - Part 2 - Add support for recovering deleted preferences. r=bgrins
This updates the user interface for adding new preferences to be closer to the mockup, and makes deleted preferences more similar to rows that are not added yet. This will later make it simpler to react to external changes in the underlying data.

Differential Revision: https://phabricator.services.mozilla.com/D15945

--HG--
extra : rebase_source : dbd4bc08ea1a75ae534dce327103f854ef84f8dc
2019-01-15 23:48:11 +00:00
Paolo Amadini
9da6d02ee2 Bug 1501410 - Part 1 - Optimize the variables containing the global state. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15944

--HG--
extra : rebase_source : dfe1baba6b1c0731d5fb12cbe4152067e997008c
2019-01-08 15:25:49 +00:00
Paolo Amadini
24cff8e905 Bug 1517507 - Part 4 - Move the editing code to the PrefRow class. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15665

--HG--
extra : rebase_source : e5516cd3c19284f20052c307aadd0c8a25f4b369
extra : amend_source : 7a5ae4155018816e2a83ac8d78d47357aff1dfb6
2019-01-08 11:48:41 +00:00
Paolo Amadini
408c7eca26 Bug 1517507 - Part 3 - Share the table row creation and update code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15664

--HG--
extra : rebase_source : cb05da81aca921417af98132537e1b03b6d06f53
extra : amend_source : d2509aede2d31582598d002aed1e7f0a0955b6c7
2019-01-08 11:48:29 +00:00
Paolo Amadini
1b5ec2acdf Bug 1517507 - Part 2 - Improve validation of numeric input. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15663

--HG--
extra : rebase_source : 372f27d0b869ae9f50c465521287d434fdb7ccb5
extra : amend_source : ed009bc1c00bd716ee19c728c72d5adf3a08198f
2019-01-08 11:48:18 +00:00
Paolo Amadini
0062e173ba Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15567

--HG--
extra : rebase_source : 4cd398779ab5baa3e404db2574ea37b13b39ae6a
extra : source : 798c09311606328e8c7374468b16859113ab883c
2019-01-02 11:54:17 +00:00
Paolo Amadini
ab65ea678c Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15570

--HG--
extra : rebase_source : 18241513d31c883b83d5e5e3ddbaa9b93a629b9e
extra : source : 8dcd5d5e815ddea060c89a7cffd2d075aadf8ab2
2019-01-03 13:27:22 +00:00
Paolo Amadini
4a00b6c301 Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15569

--HG--
extra : rebase_source : 0d67f46c617fc7a9131b34aa7059d7e3e0115a9d
extra : source : f0489fc1ef50db55b5af0e3d0a741ed1ab23b3e3
2019-01-02 09:57:59 +00:00
Margareta Eliza Balazs
35be7fb45b Backed out 3 changesets (bug 1517213) for ES lint failure in /browser/components/aboutconfig/test/browser/browser_edit.js CLOSED TREE
Backed out changeset 798c09311606 (bug 1517213)
Backed out changeset 8dcd5d5e815d (bug 1517213)
Backed out changeset f0489fc1ef50 (bug 1517213)
2019-01-03 13:47:33 +02:00
Paolo Amadini
24710db1a3 Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15567

--HG--
extra : rebase_source : 2aa1cedd806526070f6d82d4be0a509752397e9f
2019-01-02 11:54:17 +00:00
Paolo Amadini
c40ecd9e72 Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15570

--HG--
extra : rebase_source : e9488b9881ed9c88c7c9c28539cee0d3436bb60e
2019-01-02 11:53:39 +00:00
Paolo Amadini
14cde5bc12 Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15569

--HG--
extra : rebase_source : 8abc94ef54a96e1407957191038e515944468b43
2019-01-02 09:57:59 +00:00
Paolo Amadini
5bd38eeedd Bug 1516957 - Part 4 - Share the search function. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15516

--HG--
extra : rebase_source : 3eef00b8c8ff20416f7aa707d5d7cb935a799177
2018-12-31 12:15:50 +00:00
Paolo Amadini
f9667c41fa Bug 1516957 - Part 3 - Share more test functions. r=bgrins
This results in querying the document more often, but makes the test code more concise.

Differential Revision: https://phabricator.services.mozilla.com/D15515

--HG--
extra : rebase_source : b66e0c4eea62d063ea052d0ab02120b1a467f357
2018-12-31 12:15:38 +00:00
Paolo Amadini
11bc41af90 Bug 1516957 - Part 2 - Create a base test class and unify tab creation functions. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15514

--HG--
extra : rebase_source : 5fa8642aea770c30bbdc39dd579adbdb4ff881f5
2018-12-31 11:42:00 +00:00
Paolo Amadini
eba1895081 Bug 1516957 - Part 1 - Remove uses of ContentTask from the new "about:config" tests. r=bgrins
Uses of ContentTask can be removed because the page will continue to be loaded in the parent process for the time being. We don't want to give generic write access to preferences to the content processes until there is a way to separate privileged browser pages from regular web content using different process types.

Differential Revision: https://phabricator.services.mozilla.com/D15513

--HG--
extra : rebase_source : c07c2875858e4624ba3afb31782e0980cba10e0d
2018-12-31 11:41:48 +00:00
matthias
b08490b419 Bug 1500542 - Added ability to disable the disclaimer page of the new about:config. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D13870

--HG--
extra : rebase_source : 0a61cad5f9cd8b8db7def0c65780c7e97629ec8b
extra : amend_source : 5d74cf113c24d150369e9a5ca6b4035b75f1ec89
2018-12-13 14:26:20 +00:00
matthias
ab31f82d87 Bug 1500536 - Added disclaimer page for the new about:config. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D13867

--HG--
extra : rebase_source : 114546b72a06ad4b2f214c2695d10c076390f077
extra : amend_source : bdeda51514a22f23e6e9da13f0c8caeb6921bd63
2018-12-13 14:25:28 +00:00