Commit graph

67 commits

Author SHA1 Message Date
Luca Greco
3e8c931f9b Bug 1446027 - Prevents synchronous uninterruptible reflow from ExtensionPopups.jsm. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D12158

--HG--
extra : moz-landing-system : lando
2019-01-30 20:08:08 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Rob Wu
9ee0822242 Bug 1518598 - Return early if popup has already been closed r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D16033

--HG--
extra : moz-landing-system : lando
2019-01-15 18:50:49 +00:00
Gijs Kruitbosch
76afb51661 Bug 1493655 - make nsISecureBrowserUI initialize from a docshell instead of a window, r=keeler,nika
This also removes the (afaict, unused) stub implementation from TabParent. The netwerk header
inclusions were necessary because those files included TabParent.h and through it,
nsISecureBrowserUI, but now TabParent.h no longer does that.

Differential Revision: https://phabricator.services.mozilla.com/D6829

--HG--
extra : moz-landing-system : lando
2018-09-26 17:48:38 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Cosmin Sabou
1c8ad7b4ba Merge mozilla-inbound to mozilla-central. a=merge 2018-08-15 03:51:45 +03:00
Brian Grinstead
829d7647d3 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275

--HG--
extra : moz-landing-system : lando
2018-08-14 16:22:44 +00:00
Kris Maglione
f99ee35b82 Bug 1480244: Part 5 - Run most framescripts in shared scope. r=mconley
Creating non-shared scopes for frame scripts is fairly expensive. After these
changes it's even more expensive. However, many frame scripts have no use for
the shared scopes at all. Run-once scripts which execute in closures, for
instance, make no use of them. And after bug 1472491, neither do most of our
default frame scripts.

MozReview-Commit-ID: 9PK7bYdQ0yh

--HG--
extra : rebase_source : db2516d2f00a75e233e1957649f2b62a9299b7cd
2018-08-10 13:58:18 -07:00
Kris Maglione
4470001b70 Bug 1452514: Correctly handle a browser window closing before its popups do. r=mixedpuppy
MozReview-Commit-ID: DOqfniMPf87

--HG--
extra : rebase_source : 5945da4ce1496c984448bc05c86efcbc27645c88
2018-07-19 19:03:20 -07:00
Kris Maglione
fcedebb912 Bug 1471102: Move more code out of ExtensionUtils.jsm. r=aswan
MozReview-Commit-ID: Fqlv5BRuuW8

--HG--
extra : rebase_source : 348f037abd9cecfa080183bc365e5f005eac1bd6
extra : amend_source : 05dbfd12f553fc3f2a93374402e34d271e26d767
2018-06-25 19:30:21 -07:00
Jared Wein
1ee5bff85e Bug 1459066 - Overflow menu WebExtension subview header should use the default browser styling instead of the extension's styling. r=mixedpuppy
MozReview-Commit-ID: EtQ6VS5OH0e

--HG--
extra : rebase_source : 8e557423fa443d40e8db69dc46bad2709a11b38e
2018-05-07 13:06:46 -04:00
Dorel Luca
8ee8fc461e Backed out 2 changesets (bug 1317581) for Browser chrome failures on toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js. CLOSED TREE
Backed out changeset 5cc146254899 (bug 1317581)
Backed out changeset 963466173a74 (bug 1317581)
2018-04-18 18:54:38 +03:00
Jared Wein
7ee1860850 Bug 1317581 - DateTimePicker should support high contrast mode on Windows. r=dao
MozReview-Commit-ID: DEBBjcgHIyH

--HG--
extra : rebase_source : 9b52b15a0af9a56ad724dd578884856d4d5e7e20
2018-03-22 13:01:28 -04:00
Mark Striemer
ddc263525f Bug 1397809 - Part 1: Convert New Tab doorhanger to a generic class r=aswan,Gijs
MozReview-Commit-ID: 40RwrXjtsJJ

--HG--
extra : rebase_source : f688846407d32d3ec68ef96ea7432da9ed08a145
2017-12-19 13:56:04 -06:00
Jared Wein
5c4c017fb8 Bug 1453803 - Increase the opacity of the default border color for WebExtension popups. r=ntim
MozReview-Commit-ID: AeDmPJtPdBE

--HG--
extra : rebase_source : 56a6e4231e55770cd8d488941b2fd0ce1f69fe89
2018-04-12 18:48:39 -04:00
Jared Wein
4181599591 Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r=mixedpuppy
MozReview-Commit-ID: CVXySkhYaem

--HG--
extra : rebase_source : b744e0fc1a23997d6d92af4b12e9a6d3b00fecbf
2018-03-30 15:29:31 -07:00
Kris Maglione
b2ea14013a Bug 1451058: Follow-up: Fix window leak in popup tests. r=bustage
MozReview-Commit-ID: 7ucAN5usp0o
2018-04-06 19:22:39 -07:00
Kris Maglione
8ee1c6373c Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f

--HG--
extra : rebase_source : 9d8f139167b6cad8047c3ac75e5ff84886c27da2
extra : source : 29b2567d16eb2d8d58da6e3b616c42eebb0de9f1
2018-04-03 11:14:49 -07:00
Andreea Pavel
4098782378 Backed out 2 changesets (bug 1451058) for failing browser chrome at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup.js on a CLOSED TREE
Backed out changeset 7047a6811fdc (bug 1451058)
Backed out changeset 29b2567d16eb (bug 1451058)
2018-04-06 10:39:42 +03:00
Kris Maglione
33adeee7c7 Bug 1451058: Follow-up: Fix unhandled rejections. r=bustage
MozReview-Commit-ID: FELukWQ8fEz

--HG--
extra : rebase_source : 39e0e482a16c597b968f3977ffb5d59cf736cf53
2018-04-05 21:33:42 -07:00
Kris Maglione
a3fbdb02c5 Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f

--HG--
extra : rebase_source : 221d4804b6ed022ee578c6002e8c7def408fa632
extra : amend_source : f32a1f00af43ba5869d07cff4f55671a1f417b01
2018-04-03 11:14:49 -07:00
Tim Nguyen
e002c63fa4 Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 881e10f2987606e84e55c267260661c0f7b3b746
2018-03-16 23:21:46 +00:00
Margareta Eliza Balazs
27703664b0 Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE
Backed out changeset 71f61091a716 (bug 1444760)
Backed out changeset 4956db1e9bdd (bug 1444760)
2018-03-25 15:29:54 +03:00
Tim Nguyen
e2ed0b5dfb Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 8e9f24d20829021db2239435c7d8d0db08e28bf9
2018-03-16 23:21:46 +00:00
Sam Foster
c11210d2df Bug 1402845 - Fix panelview sizing when customRectGetter is used. r=mikedeboer,Paolo
* The extension content drives the sizing of the browser and popup that contains it via the Extension:BrowserResized message. The ignoreResizes property throttles/debounces this initially, stashing the dimensions received rather than triggering resize of the popup for every message. When the popup is a subview and fixedWidth, we ignore width but *do* want to use the stashed height value.

* Until the panel is given visibility, it has 0 height, so after setting visibility, wait until the next refresh-driver tick before measuring any header which should get added to the overall view height

MozReview-Commit-ID: AgcruVb9QPA

--HG--
extra : rebase_source : 429503a7d38559cc8670a3205b3290b8e0bbbfa2
2017-10-05 10:23:53 -07:00
Shane Caraveo
dd3edd16c4 Bug 1398713 pass triggeringPrincipal when using browser.loadURI, r=Gijs,kmag 2018-02-28 17:32:01 -06:00
Shane Caraveo
2f634add59 Bug 1324255 make webextension panels focused when opened, r=Gijs,rpl 2018-02-15 09:52:54 -07:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Tim Nguyen
fd655b880c Bug 1425868 - Consolidate arrow panel styling. r=dao
Original patch by Jared Wein [:jaws]

MozReview-Commit-ID: D8GxCjJ8Si3

--HG--
extra : rebase_source : 3f877d5b69e3ab86ad7d8b769e6b5459cea3b5bf
2017-12-19 08:00:00 -06:00
Dorel Luca
525a28839c Backed out changeset 4f6ed26bdb9b (bug 1425868) for build bustages on OS X and Windows r=backout on a CLOSED TREE 2017-12-19 15:43:13 +02:00
Tim Nguyen
d93d23734a Bug 1425868 - Consolidate arrow panel styling. r=dao
Original patch by Jared Wein [:jaws]

MozReview-Commit-ID: RAGeRpgoJF

--HG--
extra : rebase_source : 1ae76e2f510bda16d72e1947e92d8d882bf7a01a
2017-12-19 07:00:24 -06:00
Masatoshi Kimura
295faed3f9 Bug 1418914 - Move E10SUtils.jsm into toolkit/. r=mossop
MozReview-Commit-ID: EgDzEEKAeh1

--HG--
rename : browser/modules/E10SUtils.jsm => toolkit/modules/E10SUtils.jsm
extra : rebase_source : 0920ce818773af797a0daf3cf4ae90af41d71d2a
2017-12-12 21:35:16 +09:00
Drew Willcoxon
37cb69c21b Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: WebExtensions changes. r=mixedpuppy
MozReview-Commit-ID: n2eR3q1aZF

--HG--
extra : rebase_source : 56a68a6a268e23c05d57960040be4a441566fa03
2017-10-27 17:39:57 -04:00
Mike de Boer
ef74dc495c Bug 1403466 - Don't set a max-height on panelviews used by WebExtensions, because it causes browser contents to be cut-off. r=Gijs
Setting a max-height caused the '_handleDOMChange' method in ext-browser-content.js
to consistently lie about the scrollHeight, since it was never allowed to grow
beyond the maxHeight - even when the document needs to be larger to fit its contents.
We don't need this aggressiveness in Photon panels anyway, so that makes it
doubly safe to remove this code.

MozReview-Commit-ID: HJVMXXHS4By

--HG--
extra : rebase_source : 19cc957619afdd90d04fea0307b6323b33293841
2017-10-10 12:44:04 +02:00
Kris Maglione
8a6b0ff3bf Bug 1384078: Prevent enter key from closing extension panels. r=Gijs
MozReview-Commit-ID: DnpiIUc4RkH

--HG--
extra : amend_source : f768acea169a593bf7313a58378ca4b7c84d4e87
2017-09-19 16:37:07 -07:00
Kris Maglione
e2676b4811 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI

--HG--
extra : rebase_source : db2e5eeb8e839bb7b1212d7829b66813b9fd15bd
extra : source : c0ab60d3c1f833116d1d9d3b5ef37825726c8ec5
2017-08-02 12:49:25 -07:00
Sebastian Hengst
0fa7bded36 Backed out changeset c0ab60d3c1f8 (bug 1375490) for failing browser_ext_popup_corners.js on OSX and Windows. r=backout on a CLOSED TREE 2017-08-02 13:12:55 +02:00
Sebastian Hengst
fb62f9043e Backed out changeset ec8efb7cf1d3 (bug 1375490) 2017-08-02 13:10:14 +02:00
Kris Maglione
253c296471 Bug 1375490: Follow-up: Fix resize test failures. r=bustage CLOSED TREE
MozReview-Commit-ID: JMWjtKd7CvX

--HG--
extra : amend_source : f5910f3d58e33795eea70b22ba1f44833eb44110
2017-08-01 22:56:40 -07:00
Kris Maglione
e5655d2234 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI

--HG--
extra : rebase_source : 82ec2b3a8380fac8355009720dbd20c7a6c7dbb6
2017-08-01 15:28:25 -07:00
Gijs Kruitbosch
5b530597e8 Bug 1354086 - switch overflow panel to using a photonpanelmultiview, allowing webextension views to specify their own size, r=mikedeboer
MozReview-Commit-ID: 1uHEKXsO8vh

--HG--
extra : rebase_source : f33e277e77a09a10cb0ea3db412d293ef61a5f19
2017-07-19 21:23:46 +01:00
Kris Maglione
c593e26ab1 Bug 1381337: Don't contstrain popup select dropdowns to the document viewport. r=aswan
MozReview-Commit-ID: HzISTjddHHK

--HG--
extra : rebase_source : b0877aa4aba0ecd2e64be46ffecc95fc3b8c5cd3
2017-07-16 13:13:03 -07:00
Kris Maglione
4b46d3f00d Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers. r=zombie
MozReview-Commit-ID: BuAjyqg1aja

--HG--
extra : rebase_source : 03b7368659ccdb39ebedf7aeb6a1902b6abe5808
extra : amend_source : 53eadbc91f2468b8d116cf0e5bf457fd7107bfb8
extra : absorb_source : 379f778671c868a08f560663f31e6248872c7989
2017-07-13 15:47:52 -07:00
Kris Maglione
330469aeb9 Bug 1357486: Part 0g - Run remote debugger host browser in same TabGroup as extension pages. r=me
MozReview-Commit-ID: BPqf0X1hwV6

--HG--
extra : rebase_source : 82b80bbb47533d1bc4ad0ec1e3767b3858d0e946
extra : absorb_source : 9ee1c9f7e5a42743d2ea9e49eae2f509d85ada21
extra : histedit_source : cf82313b4725f01ecd6c6a41b519e41a2d107e09
2017-07-08 15:56:10 -07:00
Stephen A Pohl
d432368c5b Bug 1356317: Support remote layer trees in popups. r=kmag 2017-07-04 13:45:18 -05:00