Commit graph

337 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Daniel Holbert
7258ebe69e Bug 1514309 part 2: Remove C++ serialization code for CSS {align,justify}-{content,items,self} properties. r=emilio
(Also remove stale decl for DoGetOverflowY, which cleanup_computed_getters.py
found for me.)

Differential Revision: https://phabricator.services.mozilla.com/D14618

--HG--
extra : moz-landing-system : lando
2018-12-14 21:27:18 +00:00
Cameron McCormack
a9c935c355 Bug 1511854 - Part 1: Fix some formatting oddities in layout/ after the clang-format. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D13686

--HG--
extra : moz-landing-system : lando
2018-12-05 18:44:03 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Cameron McCormack
16007d2b66 Bug 1495984 - Make css::URLValue::IsLocalRef call into CssUrlData::is_fragment. r=emilio
This fixes the issue that we should no longer be looking for control characters.



MozReview-Commit-ID: 8k89Aheq3NY

Differential Revision: https://phabricator.services.mozilla.com/D8876

--HG--
extra : moz-landing-system : lando
2018-10-17 09:43:45 +00:00
Cameron McCormack
a7510da8d0 Bug 1499408 - Part 2: Have css::URLValue get URLExtraData from its CssUrlData. r=emilio
MozReview-Commit-ID: IqZGzkHlSZD

Depends on D8874

Differential Revision: https://phabricator.services.mozilla.com/D8875

--HG--
extra : moz-landing-system : lando
2018-10-17 09:43:32 +00:00
Cameron McCormack
b5d216cfa1 Bug 1499408 - Part 1: Make css::URLValue hold on to a CssUrlData, not just its serialization. r=emilio
MozReview-Commit-ID: EWcbnVtDJCS

Differential Revision: https://phabricator.services.mozilla.com/D8874

--HG--
extra : moz-landing-system : lando
2018-10-17 12:36:49 +00:00
Emilio Cobos Álvarez
e088200f02 Bug 1497981 - Simplify ImageLoader::LoadImage. r=heycam
Has a single caller, from which we pass the arguments. We can just avoid that.

Differential Revision: https://phabricator.services.mozilla.com/D8276

--HG--
extra : moz-landing-system : lando
2018-10-15 12:24:58 +00:00
Cameron McCormack
f804c8ca6b Bug 1498755 - Part 6: Move some C++ types from ServoBindingTypes.h to ServoTypes.h r=emilio
Depends on D8647

Differential Revision: https://phabricator.services.mozilla.com/D8648

--HG--
extra : moz-landing-system : lando
2018-10-14 00:05:56 +00:00
Emilio Cobos Álvarez
40b1e83d81 Bug 1498734 - Always compute angle values to degrees. r=xidorn
This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:

> All <angle> units are compatible, and deg is their canonical unit.

And https://drafts.csswg.org/css-values/#compat, which says:

>When serializing computed values [...], compatible units [...] are converted into a single canonical unit.

And also other implementations (Blink always serializes angles as degrees in
computed style for example).

Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.

Differential Revision: https://phabricator.services.mozilla.com/D8619

--HG--
extra : moz-landing-system : lando
2018-10-13 00:41:03 +00:00
Emilio Cobos Álvarez
571fa7dcd9 Bug 1497986 - Some more nsCSSValue cleanup. r=mats
I had this around, I couldn't work on more stuff today, but I may as well land
this.

Differential Revision: https://phabricator.services.mozilla.com/D8277

--HG--
extra : moz-landing-system : lando
2018-10-10 20:26:45 +00:00
Cameron McCormack
4c8408b3c2 Bug 1496308 - Require URLExtraData::mPrincipal to be non-null r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D7682

--HG--
extra : moz-landing-system : lando
2018-10-10 03:10:07 +00:00
Cameron McCormack
4daef6b3e8 Bug 1496295 - Remove some more unused methods r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D7678

--HG--
extra : moz-landing-system : lando
2018-10-04 07:51:17 +00:00
Cameron McCormack
eeb8da104f Bug 1495994 - Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio
Depends on D7595

Differential Revision: https://phabricator.services.mozilla.com/D8061

--HG--
extra : moz-landing-system : lando
2018-10-10 02:58:20 +00:00
Cameron McCormack
d254326fee Bug 1495994 - Part 3: Move mLoadID up from ImageValue to URLValueData r=emilio
Depends on D7594

Differential Revision: https://phabricator.services.mozilla.com/D7595

--HG--
extra : moz-landing-system : lando
2018-10-10 02:57:41 +00:00
Cameron McCormack
8e24dfb709 Bug 1495994 - Part 2: Remove some constructors/methods r=emilio
Depends on D7593

Differential Revision: https://phabricator.services.mozilla.com/D7594

--HG--
extra : moz-landing-system : lando
2018-10-10 02:57:13 +00:00
Cameron McCormack
9ef951ebd0 Bug 1495994 - Part 1: Make URLValue constructor take CORSMode argument r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D7593

--HG--
extra : moz-landing-system : lando
2018-10-10 02:56:52 +00:00
Emilio Cobos Álvarez
8a3d09ee15 Bug 1496486 - Remove some more leftover code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7755
2018-10-09 19:07:44 +02:00
Emilio Cobos Álvarez
046243a12e Bug 1496486 - Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
It's unused.

Differential Revision: https://phabricator.services.mozilla.com/D7754
2018-10-09 19:07:42 +02:00
Emilio Cobos Álvarez
c6c06c7f48 Bug 1496486 - Remove nsCSSValue usage from font code. r=heycam
Really sorry for the size of the patch.

Differential Revision: https://phabricator.services.mozilla.com/D7753
2018-10-09 19:07:41 +02:00
Emilio Cobos Álvarez
d9ca8fb50b Bug 1496486 - Remove a bunch of unused nsCSSValue code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7752
2018-10-09 19:07:39 +02:00
Narcis Beleuzu
e7a8994c37 Backed out 5 changesets (bug 1496486) for valgrind bustages. CLOSED TREE
Backed out changeset d2f1e35ee4b7 (bug 1496486)
Backed out changeset 7f843f4ee162 (bug 1496486)
Backed out changeset 2f629a60f12c (bug 1496486)
Backed out changeset 4dd15fa31474 (bug 1496486)
Backed out changeset e8d8e2f3f00b (bug 1496486)
2018-10-09 19:44:51 +03:00
Emilio Cobos Álvarez
bce0418466 Bug 1496486 - Remove some more leftover code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7755
2018-10-09 17:33:27 +02:00
Emilio Cobos Álvarez
6aed7c6760 Bug 1496486 - Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
It's unused.

Differential Revision: https://phabricator.services.mozilla.com/D7754
2018-10-09 17:33:25 +02:00
Emilio Cobos Álvarez
804148c319 Bug 1496486 - Remove nsCSSValue usage from font code. r=heycam
Really sorry for the size of the patch.

Differential Revision: https://phabricator.services.mozilla.com/D7753
2018-10-09 17:33:24 +02:00
Emilio Cobos Álvarez
e536bf79ad Bug 1496486 - Remove a bunch of unused nsCSSValue code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7752
2018-10-09 17:33:23 +02:00
Brindusan Cristian
3b4ca07db8 Backed out 5 changesets (bug 1496486) for build bustages on gfxUserFontSet.h. CLOSED TREE
Backed out changeset 6b740afea403 (bug 1496486)
Backed out changeset 5cf44e254ac3 (bug 1496486)
Backed out changeset 8e465202c355 (bug 1496486)
Backed out changeset 86382b2249f6 (bug 1496486)
Backed out changeset ab92ed3e0a23 (bug 1496486)
2018-10-09 16:58:38 +03:00
Emilio Cobos Álvarez
a03dd78e3f Bug 1496486 - Remove some more leftover code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7755
2018-10-09 15:33:05 +02:00
Emilio Cobos Álvarez
55bef63412 Bug 1496486 - Remove GridTemplateAreas stuff from nsCSSValue. r=heycam
It's unused.

Differential Revision: https://phabricator.services.mozilla.com/D7754
2018-10-09 15:33:04 +02:00
Emilio Cobos Álvarez
d6c743191f Bug 1496486 - Remove nsCSSValue usage from font code. r=heycam
Really sorry for the size of the patch.

Differential Revision: https://phabricator.services.mozilla.com/D7753
2018-10-09 15:33:03 +02:00
Emilio Cobos Álvarez
089e54f3f3 Bug 1496486 - Remove a bunch of unused nsCSSValue code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7752
2018-10-09 15:33:01 +02:00
Cameron McCormack
4372b55f4f Bug 1495645 - Move css::ImageValue::mRequests into a global table managed by css::ImageLoader r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D7383

--HG--
extra : moz-landing-system : lando
2018-10-04 00:20:50 +00:00
Emilio Cobos Álvarez
c620c6f47a Bug 1496041 - Remove unused ImageValue constructor. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7589

--HG--
extra : moz-landing-system : lando
2018-10-03 12:13:57 +00:00
Cameron McCormack
61c7fc41f4 Bug 1495353 - Remove unused css::URLValueData::MightHaveRef r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D7260

--HG--
extra : moz-landing-system : lando
2018-10-01 07:42:05 +00:00
Brad Werth
15674b4d46 Bug 1434963 Part 3: Remove style struct mutation in nsStyleDisplay::FinishStyle. r=emilio
Depends on D5341

Differential Revision: https://phabricator.services.mozilla.com/D5343

--HG--
extra : moz-landing-system : lando
2018-09-11 18:11:19 +00:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Emilio Cobos Álvarez
72476926ed Bug 1463386: Remove eCSSUnit_Image. r=heycam
MozReview-Commit-ID: 9OX6iW7Lr5Q

--HG--
extra : rebase_source : 07dad9bfab62b24668737751386567359806d07d
2018-05-22 13:34:17 +02:00
Xidorn Quan
8af9d264aa Bug 1456364 part 1 - Reduce dependencies to nsCSSProps.h. r=emilio
So that hacking on this header can be less painful...

MozReview-Commit-ID: LmpMnF7q9RG
2018-04-26 16:24:30 +02:00
Andreea Pavel
87bf18c74d Backed out 4 changesets (bug 1456364) for build bustages at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/AnimationEffectReadOnlyBinding.h:35 on a CLOSED TREE
Backed out changeset 020151240bb8 (bug 1456364)
Backed out changeset bc0aa5224d91 (bug 1456364)
Backed out changeset d919bbe7440c (bug 1456364)
Backed out changeset ab1472823e8a (bug 1456364)
2018-04-26 08:27:45 +03:00
Xidorn Quan
0d91cc33ac Bug 1456364 part 1 - Reduce dependencies to nsCSSProps.h. r=emilio
So that hacking on this header can be less painful...

MozReview-Commit-ID: LmpMnF7q9RG

--HG--
extra : source : b68215ade7403ae9c6fbf20cb64a64c04a67ee66
2018-04-26 15:00:50 +10:00
Jonathan Watt
156c4af1ec Bug 1436048: Use user defined types for font-stretch / font-style. r=jfkthame,jwatt
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>

MozReview-Commit-ID: 7ONYtICeAqb
2018-04-23 18:22:05 +02:00
Jonathan Watt
1e7f76576a Bug 1436048 part 1 - Use a user defined type for font weight everywhere. r=jfkthame,emilio
--HG--
extra : rebase_source : 2e267ff99de6f52484e34ac15c39e5ca8b473394
2018-04-13 20:34:37 +01:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Andreea Pavel
29ba7b4974 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2018-04-11 17:40:37 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Emilio Cobos Álvarez
9ab1873cd3 Bug 1452987: Simplify ImageValue. r=heycam
MozReview-Commit-ID: 5LRaaEPSSdY

--HG--
extra : rebase_source : 2654a870e2a985bf7a609ee436ba1800bf6033a3
2018-04-10 16:54:57 +02:00
Emilio Cobos Álvarez
7e8faed759 Bug 1452947: Remove useless PtrHolder / PtrHandle stuff now that URIs are thread-safe. r=heycam
MozReview-Commit-ID: 5f2B8bqBnDp
2018-04-11 08:41:49 +02:00
Xidorn Quan
3356a5f95f Bug 1448763 part 9 - Remove nsCSSRect. r=emilio
MozReview-Commit-ID: BOsjszpdKwt

--HG--
extra : rebase_source : 7061396323ec4e851517a7be2027447e16e8e77f
2018-04-05 18:27:33 +10:00
Xidorn Quan
3248eb765c Bug 1448763 part 7 - Remove nsCSSCornerSizes. r=emilio
MozReview-Commit-ID: jjSjoskIB8

--HG--
extra : rebase_source : a6d939852f06e595ad5e2c4ca7115872d30eca8e
2018-04-05 18:27:33 +10:00
Xidorn Quan
7d3cec4977 Bug 1448763 part 6 - Remove nsCSSValueTriplet. r=emilio
MozReview-Commit-ID: 29GtK1gtreU

--HG--
extra : rebase_source : 9b6b5c0a729228112260d3ae51db1207d003111b
2018-04-05 18:27:33 +10:00