nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
827960 commits 1 branch 98 tags 6.4 GiB
Commit graph

1455 commits

Author SHA1 Message Date
alwu
60bbc8ab3d Bug 1773551 - part1 : move AutoplayPolicy to media namespace in order to prevent naming collision. r=media-playback-reviewers,padenot 
Differential Revision: https://phabricator.services.mozilla.com/D164748
 2022-12-19 20:57:54 +00:00
alwu
2a156f31ff Bug 1803834 - part2 : pause/resume non-audible autoplay video when its visibility changes. r=media-playback-reviewers,padenot 
https://html.spec.whatwg.org/multipage/media.html#ready-states:eligible-for-autoplay-2

Depends on D163741

Differential Revision: https://phabricator.services.mozilla.com/D163742
 2022-12-06 18:21:39 +00:00
alwu
64af530cf1 Bug 1803834 - part1 : rename mAutoplaying to 'mCanAutoplayFlag'. r=media-playback-reviewers,padenot 
Our current attribute `mAutoplaying` seems be equal to the `can
autoplay flag` defined in the spec, so rename it to the spec name.

https://html.spec.whatwg.org/multipage/media.html#can-autoplay-flag

Differential Revision: https://phabricator.services.mozilla.com/D163741
 2022-12-06 18:21:39 +00:00
Martin Robinson
abb5044ca7 Bug 1803377 - Rename the values of the IntrinsicDirty enum r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D163607
 2022-12-02 12:27:31 +00:00
Andreas Pehrson
2ed52d6125 Bug 1796069 - Annotate MediaStreamTrackSources with a tracking id and apply it to CopyVideoStages. r=padenot 
This will allow time consuming tasks (copies, capture, etc.) along the pipe to
be grouped per-track-source when visualizing profiler markers.

Differential Revision: https://phabricator.services.mozilla.com/D160754
 2022-12-01 09:52:46 +00:00
Botond Ballo
68c71a503c Bug 1802225 - Remove Layers.{h,cpp}. r=tnikkel,geckoview-reviewers,jgilbert,media-playback-reviewers,padenot,m_kato 
Where appropriate, `#include "Layers.h"` is replaced with
more specific inclusions.

Differential Revision: https://phabricator.services.mozilla.com/D162934
 2022-11-29 01:52:03 +00:00
Karl Tomlinson
703b1dbfda Bug 1786306 merge AudioStreamTrack::SetAudioOutputDevice() into AddAudioOutput() r=padenot 
The SetAudioOutputDevice() implementation required a subsequent
AddAudioOutput() call, so there is no need to have separate methods.

Differential Revision: https://phabricator.services.mozilla.com/D158310
 2022-09-30 04:13:35 +00:00
Brad Werth
51de674b99 Bug 1787561 Part 2: Expose HDR telemetry to HTMLMediaElement as a Chrome property. r=alwu,emilio 
This is necessary scaffolding for testing of the HDR telemetry in a way
that involves the RDD process. This is important for matching real-world
conditions.

Depends on D155902

Differential Revision: https://phabricator.services.mozilla.com/D156245
 2022-09-08 18:02:04 +00:00
Kershaw Chang
d164608d66 Bug 1760580 - P2: Provide a reason when request is cancelled with NS_BINDING_ABORTED, r=necko-reviewers,media-playback-reviewers,valentin,chunmin 
Differential Revision: https://phabricator.services.mozilla.com/D156071
 2022-09-08 09:11:19 +00:00
criss
d87f2984cd Backed out 3 changesets (bug 1787561) for causing mochitest failures on browser_tab_visibility_and_play_time.js 
Backed out changeset a41ab0c5f32f (bug 1787561)
Backed out changeset c1375f03dc75 (bug 1787561)
Backed out changeset afef5857aea6 (bug 1787561)
 2022-09-07 23:49:05 +03:00
Brad Werth
99ed6acbb7 Bug 1787561 Part 2: Expose HDR telemetry to HTMLMediaElement as a Chrome property. r=alwu,emilio 
This is necessary scaffolding for testing of the HDR telemetry in a way
that involves the RDD process. This is important for matching real-world
conditions.

Depends on D155902

Differential Revision: https://phabricator.services.mozilla.com/D156245
 2022-09-07 18:31:46 +00:00
Emilio Cobos Álvarez
08dfe7c199 Bug 1785089 - Minor drive-by clean-ups. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D154800
 2022-08-17 21:07:27 +00:00
Emilio Cobos Álvarez
060844671d Bug 1785089 - Don't spam the console and front-end with autoplay blocked events. r=alwu 
Once per video should be enough.

Differential Revision: https://phabricator.services.mozilla.com/D154798
 2022-08-17 21:02:44 +00:00
Chun-Min Chang
edc56a360b Bug 1776796 - Rename MarkAsContentSource r=media-playback-reviewers,alwu 
`HTMLMediaElement::MarkAsContentSource` [1] was added in Bug 1299718 to
monitor the visibility / invisibility of various usage of video element.
However, that telemetry had been removed in Bug 1356046.
`MarkAsContentSource` is only used for logging currently. It's better to
reword its name and related comments to bring the code in line with the
current status.

[1] https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/dom/html/HTMLMediaElement.h#799

Differential Revision: https://phabricator.services.mozilla.com/D150434
 2022-07-27 00:20:45 +00:00
Emilio Cobos Álvarez
255763ef57 Bug 1773070 - Unify Gecko and Servo EventState/ElementState bits. r=smaug 
Add a dom/base/rust crate called just "dom" where we can share these.

Most of the changes are automatic:

  s/mozilla::EventStates/mozilla::dom::ElementState/
  s/EventStates/ElementState/
  s/NS_EVENT_STATE_/ElementState::/
  s/NS_DOCUMENT_STATE_/DocumentState::/

And so on. This requires a new cbindgen version to avoid ugly casts for
large shifts.

Differential Revision: https://phabricator.services.mozilla.com/D148537
 2022-06-07 23:09:52 +00:00
june wilde
29fb0fb057 Bug 1731614 - Clarify error phrasing in NoSupportedMediaSourceError; r=ckerschb,dveditz 
Differential Revision: https://phabricator.services.mozilla.com/D145576
 2022-05-23 21:27:48 +00:00
Kagami Sascha Rosylight
b1653a09c7 Bug 1767996 - Apply readability-make-member-function-const on dom/html r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D145627
 2022-05-13 05:35:25 +00:00
az
2607db324d Bug 1652950 - Unprefix mozPreservesPitch, update corresponding tests r=emilio,saschanaz 
Differential Revision: https://phabricator.services.mozilla.com/D143237
 2022-04-20 18:43:47 +00:00
ashley
bbae966812 Bug 1744398 - Media element load algorithm must fire 'emptied' before 'timeupdate' r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D142628
 2022-04-01 18:26:05 +00:00
Bryce Seager van Dyk
ff03cc04a5 Bug 1724106 - Clarify threading usage when getting media debug info. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D124104
 2022-03-29 22:17:58 +00:00
Paul Adenot
7506e056c3 Bug 1272636 - Reset HTMLMediaElement.played when loading a new source. r=media-playback-reviewers,alwu 
Differential Revision: https://phabricator.services.mozilla.com/D139925
 2022-03-08 13:05:28 +00:00
Paul Adenot
b980ff2250 Bug 1630569 - Change the limit at which audio is muted with high or low playback rates, and make it and other parameters configurable via prefs. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D135066
 2022-01-05 18:11:58 +00:00
Masayuki Nakano
4341d6fb0c Bug 1455514 - part 1: Add accessors and static helper methods to retrieve nsINode or its concrete classes from EventTarget r=smaug 
Currently, checking whether an `EventTarget` is `nsINode` (or its concrete
classes) or not requires a QI, but it's expensive and used a lot while we
handle each event.  Therefore, it'd be nicer for creating a virtual method,
`EventTarget::IsNode()` and use it for the check.

If trying to convert `EventTarget` to a concrete class, it may require two
virtual method calls.  I'm not sure whether it's cheaper than a QI, but at
least, it won't depend on the UUID check order of `QueryInterface()` when
multiple interfaces are implemented.

Differential Revision: https://phabricator.services.mozilla.com/D129781
 2021-11-02 13:03:43 +00:00
Jeff Muizelaar
cde3f4b00b Bug 1736077 - Remove unusued LayerManager.cpp. r=gfx-reviewers,lsalzman 
Differential Revision: https://phabricator.services.mozilla.com/D128632
 2021-10-17 01:28:41 +00:00
Paul Adenot
5f6c907318 Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125088
 2021-10-12 09:03:53 +00:00
Paul Adenot
2a5cb9f5c5 Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125084
 2021-10-12 09:03:52 +00:00
Paul Adenot
1a85208ad7 Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125083
 2021-10-12 09:03:52 +00:00
Alexandru Michis
26c14b3225 Backed out 24 changesets (bug 1678373) for causing bc failures in browser_tab_visibility_and_play_time.js 
CLOSED TREE

Backed out changeset 1886dbd81c46 (bug 1678373)
Backed out changeset aeff26b5b1ae (bug 1678373)
Backed out changeset 261d8e4483d4 (bug 1678373)
Backed out changeset 89cb5ae23632 (bug 1678373)
Backed out changeset b1eaedd192ab (bug 1678373)
Backed out changeset 58a3eb19c818 (bug 1678373)
Backed out changeset b027ec789cbe (bug 1678373)
Backed out changeset fd596a84feb9 (bug 1678373)
Backed out changeset 1f0ed0392ae2 (bug 1678373)
Backed out changeset ac2be1df81af (bug 1678373)
Backed out changeset bf6d47905d78 (bug 1678373)
Backed out changeset a9fe4f310962 (bug 1678373)
Backed out changeset a15316058968 (bug 1678373)
Backed out changeset 217cdfd46120 (bug 1678373)
Backed out changeset c33c8411129b (bug 1678373)
Backed out changeset 3b854fc36abf (bug 1678373)
Backed out changeset e47c82bcb49a (bug 1678373)
Backed out changeset 2a77cbba1c9f (bug 1678373)
Backed out changeset 65206afede36 (bug 1678373)
Backed out changeset bd04930155f4 (bug 1678373)
Backed out changeset 034e8edd4619 (bug 1678373)
Backed out changeset ed1e56487c4c (bug 1678373)
Backed out changeset b7673d20c521 (bug 1678373)
Backed out changeset 5a93251e2fea (bug 1678373)
 2021-10-07 20:36:47 +03:00
Paul Adenot
82125c0639 Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125088
 2021-10-07 15:44:54 +00:00
Paul Adenot
6dc847cdf6 Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125084
 2021-10-07 15:44:53 +00:00
Paul Adenot
94b7678216 Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125083
 2021-10-07 15:44:53 +00:00
Paul Adenot
2d55780bdd Bug 1733109 - function 'mozilla::dom::HTMLMediaElement::MozGetMetadata' has a definition with different parameter names in HTMLMediaElement.cpp. r=alwu 
Depends on D126946

Differential Revision: https://phabricator.services.mozilla.com/D126947
 2021-09-30 12:36:18 +00:00
Paul Adenot
477acd5f27 Bug 1733109 - narrowing conversion from 'double' to 'float' in HTMLMediaElement.cpp. r=alwu 
Depends on D126945

Differential Revision: https://phabricator.services.mozilla.com/D126946
 2021-09-30 12:36:18 +00:00
Paul Adenot
f3cd1e466b Bug 1733109 - 'auto cdmProxy' can be declared as 'auto *cdmProxy' in HTMLMediaElement.cpp. r=alwu 
Depends on D126944

Differential Revision: https://phabricator.services.mozilla.com/D126945
 2021-09-30 12:36:18 +00:00
Paul Adenot
97fe06afcc Bug 1733109 - do not use 'else' after 'return' in HTMLMediaElement.cpp. r=alwu 
Depends on D126943

Differential Revision: https://phabricator.services.mozilla.com/D126944
 2021-09-30 12:36:17 +00:00
Paul Adenot
915a3a4d1a Bug 1733109 - local copy 'handle' of the variable 'aPrincipalHandle' is never modified; consider avoiding the copy in HTMLMediaElement.cpp. r=alwu 
Depends on D126942

Differential Revision: https://phabricator.services.mozilla.com/D126943
 2021-09-30 12:36:17 +00:00
Paul Adenot
0f7d0e3beb Bug 1733109 - 'auto decoder' can be declared as 'auto *decoder' in HTMLMediaElement.cpp. r=alwu 
Depends on D126941

Differential Revision: https://phabricator.services.mozilla.com/D126942
 2021-09-30 12:36:16 +00:00
Paul Adenot
ab7bfb48a1 Bug 1733109 - 'auto decoder' can be declared as 'auto *decoder' in HTMLMediaElement.cpp. r=alwu 
Depends on D126940

Differential Revision: https://phabricator.services.mozilla.com/D126941
 2021-09-30 12:36:16 +00:00
Paul Adenot
4ef93dfafd Bug 1733109 - move constructors should be marked noexcept HTMLMediaElement.cpp. r=alwu 
We don't use exceptions anyways, but having no warnings allows warning us when
warnings appear, so let's fix this.

Depends on D126939

Differential Revision: https://phabricator.services.mozilla.com/D126940
 2021-09-30 12:36:16 +00:00
Paul Adenot
7b15802441 Bug 1733109 - narrowing conversion from 'unsigned long' to signed type 'int32_t' (aka 'int') is implementation-defined HTMLMediaElement.cpp. r=pehrsons 
Somewhat controversial, let me know what you think.

Differential Revision: https://phabricator.services.mozilla.com/D126939
 2021-09-30 12:36:15 +00:00
Paul Adenot
eb06a61abe Bug 1733109 - redundant return statement at the end of a function with a void return type in HTMLMediaElement.cpp. r=alwu 
Depends on D126937

Differential Revision: https://phabricator.services.mozilla.com/D126938
 2021-09-30 12:36:15 +00:00
Paul Adenot
91a3981b9c Bug 1733109 - narrowing conversion from 'double' to 'float' in HTMLMEdiaElement.cpp. r=alwu 
Depends on D126935

Differential Revision: https://phabricator.services.mozilla.com/D126936
 2021-09-30 12:36:14 +00:00
Paul Adenot
b9d6ecd246 Bug 1733109 - constructor does not initialize these fields: mOwnerBrowsingContextId in HTMLMEdiaElement.cpp. r=alwu 
Depends on D126934

Differential Revision: https://phabricator.services.mozilla.com/D126935
 2021-09-30 12:36:14 +00:00
Olli Pettay
f083f381d8 Bug 1727514 - media playback should stop in the bfcache, r=peterv 
This version doesn't change SetContainer handling, since it seems to be tricky for the top level page.
So only activity change notification is fired and IsActive() is updated.
The comment about IsActive() was wrong even with the old bfcache implementation.
(I did check that it returned false when the page was in bfcache and many of the activity observers rely on that)

The changes to HTMLMediaElement are needed to ensure page can enter bfcache..

Differential Revision: https://phabricator.services.mozilla.com/D124684
 2021-09-20 08:49:22 +00:00
Sandor Molnar
c60bc752d8 Backed out changeset 2d49d73f38aa (bug 1727514) for causing frequent crashes. a=backout 2021-09-16 15:52:56 +03:00
Olli Pettay
d0485c8a55 Bug 1727514 - media playback should stop in the bfcache, r=peterv 
SetContainer handling is similar to what DocumentViewer does for the old bfcache implementation.
(The old implementation hides it quite well).
The changes to HTMLMediaElement are needed to ensure page can enter bfcache.

Removed erroneous MOZ_ASSERT in nsPresContext, it is ok to trigger that code path in the new implementation.
And the Run() method of the relevant nsIRunnable already deals with that case.

Differential Revision: https://phabricator.services.mozilla.com/D124684
 2021-09-13 12:40:18 +00:00
Alexandru Michis
bd2de15f47 Backed out 2 changesets (bug 1724106) for causing Bug 1728715. 
CLOSED TREE

Backed out changeset 81d1db229eea (bug 1724106)
Backed out changeset 8ed4675541c6 (bug 1724106)
 2021-09-02 21:03:07 +03:00
Bryce Seager van Dyk
cfec4e7dfa Bug 1724106 - Clarify threading usage when getting media debug info. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D124104
 2021-09-01 22:29:48 +00:00
alwu
01fee60b95 Bug 1723799 - part2 : add test. r=padenot,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D121681
 2021-08-09 19:30:12 +00:00
Kagami Sascha Rosylight
c69d367ce0 Bug 1723050 - Part 14: Replace typedef by using in dom/html/ r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D121312
 2021-08-09 13:37:27 +00:00