In some cases, the setTimeoutIfNeeded function can
be called before the store is initialized, which is
causing an exception when we try to dispatch the
messages.
With this patch, we check if the store is not ready,
and re-schedule a timeout so messages can be handled
properly when the store is ready.
Differential Revision: https://phabricator.services.mozilla.com/D11044
--HG--
extra : moz-landing-system : lando
hud.owner can be null in some condition, so we
need to guard the access to hud.owner.target.
Differential Revision: https://phabricator.services.mozilla.com/D9069
--HG--
extra : moz-landing-system : lando
- Various telemetry methods now need an object to be passed in in order to keep them seperate e.g. if the inspector is opened in tab 1 a timer is started. If an inspector is opened in tab 2 the same timer is restarted. Closing tab 2 would then erase the timing event invalidating the timer in tab 1.
- We no longer need to preface telemetry calls with category "devtools.main" because this is the only category we will be using.
- There are some changes to `devtools/client/debugger/new/dist/vendors.js` and `devtools/client/debugger/new/src/utils/telemetry.js` that need to be ported to the debugger at the same time as landing this.
Differential Revision: https://phabricator.services.mozilla.com/D6137
--HG--
extra : moz-landing-system : lando
The App component takes the whole document space, so we can move the
code that listen for every click in the console UI to decide if the
jsterm should be focused or not.
This feels more like the React way, and will also provide us better
access to the store and the props when we need them in this focus
handling (like this will be the case for hiding the reverse search UI).
Depends on D5150
Differential Revision: https://phabricator.services.mozilla.com/D5152
--HG--
extra : moz-landing-system : lando
Retrieve this preference in the console to pass it as a prop to the root
App component.
Differential Revision: https://phabricator.services.mozilla.com/D5149
--HG--
extra : moz-landing-system : lando
The App component takes the whole document space, so we can move the
code that listen for every click in the console UI to decide if the
jsterm should be focused or not.
This feels more like the React way, and will also provide us better
access to the store and the props when we need them in this focus
handling (like this will be the case for hiding the reverse search UI).
Depends on D5150
Differential Revision: https://phabricator.services.mozilla.com/D5152
--HG--
extra : moz-landing-system : lando
Retrieve this preference in the console to pass it as a prop to the root
App component.
Differential Revision: https://phabricator.services.mozilla.com/D5149
--HG--
extra : moz-landing-system : lando
Changes:
Pretty much all files contain changes to the order of events and properties... these are to stop subtle issues with events not being logged because not all properties were sent and some events were sent in the wrong order.
-devtools/client/framework/test/browser_devtools_api.js
- Renamed test-tool-1 and 2 because we need to include the panel names in Events.yaml and "-" is not allowed.
- devtools/client/framework/toolbox.js
- Removed unneeded const REGEX_PANEL.
- Generally shifted things around to ensure we send events from all codepaths.
- toolkit/components/telemetry/Events.yaml
- Changed telemetry event `"devtools.main", "enter"` to include all built-in panel names including "other."
MozReview-Commit-ID: 2G3Z9pzj1QC
--HG--
extra : rebase_source : 54920e6fe2116a3112fefe17715b5b22ad6f5d32
Changes:
Pretty much all files contain changes to the order of events and properties... these are to stop subtle issues with events not being logged because not all properties were sent and some events were sent in the wrong order.
-devtools/client/framework/test/browser_devtools_api.js
- Renamed test-tool-1 and 2 because we need to include the panel names in Events.yaml and "-" is not allowed.
- devtools/client/framework/toolbox.js
- Removed unneeded const REGEX_PANEL.
- Generally shifted things around to ensure we send events from all codepaths.
- toolkit/components/telemetry/Events.yaml
- Changed telemetry event `"devtools.main", "enter"` to include all built-in panel names including "other."
MozReview-Commit-ID: 2G3Z9pzj1QC
--HG--
extra : rebase_source : bc691ae42b521e3a58c1a4aa9dbd455a3aa258a0
This introduces an event-telemetry middleware that we'll
be able to re-use for other events.
A test is added to make sure we do log those events as intended.
The telemetry mock for mocha test is modified to include
recordEvent so the test still run.
MozReview-Commit-ID: 1SHnVIRGdDz
--HG--
extra : rebase_source : 7a7d6c7ff3fdbe1da6a16bc47017dbf5d90582db
This then can be used directly in the console, or passed to reps
and ObjectInspector so it can be called from there.
MozReview-Commit-ID: uQOiGuYbJK
--HG--
extra : rebase_source : a8a84b558dea69b7c2793b9e2d67a44a0809eb43
This allows us to open the context menu directly from webconsole.html when it's
running as a top level window. Ultimately, I'd like to not have to use special
handling in the console - all top-level windows should get the edit menu working
automatically for HTML inputs - but this lets us prove it out as a first consumer.
MozReview-Commit-ID: BYisQDtXWe4
--HG--
extra : rebase_source : 8000147713000a30af48f1da17d50356a4cd4a04
In order to do that, we pass an onCmdCtrlClick to the ObjectInspector.
We also extract the dispatching of the SHOW_OBJECT_IN_SIDEBAR action to
its own function so it can be called directly with a grip.
browser_webconsole_object_in_sidebar is renamed and repurposed to test
this specific behavior, since there's already a test checking the context
menu way (browser_webconsole_context_menu_object_in_sidebar.js).
MozReview-Commit-ID: GCF1wFPWTH
--HG--
rename : devtools/client/webconsole/test/mochitest/browser_webconsole_object_in_sidebar.js => devtools/client/webconsole/test/mochitest/browser_webconsole_object_ctrl_click.js
extra : rebase_source : ad40ffb48695e3156a5730a5a41c1e8d9cb73b88
This is only about adding an editor in the JsTerm and making
sure we can still execute input strings.
The styles should stay the same, except that now we don't have
to do the computation for the input height, since they're already
done in CodeMirror. In-line style, history navigation and
autocompletion will be handled in separate bugs.
The creation of the editor might be done outside of the JsTerm in
the future so we can re-use it to syntax highlight Evaluation input
in the output; but not in this bug since it would need to move
jsterm.execute as well.
MozReview-Commit-ID: 75TmF055mkp
--HG--
extra : rebase_source : ec7edb17ffb13c757ed51e03a1174399ea2bcbde
