Commit graph

346 commits

Author SHA1 Message Date
Emily McMinn
079ff41016 Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Thomas Wisniewski
e8439f4015 Bug 1881798 - remove the legacy ETP webcompat reporter; r=pbz,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D203022
2024-03-03 01:39:42 +00:00
Itiel
630b1a8f1f Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.

Differential Revision: https://phabricator.services.mozilla.com/D196671
2024-01-09 17:01:25 +00:00
Anna Yeddi
49495502bb Bug 1872954 - [Protections Panel] Ensure blocker tracker milestones subviewbutton is labeled. r=anti-tracking-reviewers,pbz
The Protections doorhanger UI includes [a subview button with id `protections-popup-milestones-content`](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/components/controlcenter/content/protectionsPanel.inc.xhtml#160-167) that does not provide an accessible name,

It appears to happen because this `<toolbarbutton>` XUL control is marked up with [`<description>` as its child containing the on-screen text](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/components/controlcenter/content/protectionsPanel.inc.xhtml#164-165), while `<label>` does provide an expected output for the Accessibility API preserving its visual appearance at the same time.

Since this control would become labeled and would start passing a11y_checks, we are also removing [the `fail-if` notation](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/base/content/test/protectionsUI/browser.toml#57) from the `browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js` test manifest.

Note: the following prefs are needed:
```
      // Hide protections cards so as not to trigger more async messaging
      // when landing on the page.
      ["browser.contentblocking.report.monitor.enabled", false],
      ["browser.contentblocking.report.lockwise.enabled", false],
      ["browser.contentblocking.report.proxy.enabled", false],
      ["browser.contentblocking.cfr-milestone.update-interval", 0],
```

Differential Revision: https://phabricator.services.mozilla.com/D197634
2024-01-04 17:18:28 +00:00
Thomas Wisniewski
0a53bd7f45 Bug 1870887 - hide the Report Broken Site menu options until the component initializes; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D197009
2023-12-22 13:31:12 +00:00
Benjamin VanderSloot
e72674d7b6 Bug 1525943 - Add associated to the identity UI - r=pbz,Gijs,nika,flod
Differential Revision: https://phabricator.services.mozilla.com/D193806
2023-11-30 18:32:48 +00:00
Itiel
867ac130fa Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r=Gijs,twisniewski,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D194416
2023-11-27 17:13:56 +00:00
Thomas Wisniewski
6cb66d4ccd Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-20 01:50:36 +00:00
Cristian Tuns
c76093316c Backed out 3 changesets (bug 1852340) for causing frequent mochitest failures in docshell/test/chrome/ CLOSED TREE
Backed out changeset 61875987e62c (bug 1852340)
Backed out changeset 05320d6c0441 (bug 1852340)
Backed out changeset 411374d444d1 (bug 1852340)
2023-11-19 11:46:26 -05:00
Thomas Wisniewski
4c054b0ab4 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 15:34:40 +00:00
Natalia Csoregi
42acdc9cd5 Backed out 3 changesets (bug 1852340) for causing failures due to reportBrokenSite.ftl. CLOSED TREE
Backed out changeset 86f9e01f70d6 (bug 1852340)
Backed out changeset 0049d0494b17 (bug 1852340)
Backed out changeset 7851355d5c95 (bug 1852340)
2023-11-19 10:50:25 +02:00
Thomas Wisniewski
ad730e4654 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 07:31:31 +00:00
Natalia Csoregi
67ce438ab8 Backed out changeset 59a1d385ed2a (bug 1852340) for causing multiple failures e.g. browser_startup_images.js. CLOSED TREE 2023-11-17 15:59:18 +02:00
Thomas Wisniewski
ca1fea74be Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-17 12:34:52 +00:00
DJ
4fc8c81ec4 Bug 1862982 - fix fluent schema for cookie banner blocker cancel button. r=fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D193235
2023-11-10 15:16:41 +00:00
DJ
3c60ccd865 Bug 1862427 - move cookie banner blocker info to bottom of privacy panel. r=cmkm
Differential Revision: https://phabricator.services.mozilla.com/D192477
2023-11-01 16:27:35 +00:00
DJ
9315ecdf22 Bug 1856014 - Fix fluent schema for strings in protections panel. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D191997
2023-10-30 15:34:55 +00:00
Emilio Cobos Álvarez
8c74cf2354 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-23 15:51:37 +00:00
Cieara Meador
acee9d9408 Bug 1857972 - Update cookie banner blocker strings on privacy panel r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190813
2023-10-13 13:59:17 +00:00
Cristina Horotan
db3ec44028 Backed out changeset 6d11e2f54668 (bug 1855875) for causing bug 1856697 2023-10-04 18:46:25 +03:00
Emilio Cobos Álvarez
154a323648 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-02 16:51:52 +00:00
ganna
f8248231f8 Bug 1832348 - Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183417
2023-08-30 17:35:39 +00:00
Hanna Jones
802b80fec2 Bug 1801936 - use moz-toggle in the ETP panel r=mstriemer,tgiles,desktop-theme-reviewers,flod,dao
This patch replaces both toggles in the different sub views of the ETP panel with `moz-toggle`. Previously there was a small discrepancy where we were setting an `aria-label` on one toggle but not the other. I added a method to handle updating both toggles at once to ensure they stay in sync/always receive the same updates.

Differential Revision: https://phabricator.services.mozilla.com/D176700
2023-08-09 18:18:44 +00:00
Butkovits Atila
fa74cadd25 Backed out 6 changesets (bug 1832348) for causing mochitest failures with leaks. CLOSED TREE
Backed out changeset 50f0546e5e0e (bug 1832348)
Backed out changeset 294d38c19889 (bug 1832348)
Backed out changeset 9cc22e70d293 (bug 1832348)
Backed out changeset fdcd11e66071 (bug 1832348)
Backed out changeset a357b1c75148 (bug 1832348)
Backed out changeset fcc56c5fd7e4 (bug 1832348)
2023-07-26 20:41:26 +03:00
ganna
b748e2fa51 Bug 1832348 - Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183417
2023-07-26 15:47:40 +00:00
Malte Juergens
05a00d1692 Bug 1720458: Do not isolate https-only-load-insecure by origin attributes r=fluent-reviewers,settings-reviewers,flod,ckerschb,Gijs
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.

Depends on D182761

Differential Revision: https://phabricator.services.mozilla.com/D183745
2023-07-24 13:31:19 +00:00
Malte Juergens
a7c59a9b78 Bug 1838183: Include HTTPS-First in current HTTPS-Only exemption options on site identity pane r=freddyb,fluent-reviewers
Depends on D182322

Differential Revision: https://phabricator.services.mozilla.com/D181356
2023-07-11 11:07:24 +00:00
ganna
3b67d44293 Bug 1814411 - Use moz-support-link for the protections-popup-shim-allow-learn-more labels in protectionsPanel.inc.xhtml. r=tgiles
Depends on D179594

Differential Revision: https://phabricator.services.mozilla.com/D179719
2023-06-05 14:25:52 +00:00
ganna
de17418440 Bug 1814412 - Use moz-support-link for the protections-popup-sendReportView-learn-more label. r=tgiles,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D179594
2023-06-05 14:25:51 +00:00
Ebilite Uchenna
3ecf643cb4 Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173701
2023-04-14 15:01:10 +00:00
Mark Striemer
055afa3dfb Bug 1819372 - Part 3: Use moz-button-group in ETP report site panel r=pbz
Depends on D173892

Differential Revision: https://phabricator.services.mozilla.com/D175190
2023-04-13 16:20:50 +00:00
Mark Striemer
db43a5ce41 Bug 1819372 - Part 2: Use moz-button-group in Cookie Banner Reduction panel r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D173892
2023-04-13 16:20:50 +00:00
Itiel
862ebed2c6 Bug 1827730 - Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r=emilio
Specifically, here:
https://searchfox.org/mozilla-central/rev/ad732108b073742d7324f998c085f459674a6846/browser/components/customizableui/PanelMultiView.jsm#1403-1457

Differential Revision: https://phabricator.services.mozilla.com/D175286
2023-04-13 15:30:57 +00:00
Noah
4371549920 Bug 1814261 - Use moz-support-link in Mixed Content Blocking. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173620
2023-04-13 15:14:25 +00:00
Csoregi Natalia
fd43043337 Backed out 2 changesets (bug 1814261) as per request. CLOSED TREE
Backed out changeset 8640c4a18d9e (bug 1814261)
Backed out changeset c00c8fc88dbd (bug 1814261)
2023-04-06 18:40:06 +03:00
Noah
47b283c6e9 Bug 1814261 - Use moz-support-link in Mixed Content Blocking. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173620
2023-04-06 06:00:16 +00:00
Noemi Erli
e465420048 Backed out 2 changesets (bug 1814266) for causing failures in browser_identityPopup_focus.js
Backed out changeset fb7b697636ae (bug 1814266)
Backed out changeset 7e5ac07b53d9 (bug 1814266)
2023-04-06 00:02:41 +03:00
Ebilite Uchenna
b9a1be77e6 Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
Differential Revision: https://phabricator.services.mozilla.com/D173701
2023-04-05 20:23:05 +00:00
ganna
451ba15d72 Bug 1814270 - Use moz-support-link for permission-popup-storage-access-permission-learn-more label. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D173748
2023-03-30 17:59:46 +00:00
Tom Ritter
3c46efdcb3 Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173565
2023-03-29 16:02:37 +00:00
ganna
5ea9f76714 Bug 1802364 - Convert ETP breakage report links to toolbarbuttons in ETP panel. r=hjones,desktop-theme-reviewers,anti-tracking-reviewers,Itiel,pbz
Differential Revision: https://phabricator.services.mozilla.com/D172957
2023-03-28 19:44:11 +00:00
Jared Hirsch
76a6a422ec Bug 1812796 - Refactor and simplify cookie banner handling UI state r=pbz,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D172075
2023-03-28 16:31:48 +00:00
Itiel
df7719b48e Bug 1822134 - Fix panel header footer buttons appearance in the protections panel r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172461
2023-03-13 18:40:45 +00:00
Emilio Cobos Álvarez
6e32187716 Bug 1821387 - Don't use vbox on panel headers. r=Gijs
While at it remove useless display declaration too.

vbox was setting -moz-box-orient: vertical, but that had no effect
because it had display: flex explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D172145
2023-03-09 20:18:47 +00:00
DJ
1e91f6882d Bug 1810052 - update strings for protections panel and expose to localization. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D168011
2023-02-06 19:09:01 +00:00
Jared Hirsch
978a1b7fa2 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-02 19:12:57 +00:00
Butkovits Atila
4a919ce347 Backed out changeset f878cff45427 (bug 1800670) for causing failures at browser_protectionsUI_cookie_banner.js. CLOSED TREE 2023-02-01 20:40:46 +02:00
Jared Hirsch
9ab5498253 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-01 14:51:39 +00:00
Noemi Erli
4198c1ee2f Backed out changeset 68de023d3c5c (bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE 2023-01-30 21:16:42 +02:00
Jared Hirsch
fd622a42aa Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 16:30:28 +00:00