Commit graph

227 commits

Author SHA1 Message Date
Joel Maher
ab7ae9ad03 Bug 1743907 - remove webrender from harnesses and taskcluster. r=MasterWayZ,webdriver-reviewers,perftest-reviewers,AlexandruIonescu,whimboo,ahal
Differential Revision: https://phabricator.services.mozilla.com/D134715
2022-01-04 20:07:45 +00:00
Alex Lopez
63022efc7a Bug 1696251: Allow mach commands as stand-alone functions and adapt existing commands. r=mhentges,webdriver-reviewers,perftest-reviewers,sparky,whimboo
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.

Differential Revision: https://phabricator.services.mozilla.com/D121512
2021-09-27 18:12:51 +00:00
Alex Lopez
3a5f2e96c6 Bug 1696251: Adjust usages of mozbuild/build_commands.py's Build to simplify future declassing. r=mhentges
In this patch, we differentiate methods that actually come from the `Build`
class from those that actually come from the parent `MachCommandBase` class,
which will have to be called on the `command_context` object. Also, we rename
`builder` to `build_commands` in preparation for those methods becoming top-level
functions of the module of the same name.

Differential Revision: https://phabricator.services.mozilla.com/D126621
2021-09-27 15:17:58 +00:00
Butkovits Atila
eb735ac57e Backed out changeset 53b1fa0faa6d (bug 1696251) for breaking the static-analysis integration. a=backout 2021-09-23 13:06:40 +03:00
Alex Lopez
a8e7083c84 Bug 1696251: Allow mach commands as stand-alone functions and adapt existing commands. r=mhentges,webdriver-reviewers,perftest-reviewers,sparky,whimboo
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.

Differential Revision: https://phabricator.services.mozilla.com/D121512
2021-09-21 20:38:16 +00:00
Butkovits Atila
c06a3dd9fa Backed out changeset 510dd46a9de7 (bug 1696251) for causing Android build bustages. 2021-09-21 05:16:50 +03:00
Alex Lopez
fe61e94ec8 Bug 1696251: Allow mach commands as stand-alone functions and adapt existing commands. r=mhentges,webdriver-reviewers,perftest-reviewers,sparky,whimboo
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.

Differential Revision: https://phabricator.services.mozilla.com/D121512
2021-09-20 20:21:07 +00:00
Noemi Erli
91aa2e2b9c Backed out changeset 5f5b612878f3 (bug 1696251) for causing multiple bustages 2021-09-18 02:22:39 +03:00
Alex Lopez
bf860fe7dc Bug 1696251: Allow mach commands as stand-alone functions and adapt existing commands. r=mhentges,webdriver-reviewers,perftest-reviewers,sparky,whimboo
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.

Differential Revision: https://phabricator.services.mozilla.com/D121512
2021-09-17 19:00:39 +00:00
Michael Smith
7bc47a6675 Bug 1728438 - Fix ./mach cppunittest missing argument error r=mhentges
Bug 1696251 forgot to add a `command_context` argument to
`run_cppunit_test`, leading to a mach internal error when running
`./mach cppunittest`.

Differential Revision: https://phabricator.services.mozilla.com/D124128
2021-09-01 15:34:40 +00:00
Steve Fink
0df8aa085c Bug 1721291 - Report jsapi-tests failures with more than just the result code. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D120294
2021-07-26 18:47:48 +00:00
Brindusan Cristian
025b57bdaa Backed out changeset e141930afc4c (bug 1721291) for causing python checks failure in mach_commands.py.
CLOSED TREE
2021-07-22 21:59:05 +03:00
Steve Fink
45f13cfa7c Bug 1721291 - Report jsapi-tests failures with more than just the result code. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D120294
2021-07-22 18:34:18 +00:00
Alex Lopez
77ce415604 Bug 1696251 - Replace self with command_context where possible in existing mach commands. r=mhentges,webdriver-reviewers,perftest-reviewers,whimboo
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D118058
2021-07-19 16:04:25 +00:00
Butkovits Atila
a07f790e42 Backed out changeset e1921c5112d8 (bug 1696251) for causing bustages complaining about 'CommandContext'. CLOSED TREE 2021-07-16 20:35:55 +03:00
Alex Lopez
190e03aaab Bug 1696251 - Replace self with command_context where possible in existing mach commands. r=mhentges,webdriver-reviewers,perftest-reviewers,whimboo
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D118058
2021-07-16 15:51:29 +00:00
Alex Lopez
455d9a088b Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-05-17 16:15:58 +00:00
Mitchell Hentges
20c068df32 Bug 1709084: Don't encode debugger arg as ascii r=sheehan
We're mostly using Python 3 today, so the old `.encode("ascii")`
conversion is no longer needed.

Differential Revision: https://phabricator.services.mozilla.com/D114152
2021-05-04 15:07:07 +00:00
Butkovits Atila
2e34e363b9 Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE
Backed out changeset 1c84c9a34575 (bug 1696251)
Backed out changeset e169193b7423 (bug 1696251)
2021-04-23 02:53:36 +03:00
Alex Lopez
d1a82b8092 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-22 18:56:15 +00:00
Cosmin Sabou
785f9b8a87 Backed out changeset d4a5d8567977 (bug 1696251) for non-unified build bustages. CLOSED TREE 2021-04-19 19:43:31 +03:00
Alex Lopez
75dfe35468 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-19 16:15:11 +00:00
Joel Maher
113df4f3a2 Bug 1692453 - remove activedata from test-info. r=releng-reviewers,aki CLOSED TREE
remove activedata from test-info

Differential Revision: https://phabricator.services.mozilla.com/D106301
2021-02-24 22:52:18 +00:00
Csoregi Natalia
d8ef0fbfe6 Backed out changeset 24db9230985e (bug 1692453) for lint failure. CLOSED TREE 2021-02-25 02:27:35 +02:00
Joel Maher
a9dd0fa077 Bug 1692453 - remove activedata from test-info. r=releng-reviewers,aki
remove activedata from test-info

Differential Revision: https://phabricator.services.mozilla.com/D106301
2021-02-24 22:52:18 +00:00
Steve Fink
536f49d107 Bug 1688919 - Implement mach jit-test --cgc r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D103056
2021-01-26 23:22:46 +00:00
Bob Clary
c35f5ec5c8 Bug 1681096 - python3 - pylint --py3k - W1655: dict.keys referenced when not iterating (dict-keys-not-iterating) r=marionette-reviewers,perftest-reviewers,jmaher,maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D99056
2020-12-11 21:13:12 +00:00
Andrey Bienkowski
6bb5b574bc Bug 1674635 Improve documentation for mach test r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D95455
2020-11-03 17:09:46 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Ben Hearsum
b81bccea51 Bug 1638952: remove check-spidermonkey mach command. r=sfink,releng-reviewers,aki DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D94159
2020-10-22 13:12:32 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Ricky Stewart
6e1d74e077 Bug 1624667 - Allow running mach jit-test if tests are disabled r=mhentges,froydnj
This works fine, so no reason not to allow it.

Differential Revision: https://phabricator.services.mozilla.com/D86398
2020-08-26 14:45:52 +00:00
Ricky Stewart
26df756a8a Bug 1659113 - Fix bad call to constructor of Build object after bug 985141 r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D87076
2020-08-14 14:18:43 +00:00
Andrew Halberstadt
d0fbcca0b6 Bug 985141 - [mozbuild] Remove leading underscore from MozbuildObject._activate_virtualenv, r=firefox-build-system-reviewers,perftest-reviewers,andi,AlexandruIonescu,rstewart
This function is used all across the tree and should be considered a public API.

Differential Revision: https://phabricator.services.mozilla.com/D85045
2020-07-28 16:06:10 +00:00
Geoff Brown
d0f02440a4 Bug 1422005 - Fix 'mach test cppunittest'; r=jmaher
Correct typo in parameter name to enable 'mach test cppunittest'.

Differential Revision: https://phabricator.services.mozilla.com/D78984
2020-06-09 22:32:21 +00:00
Geoff Brown
446e3be5f6 Bug 1516847 - Update help and remove support for 'mach test' with no arguments; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D78804
2020-06-09 19:35:19 +00:00
Geoff Brown
3ce8434d77 Bug 1597261 - [mach test] Avoid re-using subsuite from earlier manifest; r=bc
Simply ensuring an empty kwargs['subsuite'] avoids this tricky edge case.

Differential Revision: https://phabricator.services.mozilla.com/D77910
2020-06-04 16:14:08 +00:00
Tooru Fujisawa
68c7f2f41e Bug 1628784 - Pass TOPSRCDIR environment variable to jsapi-tests, in order to read test files. r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D71255
2020-04-27 11:37:13 +00:00
Jan de Mooij
599df644e7 Bug 1619961 - Change 'mach jstests' to not run tests with --jitflags=jstests. r=tcampbell
Running tests with different JIT flags by default is inconsistent with
jstests.py or mach jit-test.

Differential Revision: https://phabricator.services.mozilla.com/D65325

--HG--
extra : moz-landing-system : lando
2020-03-04 16:45:55 +00:00
Geoff Brown
ab2019a124 Bug 1619693 - Implement 'mach test-info report-diff'; r=bc
A quick and basic implementation of 'mach test-info report-diff' to provide a
high level comparison of two reports generated by 'mach test-info report'.
Mostly this is trying to give an impression of how many and which tests
have been added and deleted during the time period between the reports.
There is more information in the reports; a more thorough comparison is
possible, but seems lower-value: To be considered in a future bug.

Differential Revision: https://phabricator.services.mozilla.com/D65202

--HG--
extra : moz-landing-system : lando
2020-03-04 08:09:13 +00:00
Hamzah
becd55c159 Bug 1614771 - Run ./mach addtest with Python 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D62541

--HG--
extra : moz-landing-system : lando
2020-02-13 16:56:44 +00:00
Chris Manchester
8f676d8627 Bug 1611298 - Fix TypeError in |./mach addtest|. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D60913

--HG--
extra : moz-landing-system : lando
2020-01-23 22:46:24 +00:00
Gijs Kruitbosch
e5848ed25c Bug 1610331 - use unix newlines when using 'mach addtest' on Windows, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D60459

--HG--
extra : moz-landing-system : lando
2020-01-21 16:51:39 +00:00
Geoff Brown
17e2f934a6 Bug 1601383 - Re-structure 'mach test-info' code; r=jmaher
Move almost all test-info code out of mach_commands.py and into its own file
and consolidate logging and imports; no functional changes.

Differential Revision: https://phabricator.services.mozilla.com/D56064

--HG--
extra : moz-landing-system : lando
2019-12-06 13:27:54 +00:00
Geoff Brown
320c507752 Bug 1600758 - Add basic ActiveData data to 'mach test-info report'; r=jmaher
This adds test run time and test run/skipped/failed counts for most test types.
There are numerous shortcomings (sometimes exceeding the ActiveData 10K record limit,
test path/name mismatches, no totals for manifest/component/all, etc) but I would
like to see this running asap as I think it provides a good foundation for further
work and discussion.

Differential Revision: https://phabricator.services.mozilla.com/D55576

--HG--
extra : moz-landing-system : lando
2019-12-03 18:56:25 +00:00
Botond Ballo
83bfe6cee0 Bug 1590857 - Don't prompt to install Android app if the user is running 'mach install'. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D54381

--HG--
extra : moz-landing-system : lando
2019-11-25 22:17:59 +00:00
Geoff Brown
c5fdf45f02 Bug 1582516 - Use TestManifestLoader for 'mach test-info'; r=ahal
Switch 'mach test-info report' and 'mach test-info tests' to use the TestManifestLoader.

Differential Revision: https://phabricator.services.mozilla.com/D54053

--HG--
extra : moz-landing-system : lando
2019-11-21 19:43:11 +00:00