Commit graph

51 commits

Author SHA1 Message Date
Hanna Jones
36a699b418 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
72bee76688 Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
dfc2a2c958 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Aron Cseh
a3a7c8505a Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
a1661cdc87 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Dave Townsend
95ccf713ef Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Benjamin VanderSloot
1dfc74c9fc Bug 1836792, part 3 - Adopt permissions UI to just show the same old prompt for 3rdPartyFrameAccess requests, r=anti-tracking-reviewers,timhuang,pbz
Differential Revision: https://phabricator.services.mozilla.com/D180217
2023-06-23 12:14:18 +00:00
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Iulian Moraru
170aaf5bb7 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
076aaf6671 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Abhishek Madan
ba1d4a0dfc Bug 1831363 - Converted SitePermissions.jsm to ES modules and all of its corresponding references. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D177380
2023-05-17 14:45:26 +00:00
Emilio Cobos Álvarez
1e06c8368f Bug 1826072 - Don't flex permission state label. r=pbz
Err, so the original patch is necessary but not sufficient, and I
clearly goofed my testing (I had removed this attribute in a separate
commit).

The issue is that this button ends up with a markup like:

  <button class="permission-popup-permission-remove-button">
    <label flex="1" class="permission-popup-permission-state-label">Allowed Temporarily</label>
    <hbox class="box-inherit button-box" align="center" pack="center" flex="1" anonid="button-box">
      <image class="button-icon"/>
      <label class="button-text"/>
    </hbox>
  </button>

So the label and hbox divide the available space in half. Removing any
of the flex="1" attributes would cause the desired rendering.

I don't think the hbox needs to be flexible tbh, but ok, that's a
riskier change. I'm pretty sure the label in this case doesn't need to
be flexible at all though, specially since we don't want these buttons
to take any minimum amount of space.

An alternative would be to use `flex: 1 auto` or so for the label (via
CSS). That'd match the pre-regression behavior more exactly, but again I
don't think flexing the label is needed at all.

Depends on D174706

Differential Revision: https://phabricator.services.mozilla.com/D174707
2023-04-05 12:04:03 +00:00
ganna
451ba15d72 Bug 1814270 - Use moz-support-link for permission-popup-storage-access-permission-learn-more label. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D173748
2023-03-30 17:59:46 +00:00
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Karl Tomlinson
281ca8cf56 Bug 1712892 use _createWebRTCPermissionItem() for speaker selection permissions r=pbz
so as to add support for double-keyed per device permissions, which can then
all be cleared from a single item/button.

Differential Revision: https://phabricator.services.mozilla.com/D162233
2022-12-13 09:37:34 +00:00
Emilio Cobos Álvarez
e83fac1f59 Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Mike Conley
bc4a7e92e8 Bug 1783918 - Part 3: Make it possible for the permission panel anchor and position to be overridden. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154129
2022-08-10 15:05:32 +00:00
Mike Conley
81ace6c055 Bug 1783918 - Part 2: Make gPermissionPanel._openPopup public. r=pbz
This also moves the fullscreen fix for bug 1557041 to the top of openPopup so that
direct callers of openPopup don't bypass the fix.

Differential Revision: https://phabricator.services.mozilla.com/D154128
2022-08-10 15:05:32 +00:00
Dão Gottwald
c1126d1f68 Bug 1706534 - Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D114475
2021-10-13 16:37:56 +00:00
Cristian Tuns
46ff225256 Backed out changeset 3132e2d5dc45 (bug 1706534) for causing mochitest failures on browser_creditCard_doorhanger.js. CLOSED TREE 2021-10-13 10:48:47 -04:00
Dão Gottwald
5e3dbb91d5 Bug 1706534 - Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D114475
2021-10-13 12:39:06 +00:00
Bernard Igiri
d8cff91aa0 Bug 1706192 - Get rid of popup-subitem r=mconley
Removed occurences of popup-subitem.

Differential Revision: https://phabricator.services.mozilla.com/D117330
2021-06-17 15:30:28 +00:00
Csoregi Natalia
ee2d1d13f4 Backed out changeset 9c2ba085b136 (bug 1703609) for failures on browser_devices_get_user_media_queue_request.js. CLOSED TREE 2021-06-15 02:55:35 +03:00
Molly Howell
c5b07911a3 Bug 1703609 - Hide doorhangers while site permissions panel is showing. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D117700
2021-06-14 20:49:38 +00:00
Ramya Praneetha
bb64177cfa Bug 1676067 - Renamed "Show blocked pop-up" to "Open blocked pop-up" in site info menu. r=prathiksha,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D112016
2021-04-15 16:23:11 +00:00
Tim Huang
695ae2a516 Bug 1676074 - Part 1: Add a learn more link into the "Cross-site cookies" permission header description. r=johannh,fluent-reviewers,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D112044
2021-04-15 09:27:26 +00:00
Dão Gottwald
725e4d8466 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-14 13:57:34 +00:00
Jan-Ivar Bruaroey
f0138debf4 Bug 1697487 - Show gray cam/mic indicator during permission grace periods. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D111000
2021-04-14 11:20:15 +00:00
Emma Malysz
c8cee984e2 Bug 1703476, update site permission panel formatting r=mconley,pbz
Changes includde padding/margin changes and button structure

Differential Revision: https://phabricator.services.mozilla.com/D111479
2021-04-12 16:28:01 +00:00
smolnar
6524a17cb9 Backed out changeset 034a69e0a73e (bug 1701306) for causing browser-chrome failures in browser_page_action_menu. CLOSED TREE 2021-04-08 17:16:21 +03:00
Dão Gottwald
ce1716242b Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-08 12:53:08 +00:00
Alexandru Michis
8c30456526 Backed out changeset 8d8aa8575c1d (bug 1701306) for causing multiple bc failures.
CLOSED TREE
2021-04-06 19:45:27 +03:00
Dão Gottwald
53e4be34d5 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-06 13:22:50 +00:00
Paul Zuehlcke
d94f9c0a90 Bug 1695615 - Updated permission panel for double-keyed WebRTC permissions. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D107071
2021-03-12 10:06:16 +00:00
Paul Zuehlcke
f58f5ab06c Bug 1695615 - Removed obsolete per-frame permission tracking for geolocation and WebRTC permissions. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D107070
2021-03-12 10:06:16 +00:00
Paul Zuehlcke
805563414d Bug 1695356 - Show permission indicator for any non-default site-permissions. r=johannh
Before decoupling the permission panel in Bug 1596897, the permission indicator was
not shown if we had a blocked permission icon to show instead. With the decoupled
permissions panel it needs to be shown whenever we have permissions listed in the
panel. The granted permissions icon is now the anchor for the panel.

Differential Revision: https://phabricator.services.mozilla.com/D106771
2021-03-04 12:18:06 +00:00
Marco Bonardo
4bec69c9ae Bug 1693338 - Remove obsolete WebRTC icon blink synchronization code. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D106277
2021-02-24 23:11:44 +00:00
james
16060f0cc4 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
ed6880e281 Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
8069ab6165 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Paul Zuehlcke
66fe5653ff Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-02-05 13:40:35 +00:00
Narcis Beleuzu
868935867c Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Paul Zuehlcke
6445d181dc Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-29 16:06:08 +00:00
Brindusan Cristian
e117dc4695 Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00