nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
772641 commits 1 branch 98 tags 6.4 GiB
Commit graph

1428 commits

Author SHA1 Message Date
Alexandru Michis
26c14b3225 Backed out 24 changesets (bug 1678373) for causing bc failures in browser_tab_visibility_and_play_time.js 
CLOSED TREE

Backed out changeset 1886dbd81c46 (bug 1678373)
Backed out changeset aeff26b5b1ae (bug 1678373)
Backed out changeset 261d8e4483d4 (bug 1678373)
Backed out changeset 89cb5ae23632 (bug 1678373)
Backed out changeset b1eaedd192ab (bug 1678373)
Backed out changeset 58a3eb19c818 (bug 1678373)
Backed out changeset b027ec789cbe (bug 1678373)
Backed out changeset fd596a84feb9 (bug 1678373)
Backed out changeset 1f0ed0392ae2 (bug 1678373)
Backed out changeset ac2be1df81af (bug 1678373)
Backed out changeset bf6d47905d78 (bug 1678373)
Backed out changeset a9fe4f310962 (bug 1678373)
Backed out changeset a15316058968 (bug 1678373)
Backed out changeset 217cdfd46120 (bug 1678373)
Backed out changeset c33c8411129b (bug 1678373)
Backed out changeset 3b854fc36abf (bug 1678373)
Backed out changeset e47c82bcb49a (bug 1678373)
Backed out changeset 2a77cbba1c9f (bug 1678373)
Backed out changeset 65206afede36 (bug 1678373)
Backed out changeset bd04930155f4 (bug 1678373)
Backed out changeset 034e8edd4619 (bug 1678373)
Backed out changeset ed1e56487c4c (bug 1678373)
Backed out changeset b7673d20c521 (bug 1678373)
Backed out changeset 5a93251e2fea (bug 1678373)
 2021-10-07 20:36:47 +03:00
Paul Adenot
82125c0639 Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125088
 2021-10-07 15:44:54 +00:00
Paul Adenot
6dc847cdf6 Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125084
 2021-10-07 15:44:53 +00:00
Paul Adenot
94b7678216 Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D125083
 2021-10-07 15:44:53 +00:00
Paul Adenot
2d55780bdd Bug 1733109 - function 'mozilla::dom::HTMLMediaElement::MozGetMetadata' has a definition with different parameter names in HTMLMediaElement.cpp. r=alwu 
Depends on D126946

Differential Revision: https://phabricator.services.mozilla.com/D126947
 2021-09-30 12:36:18 +00:00
Paul Adenot
477acd5f27 Bug 1733109 - narrowing conversion from 'double' to 'float' in HTMLMediaElement.cpp. r=alwu 
Depends on D126945

Differential Revision: https://phabricator.services.mozilla.com/D126946
 2021-09-30 12:36:18 +00:00
Paul Adenot
f3cd1e466b Bug 1733109 - 'auto cdmProxy' can be declared as 'auto *cdmProxy' in HTMLMediaElement.cpp. r=alwu 
Depends on D126944

Differential Revision: https://phabricator.services.mozilla.com/D126945
 2021-09-30 12:36:18 +00:00
Paul Adenot
97fe06afcc Bug 1733109 - do not use 'else' after 'return' in HTMLMediaElement.cpp. r=alwu 
Depends on D126943

Differential Revision: https://phabricator.services.mozilla.com/D126944
 2021-09-30 12:36:17 +00:00
Paul Adenot
915a3a4d1a Bug 1733109 - local copy 'handle' of the variable 'aPrincipalHandle' is never modified; consider avoiding the copy in HTMLMediaElement.cpp. r=alwu 
Depends on D126942

Differential Revision: https://phabricator.services.mozilla.com/D126943
 2021-09-30 12:36:17 +00:00
Paul Adenot
0f7d0e3beb Bug 1733109 - 'auto decoder' can be declared as 'auto *decoder' in HTMLMediaElement.cpp. r=alwu 
Depends on D126941

Differential Revision: https://phabricator.services.mozilla.com/D126942
 2021-09-30 12:36:16 +00:00
Paul Adenot
ab7bfb48a1 Bug 1733109 - 'auto decoder' can be declared as 'auto *decoder' in HTMLMediaElement.cpp. r=alwu 
Depends on D126940

Differential Revision: https://phabricator.services.mozilla.com/D126941
 2021-09-30 12:36:16 +00:00
Paul Adenot
4ef93dfafd Bug 1733109 - move constructors should be marked noexcept HTMLMediaElement.cpp. r=alwu 
We don't use exceptions anyways, but having no warnings allows warning us when
warnings appear, so let's fix this.

Depends on D126939

Differential Revision: https://phabricator.services.mozilla.com/D126940
 2021-09-30 12:36:16 +00:00
Paul Adenot
7b15802441 Bug 1733109 - narrowing conversion from 'unsigned long' to signed type 'int32_t' (aka 'int') is implementation-defined HTMLMediaElement.cpp. r=pehrsons 
Somewhat controversial, let me know what you think.

Differential Revision: https://phabricator.services.mozilla.com/D126939
 2021-09-30 12:36:15 +00:00
Paul Adenot
eb06a61abe Bug 1733109 - redundant return statement at the end of a function with a void return type in HTMLMediaElement.cpp. r=alwu 
Depends on D126937

Differential Revision: https://phabricator.services.mozilla.com/D126938
 2021-09-30 12:36:15 +00:00
Paul Adenot
91a3981b9c Bug 1733109 - narrowing conversion from 'double' to 'float' in HTMLMEdiaElement.cpp. r=alwu 
Depends on D126935

Differential Revision: https://phabricator.services.mozilla.com/D126936
 2021-09-30 12:36:14 +00:00
Paul Adenot
b9d6ecd246 Bug 1733109 - constructor does not initialize these fields: mOwnerBrowsingContextId in HTMLMEdiaElement.cpp. r=alwu 
Depends on D126934

Differential Revision: https://phabricator.services.mozilla.com/D126935
 2021-09-30 12:36:14 +00:00
Olli Pettay
f083f381d8 Bug 1727514 - media playback should stop in the bfcache, r=peterv 
This version doesn't change SetContainer handling, since it seems to be tricky for the top level page.
So only activity change notification is fired and IsActive() is updated.
The comment about IsActive() was wrong even with the old bfcache implementation.
(I did check that it returned false when the page was in bfcache and many of the activity observers rely on that)

The changes to HTMLMediaElement are needed to ensure page can enter bfcache..

Differential Revision: https://phabricator.services.mozilla.com/D124684
 2021-09-20 08:49:22 +00:00
Sandor Molnar
c60bc752d8 Backed out changeset 2d49d73f38aa (bug 1727514) for causing frequent crashes. a=backout 2021-09-16 15:52:56 +03:00
Olli Pettay
d0485c8a55 Bug 1727514 - media playback should stop in the bfcache, r=peterv 
SetContainer handling is similar to what DocumentViewer does for the old bfcache implementation.
(The old implementation hides it quite well).
The changes to HTMLMediaElement are needed to ensure page can enter bfcache.

Removed erroneous MOZ_ASSERT in nsPresContext, it is ok to trigger that code path in the new implementation.
And the Run() method of the relevant nsIRunnable already deals with that case.

Differential Revision: https://phabricator.services.mozilla.com/D124684
 2021-09-13 12:40:18 +00:00
Alexandru Michis
bd2de15f47 Backed out 2 changesets (bug 1724106) for causing Bug 1728715. 
CLOSED TREE

Backed out changeset 81d1db229eea (bug 1724106)
Backed out changeset 8ed4675541c6 (bug 1724106)
 2021-09-02 21:03:07 +03:00
Bryce Seager van Dyk
cfec4e7dfa Bug 1724106 - Clarify threading usage when getting media debug info. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D124104
 2021-09-01 22:29:48 +00:00
alwu
01fee60b95 Bug 1723799 - part2 : add test. r=padenot,webidl,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D121681
 2021-08-09 19:30:12 +00:00
Kagami Sascha Rosylight
c69d367ce0 Bug 1723050 - Part 14: Replace typedef by using in dom/html/ r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D121312
 2021-08-09 13:37:27 +00:00
Karl Tomlinson
50445cc8e2 Bug 1577199 apply speaker-selection feature policy r=jib 
Differential Revision: https://phabricator.services.mozilla.com/D119867
 2021-08-02 00:13:57 +00:00
Tooru Fujisawa
cc92ef732d Bug 1708448 - Move property and element functions into js/public/PropertyAndElement.h. r=nbp 
Differential Revision: https://phabricator.services.mozilla.com/D119619
 2021-07-13 11:52:42 +00:00
Karl Tomlinson
ebbb65d72e Bug 1493982 accept only sinkIds exposed via enumerateDevices() r=jib 
and reject with NotFoundError otherwise.

Depends on D118444

Differential Revision: https://phabricator.services.mozilla.com/D118445
 2021-07-06 23:37:33 +00:00
Karl Tomlinson
832509f1a5 Bug 1493982 move GetSinkDevice() to MediaDevices for access to device exposure history r=jib 
Depends on D118443

Differential Revision: https://phabricator.services.mozilla.com/D118444
 2021-07-06 23:37:32 +00:00
Paul Adenot
78824dbdc4 Bug 1703603 - Handle HTMLMediaElement playing MediaSource when using mozCaptureStreamUntilEnded. r=bryce 
This means keeping a reference to the MediaSource object in the MediaStream to
ensure it's being kept alive for the duration of the playback.

Differential Revision: https://phabricator.services.mozilla.com/D112607
 2021-06-02 14:20:40 +00:00
Olli Pettay
b01c8b4aff Bug 1705080, make MediaStreams behave as normal EventTargets, r=jib 
Differential Revision: https://phabricator.services.mozilla.com/D115269
 2021-05-18 16:21:27 +00:00
Csoregi Natalia
d1bbd6e368 Backed out 2 changesets (bug 1693250) for failures on test_recreate_media_sink_audible_change.html. CLOSED TREE 
Backed out changeset 0e0f90271853 (bug 1693250)
Backed out changeset 45cd86944c9f (bug 1693250)
 2021-05-06 01:14:51 +03:00
alwu
429bd59056 Bug 1693250 - part2 : reset the audible state when the audio sink get shutdown. r=bryce 
When the audio sink shutdown, we should also reset the audible state for the listeners. Otherwise, MediaDecoderStateMachine would possibly rely on the incorrect audible state that is produced by previous sink, which would cause showing the sound indicator even if no sound is being playing.

Eg.
Considering following case without the reset of the audible state
1. Sink A is audible -> MDSM set `mIsAudioDataAudible=true`
2. Stop sink
3. Recreate sink B and it's playing silence -> MDSM's `mIsAudioDataAudible=true` is still true, this is wrong!

Differential Revision: https://phabricator.services.mozilla.com/D113550
 2021-05-05 20:07:07 +00:00
alwu
ebd128cde0 Bug 1689741 - not controlling the real-time media via the media control. r=padenot 
Differential Revision: https://phabricator.services.mozilla.com/D112668
 2021-04-20 16:47:41 +00:00
Brendan Early
11d4046786 Bug 1120222 - Set AudioSink name to title of MediaElement's parent r=padenot 
Differential Revision: https://phabricator.services.mozilla.com/D93462
 2021-04-19 15:17:26 +00:00
Peter Van der Beken
164f59d833 Bug 1696158 - Move CanSavePresentation to the parent process. Keep track of various flags for deciding whether to put a page in BFCache. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D110231
 2021-04-19 14:50:54 +00:00
smolnar
84a0543987 Backed out 8 changesets (bug 1696158) for causing multiple failures. CLOSED TREE 
Backed out changeset 09c598c8fd29 (bug 1696158)
Backed out changeset 02f956c26901 (bug 1696158)
Backed out changeset b61a3a324cce (bug 1696158)
Backed out changeset 95810ed7f1e5 (bug 1696158)
Backed out changeset 4f93a7b61496 (bug 1696158)
Backed out changeset c80c55b56f2a (bug 1696158)
Backed out changeset 11627c409882 (bug 1696158)
Backed out changeset b98b4316a510 (bug 1696158)
 2021-04-19 17:04:08 +03:00
Peter Van der Beken
a1306f8324 Bug 1696158 - Move CanSavePresentation to the parent process. Keep track of various flags for deciding whether to put a page in BFCache. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D110231
 2021-04-19 12:39:19 +00:00
Paul Adenot
8d2ea44b0e Bug 1701276 - Adjust currentSrc behaviour to match the spec more closely. r=bryce 
Firefox and Chrome support setting `src` with an `ObjectURL`. This is
technically a URL and should be treated as such. Firefox recently changed to
return `""` when a `MediaSource` is playing, and this is wrong, because even
though it's playing a from a "Media Provider Object", it got loaded from the
`src` attribute, so should have a non-null `currentSrc`, which should be the
blob url (`blob:origin/<an uuid>`). In this case, `currentSrc` is a string that
is opaque and doesn't allow introspection but refers to the "real" `MediaSource`
or `Blob`.

If the same `MediaSource` is loaded via the `srcObject` attribute (that Firefox
and Chrome don't support), then `currentSrc` should return `""` and `srcObject`
still has the object set to it to understand what the HTMLMediaElement is
playing. We'll implement and test this later.

Differential Revision: https://phabricator.services.mozilla.com/D110290
 2021-04-01 12:28:50 +00:00
Csoregi Natalia
e99de2637f Backed out changeset fe753b00f953 (bug 1701276) for wpt fails on resource-selection-currentSrc.html. CLOSED TREE 2021-03-31 21:00:20 +03:00
Paul Adenot
3a84032713 Bug 1701276 - Adjust currentSrc behaviour to match the spec more closely. r=bryce 
Firefox and Chrome support setting `src` with an `ObjectURL`. This is
technically a URL and should be treated as such. Firefox recently changed to
return `""` when a `MediaSource` is playing, and this is wrong, because even
though it's playing a from a "Media Provider Object", it got loaded from the
`src` attribute, so should have a non-null `currentSrc`, which should be the
blob url (`blob:origin/<an uuid>`). In this case, `currentSrc` is a string that
is opaque and doesn't allow introspection but refers to the "real" `MediaSource`
or `Blob`.

If the same `MediaSource` is loaded via the `srcObject` attribute (that Firefox
and Chrome don't support), then `currentSrc` should return `""` and `srcObject`
still has the object set to it to understand what the HTMLMediaElement is
playing. We'll implement and test this later.

Differential Revision: https://phabricator.services.mozilla.com/D110290
 2021-03-31 12:28:39 +00:00
Eden Chuang
c7aa9a7c9c Bug 1696111 - Make LoadInfo know if the request is triggered from a media element and if it's an initial request. r=necko-reviewers,alwu,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D106890
 2021-03-30 00:52:31 +00:00
Butkovits Atila
ad9b1ed9d7 Backed out 12 changesets (bug 1683131, bug 1696111, bug 1695987) for causing crashes(Bug 1701151). a=backout 
Backed out changeset 8ffef57e27d2 (bug 1683131)
Backed out changeset c02d5dc72abb (bug 1695987)
Backed out changeset 276f016ddc67 (bug 1683131)
Backed out changeset 2c7a45e20b50 (bug 1683131)
Backed out changeset 11fdb503d537 (bug 1696111)
Backed out changeset 2946eff1e9c8 (bug 1696111)
Backed out changeset e4d01b88e517 (bug 1696111)
Backed out changeset fab7f4cd445d (bug 1696111)
Backed out changeset d60c38f8939a (bug 1696111)
Backed out changeset 3fdc8089a46f (bug 1696111)
Backed out changeset 51a16dfabc98 (bug 1696111)
Backed out changeset 642bdd52fd57 (bug 1696111)
 2021-03-26 11:30:28 +02:00
Eden Chuang
908b174731 Bug 1696111 - Make LoadInfo know if the request is triggered from a media element and if it's an initial request. r=necko-reviewers,alwu,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D106890
 2021-03-25 12:09:40 +00:00
Simon Giesecke
cc730d05dd Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D108588
 2021-03-24 17:56:50 +00:00
Simon Giesecke
613e20d136 Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D108587
 2021-03-24 17:56:49 +00:00
Simon Giesecke
b9621d6376 Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D108585
 2021-03-17 15:49:46 +00:00
Simon Giesecke
cb6c8aead4 Bug 1695162 - Make nsTHashtable::ConstIter return a real ConstIterator. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D107038
 2021-03-09 10:28:16 +00:00
Sylvestre Ledru
4edd85cc9b Bug 1519636 - Reformat recent changes to the Google coding style r=necko-reviewers,valentin 
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D106920
 2021-03-02 16:14:46 +00:00
Simon Giesecke
2586ff14b9 Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/html. r=mattwoodrow 
Differential Revision: https://phabricator.services.mozilla.com/D106112
 2021-03-01 09:59:29 +00:00
Simon Giesecke
9af107a839 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika 
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
 2021-02-26 09:11:46 +00:00
alwu
02a5936205 Bug 1691578 - part7 : add test case for audio sink failed start-up. r=bryce,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D104571
 2021-02-25 18:07:07 +00:00