(To be landed right after the soft freeze is over)
One interesting consequence of my previous patch in this bug, is that
the time at which the XUL element processes the click event is different
(earlier, at bubbling phase rather than after everything).
This caused some test failures caused by the panel autohide, since now
it goes after than the native handling and the native handling
default-prevents to dispatch the XUL command.
Given we don't check key events for defaultPrevented either, it makes
sense to be consistent.
This uncovered an interesting failure, where the "show more tabs" button
in the sync menu starts closing the panel unexpectedly on click. The
right fix is to use closemenu="none" in that button, since otherwise
that button is not keyboard accessible (this is an issue on current
nightly that this patch fixes).
Differential Revision: https://phabricator.services.mozilla.com/D157584
Only two strings that appear in the accounts panel are still in title case,
but those two need to be forked, because they are also used in other menus
where they need to remain in title case.
This patch adds the two "new" strings and the necessary switch to select
between them and the existing strings, since all of these menus are dynamically
constructed by the same code.
Differential Revision: https://phabricator.services.mozilla.com/D122764
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
other commands, namely the wipeEngine command
Differential Revision: https://phabricator.services.mozilla.com/D118086
This also removes code that handled the case where a Send Tab or Send Link to Device
menu needed to be populated when in the STATUS_NOT_CONFIGURED state. Since those menus
should be unavailable when in the STATUS_NOT_CONFIGURED state, we throw instead.
Depends on D118622
Differential Revision: https://phabricator.services.mozilla.com/D118623
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
other commands, namely the wipeEngine command
Differential Revision: https://phabricator.services.mozilla.com/D118086
The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.
In the signed in and signed out state, the label is already correct (and either doesn't include
an email address, or doesn't include anything *but* the email address).
Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).
Differential Revision: https://phabricator.services.mozilla.com/D113657
The Proton app menu version of the accounts button doesn't need the button
label attribute for display purposes, but if the attribute isn't updated when
an error happens, then accessibility tools only ever see the "Sign in" text.
Differential Revision: https://phabricator.services.mozilla.com/D111183
This patch:
-displays the correct fxa button in the app menu when
unverified or disconnected
-shows the "sign out" button in the fxa panel for the above states
-introduces a new string for a disconnected state
-strengthens our test coverage for the proton fxa panel
Differential Revision: https://phabricator.services.mozilla.com/D109802
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Differential Revision: https://phabricator.services.mozilla.com/D106651
