Hanna Jones
614f900ec6
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,karlt,whimboo,tgiles,dao,devtools-reviewers
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-10 18:55:29 +00:00
Norisz Fay
0d4fc02631
Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
...
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones
fc2bc4071a
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,karlt,whimboo,tgiles,dao,devtools-reviewers
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-05 15:04:18 +00:00
Cosmin Sabou
45ad585956
Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE
...
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
2024-01-04 18:53:25 +02:00
Hanna Jones
f78c584212
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,reusable-components-reviewers,karlt,whimboo,tgiles,dao
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-04 15:31:12 +00:00
Mark Banner
8d1ebcb9d6
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Eemeli Aro
6b9e2716f0
Bug 1732151 - Migrate dataReportingNotification strings to Fluent. r=preferences-reviewers,fluent-reviewers,flod
...
The dataReportingNotification is the last place where the .properties
vendorShortName is used. As notifications already support Fluent,
porting this to use Fluent as well seems pretty strqaightforward.
Differential Revision: https://phabricator.services.mozilla.com/D141860
2022-03-24 15:57:54 +00:00
Neil Deakin
a62618baa7
Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-17 09:04:59 +00:00
Narcis Beleuzu
72152613c6
Backed out 3 changesets (bug 1690390) for mochitest failures on test_notificationbox.xhtml . CLOSED TREE
...
Backed out changeset e6404b7424cd (bug 1690390)
Backed out changeset a161177099af (bug 1690390)
Backed out changeset cc7e02d3d418 (bug 1690390)
2021-09-16 23:41:21 +03:00
Neil Deakin
82501df9f7
Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-16 19:11:17 +00:00
Kris Maglione
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Victor Porof
f9f5914039
Bug 1561435 - Format browser/base/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D36041
--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Trushita
89435f2ad4
Bug 1494948: Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten
...
Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.
Differential Revision: https://phabricator.services.mozilla.com/D26795
--HG--
extra : moz-landing-system : lando
2019-04-09 20:40:26 +00:00
Kris Maglione
e930b89c34
Bug 1514594: Part 3 - Change ChromeUtils.import API.
...
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Dão Gottwald
5973fb688b
Bug 1509451 - Remove LOGGER_NAME and LOGGER_PREFIX as global variables. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D12729
--HG--
extra : moz-landing-system : lando
2018-11-23 10:22:45 +00:00
Paolo Amadini
ce13039af3
Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D10892
--HG--
extra : rebase_source : f66fe90d780c3d446f4a065c0397cbb37f43cb0c
2018-11-09 14:38:49 +00:00
Kris Maglione
a259026c9d
Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
...
This also removes any redundant Ci.nsISupports elements in the interface
lists.
This was done using the following script:
acecb401b7/processors/chromeutils-generateQI.jsm
2018-04-22 20:55:06 -07:00
Kris Maglione
918ed6c474
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178
Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
...
Backed out changeset a1eca62826a1 (bug 143153314315331431533
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb
Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
...
Backed out changeset 6e56f4c8843e (bug 14315331431533
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
2018-01-29 15:20:18 -08:00
Ricky Chien
daac97d466
Bug 1349689 - Remove old preferences fork r=jaws
...
MozReview-Commit-ID: GNPcQGUTUKJ
--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 9adc8231c896f93f7f262a09482b44a2875bd5fd
2017-08-21 17:48:18 +08:00
Sebastian Hengst
51133fbff6
Backed out changeset df8215261c7e (bug 1349689) on request from rchien. r=backout
...
--HG--
rename : browser/components/preferences/in-content/findInPage.js => browser/components/preferences/in-content-new/findInPage.js
rename : browser/components/preferences/in-content/searchResults.xul => browser/components/preferences/in-content-new/searchResults.xul
rename : browser/components/preferences/in-content/tests/browser_checkspelling.js => browser/components/preferences/in-content-new/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content/tests/browser_engines.js => browser/components/preferences/in-content-new/tests/browser_engines.js
rename : browser/components/preferences/in-content/tests/browser_layersacceleration.js => browser/components/preferences/in-content-new/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content/tests/browser_masterpassword.js => browser/components/preferences/in-content-new/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content/tests/browser_permissions_dialog.js => browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content/tests/browser_security-1.js => browser/components/preferences/in-content-new/tests/browser_security-1.js
rename : browser/components/preferences/in-content/tests/browser_security-2.js => browser/components/preferences/in-content-new/tests/browser_security-2.js
2017-08-31 16:58:32 +02:00
Ricky Chien
3ff2ff68ed
Bug 1349689 - Remove old preferences fork r=jaws
...
MozReview-Commit-ID: GNPcQGUTUKJ
--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 6f59261adcb6cd3098b3596c01c9165ad6bfc03c
2017-08-21 17:48:18 +08:00
Marco Castelluccio
1ac9951d82
Bug 1357517 - Remove or delay Preferences.jsm usage from some browser/base/content/* files. r=Gijs
...
--HG--
extra : rebase_source : 838f891fc0d6a53a82f06f6b9c4261ae89c79cc3
2017-07-31 12:51:35 +02:00
Timothy Guan-tin Chien
0d616cb6d0
Bug 1363850, Part III, Set pref to make new about:preferences Nightly only, r=jaws,mconley
...
MozReview-Commit-ID: Khanjh79tPd
--HG--
extra : rebase_source : 84d197b1b1915d767049bfc0280c070e89c286d1
2017-05-25 18:12:00 +08:00
Fischer.json
c0472057e4
Bug 1330315 - Add a telemetry probe to track how the Preferences are opened, r=mconley
...
MozReview-Commit-ID: GfuGF4v30pI
--HG--
extra : rebase_source : e8b4399bd1e3fc5e5b220e80d6694c00a4b7e482
2017-05-09 10:43:48 -04:00
Sebastian Hengst
8bd051237a
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: JpAhOPjgvkF
2017-04-15 19:59:24 +02:00
Jared Wein
70423b9a34
Bug 1355522 - Move Telemetry and Health Report prefs to Privacy & Security section. r=florian
...
MozReview-Commit-ID: 1Ybpr68SKC0
--HG--
extra : rebase_source : ffb1c0430105dd30a6d406fbebdbb9b84bca245d
2017-04-12 10:14:51 -04:00
Jared Wein
bb639760df
Bug 1353805 - Allow showing only subcategories of a section to make finding prefs easier. r=mconley
...
This is a temporary measure until we have search complete and shipped (1353954).
MozReview-Commit-ID: KFeOefJ1RGM
--HG--
extra : rebase_source : 326a61f43e3e6f6d771b5bab713454945c9ee060
2017-04-05 23:03:10 -04:00
Zack Herrick
84361e7e85
Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
...
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).
The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).
Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.
MozReview-Commit-ID: 1sx0Wj15yM7
--HG--
extra : rebase_source : 0266027fb3023d4cb155533193d6809d799de1e4
2017-03-29 11:52:08 -04:00
Florian Queze
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Sebastian Hengst
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Quèze
85611a7b6d
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
...
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Jared Wein
b33bfba51a
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8
...
MozReview-Commit-ID: 2MhpvzUDgtK
--HG--
extra : rebase_source : 1df2b81badfe556928f6424c8990e4b3fde7056f
2017-01-06 12:09:28 -05:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mark Banner
09ab00a94f
Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
...
MozReview-Commit-ID: IyFGBotfd11
--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Alessio Placitelli
cf73009777
Bug 1234522 - Remove services/datareporting. r=gfritzsche
...
--HG--
rename : services/datareporting/datareporting-prefs.js => toolkit/components/telemetry/datareporting-prefs.js
2016-01-05 02:01:00 +01:00
Felipe Gomes
909d49249d
Bug 1228627 - Remove #includes from browser.js. r=Gijs
2015-11-30 12:13:57 -02:00
Shu-yu Guo
64db2267cf
Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
Giovanny Andres Gongora Granada
1adc493a26
Bug 1126738 - Use arrow functions in browser-data-submission-info-bar.js. r=dao
2015-01-28 23:18:14 +01:00
Alexander Dimitrov
8bc958ce39
Bug 1126259 - Removal of the unload event handler in browser-data-submission-info-bar.js is broken and can go away. r=dao
...
--HG--
extra : rebase_source : 373c4b2381c71d5b36338ab789cd7696f84bc717
2015-01-27 17:09:04 +01:00
Georg Fritzsche
db980a370f
Bug 862563 - Remove implicit acceptance for data reporting notification and notify on first run. r=gps
...
The data reporting notification was over-complicated. It wasn't
displayed for +24hr after first run and it had a weird, non-required
policy around what constituted acceptance of the policy.
The notification is now shown shortly after first startup.
The logic around "notification accepted" has been greatly simplified by
rolling it into "notification shown." Where we once were checking
whether the notification has been "accepted," we now check whether it
has been displayed. The overly complicated logic around the implicit
acceptance of the policy has also been removed.
The end result is the code for managing the state of the notification is
greatly simplified.
2014-07-09 14:32:29 -07:00
Wes Kocher
12b6391129
Backed out changeset 8673477f5fc2 (bug 862563) for Windows mochitest-5 failures
2014-07-11 17:00:08 -07:00
