Commit graph

433 commits

Author SHA1 Message Date
roc+%cs.cmu.edu
b65c655ed9 Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc 2005-12-12 23:53:06 +00:00
bzbarsky%mit.edu
5c508f5e01 Remove no longer needed event hack. Bug 146399, patch by Vidar Haarr
<vhaarr+bmo@gmail.com>, r=dbaron, sr=rbs
2005-12-08 01:44:30 +00:00
neil%parkwaycc.co.uk
0d29adadea Bug 317937 Get rid of some unnecessary CIDs and change some possibly unsafe nsCOMPtr usage into the equivalently unsafe static casts r=darin sr=jst 2005-12-02 12:02:44 +00:00
timeless%mozdev.org
1c34e68034 Bug 106386 Correct misspellings in source code
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
2005-11-20 22:05:24 +00:00
bzbarsky%mit.edu
27c439cb3c Remove the dummy frame stuff from selects. Replace it with smarter focus rect
painting and sizing for empty selects.  Bug 314879, r+sr=dbaron
2005-11-04 23:36:27 +00:00
roc+%cs.cmu.edu
520b30a7f7 Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell 2005-11-04 02:38:33 +00:00
cvshook%sicking.cc
64a0fbd45f Bug 311827: Make GetAttr return a bool rather then an nsresult.
r/sr=bz
2005-10-28 11:25:24 +00:00
bzbarsky%mit.edu
04825cfb67 Fix bug 313498 -- no need for aPresContext in GetOptionsContainer. r+sr=roc. 2005-10-23 22:11:27 +00:00
dbaron%dbaron.org
6beb9b195c Indentation fixes needed after s/nsIPresContext/nsPresContext/. Whitespace changes only. 2005-10-15 04:08:04 +00:00
peterv%propagandism.org
3609c87767 Fix for bug 27382 (ownerDocument of orphan text and attr nodes is null). Patch by sicking, updated by peterv, r=bz, sr=peterv. 2005-09-24 18:43:15 +00:00
aaronleventhal%moonset.net
030b1bfae0 Bug 306437. Onchange events fired twice for option selection via mouseclick. r=dbaron, sr=neil 2005-09-04 18:20:56 +00:00
bzbarsky%mit.edu
0f56e73dd0 Make sure kepress handlers are not affected by Caps Lock state. Bug 295228,
patch by Dainis Jonitis <Dainis_Jonitis@swh-t.lv>, r=neil, sr=bzbarsky
2005-08-30 18:13:48 +00:00
bzbarsky%mit.edu
0d6a610963 Make nsIPresShell::GetPrimaryFrameFor return nsIFrame* instead of using an out
param.  Bug 303779, patch by Bastiaan Jacques <b.jacques@planet.nl>, r+sr=bzbarsky
2005-08-22 22:24:29 +00:00
timeless%mozdev.org
52a2f797f2 Bug 302356 Crash when drag-scrolling combobox [@ nsIFrame::HasView][@ nsIFrame::GetOffsetTo]
r=roc sr=roc a=bsmedberg
2005-08-07 14:35:45 +00:00
bzbarsky%mit.edu
7764d0d5fc Fix leaks on any page with a <select> by using already_AddRefed instead of a
raw addrefed return so that callers can't screw up as easily.  Bug 300833,
r+sr=roc, a=bsmedberg
2005-07-28 16:23:22 +00:00
roc+%cs.cmu.edu
920e33d25a Bug 301439. Don't update scrollbars when we do first-pass layout of a listbox. r+sr=dbaron,a=bsmedberg 2005-07-25 23:23:53 +00:00
mats.palmgren%bredband.net
204695d4bf Consider height of <OPTGROUP> labels when calculating visible height. b=300474 r+sr=bzbarsky a=benjamin 2005-07-24 01:02:15 +00:00
aaronleventhal%moonset.net
37551fbadf Bug 290354. Support multiple selection. r=timeless, sr=bryner, a=asa 2005-07-14 14:20:21 +00:00
roc+%cs.cmu.edu
778266c986 Bug 291443. Capture the mouse if the user clicks on an item in a showed drop-down list. r+sr=bzbarsky,a=asa 2005-07-10 23:46:56 +00:00
mats.palmgren%bredband.net
293246508e Stop trying to observe content changes for the selected option, instead rely on getting a combobox reflow if it changed. b=297389 r+sr=roc a=asa 2005-06-21 00:00:14 +00:00
roc+%cs.cmu.edu
158a8445d3 Bug 290428. Don't change listbox selection when the cursor is over the listbox border and we're not capturing the mouse. r+sr=bzbarsky,a=asa 2005-06-17 02:44:31 +00:00
roc+%cs.cmu.edu
d960828b32 Bug 296803. Don't start list item selection prematurely when the combobox pops up above the select control. r+sr=me, patch by Jan Darmochwal, a=asa 2005-06-14 22:15:53 +00:00
roc+%cs.cmu.edu
90518d0020 Bug 290428. When the mouse drags above or below the end of a listbox/comboboxdropdown, select the first or last option. Also, for comboboxes, start listbox selection as soon as the mouse moves to or below the top padding-edge of the dropdown list, and don't stop listbox selection even if the mouse moves back above that edge. r+sr=bzbarsky,a=shaver 2005-06-02 09:00:48 +00:00
jst%mozilla.jstenback.com
50de4a3e1d Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org 2005-04-28 23:48:28 +00:00
roc+%cs.cmu.edu
bc6893b6ba Bug 291443. Listboxes should always direct mouse capture to their scrolled frame, to ensure that events reach the DOM event listener. r+sr=bzbarsky,a=chofmann 2005-04-26 03:14:38 +00:00
roc+%cs.cmu.edu
217d29553f Bug 287338. Free up unused frame state bit NS_SYNC_FRAME_AND_VIEW. r+sr=bzbarsky 2005-03-28 21:08:22 +00:00
ginn.chen%sun.com
1ef92d4540 Bug 262236 Can't select listitems which are not next to.
patch=neo.liu at sun.com, r=aaronleventhal sr=neil
2005-03-08 03:05:03 +00:00
jst%mozilla.jstenback.com
a57ec3f6dc Fixing bug 283531. Fix confusingly named argument to nsIEventStateManager::DispatchNewEvent() that has caused confusing event handling code (also fixed) to creap into the tree. r=bzbarsky@mit.edu, sr=bryner@brianryner.com 2005-03-04 02:01:54 +00:00
bzbarsky%mit.edu
50134ed570 Setting selectedIndex should clear all "previous value" state so that onchange
won't fire unless the user actually changes the value from the one set by
setting selectedIndex.  r=mats, sr=roc, a=roc
2005-02-17 04:29:37 +00:00
smfr%smfr.org
0874f92566 Fix bug 281732: event handling in camino's native popup got broken when screen-relative coordinates in Cocoa widget were fixed (bug 281470), which caused the nsComboboxControlFrame/nsListControlFrame code to start doing mouse capture, and showing the XUL popup. So add a static method, ToolkitHasNativePopup(), and query that (rather than #ifdeffing). r/sr=roc, a=dbaron. 2005-02-16 05:13:16 +00:00
aaronleventhal%moonset.net
e177758a41 Bug 280871. Fix various problems with how we expose HTML and XUL combo boxes via accessibility APIs 2005-02-07 23:11:30 +00:00
mats.palmgren%bredband.net
c967eac0c7 Make assignments to DOM 'selectedIndex' change the focused index for lists/comboboxes. b=279868 r+sr=bzbarsky 2005-02-04 22:56:13 +00:00
mats.palmgren%bredband.net
54108dc6db Add NS_FRAME_INDEPENDENT_SELECTION to ListControlFrame (and children) and skip such frames (TextControlFrame also) in GetContentAndOffsetsFromPoint() when the point is only "near" (not inside) the frame. b=268497 r=bzbarsky sr=dbaron 2005-01-16 18:44:01 +00:00
bmlk%gmx.de
ca3e9f85c3 remove unused prescontext from PlaceFrameView, PlaceChildsView, ConsiderChildOverflow bug 276092 r/sr=dbaron 2004-12-27 15:05:18 +00:00
bmlk%gmx.de
d3197a9276 remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron 2004-12-26 19:48:54 +00:00
robin.lu%sun.com
864e562e03 back out patch for bug 262236 on request 2004-12-16 06:40:04 +00:00
robin.lu%sun.com
f395533f29 fix bug 262236 can't select incontinuous list items. patched by nian.liu@sun.com r=aaron sr=neil 2004-12-13 07:34:54 +00:00
bzbarsky%mit.edu
7fd8feb31d Create an api for easily converting between the coordinate systems of two
frames or two views.  Use this to fix the auto-positioning of abs pos boxes to
work no matter how their containing block and the block their placeholder lives
in are related, and convert various other callers to the new API.  Bug 266968,
r+sr=roc
2004-11-03 16:16:57 +00:00
neil%parkwaycc.co.uk
6a4f37de6b Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc 2004-09-20 22:25:07 +00:00
roc+%cs.cmu.edu
2a8936b1a7 Bug 257916. Move history scroll position save and restore from nsScrollBoxFrame to nsHTML/XULScrollFrame. +sr=dbaron(rubber-stamp) 2004-09-13 02:10:29 +00:00
roc+%cs.cmu.edu
6255acffd9 Bug 254039. deCOMtaminate nsIScrollableFrame. r+sr=roc, patch by Will Levine 2004-09-06 02:44:43 +00:00
bryner%brianryner.com
96ff7a927c Update the displayed text when closing a combobox with the keyboard causes a new option to be selected. Bug 257572, r=mkaply, sr=jst. 2004-09-02 21:10:40 +00:00
bzbarsky%mit.edu
d4226e05fa Relanding bug 108817, since it did not cause the Tp problem. r+sr=still roc 2004-08-11 04:49:05 +00:00
bzbarsky%mit.edu
f5ed95e537 Backing out patch for bug 108817 to test whether it causes the Tp regression. 2004-08-10 23:37:43 +00:00
bzbarsky%mit.edu
b34ac7a3db Remove the timer stuff in nsListControlFrame and replace it with a simple
boolean that's set as needed if the options change and checked in DidReflow()
to decide whether to scroll the list.  Also eliminate the mPresContext member.
Bug 108817, r+sr=roc
2004-08-10 22:21:03 +00:00
bryner%brianryner.com
6a8c79a9b2 Remove non-inlined version of nsIPresShell::GetDocument(). Bug 253889, r+sr=roc. 2004-08-02 04:52:55 +00:00
bryner%brianryner.com
5c02a6978c Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
bryner%brianryner.com
0fd21c3872 Consolidate PresContext classes into a single nsIPresContext implementation, and finish deCOMtaminating it. Bug 253470, r+sr=roc. 2004-07-29 19:41:39 +00:00
roc+%cs.cmu.edu
748bc62eb8 Bug 252850. Backing out minor listbox layout fix, because it broke something worse 2004-07-28 01:24:58 +00:00
roc+%cs.cmu.edu
a406f5f3c0 Bug 232540. Make unconstrained-width comboboxes reflow their dropdowns with unconstrained width, always, to avoid a problem where the vertical scrollbar is added but the dropdown doesn't get correspondingly wider. r+sr=dbaron 2004-07-23 23:46:25 +00:00
neil%parkwaycc.co.uk
92f587883a Fix regression from bug 244761 so that only user actions will enable onChange after blur b=251833 r/sr=roc 2004-07-23 08:25:44 +00:00
rbs%maths.uq.edu.au
e2527bce29 Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky 2004-07-21 01:05:44 +00:00
roc+%cs.cmu.edu
b751c53c83 Bug 251501. Refactor handling where frames get inserted on content insertion. r+sr=dbaron 2004-07-18 12:02:53 +00:00
roc+%cs.cmu.edu
c81d937cfe Bug 240276. Fork nsGfxScrollFrame into nsHTMLScrollFrame and nsXULScrollFrame. No behaviour is changed yet. r+sr=dbaron 2004-06-18 02:08:19 +00:00
robin.lu%sun.com
b8205678d0 fix bug 220390 ACCESSKEY incorrectly supported on multiline SELECT tag.
patched by Nian Liu (neo.liu@sun.com).
r=aaronleventhal sr=jst
2004-06-11 08:03:16 +00:00
roc+%cs.cmu.edu
626c4c26f5 Bug 217715. Delay instantiating plugin until we've closed its HTML element, so Java applets are guaranteed to see all PARAMs. r+sr=jst 2004-06-02 00:25:00 +00:00
neil%parkwaycc.co.uk
467eb2c764 Bug 244761 ESC shouldn't change displayed selection also improve consistency of change events for drop-downs r/sr=roc 2004-05-28 16:25:04 +00:00
bzbarsky%mit.edu
a7bff6ad5b Change FlushPendingNotifications to have more granularity and update callers to
only flush the things they really need flushed.  Bug 144072, r+sr=jst
2004-05-27 22:08:42 +00:00
roc+%cs.cmu.edu
cc6fdc52b2 Bug 232540. List controls should not scroll an item into view if it is only outside the list in the horizontal direction. 2004-05-05 02:49:57 +00:00
roc+%cs.cmu.edu
47ce3369a5 Backing out the part of the patch that was incorrectly checked in. 2004-05-05 02:48:53 +00:00
roc+%cs.cmu.edu
a6dd695671 Bug 240276. Trim fat from nsGfxScrollFrame, move functionality into nsGfxScrollFrameInner so that when we fork nsGfxScrollFrame, it will be shared 2004-05-05 02:32:27 +00:00
roc+%cs.cmu.edu
b39d104f02 No bug. Remove unused code and variables from nsListControlFrame. rs=shaver 2004-05-04 04:30:23 +00:00
gerv%gerv.net
708b56cff4 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
roc+%cs.cmu.edu
17f81274ba Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky 2004-04-13 03:11:05 +00:00
roc+%cs.cmu.edu
8397ac8d8f Bug 235264. Clean up invalidation to go through a single nsIFrame::Invalidate function and take account of 'outline' where necessary. r+sr=dbaron 2004-03-10 03:09:05 +00:00
bryner%brianryner.com
ab4ac54b6f inline IsPaginated, SetPaginatedScrolling, and GetPaginatedScrolling. Bug 229371, r+sr=roc. 2004-03-03 18:24:20 +00:00
bryner%brianryner.com
ed98c9a308 deCOMtaminate nsIPresContext::GetEventStateManager. Bug 229371, r+sr=roc. 2004-02-27 17:17:37 +00:00
bryner%brianryner.com
5f7a8b383e Inline boolean getters and setters on nsIPresContext, and change the storage to a bitfield. Bug 229371, r+sr=roc. 2004-02-20 17:49:01 +00:00
bryner%brianryner.com
92499cbd13 Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron. 2004-02-11 04:57:07 +00:00
bryner%brianryner.com
4f69ec2c2e Guarantee that the pres context's device context will be non-null by returning failure from Init() if it's null. Rename inline getter GetDeviceContext() to DeviceContext(), convert all callers to use the inline getter, and remove the virtual/refcounting getter. Bug 229371, r+sr=dbaron. 2004-02-02 22:17:21 +00:00
bryner%brianryner.com
ef5c330583 Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky. 2004-01-21 09:35:59 +00:00
peterv%propagandism.org
379d6c8a41 Miscellaneous cleanup. r/sr=jst. 2004-01-18 10:45:26 +00:00
bryner%brianryner.com
2bddef83ba Improve the way in which nsEvent and its subclasses are initialized. Commonly-used members can now be initialized via an inline constructor, and all other members are initialized to zero. eventStructType is set automatically. This also fixes some cases where an eventStructType was doubling as a message -- NS_TEXT_EVENT is now only used as an eventStructType, with a message of NS_TEXT_TEXT. NS_COMPOSITION_* events get an eventStructType of NS_COMPOSITION_EVENT, and ditto for NS_RECONVERSION_*. NS_DRAGDROP_EVENT is no longer an eventStructType since it is not a unique type of struct. There is also some miscellaneous cleanup to nsDOMEvent. Bug 220228, r=jst, sr=blizzard. 2004-01-12 08:25:18 +00:00
bryner%brianryner.com
0286fde9c1 Eliminate old nsCWeakReference implementation (bug 230480). This rewrites nsListControlFrame's event listener to be a little more sane. r+sr=dbaron. 2004-01-09 22:18:26 +00:00
roc+%cs.cmu.edu
e7f165c614 Bug 190735. deCOMtaminate nsIFrame::FirstChild and nsIFrame::GetAdditionalChildListName. r+sr=bz 2004-01-09 14:20:53 +00:00
bryner%brianryner.com
dfe3513814 Change all callers of nsIPresContext::GetShell() to use the non-refcounting versions. Most callers now use PresShell(), a few that were checking for null conditions are using GetPresShell() -- this will be remedied once we can ensure that a prescontext never has a null pres shell. Bug 227690, r+sr=bzbarsky. 2003-12-21 05:36:36 +00:00
bzbarsky%mit.edu
bb59181099 Don't clear previous selection when range is extended using shift-ctrl-click.
Bug 112281, r+sr=roc
2003-11-15 04:23:53 +00:00
uid502
d81619b4fa Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky 2003-10-31 20:19:18 +00:00
roc+%cs.cmu.edu
ec0c023645 Bug 212753. Make sure mouse capture is released when combobox popup is hidden. r+sr=bryner,a=mkaply 2003-09-02 15:21:13 +00:00
roc+%cs.cmu.edu
46638c553d Bug 207637. Don't fire onchange for MouseUp events where we didn't see a mousedown. r+sr=dbaron,a=asa 2003-08-12 16:00:20 +00:00
dbaron%dbaron.org
476143ae1a Remove workaround for timer bug, since the timer bug is fixed and the workaround now causes a crash. b=215250 r+sr=brendan a=asa 2003-08-07 00:00:13 +00:00
bzbarsky%mit.edu
e2e733b5de DeCOMify GetParent/GetBindingParent/GetDocument on nsIContent. Bug 213823,
r+sr=jst
2003-07-28 21:25:13 +00:00
jaggernaut%netscape.com
817298ce0b Bug 212272: Switch some Substring users over to String(Begins|Ends)With. r=dwitte, sr=bzbarsky 2003-07-14 07:37:39 +00:00
aaronl%netscape.com
5c5a6660ec Bug 211846. alt+down not working consistently for dropdowns. Also fixes bug 110801 and bug 205942, dropdown from alt+down not showing in the right place. r=jkieser, sr=bz 2003-07-09 06:36:33 +00:00
roc+%cs.cmu.edu
9bd83767f7 Fixing build bustage 2003-07-04 13:36:03 +00:00
roc+%cs.cmu.edu
0b15c3893e Ongoing deCOMtamination. r+sr=dbaron 2003-07-04 12:50:32 +00:00
dbaron%dbaron.org
4afcaa0e69 DeCOMtaminate nsIFrame::GetView and SetView, and add HasView, GetClosestView, and AreAncestorViewsVisible to consolidate common patterns. b=208004 r+sr=roc 2003-06-19 23:44:01 +00:00
caillon%returnzero.com
2df173e9c8 Bug 209087
Content interface out-parameters should use ptr-to-ptrs instead of ref-to-ptrs and some small deCOMtamination.
r+sr=jst@netscape.com
2003-06-13 20:10:01 +00:00
jkeiser%netscape.com
2e29273c63 Remove unused variables, r+sr=sfraser@netscape.com 2003-06-06 01:11:57 +00:00
dwitte%stanford.edu
270d3909ca bug 100649: Length() being used where IsEmpty() is meant
treewide changes to convert incorrect usages of string.Length() to string.IsEmpty().

thanks to afatecha@idea.com.py (Ariel Fatecha) for the patch. r=dwitte, sr=jst.

got the ok from Asa to land into a closed tree.
2003-05-23 21:34:47 +00:00
roc+%cs.cmu.edu
f5b886b9cd Bug 202681. Do not recreate frames during reflow via -moz-binding change for lazy scrollbars. Instead of lazy scrollbars, completely remove the anonymous scrollbar element for scrollbars which are disabled by CSS. r+sr=dbaron,a=asa 2003-05-22 01:46:13 +00:00
dbaron%dbaron.org
75ff60c62f Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan 2003-05-15 03:42:21 +00:00
roc+%cs.cmu.edu
ade40a3ae3 Bug 204531. Remove bogus RTL listbox reflow hack. Fix border computation for desired size of combobox dropdowns. 2003-05-15 01:42:53 +00:00
roc+%cs.cmu.edu
f4a1c61d8c Bug 201797. Do an extra reflow of the scrollframe if we adjusted the width or height after reflowing it the first time. Also, don't include border/padding when calculating the visible width in the unconstrained case 2003-05-04 19:00:21 +00:00
roc+%cs.cmu.edu
3936b4c393 Bug 126263. Whack comboboxes/listboxes to use Gfx scrollbars. Also, make scrollbars attach their XBL content only when they become visible, to avoid pageload hit. r+sr=dbaron 2003-04-08 20:50:57 +00:00
jst%netscape.com
0b5cb41238 Fixing bug 192837. Freezing the rest of the DOM HTML interfaces. r=fabian@imajes.info, sr=peterv@netscape.com 2003-03-14 07:00:53 +00:00
kyle.yuan%sun.com
d2a4744e14 Bug 188199 incremental search in <select> fails if item starts with repeats of a letter
r=jkeiser, sr=henry.jia
2003-02-23 01:19:17 +00:00
bryner%netscape.com
e43f5a49fd Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron. 2003-02-22 00:32:13 +00:00
neil%parkwaycc.co.uk
aa05374d8e Fix regression to bug 150759 caused by bug 147148 r=jkeiser sr=sfraser 2003-01-10 09:24:30 +00:00
dbaron%dbaron.org
849440045e Fix sizing regression for selects with optgroups. b=188426 r+sr=bzbarsky 2003-01-10 00:30:50 +00:00