Commit graph

511 commits

Author SHA1 Message Date
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Neil Deakin
cf9835ac8b Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Paolo Amadini
3193903d17 Bug 1391948 - Don't use checkboxes for the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=mak
MozReview-Commit-ID: 2P3yV6xHLxi

--HG--
extra : rebase_source : 9352eac0344844218622149a3dc34959e620d431
2018-04-11 12:42:18 +01:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Manish Kumar
8084e0be59 Bug 1450588 - Remove old bookmark animation code and images. r=ntim,dao 2018-04-04 10:47:50 +02:00
Paolo Amadini
bd53878f66 Bug 1434860 - Part 2 - Remove support for menu-button toolbar buttons. r=enn
MozReview-Commit-ID: MTLaIPzg7a

--HG--
extra : rebase_source : edcefa844e36f8e1ff4199580502d516d26b0f8f
extra : amend_source : ca4896a89bb7b45aef8d782d31e47d4ed3be5351
extra : source : 54f36172186d7345c6aeb92fd3c1254717156767
2018-04-03 16:26:03 +01:00
Masayuki Nakano
989795493b Bug 1449018 - The bookmark panel should listen to keypress event at the system event group r=mak
The bookmark panel should handle keypress events at the system event group
because it needs to handle keypress events after autocomplete module which
handles keypress events at the system event group.

MozReview-Commit-ID: 9KjBlQ59gHw

--HG--
extra : rebase_source : 7a626d2b1bd7ae4f8fd917d5e569be34e34227dc
2018-03-27 16:50:18 +09:00
Marco Bonardo
59e8fa7fa3 Bug 1448362 - Remove some unused code from Places. r=standard8
MozReview-Commit-ID: DQCoYyZIvGD

--HG--
extra : rebase_source : 4e54453619111fcae1d57627049b0bf73ab01c23
2018-03-23 16:26:56 +01:00
Brendan Dahl
c52106c442 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN

--HG--
rename : browser/components/places/content/editBookmarkOverlay.js => browser/components/places/content/editBookmark.js
rename : browser/components/places/content/editBookmarkOverlay.xul => browser/components/places/content/editBookmarkPanel.inc.xul
rename : browser/components/places/tests/chrome/test_bug427633_no_newfolder_if_noip.xul => browser/components/places/tests/browser/browser_bug427633_no_newfolder_if_noip.js
rename : browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul => browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js
rename : browser/components/places/tests/chrome/test_bug631374_tags_selector_scroll.xul => browser/components/places/tests/browser/browser_bug631374_tags_selector_scroll.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_keywords.xul => browser/components/places/tests/browser/browser_editBookmark_keywords.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_tags_liveUpdate.xul => browser/components/places/tests/browser/browser_editBookmark_tags_liveUpdate.js
rename : browser/themes/linux/places/editBookmarkOverlay.css => browser/themes/linux/places/editBookmark.css
rename : browser/themes/osx/places/editBookmarkOverlay.css => browser/themes/osx/places/editBookmark.css
rename : browser/themes/windows/places/editBookmarkOverlay.css => browser/themes/windows/places/editBookmark.css
extra : rebase_source : aca072691251c1a44e82ab8091796abd2b140e22
2018-03-16 09:26:49 -07:00
Mark Banner
2155e56144 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : c98e6a50702ef0c238d036fa2a26f4a6ac9f15af
2018-02-16 20:30:04 +00:00
Dorel Luca
7065341d2f Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)

--HG--
extra : rebase_source : cb7317f5afa7c828ec3b6d9b7679b474fa9cf5da
2018-03-14 18:23:46 +02:00
Mark Banner
80abee119b Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : a956958f5c9adde0ee775e9bc918a8970564bbb7
2018-02-16 20:30:04 +00:00
Marco Bonardo
388f9e4090 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC

--HG--
extra : rebase_source : 9e3e6f58742a0900fdd73e6c5ed5089f7d01da63
2018-02-28 12:10:12 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Tawny Hoover
85044e0002 Bug 1420749 - Allow browser.bookmarks.openInTabClosesMenu to work with containers as well as single menuitems r=mak
MozReview-Commit-ID: Bba3pLyHZUV

--HG--
extra : rebase_source : 9b82b3452277b2230783329c1f68edde2d967848
2018-02-08 20:59:08 -05:00
Mark Banner
362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Coroiu Cristina
1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Marco Bonardo
9645d23bf4 Bug 1434241 - showEditBookmarkPopup should stop accepting itemIds. r=standard8
MozReview-Commit-ID: 8doEkhc8Wyd

--HG--
extra : rebase_source : a08336ea1442752b76132c60af62d41b78b1c01e
2018-01-31 13:49:35 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Mark Banner
412e825e77 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak
MozReview-Commit-ID: 9EKNvA8Q9jo

--HG--
extra : rebase_source : 289082be4a1f086620bf0fe3008c2eacbdc6a9fa
2018-01-22 13:36:41 +00:00
Gijs Kruitbosch
f98c738db9 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ

--HG--
extra : rebase_source : 76f0f2acb9c785e9497fccb493e5c158d9d35eb4
2017-11-07 11:54:47 +00:00
Mike de Boer
cd5f71abe4 Bug 1120110 - Consistently save pages bookmarked using 'Bookmark This Page' anywhere into the 'Other Bookmarks' folder. r=mak
Since we're not passing an optional parent folder around anymore, this patch also
removes PlacesCommandHook.bookmarkCurrentPage() in favor of a simplified
PlacesCommandHook.bookmarkPage() signature.

MozReview-Commit-ID: HmzwmATgQyw

--HG--
extra : rebase_source : 384e7dba2ab58b212273d39bf6344424a9841e4f
2017-10-23 14:10:04 +02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
f63f3b49e4 Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r=mikedeboer
MozReview-Commit-ID: 1zesvAmYkAM

--HG--
extra : rebase_source : f5ab724b445e457ae8970b10489912625bab629f
2017-10-04 11:49:14 +01:00
Jared Wein
7eb2fe3c97 Bug 1403550 - Update the X offset of the library button when the window is resized. r=sfoster
MozReview-Commit-ID: J3XpTOZwO1Y

--HG--
extra : rebase_source : 72d23e7f73347f7b3e51079bf91ee20a9d8f3092
2017-09-27 12:40:04 -04:00
Drew Willcoxon
2fa9f06a0b Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs
MozReview-Commit-ID: JMviXx5ov7F

--HG--
extra : rebase_source : b205b0ae9d0e4eb7ed34b912f62e28fb2e2f9467
2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
40de26eb54 Bug 1401238 - remove recent bookmarks from the bookmarks menu button and toplevel bookmarks menu, r=mak
MozReview-Commit-ID: 7JT9xCq9zcS

--HG--
extra : rebase_source : b6dca5a110636a66181c6843aba616192288fa92
2017-09-20 00:38:39 +01:00
Gijs Kruitbosch
49a325326c Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw
MozReview-Commit-ID: 7QrhAB79yNw

--HG--
extra : rebase_source : 90c3715259271bf9cb34b635ca8348acd020c51c
2017-09-19 15:13:25 +01:00
Tawny Hoover
2415e21cbc Bug 260611 - Introduce pref browser.bookmarks.openInTabClosesMenu to optionally leave menu open for single bookmark menuitem clicks that open in new tab. r=mak
MozReview-Commit-ID: HreM02pdzWP

--HG--
extra : rebase_source : aa9934418fbc55a66848e5e7757b0885ac3be275
2017-09-11 12:12:21 -04:00
Jared Wein
b4b4d0cbd6 Bug 1399651 - Don't run the library animations in popup windows with toolbar=false. r=Gijs
MozReview-Commit-ID: 2vswZ2BTFwp

--HG--
extra : rebase_source : 7dec9fe6a3d60380c96ac0d71bd55e96c13ede63
2017-09-13 19:37:43 -04:00
Drew Willcoxon
d80536f61f Bug 1386745 - Activated URL/address/location bar makes bookmark doorhanger/panelUI located under "Show site information" button area after landing patch from bug #1352063. r=Gijs
MozReview-Commit-ID: Kzymx5qbp4i

--HG--
extra : rebase_source : a0b5eed918d8c9552c2114acc128ee7f56085653
2017-09-08 10:16:38 -07:00
Marco Bonardo
1e78e32502 Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M

--HG--
extra : rebase_source : eec1608c106b56b7ef090c52d6b57bedf948741d
2017-09-08 11:43:08 +02:00
Jared Wein
8a5df47f41 Bug 1394588 - Include the gNavToolbox offset in the calculation of the library drop animation. r=Gijs
MozReview-Commit-ID: 90eUNtqE0ee

--HG--
extra : rebase_source : 833a1738599b9620a05859a40e687329a229368a
2017-09-05 14:50:52 -04:00
Jared Wein
8bcd5cb19e Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs
MozReview-Commit-ID: HXbjhQFCplb

--HG--
extra : rebase_source : ad0ca5e01d4fae85308b7be63ce3953d9767fe12
2017-09-07 03:46:46 -04:00
Mark Banner
3d92d0e6d3 Bug 1397545 - Don't update the recently bookmarks item list when it is hidden and a bookmark is deleted. r=mak
MozReview-Commit-ID: CnbFMONaRil

--HG--
extra : rebase_source : 93fb1713b1ad74f52b9945f71c267f0a27e39426
2017-09-07 10:49:03 +01:00
Marco Bonardo
b3ab6629a6 Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX

--HG--
extra : rebase_source : 6605bd328273fb283e62a74ee14ca37aaaf6c4c8
2017-08-29 23:26:24 +02:00
Sebastian Hengst
7fe9943c8c Backed out changeset cf5b68506bef (bug 1392081) 2017-09-05 23:11:08 +02:00
Marco Bonardo
7298681f5c Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX

--HG--
extra : rebase_source : 446fb2849146df0560336bd8cf751d93e18648b3
2017-08-29 23:26:24 +02:00
Jared Wein
d395875dc0 Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r=Gijs
MozReview-Commit-ID: Z1kIdrY2Um

--HG--
extra : rebase_source : fbff99adf6446d060f32cb49cfdce8a9912da891
2017-08-30 15:58:24 -04:00
Jared Wein
b10d09d78c Bug 1395438 - The bookmarks panel should fade out when it times out, not close abruptly. r=adw
MozReview-Commit-ID: 2alzsK8M9Xb

--HG--
extra : rebase_source : 94deabb9f416ce4f84d42c864bda6ffe9052c62b
2017-08-31 00:27:07 -04:00
Dão Gottwald
7f59f101a8 Bug 1394753 - Remove unstarred48.png. r=mak
MozReview-Commit-ID: EKUEQsOxy50

--HG--
extra : rebase_source : 9e014c80ba2bfae0563dc62af1cf49bca03ad209
2017-08-29 11:51:12 +02:00
Mark Banner
a74cac68c6 Bug 1388687 - Change the recent bookmarks object to only update the menu items when really necessary, and only do a database query when the recent bookmarks need updating. r=mak
MozReview-Commit-ID: J4WxNoTPxkc

--HG--
extra : rebase_source : d4c014b2e1b77bc761a62de49a767f539689ee29
2017-08-21 16:05:30 +01:00
Mark Banner
f75bd69b38 Bug 1388687 - Split out inline functions into members of RecentBookmarksMenuUI to make testing/updates easier. r=mak
MozReview-Commit-ID: 1qD7xmlGa8y

--HG--
extra : rebase_source : b528bd3d1b1ba9d6ccb6a6f5da64f7cea9a8d890
2017-08-10 08:27:36 +01:00
Mark Banner
70cb5355a6 Bug 1388687 - Separate out the recent bookmarks menu code into its own object. r=mak
MozReview-Commit-ID: EhNk4cDLbAH

--HG--
extra : rebase_source : 4afdaef70da7578b3f185e6b11b2155d75d5057b
2017-08-09 11:07:50 +01:00
Jared Wein
e5bbbb1e79 Bug 1384953 - Run the library and pocket animations outside of the navigation-toolbar to workaround z-index issues with the selected tab. r=gijs
MozReview-Commit-ID: dXVThUXdXi
2017-08-09 20:36:17 -04:00