Commit graph

96 commits

Author SHA1 Message Date
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Mark Banner
a32bc883e7 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d

--HG--
extra : rebase_source : c62ad4e97fc5da7c59cbb03ba08928f7bbe5be6b
2018-03-01 20:06:06 +00:00
Ursula Sarracini
12bbfa710e Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights r=Mardak
MozReview-Commit-ID: 5St8NablevZ

--HG--
extra : rebase_source : d58ee8389060632616818c012a4d6b61eae9c1e1
2018-02-28 14:16:46 -05:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Ursula Sarracini
9c4753f4d6 Bug 1438658 - Allow pktApi.jsm to archive an item r=Mardak
MozReview-Commit-ID: JoTzYy84ZI5

--HG--
extra : rebase_source : ef4f11f414b4c2bd551d3c62ee165ca1d89795e8
2018-02-16 11:38:37 -05:00
Thomas Wisniewski
1966e88a4a Bug 792808 - Change pktApi.jsm to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=Gijs
MozReview-Commit-ID: 8jdzIb95MmB

--HG--
extra : rebase_source : 34383e0d7a6279e82cde23a3e93c69a001c6fe93
2017-09-19 12:18:20 -04:00
Timothy Guan-tin Chien
a2a559db3e Bug 1234008 - Recompress some png images with zopflipng r=Dolske,Grisha,jryans
MozReview-Commit-ID: Cr2iMSB04uu

--HG--
extra : rebase_source : 49f69cca3a4f27af1060ed82283b5cc96f717229
2018-01-27 15:57:42 +08:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Gijs Kruitbosch
5a980122fd Bug 1435217 - remove vestiges of dead pocket toolbar/panel button and always-hidden bookmarks menu button panel menu item, r=jaws
MozReview-Commit-ID: 9V7w9VnTZTN

--HG--
extra : rebase_source : 7e5d45c9b38f3702c0a81d2386f51f5ef1b6ed80
2018-02-02 11:54:24 +00:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Ursula Sarracini
bade77fe89 Bug 1432659 - Expose Pocket API to get your pocket stream r=csadilek
MozReview-Commit-ID: B3mbvCaLQw7

--HG--
extra : rebase_source : 99e5b8ac5fcb9ec59497d978b2be52fe3aa4e69a
2018-01-29 16:57:32 -05:00
Ian Moody
21c85fbf73 Bug 1426833 - Update Fx logos in Pocket extension to Photon versions. r=Gijs
MozReview-Commit-ID: FqIkd498ull

--HG--
extra : rebase_source : 07ebf69245921885a904d5c9f7ac73de86c7ee1a
2017-12-20 00:50:06 +00:00
Mark Banner
f99ae4c2a9 Bug 1421376 - Change various instances of manually calling getService to use Services.jsm in browser/. r=mossop
MozReview-Commit-ID: FW3X2fkOwK2

--HG--
extra : rebase_source : f71e053e18017d675d4ea4d758e2552adcf5adc6
2017-11-28 19:21:33 +00:00
Valentin Gosu
1bd153659e Bug 1407720 - Merge nsICookieManager and nsICookieManager2 r=nwgh
MozReview-Commit-ID: HuzeeB43YZZ

--HG--
extra : rebase_source : 3924170ce50126dbbae7c97cae601b69d0ab95af
2017-10-31 13:02:28 +01:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
8dea08a240 Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw

--HG--
extra : rebase_source : 0921854ff6d1110a35bb225d946cea3caa2ae3c1
2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
27a784c809 Bug 1375806 - don't overwrite the current non-empty tab when viewing pocket list, r=mixedpuppy
This moves the logic into Pocket.jsm, and first determines the right place based on modifiers etc.
using whereToOpenLink. If that returns 'current', we override with 'tab' if and only if the current
tab is non-empty (so we'll reuse about:blank or about:newtab, but not tabs with a website / history).

MozReview-Commit-ID: H64bREBn8OU

--HG--
extra : rebase_source : 9f7df22d0fc08fcdb9e37b4cce0a95f9979b98e5
2017-08-23 23:31:19 +01:00
Drew Willcoxon
3c27aee62b Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV

--HG--
extra : rebase_source : f87650ab8c09f7a313cda9b7ec73ee1e20d6fe34
2017-08-16 10:13:15 -07:00
Jared Wein
baaaed0eec Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : e862c01c1d71165ccd5d0932299c7f1fbdebe659
2017-08-08 11:56:49 -04:00
Wes Kocher
3c7cc8f012 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout
MozReview-Commit-ID: kEMoucDCJY
2017-08-10 15:46:38 -07:00
Jared Wein
8880224f6b Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : bef396788013f8ed60d72b01bf59e34e01d36209
2017-08-08 11:56:49 -04:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Drew Willcoxon
b18ff3f722 Bug 1367927 - Add a "save to pocket" item to the page action menu. r=mixedpuppy
MozReview-Commit-ID: APmutOUh2Q6

--HG--
extra : rebase_source : 734be8511fd4ac21efbaf6182f644aa9a3930270
2017-08-01 10:17:00 -07:00
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Jared Wein
827e22d063 Bug 1383886 - Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check. r=Gijs
MozReview-Commit-ID: L6weawO4qB0

--HG--
extra : rebase_source : 5e7b1d6df7fe68bcbf11b409f9897f63cf34e179
2017-07-24 16:27:10 -04:00
Jared Wein
da6c891ee3 Bug 1383882 - Don't show the Pocket library animation if the Pocket page was removed. r=Gijs
MozReview-Commit-ID: D6xsPEUIC96

--HG--
extra : rebase_source : b719aea283275305e51dbf9cdfa30ffce2145bb7
2017-07-24 16:16:56 -04:00
Michael Kaply
055e88c1c3 Bug 1383848 - Null check library button since it's not there by default. r=jaws
MozReview-Commit-ID: 4IRASZc5icm

--HG--
extra : rebase_source : 5651c5b13d94a79a71df68f4dd0c0f80b1bc5625
2017-07-24 13:58:43 -05:00
Jared Wein
b451d4ce96 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg

--HG--
extra : rebase_source : de322ffcc261ad3ef497ec82494056d44c767590
2017-07-21 18:00:01 -04:00
Wes Kocher
b33abfa979 Backed out changeset d4b7fc921b88 (bug 1355922) for assertions in test_display_mode.html a=backout
MozReview-Commit-ID: GQh4DRTEUJI
2017-07-21 00:36:41 -07:00
Jared Wein
3d8a18b1a2 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg

--HG--
extra : rebase_source : 216557e4bbb265c222b104f2314ac7a0e00fe459
2017-07-20 09:59:22 -04:00
Rajesh Kathiriya
881bce09ea Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
MozReview-Commit-ID: RT5QTipaOW

--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
2017-07-04 21:30:18 +05:30
Andrea Marchesini
e7eda19b3d Bug 1369323 - Get rid of nsScriptSecurityManager::GetNoAppCodebasePrincipal, r=bholley 2017-06-02 11:05:28 +02:00
Gijs Kruitbosch
04fd5e2765 Bug 1354155 - fix pocket button's checks for whether it is the mainview in a panelmultiview, r=mikedeboer
MozReview-Commit-ID: 6kLNAtOmCjn

--HG--
extra : rebase_source : a1428cab9a46cfac52162c3544dcf11761f4b87c
2017-05-30 16:29:45 +01:00
Honza Bambas
d6d727a69e backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-13 13:55:11 +02:00
Wes Kocher
0a1e1fe23b Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
Honza Bambas
70f62bdec1 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-12 22:13:49 +02:00
Honza Bambas
a1b64b4694 Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz 2017-01-27 19:10:01 +01:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Zibi Braniecki
3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Florian Quèze
9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
09889d3184 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
MozReview-Commit-ID: FTDV8BcMGeF

--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
extra : rebase_source : f0e89f2ce3cfdf343213f66a007f74a80a785c19
2017-03-01 21:29:52 +00:00
Mark Banner
e5c2479848 Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop
MozReview-Commit-ID: CJtpm8zlLxa

--HG--
extra : rebase_source : c6a834d5aaba0f84f5e147333085883de1a118e8
2017-02-02 09:08:42 +00:00