In a previous patch in this stack, AppUpdater was changed to remove the checkForUpdates function. This change updates aboutDialog-appUpdater to accomodate this change.
It was probably incorrect for this function to be called previously. Calling into checkForUpdates() is functionally similar to calling into check(), except that checks are bypassed that probably shouldn't be bypassed.
Differential Revision: https://phabricator.services.mozilla.com/D159299
This was introduced so they can wrap when you shrink the window, but
other links don't behave like that so we can probably live without it.
Differential Revision: https://phabricator.services.mozilla.com/D160202
The changes in pageInfo.js is just trying to keep the existing behavior where the event listener
is handling both the successful and failing loads. Based on the code the listener may not be designed to
handle error case, but that is what it does currently.
Depends on D159929
Differential Revision: https://phabricator.services.mozilla.com/D159930
Incorporates the "Places Database Statistics" table from `chrome://browser/content/places/interactionsViewer.html` into the `about:support` page, under the existing "Places Database" table. The table is hidden by default, and it can be toggled on/off using a button. Table contents will always be part of the "Copy text to clipboard" export, regardless of visibility.
Try Job: https://treeherder.mozilla.org/jobs?revision=923a9df8c477f6e2b1f0a2fee3b0291ddbdd32e3&repo=try
Initial state:
{F4177493}
After clicking "Show Statistics":
{F4177495}
Text export:
{F4177496}
Differential Revision: https://phabricator.services.mozilla.com/D158200
In a previous patch in this stack, AppUpdater was changed to remove the checkForUpdates function. This change updates aboutDialog-appUpdater to accomodate this change.
It was probably incorrect for this function to be called previously. Calling into checkForUpdates() is functionally similar to calling into check(), except that checks are bypassed that probably shouldn't be bypassed.
Differential Revision: https://phabricator.services.mozilla.com/D159299
The changes in pageInfo.js is just trying to keep the existing behavior where the event listener
is handling both the successful and failing loads. Based on the code the listener may not be designed to
handle error case, but that is what it does currently.
Depends on D159929
Differential Revision: https://phabricator.services.mozilla.com/D159930
There was only a min-height: 0 missing. I also cleaned-up a bit because
flex: 1 is the same as flex: 1 1 auto, and flex attribute (which only
sets -moz-box-flex) is not doing anything because it was inside flex
layout (so legacy properties aren't looked at).
Differential Revision: https://phabricator.services.mozilla.com/D160094
Incorporates the "Places Database Statistics" table from `chrome://browser/content/places/interactionsViewer.html` into the `about:support` page, under the existing "Places Database" table. The table is hidden by default, and it can be toggled on/off using a button. Table contents will always be part of the "Copy text to clipboard" export, regardless of visibility.
Try Job: https://treeherder.mozilla.org/jobs?revision=923a9df8c477f6e2b1f0a2fee3b0291ddbdd32e3&repo=try
Initial state:
{F4177493}
After clicking "Show Statistics":
{F4177495}
Text export:
{F4177496}
Differential Revision: https://phabricator.services.mozilla.com/D158200
By using delegatesanchor="true", we delegate the anchor node to the
first in-flow box (that is the icon), simplifying a lot of the
hard-coded margins in the CSS.
Do that, plus make menupopup[type="arrow"] work consistently, to
simplify the styling of the bookmarks popup a bit.
Differential Revision: https://phabricator.services.mozilla.com/D158569
These don't work on emulated flexbox. We only have a couple of uses.
See D159726 for the diagnostic patch I used to catch these.
Differential Revision: https://phabricator.services.mozilla.com/D159727
These don't work on emulated flexbox. We only have a couple of uses.
See D159726 for the diagnostic patch I used to catch these.
Differential Revision: https://phabricator.services.mozilla.com/D159727
This depends on bug 1795892 and restores the sizing behavior that XUL had for
this case (making the overflow: hidden element not contribute to the intrinsic
size of the container).
If this were to be written today, we couldd probably use absolute positioning
or transforms, and maybe this could be simplified a bit. This is the less risky
change tho.
Differential Revision: https://phabricator.services.mozilla.com/D159639
This turned out to be more complicated than expected, because:
- SameSite=None requires https://
- Many test were using the mochi.test domain, which is not reachable via https
Differential Revision: https://phabricator.services.mozilla.com/D157637
This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.
Differential Revision: https://phabricator.services.mozilla.com/D159461
The min-width / contain are as usual to allow elements to shrink under
their intrinsic size. You can only see its effects with relatively thin
windows (or with a very large number of tabs in the tabstrip case).
Differential Revision: https://phabricator.services.mozilla.com/D157216
