Commit graph

262 commits

Author SHA1 Message Date
Mike Conley
354a4a1210 Bug 1663784 - Rename mozilla.org/widget/macsystemstatusbar to mozilla.org/widget/systemstatusbar. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D89786
2020-09-15 17:38:27 +00:00
Mike Conley
e0a8c9cdae Bug 1656127 - Remove some unneeded WebRTC UI probes. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D89790
2020-09-10 17:36:46 +00:00
Mike Conley
f652d0465b Bug 1658052 - Only remember allowed shared browser tabs for tabbrowser <browser> elements. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D86444
2020-08-10 09:20:29 +00:00
Mike Conley
3143e581af Bug 1656274 - Add a probe to record when users cause the WebRTC sharing indicator to open. r=pbz,data-review=chutten
Differential Revision: https://phabricator.services.mozilla.com/D85422
2020-08-04 22:37:39 +00:00
Mike Conley
be5766d15a Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-17 01:22:10 +00:00
Bogdan Tara
d115b9a6ea Backed out 2 changesets (bug 1649032) for leakcheck failures CLOSED TREE
Backed out changeset ef80a597db37 (bug 1649032)
Backed out changeset a8462c37bef1 (bug 1649032)
2020-07-16 00:37:06 +03:00
Mike Conley
974f560325 Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-15 10:22:12 +00:00
pbz
e5fb1763cc Bug 1636496 - Only show global sharing indicator window if we have a media indicator to show. r=johannh
The webrtc global indicator shows media indicators based on the indicator state
of the individual tabs.
Determining the visibility of the global indicator based on if there are active
streams (globally), but saving that state on tab level, lead to conditions where,
after a stream had ended, no tab had any indicators set, but a stray global
indicator without any icons would still be shown.
This patch fixes that by only showing the global indicator if there is actually
a tab with an indicator.

Differential Revision: https://phabricator.services.mozilla.com/D79315
2020-06-12 19:18:25 +00:00
Mike Conley
38b14b57d0 Bug 1641546 - Make the new WebRTC global sharing indicator a dialog instead of a popup. r=pbz
Depends on D77696

Differential Revision: https://phabricator.services.mozilla.com/D77504
2020-06-08 18:36:24 +00:00
Coroiu Cristina
093544ac23 Backed out 6 changesets (bug 1641546) for permafailing browser-chrome at browser_devices_get_user_media_unprompted_access_tear_off_tab.js
Backed out changeset 2652e1c084a7 (bug 1641546)
Backed out changeset 72a62a455c47 (bug 1641546)
Backed out changeset 4746c37be3e6 (bug 1641546)
Backed out changeset a2b64d290c0b (bug 1641546)
Backed out changeset 2dc2a430c2e7 (bug 1641546)
Backed out changeset 041cd14e3893 (bug 1641546)
2020-06-06 19:13:06 +03:00
Mike Conley
4cbbdd3058 Bug 1641546 - Make the new WebRTC global sharing indicator a dialog instead of a popup. r=pbz
Depends on D77696

Differential Revision: https://phabricator.services.mozilla.com/D77504
2020-06-05 14:29:29 +00:00
Mike Conley
bf6bb6f1c4 Bug 1639997 - Have webrtcUI handle the case where the selectedTab is set to null. r=pbz
It's possible for gBrowser.selectedTab to be set to null. This should be a no-op, but this
part of webrtcUI that tabbrowser calls doesn't handle the case, and causes an exception to
be thrown. This patch allows the no-op case to occur properly.

Differential Revision: https://phabricator.services.mozilla.com/D76736
2020-05-26 18:01:04 +00:00
Mike Conley
490f3dcbdf Bug 1639997 - Use more appropriate window features for new WebRTC global indicator. r=pbz
These features allow the indicator to not pull focus from the originating window, which
is important to maintain user task continuity, especially for screenreader users.

Differential Revision: https://phabricator.services.mozilla.com/D76735
2020-05-26 18:00:46 +00:00
Mike Conley
9af48e3c6d Bug 1639337 - Factor out the macOS status bar WebRTC indicator into a reusable class. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D76388
2020-05-26 18:00:36 +00:00
Mike Conley
881576fd11 Bug 1639283 - Add Telemetry to some of our WebRTC UI. r=pbz, data-review=mmccorquodale
Differential Revision: https://phabricator.services.mozilla.com/D76213
2020-05-20 22:51:31 +00:00
pbz
ab0ae62c5f Bug 1562600 - WebRTCParent: Get document URI from WindowGlobalParent instead of child message. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76121
2020-05-20 16:25:06 +00:00
Mike Conley
27a590bd9e Bug 1634796 - Add a panel that warns users before switching tabs when sharing the window over WebRTC. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D73734
2020-05-18 22:41:43 +00:00
Mike Conley
baa852c82b Bug 1636207 - Create a new WebRTC global indicator. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D74333
2020-05-18 18:57:40 +00:00
Mike Conley
55cdaf6040 Bug 1636207 - Have webrtcUI.getActiveStreams support getting window streams. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D74730
2020-05-18 18:55:54 +00:00
Mike Conley
9ed5c3ff6f Bug 1636207 - Include the serialized nsIMediaDevice list with the tab sharing state. r=florian,johannh
Differential Revision: https://phabricator.services.mozilla.com/D74729
2020-05-18 18:55:41 +00:00
Mike Conley
93c3fbc24e Bug 1636207 - Fork the WebRTC global indicator for a refresh. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D74332
2020-05-18 18:55:28 +00:00
Mike Conley
a316bd1675 Bug 1635257 - Add a checkbox to allow users to suppress notifications from the browser when sharing the screen. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D74244
2020-05-16 00:58:48 +00:00
Noemi Erli
573977550b Backed out 4 changesets (bug 1635257, bug 1637336) fr causing failures in browser_all_files_referenced.js CLOSED TREE
Backed out changeset 732ef8965a6e (bug 1635257)
Backed out changeset e3b350425e08 (bug 1635257)
Backed out changeset 2052da1ed54c (bug 1635257)
Backed out changeset 01ea90534f02 (bug 1637336)
2020-05-16 03:21:32 +03:00
Mike Conley
716c233a84 Bug 1635257 - Add a checkbox to allow users to suppress notifications from the browser when sharing the screen. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D74244
2020-05-15 18:02:17 +00:00
Mike Conley
ab2b2aaf18 Bug 1634703 - Have the webrtcUI module track which windows are being shared. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D73483
2020-05-12 14:51:08 +00:00
Bogdan Tara
8c5c4f1dd7 Backed out 7 changesets (bug 1634703) for testDeviceRecordingEventAudioAndVideo failures CLOSED TREE
Backed out changeset b982f5d74610 (bug 1634703)
Backed out changeset 59229853930e (bug 1634703)
Backed out changeset e017380f5539 (bug 1634703)
Backed out changeset 47a3a96b969b (bug 1634703)
Backed out changeset b4af76cfbdaf (bug 1634703)
Backed out changeset 7ef57434b09d (bug 1634703)
Backed out changeset 9df87d346b0f (bug 1634703)
2020-05-11 23:04:54 +03:00
Mike Conley
e3806f335f Bug 1634703 - Have the webrtcUI module track which windows are being shared. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D73483
2020-05-11 18:48:55 +00:00
Neil Deakin
64d1a3665c Bug 1616600, properly update the tab-indicator state when a tab is closed; it previously wasn't being removed properly from the per-tab indicator map when the indicator was from a subframe,r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D63535

--HG--
extra : moz-landing-system : lando
2020-02-25 18:08:06 +00:00
Neil Deakin
16f95497b9 Bug 1601301, rework webrtc permission granting UI around JSWindowActor, performing the work of determining the ultimate state for the tab icon and menu in the parent rather than the content process, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D56570

--HG--
rename : browser/modules/webrtcUI.jsm => browser/actors/WebRTCParent.jsm
extra : moz-landing-system : lando
2020-01-10 15:09:59 +00:00
Emma Malysz
57215abe07 Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751

--HG--
rename : browser/base/content/aboutDialog.xul => browser/base/content/aboutDialog.xhtml
rename : browser/base/content/newInstall.xul => browser/base/content/newInstall.xhtml
rename : browser/base/content/pageinfo/pageInfo.xul => browser/base/content/pageinfo/pageInfo.xhtml
rename : browser/base/content/safeMode.xul => browser/base/content/safeMode.xhtml
rename : browser/base/content/sanitize.xul => browser/base/content/sanitize.xhtml
rename : browser/base/content/titlebar-items.inc.xul => browser/base/content/titlebar-items.inc.xhtml
rename : browser/base/content/webext-panels.xul => browser/base/content/webext-panels.xhtml
rename : browser/base/content/webrtcIndicator.xul => browser/base/content/webrtcIndicator.xhtml
rename : browser/components/downloads/content/contentAreaDownloadsView.xul => browser/components/downloads/content/contentAreaDownloadsView.xhtml
rename : browser/components/migration/content/migration.xul => browser/components/migration/content/migration.xhtml
rename : browser/components/places/content/bookmarkProperties.xul => browser/components/places/content/bookmarkProperties.xhtml
rename : browser/components/places/content/bookmarksSidebar.xul => browser/components/places/content/bookmarksSidebar.xhtml
rename : browser/components/places/content/historySidebar.xul => browser/components/places/content/historySidebar.xhtml
rename : browser/components/places/content/places.xul => browser/components/places/content/places.xhtml
rename : browser/components/shell/content/setDesktopBackground.xul => browser/components/shell/content/setDesktopBackground.xhtml
extra : moz-landing-system : lando
2019-12-11 00:27:19 +00:00
Thomas Nguyen
a0b817ac65 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417

--HG--
extra : moz-landing-system : lando
2019-12-04 15:39:14 +00:00
Gurzau Raul
4f21dcd081 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE.
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
2019-12-03 21:57:55 +02:00
Thomas Nguyen
023216a561 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417

--HG--
extra : moz-landing-system : lando
2019-12-03 16:25:31 +00:00
thomasmo
d4926629a3 Bug 1591755 - Support Web Permissions in FxR for Desktop r=Gijs,pbz
This change will be the first of multiple changes to control permissions in FxR on PC. This change introduces a new class, FxrPermissionPromptPrototype, in the FxR front end code. With the introduction of this class, all permission requests are denied by default. Subsequent changes will provide UI to give user control.

Differential Revision: https://phabricator.services.mozilla.com/D52283

--HG--
extra : moz-landing-system : lando
2019-11-14 18:51:32 +00:00
Jan-Ivar Bruaroey
45fe5da43a Bug 1588640: Show OS Screen Recording helper prompt when user makes a selection. r=johannh,haik
Depends on D49217

Differential Revision: https://phabricator.services.mozilla.com/D49328

--HG--
extra : moz-landing-system : lando
2019-10-16 16:13:15 +00:00
Jan-Ivar Bruaroey
8f436b2bf0 Bug 1588640: Split out Screen Recording OSX permission from Camera, and reject even own window sharing sans OS permission. r=johannh,haik
Differential Revision: https://phabricator.services.mozilla.com/D49217

--HG--
extra : moz-landing-system : lando
2019-10-16 19:35:42 +00:00
Haik Aftandilian
445acf98e9 Bug 1565738 - Re-enable disabled WebRTC tests on macOS Mojave r=jib
Re-enable skipped webRTC tests on Mac which were disabled due to the macOS 10.14 permission prompts causing timeouts.

Don't trigger OS camera and microphone permission prompts for fake devices (used for tests).

Differential Revision: https://phabricator.services.mozilla.com/D46893

--HG--
extra : moz-landing-system : lando
2019-09-25 17:43:46 +00:00
Paul Zuehlcke
172c56e5ba Bug 1580189 - Clear geolocation permission for sub-frames with active sharing state. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D45827

--HG--
extra : moz-landing-system : lando
2019-09-25 09:16:32 +00:00
Johann Hofmann
fe6f796bbc Bug 1579489 - Check the persistent permission checkbox by default for WebExtension WebRTC prompts. r=jib
This is done to offset the requirement that extensions have to get persistent permission before
they can start using WebRTC in popups.

Differential Revision: https://phabricator.services.mozilla.com/D45335

--HG--
extra : moz-landing-system : lando
2019-09-17 12:55:42 +00:00
Johann Hofmann
0985571105 Bug 1579489 - Improve getUserMedia handling in extension pages. r=jib,rpl
The goal is to

- Avoid showing any permission prompt when calling getUserMedia in webextension popups,
  while still checking for persistent permissions.
- Never allow getUserMedia calls on background pages.

Differential Revision: https://phabricator.services.mozilla.com/D45333

--HG--
extra : moz-landing-system : lando
2019-09-17 12:55:22 +00:00
Bogdan Tara
06351a8472 Backed out 3 changesets (bug 1579489) for ES lint failure on browser_ext_webrtc.js CLOSED TREE
Backed out changeset 281d238e6259 (bug 1579489)
Backed out changeset 764628963a3c (bug 1579489)
Backed out changeset 680a45ca89b7 (bug 1579489)
2019-09-17 13:01:37 +03:00
Johann Hofmann
5ee7e03637 Bug 1579489 - Check the persistent permission checkbox by default for WebExtension WebRTC prompts. r=jib
This is done to offset the requirement that extensions have to get persistent permission before
they can start using WebRTC in popups.

Differential Revision: https://phabricator.services.mozilla.com/D45335

--HG--
extra : moz-landing-system : lando
2019-09-17 09:26:01 +00:00
Johann Hofmann
b368e3b21a Bug 1579489 - Improve getUserMedia handling in extension pages. r=jib,rpl
The goal is to

- Avoid showing any permission prompt when calling getUserMedia in webextension popups,
  while still checking for persistent permissions.
- Never allow getUserMedia calls on background pages.

Differential Revision: https://phabricator.services.mozilla.com/D45333

--HG--
extra : moz-landing-system : lando
2019-09-17 09:25:37 +00:00
Mihai Alexandru Michis
ee8e5475f4 Backed out 3 changesets (bug 1579489) for causing bc failures at browser_ext_webrtc.js CLOSED TREE
Backed out changeset 71978ebe41f1 (bug 1579489)
Backed out changeset b5e35c96c2f7 (bug 1579489)
Backed out changeset 71130160afee (bug 1579489)
2019-09-16 22:02:47 +03:00
Johann Hofmann
cbdf930501 Bug 1579489 - Check the persistent permission checkbox by default for WebExtension WebRTC prompts. r=jib
This is done to offset the requirement that extensions have to get persistent permission before
they can start using WebRTC in popups.

Differential Revision: https://phabricator.services.mozilla.com/D45335

--HG--
extra : moz-landing-system : lando
2019-09-16 15:40:50 +00:00
Johann Hofmann
ec59c497c6 Bug 1579489 - Improve getUserMedia handling in extension pages. r=jib,rpl
The goal is to

- Avoid showing any permission prompt when calling getUserMedia in webextension popups,
  while still checking for persistent permissions.
- Never allow getUserMedia calls on background pages.

Differential Revision: https://phabricator.services.mozilla.com/D45333

--HG--
extra : moz-landing-system : lando
2019-09-16 15:40:21 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Ehsan Akhgari
da187aab70 Bug 1560741 - Part 2: Remove the now unneeded PERMISSION_REQUEST_THIRD_PARTY_ORIGIN telemetry probe; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41306

--HG--
extra : moz-landing-system : lando
2019-08-12 21:39:05 +00:00
Brindusan Cristian
29eb45c017 Backed out 2 changesets (bug 1560741) for mochitest failures at test_permission_isHandlingUserInput.xul. CLOSED TREE
Backed out changeset c08aa2078829 (bug 1560741)
Backed out changeset 9dc1d39d2786 (bug 1560741)
2019-08-13 00:23:59 +03:00
Ehsan Akhgari
6f54e8e054 Bug 1560741 - Part 2: Remove the now unneeded PERMISSION_REQUEST_THIRD_PARTY_ORIGIN telemetry probe; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41306

--HG--
extra : moz-landing-system : lando
2019-08-12 19:34:43 +00:00