Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Stone Shih
16a8810124
Bug 1295719 - input[type=range,number] does not fire 'change' event for some key combinations. r=smaug
...
--HG--
extra : rebase_source : 89f46401a53dcab3dd3845477acfc7aaf9fdd3cc
2016-08-19 09:19:35 +08:00
Thomas Wisniewski
e18ef07821
Bug 1069015 - Restore code for :placeholder-shown pseudo-class. r=dbaron
2016-08-31 14:21:44 -04:00
Jessica Jong
1b328436b6
Bug 885359 - Support :indeterminate pseudo-class for radio groups. r=smaug
2016-08-24 18:39:00 -04:00
Olli Pettay
f684a31ad3
Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm
...
--HG--
extra : rebase_source : 17d97b01d1e7d27b37369f46a6ea8854f9384f54
2016-08-24 02:07:21 +03:00
Olli Pettay
dacd5c3661
Bug 1295914, improve the title of the folder picker a bit, r=baku
...
--HG--
extra : rebase_source : 2866f08c670897dad99f54f0c66ae81e2699630e
2016-08-24 02:06:08 +03:00
Andrea Marchesini
94d10aeb4c
Bug 1295570 - Entries API - part 2 - Rename Entry to FileSystemEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/Entry.cpp => dom/filesystem/compat/FileSystemEntry.cpp
rename : dom/filesystem/compat/Entry.h => dom/filesystem/compat/FileSystemEntry.h
2016-08-18 09:17:25 +02:00
Andrea Marchesini
f0c18d080e
Bug 1295570 - Entries API - part 1 - Rename DOMFileSystem to FileSystem, r=smaug
...
--HG--
rename : dom/filesystem/compat/DOMFileSystem.cpp => dom/filesystem/compat/FileSystem.cpp
rename : dom/filesystem/compat/DOMFileSystem.h => dom/filesystem/compat/FileSystem.h
rename : dom/webidl/DOMFileSystem.webidl => dom/webidl/FileSystem.webidl
2016-08-18 09:17:02 +02:00
Olli Pettay
89332bbcd3
Bug 1295922 - <input type=file webkitdirectory>.click() doesn't work. r=baku
...
--HG--
extra : rebase_source : cc42f9aa791ec7a694870b9dc933f034e40430d6
2016-08-17 17:59:53 +03:00
Thomas Wisniewski
fe6139c017
Bug 932755 - Add support for input/textarea minLength and tooShort. r=mrbkap
...
--HG--
extra : rebase_source : 064985cbb241ef8705dcec28f60db9f4caf65ae4
2016-08-17 00:11:24 -04:00
Decky Coss
08a416fd4e
Bug 1283915 - Preserve input selection properties after type change. r=smaug
...
MozReview-Commit-ID: 7xJKc3vIpTY
--HG--
extra : rebase_source : 6fa36a607efb1e8eec1cc8efbb174d622aa0281f
2016-07-27 11:04:53 -04:00
Jessica Jong
5a9b39d967
Bug 1278738 - Add 'week' to the list of valid types attributes for <input>. r=smaug
2016-08-15 23:15:00 -04:00
Jessica Jong
6f6b9ca3bc
Bug 1281769 - Do not throw when getting selectionDirection/selectionStart/selectionEnd on input/textarea. r=smaug
2016-08-08 23:19:00 +02:00
Ben Tian
6107aa70d5
Bug 1272297 - Do not check pattern validity while parser is creating this input element. r=smaug
2016-08-09 15:21:15 +08:00
Thomas Wisniewski
30ab766837
Bug 613019 - Track whether the last input/textarea change was done interactively, and enable the commented-out maxLength tracking code. r=mrbkap
...
--HG--
extra : rebase_source : 59c0986d6184f09f79fcda848de9d822949aa47b
2016-08-06 11:59:08 -04:00
Stone Shih
4f6e8a25cc
Bug 1286509 - Range input does not fire ‘change’ event when the range is changed using the keyboard. r=smaug
2016-08-01 10:47:34 +08:00
Decky Coss
b69450d2ea
Bug 1287655 - place textarea/input cursor at end of text when initialized; r=smaug
...
MozReview-Commit-ID: 2srGXFmla07
--HG--
extra : transplant_source : %3Cn%D30%86%24%82%90%29%191%9C%8A%EB%0D%5D%E2%20%22%E5
2016-07-21 14:52:49 -04:00
Jessica Jong
b92c3511ea
Bug 1283023 - Implement the step attribute for <input type=month>. r=smaug
...
--HG--
extra : rebase_source : 730c799687da786279efcd3134777b7208567e9e
2016-08-03 02:54:00 +02:00
Carsten "Tomcat" Book
6b13b3cde6
Merge mozilla-central to autoland
2016-08-03 17:08:48 +02:00
Masayuki Nakano
91380f92d1
Bug 1259672 Rename InternalFormEvent::originator to mOriginator r=smaug
...
MozReview-Commit-ID: 1RoHVeziNr3
--HG--
extra : rebase_source : 85c63944e477603cee3a36e435c83890ea037715
2016-08-03 17:06:10 +09:00
Boris Zbarsky
f04672a88c
Bug 1287989. Don't try to do validation or fire submit events in iframes that are sandboxed without allow-forms. r=smaug
2016-08-02 11:05:36 -07:00
Olli Pettay
17d576d0b3
Bug 1289254 - Support dnd for webkitdirectory, r=baku
...
--HG--
extra : rebase_source : dafc058127ea6ededb6df0ec7bcf6f9fbff36202
2016-07-29 14:41:38 +03:00
Jessica Jong
67751356ee
Bug 1289272 - Simplify the computation of step values for input type=date. r=smaug
...
--HG--
extra : rebase_source : 24bf85cff09e6ace2806778e9e5409756a598e57
2016-07-28 02:44:00 -04:00
Andrea Marchesini
3660cacdaf
Bug 1288681 - Rename HTMLInputElement::directory to HTMLInputElement::allowdirs, r=smaug
2016-07-23 10:20:15 +02:00
Andrea Marchesini
60ab8339e0
Bug 1288736 - Add some missing rv.SuppressException(), r=smaug
2016-07-22 16:50:10 +02:00
Carsten "Tomcat" Book
4a64baa9d4
merge mozilla-inbound to mozilla-central a=merge
2016-07-21 16:24:36 +02:00
Olli Pettay
2c576a46e2
Bug 1287321 - Don't fire input event on type=range when value hasn't changed. r=baku
...
--HG--
extra : rebase_source : 561195bb4aeb4883a368464b0b6e8d3d53f3873f
2016-07-20 21:06:57 +03:00
Chris Peterson
b175c9fdd5
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
Jessica Jong
17b5002551
Bug 1283022 - Implement the min and max attribute for <input type=month>. r=smaug
2016-07-15 00:07:00 +02:00
Stone Shih
9a816de486
Bug 1261674 - Handle wheel event when mouse cursor is hovered on a focused range input as increasing/decreasing it's value. r=smaug
...
--HG--
extra : rebase_source : 1e801d569b3c3b49f3c7f1fe409b929fa27de17e
2016-07-05 17:48:19 +08:00
Carsten "Tomcat" Book
7c0644d587
Merge mozilla-central to mozilla-inbound
2016-07-14 11:56:37 +02:00
Andrea Marchesini
fbe3bd5abf
Bug 1186932 - Implement support for form submission of a picked directory - part 4 - Moving GetFilesHelper to separate files, r=smaug
2016-07-14 09:03:10 +02:00
Andrea Marchesini
f8488defb9
Bug 1186932 - Implement support for form submission of a picked directory - part 3 - tests + fixes, r=smaug
2016-07-14 09:02:30 +02:00
Andrea Marchesini
3c6ff93c8f
Bug 1186932 - Implement support for form submission of a picked directory - part 1 - FormData and Directory, r=smaug
2016-07-14 09:01:31 +02:00
Thomas Wisniewski
5bc757cfaa
Bug 1264157 - Do not match disabled/readonly inputs with :in-range and :out-of-range. r=bz
...
--HG--
rename : dom/html/test/test_bug535043.html => dom/html/test/test_bug1264157.html
2016-07-10 14:37:00 -04:00
Jessica Jong
bc0a1bc5f8
Bug 1278185 - Implement valueAsNumber and valueAsDate for <input type=month>. r=smaug
2016-07-11 01:00:00 +02:00
Jessica Jong
2e7c66c5e9
Bug 1278191 - Implement the value sanitizing algorithm for <input type=month>. r=smaug
...
--HG--
extra : rebase_source : f2e424614490db76d8899c7f1583fd9fc1a2f53c
2016-07-06 01:59:00 +02:00
Jeremy Chen
122a1b7056
Bug 906116 - part3.3: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
...
Use ReconstructFrame to replace NS_STYLE_HINT_FRAMECHANGE in many places, such
as HTML*Element::GetAttributeChangeHint and HTMLFrameSetElement::SetAttr.
MozReview-Commit-ID: EHbc4RMeuu0
--HG--
extra : rebase_source : afffc0d2ee2861a58dee82f0af06a67f4b8e3a78
2016-07-06 13:06:14 +08:00
Carsten "Tomcat" Book
45017d7986
Backed out changeset 8c1f9996a7d6 (bug 906116)
2016-07-06 05:40:06 +02:00
Jeremy Chen
160b96f9a4
Bug 906116 - part3.3: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
...
Use ReconstructFrame to replace NS_STYLE_HINT_FRAMECHANGE in many places, such
as HTML*Element::GetAttributeChangeHint and HTMLFrameSetElement::SetAttr.
MozReview-Commit-ID: EHbc4RMeuu0
--HG--
extra : rebase_source : f5163608c88362595ef5af5fcd36fa64c9c79ce7
2016-07-06 09:59:56 +08:00
Fabrice Desré
2d7ccfe630
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS r=bz
...
MozReview-Commit-ID: Lx2kozynptu
--HG--
extra : rebase_source : 3f7b9004cd26675dbab6a1909a4b5135d753fd04
2016-04-05 13:34:53 +02:00
Jessica Jong
ba75f42662
Bug 1278737 - Add 'month' to the list of valid types attributes for <input>. r=smaug
...
--HG--
rename : dom/html/test/forms/test_experimental_forms_pref.html => dom/html/test/forms/test_input_types_pref.html
2016-07-03 23:19:00 +02:00
Stone Shih
f3651866bf
Bug 1261673: Handle wheel event when mouse cursor is hovered on a focused number input as increasing/decreasing it's value. r=smaug
2016-05-06 18:39:10 +08:00
Sebastian Hengst
f74056ca75
Backed out changeset 444a4a7233f7 (bug 1278737) for frequent web platform test 2 failure on OSX in form-validation-reportValidity.html. r=backout
...
--HG--
rename : dom/html/test/forms/test_input_types_pref.html => dom/html/test/forms/test_experimental_forms_pref.html
2016-07-01 20:04:58 +02:00
Jessica Jong
7db8d433f6
Bug 1278737 - Add 'month' to the list of valid types attributes for <input>. r=smaug
...
--HG--
rename : dom/html/test/forms/test_experimental_forms_pref.html => dom/html/test/forms/test_input_types_pref.html
2016-06-29 23:16:00 +02:00
Andrea Marchesini
5cddd3946d
Bug 1283061 - HTMLInputElement type=file webkitdirectory/directory should show just 1 button, r=smaug
2016-06-29 18:18:42 +02:00
Andrea Marchesini
f181ac8328
Bug 1272501 - Add Telemetry to the Blink/Webkit FileSystem API - part 2, r=smaug
2016-06-28 18:02:30 +02:00
Andrea Marchesini
93b1b8e92a
Bug 1272501 - Add Telemetry to the Blink/Webkit FileSystem API - part 1, r=smaug
2016-06-28 18:02:13 +02:00
Jordan
f35a9b375c
Bug 825294 - Add framework for datepicker widgets to input[type=date]. r=smaug
...
-Add framework for datepicker widgets
-Split date input preference from dom.experimental_forms to dom.forms.date
2016-06-20 15:55:00 +02:00
Andrea Marchesini
aadce059f5
Bug 1279860 - part 1 - Renaming nsFormSubmission to mozilla::dom::HTMLFormSubmission, r=smaug
...
--HG--
rename : dom/html/nsFormSubmission.cpp => dom/html/HTMLFormSubmission.cpp
rename : dom/html/nsFormSubmission.h => dom/html/HTMLFormSubmission.h
rename : dom/html/nsFormSubmissionConstants.h => dom/html/HTMLFormSubmissionConstants.h
2016-06-16 08:24:16 +01:00