Commit graph

102 commits

Author SHA1 Message Date
Simon Giesecke
a892bc01f6 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
078debe589 Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
98b9d42815 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
Simon Giesecke
86ba544cc6 Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-23 08:38:57 +00:00
Chris Peterson
843c954b43 Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
Andreea Pavel
80afdc5ddc Backed out changeset 7dccafbf3437 (bug 1536540) for failing wpt at idlharness.any.worker.html on a CLOSED TREE 2020-04-22 21:54:11 +03:00
Simon Giesecke
bcf94e6de5 Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-22 14:53:17 +00:00
Dorel Luca
41c3ea3ee8 acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE 2020-04-22 08:41:47 +03:00
Chris Peterson
0aeb2db4f6 Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
Simon Giesecke
02753c9665 Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D65710

--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:39 +00:00
Mihai Alexandru Michis
2922453b6e Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages.
CLOSED TREE

Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
2020-03-19 13:30:26 +02:00
Simon Giesecke
59bc885b82 Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D65710

--HG--
extra : moz-landing-system : lando
2020-03-19 09:34:40 +00:00
Simon Giesecke
f28bafa279 Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64131

--HG--
extra : moz-landing-system : lando
2020-03-11 17:30:33 +00:00
Simon Giesecke
a5e45033f2 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8c7b4f143a Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
a48be584a9 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke
44cadc4359 Bug 1608115 - Use CheckedUnsafePtr for IDBCursor::mTransaction to improve safety r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D51411

--HG--
extra : moz-landing-system : lando
2020-01-10 14:10:00 +00:00
Simon Giesecke
0d5b4fd7af Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57990

Differential Revision: https://phabricator.services.mozilla.com/D57991

--HG--
extra : moz-landing-system : lando
2020-01-06 14:19:39 +00:00
Simon Giesecke
477b7e637e Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55492

--HG--
extra : moz-landing-system : lando
2019-12-16 14:42:54 +00:00
Simon Giesecke
b6fc689caf Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
Depends on D45674

Differential Revision: https://phabricator.services.mozilla.com/D45675

--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:31 +00:00
Simon Giesecke
59cd698867 Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:35 +00:00
Simon Giesecke
9804c8f159 Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1211bbc800 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
95a4ff4109 Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
Depends on D45674

Differential Revision: https://phabricator.services.mozilla.com/D45675

--HG--
extra : moz-landing-system : lando
2019-11-05 13:23:58 +00:00
Simon Giesecke
69cd8f61cb Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando
2019-11-05 12:45:48 +00:00
Simon Giesecke
1db45a09bf Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Simon Giesecke
cd0b6f05a1 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
Simon Giesecke
16d87d7487 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:32 +00:00
Oana Pop Rus
cb31d323be Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke
a9cf10ae19 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
Simon Giesecke
0438fc4336 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-01 08:56:37 +00:00
Simon Giesecke
860d44f9b4 Bug 1168606 - Added comments on almost-const data members r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D42645

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:20 +00:00
Mihai Alexandru Michis
b5c83385d6 Backed out 8 changesets (bug 1168606) for failures in idbcursor-continuePrimaryKey.htm
Backed out changeset 066bee573945 (bug 1168606)
Backed out changeset 1485cea56f41 (bug 1168606)
Backed out changeset 4858e4e132de (bug 1168606)
Backed out changeset 5be5a3bf0499 (bug 1168606)
Backed out changeset 6078d5a9c010 (bug 1168606)
Backed out changeset f5aee1ae7282 (bug 1168606)
Backed out changeset acae76cea927 (bug 1168606)
Backed out changeset 0133605c6169 (bug 1168606)

--HG--
extra : rebase_source : 27477feb2e52f4149ede2fe5db9d86b5e322046d
2019-09-11 14:36:57 +03:00
Simon Giesecke
a947f3b52f Bug 1168606 - Added comments on almost-const data members r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D42645

--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:01 +00:00
Andrea Marchesini
da174a4757 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jonathan Kew
853c408d06 Bug 1402858 - Remove ENABLE_INTL_API conditional and non-Intl legacy codepaths from IndexedDB. r=janv 2017-09-25 17:32:23 +01:00
Bevis Tseng
efa7337a9a Bug 1271505 - Support of IDBCursor.continuePrimaryKey. r=khuey 2016-07-26 15:26:50 +08:00
Bevis Tseng
c36eaf728e Bug 1289375 - Rollback incomplete change of preloading cursors for IndexedDB. r=khuey 2016-07-26 18:51:19 +08:00
Jonathan Watt
b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Kyle Huey
31dabb4558 Bug 1247117: De-namespace much of IndexedDB. r=baku 2016-02-16 13:46:08 -08:00
Kyle Huey
91efc5a86c Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
Nathan Froyd
01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Reuben Morais
e493377d61 Bug 871846 - API changes for locale aware indexes. r=janv r=sicking 2015-09-04 16:12:29 -03:00
Birunthan Mohanathas
258615a1ba Bug 1168606 - Part 5: Send two records with every ObjectStoreCursorResponse. r=khuey 2015-08-19 14:59:29 -07:00
Ben Turner
6262017c4a Bug 1179025 - Protect against using cursors on a deleted objectStore/index, r=janv. 2015-07-02 10:47:53 -07:00
Ryan VanderMeulen
3da97f6aee Backed out changeset c725221a7c45 (bug 1179025) for Werror bustage.
CLOSED TREE
2015-07-02 14:22:28 -04:00