Commit graph

70 commits

Author SHA1 Message Date
Frederik Braun
a7153982e8 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Gijs Kruitbosch
dbbc92362d Bug 1644877 - mark .der files as executable (just like .crt), r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D80172
2020-06-18 13:09:50 +00:00
Simon Giesecke
82dc9b2271 Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
Butkovits Atila
e3dce68834 Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
Simon Giesecke
d419f0ff08 Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
Sebastian Streich
dca41f9190 Bug 1630313 - Use BasePrincipal in ApplicationReputation.cpp r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D71070
2020-04-20 10:23:07 +00:00
Eric Rahm
b224a7461c Bug 1617334 - Remove nsAutoPtr usage from toolkit. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D63746

--HG--
extra : moz-landing-system : lando
2020-02-22 14:50:52 +00:00
Gijs Kruitbosch
7e32d47d84 Bug 1605102, r=mak,dimi
Differential Revision: https://phabricator.services.mozilla.com/D58674

--HG--
extra : moz-landing-system : lando
2020-01-22 18:20:23 +00:00
Zibi Braniecki
4fb4f2f900 Bug 1609585 - Migrate all possible uses from AppLocalesAsLangTag(s) to AppLocale(s)AsBCP47. r=marionette-reviewers,jfkthame,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D60096

--HG--
extra : moz-landing-system : lando
2020-01-17 19:29:09 +00:00
Gabriele Svelto
5dc21d568c Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444

--HG--
extra : moz-landing-system : lando
2019-12-06 09:17:57 +00:00
Sean Feng
f8ddb7e6f1 Bug 1580316 - Update signatureInfo to Array of Array of nsIX509Cert(in raw bytes) r=keeler,dimi
The signatureInfo that has been used in ExternalHelperAppService and
ReputationService has been stored Array of nsIX509CertList, which
isn't necessary because only the raw bytes of the certs are required.
This patch intends to remove the usage of nsIX509CertList and store
the raw bytes directly.

Differential Revision: https://phabricator.services.mozilla.com/D44243

--HG--
extra : moz-landing-system : lando
2019-11-19 19:51:44 +00:00
Sean Feng
3d651bb90e Bug 1578534 - Change nsIX509CertDB.constructX509 to take Array<uint8_t> r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D44730

--HG--
extra : moz-landing-system : lando
2019-11-12 20:59:02 +00:00
Thomas Nguyen
fe6a6a4285 Bug 1567940 Apply ReferrerInfo to Download and fix Go to Download Page button r=Gijs,dimi
In the old way, if referrer is ommited we will not be able to go to
download page. In that case, we should use originalReferrer in
ReferrerInfo object

Differential Revision: https://phabricator.services.mozilla.com/D39875

--HG--
extra : moz-landing-system : lando
2019-08-20 16:22:44 +00:00
dimi
1e0f988331 Bug 1564041 - P2. Remove old application reputation telemetry r=chutten
APPLICATION_REPUTATION_BINARY is now replaced by APPLICATION_REPUTATION_BINARY_TYPE,
we can remove it from telemetry.

Depends on D37275

Differential Revision: https://phabricator.services.mozilla.com/D37276

--HG--
extra : moz-landing-system : lando
2019-08-08 07:39:23 +00:00
dimi
7e316918d8 Bug 1564041 - P1. Add telemetry to measure download protection binary type r=gcp
This patch adds a telemetry, APPLICATION_REPUTATION_BINARY_TYPE, which
records different binary type based on the file extension.

1. BinaryFile, file is considered as a binary file, file is eligible for remote lookup
2. NonBinaryFile, file is not considered as a binary file.
3. MozNonBinaryFile, file is considered as a binary file in Chrome, but we don't
   send a download protection ping for this file
4. UnknownFile, file is not in any of the above lists.

Differential Revision: https://phabricator.services.mozilla.com/D37275

--HG--
extra : moz-landing-system : lando
2019-08-08 07:38:19 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Boris Zbarsky
d40a269ffc Bug 1558735 part 1. Stop using [array] in nsIX509Cert.getRawDER. r=keeler,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D34670

--HG--
extra : moz-landing-system : lando
2019-06-14 18:17:20 +00:00
dlee
cd530d2abf Bug 1547732 - Use LOAD_BYPASS_URL_CLASSIFIER flag for download protection ping. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D29231

--HG--
extra : moz-landing-system : lando
2019-04-29 17:36:44 +00:00
Dimi Lee
fe3a1447b2 Bug 1542149 - Add some MacOS file extensions to to the list of executable extensions in download protection. r=Gijs
Here are the file extensions are added to the list:
1. action
2. caction
3. configprofile
4. definition
5. dylib
6. internetconnect
7. networkconnect
8. service
9. wflow
10.workflow

Differential Revision: https://phabricator.services.mozilla.com/D26284

--HG--
extra : moz-landing-system : lando
2019-04-05 12:04:49 +00:00
Sylvestre Ledru
ef0bfc3822 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D24168

--HG--
extra : moz-landing-system : lando
2019-03-31 15:12:55 +00:00
Dimi Lee
9b8bb702a9 Bug 1536020 - Add "mobileconfig" to the list of executable extensions in download protection. r=Gijs
This is from Chromium's change log:
.mobileconfig files gives powerful controls over both system settings
and Chrome settings on MacOS, with a fairly straightforward installation process.

Differential Revision: https://phabricator.services.mozilla.com/D24285

--HG--
extra : moz-landing-system : lando
2019-03-20 22:56:49 +00:00
Sylvestre Ledru
4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Gijs Kruitbosch
b0993c3f95 Bug 1392955, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D19475

--HG--
extra : moz-landing-system : lando
2019-03-02 00:01:26 +00:00
Dimi Lee
c1d05c5637 Bug 1531322 - Add "bin" to the list of executable extensions in download protection. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D21529

--HG--
extra : moz-landing-system : lando
2019-02-28 13:22:15 +00:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston
c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:31 +00:00
Jonathan Kingston
f7e35ae39e Bug 1525319 - Removing context from OnStartRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:04 +00:00
Dorel Luca
4a4dcd57fa Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
2019-02-25 04:06:11 +02:00
Jonathan Kingston
63ab2bd8aa Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-24 20:27:55 +00:00
Jonathan Kingston
332531fa9c Bug 1525319 - Removing context from OnStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
2019-02-24 20:26:59 +00:00
Jonathan Kingston
2441197975 Bug 1525319 - Removing context from OnStartRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
2019-02-24 20:26:16 +00:00
Christoph Kerschbaumer
08be3dab62 Bug 1529252: Remove the 2 from the various version to create a channel within nsIIOService.idl. r=valentin 2019-02-21 12:48:20 +01:00
Christoph Kerschbaumer
54df1cb98c Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Dimi Lee
418cd3709c Bug 1526885 - P2. Add MS Office files to the list of executable extensions in download protection. r=gcp
Sync with the list in chrome, chrome adds office docs because they have been abused in the past
through embedded executables.

Differential Revision: https://phabricator.services.mozilla.com/D19759

--HG--
extra : moz-landing-system : lando
2019-02-14 13:30:38 +00:00
Dimi Lee
3571f40e76 Bug 1526885 - P1. Add extensions to download protectionn executable list. r=gcp
Those extensions are set to SAMPLED_PING by google, which means they are
not really dangerous.
Add these extensions to sync up with google's list but comment them
because we don't need to trigger remote lookup request for them.

Differential Revision: https://phabricator.services.mozilla.com/D19758

--HG--
extra : moz-landing-system : lando
2019-02-14 13:29:45 +00:00
Jonathan Kingston
3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Kris Maglione
b83df4e952 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D15039

--HG--
extra : rebase_source : 1683d6ced9a6c10e6fa19425debbb51950b9b629
extra : source : d94039b199437180309264cb4c206ae7ebb7d21d
2018-12-16 16:03:00 -08:00
arthur.iakab
c1fae83952 Backed out 16 changesets (bug 1478124) for failing android geckoview-junit CLOSED TREE
Backed out changeset fce62c77a56b (bug 1478124)
Backed out changeset eb2fa3b5edf7 (bug 1478124)
Backed out changeset 8dacce59fcc0 (bug 1478124)
Backed out changeset 012fd0107204 (bug 1478124)
Backed out changeset 496aaf774697 (bug 1478124)
Backed out changeset 21f4fda03159 (bug 1478124)
Backed out changeset b0444e0bc801 (bug 1478124)
Backed out changeset d94039b19943 (bug 1478124)
Backed out changeset 5d85deac61c2 (bug 1478124)
Backed out changeset 929fd654c9df (bug 1478124)
Backed out changeset 1ddd80d9e91a (bug 1478124)
Backed out changeset b8d2dfdfc324 (bug 1478124)
Backed out changeset f500020a273a (bug 1478124)
Backed out changeset dd00365ebb55 (bug 1478124)
Backed out changeset 538e40c5ee13 (bug 1478124)
Backed out changeset bedaa9c437ad (bug 1478124)
2019-01-29 10:03:06 +02:00
Kris Maglione
d20f7f8e72 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D15039

--HG--
extra : rebase_source : 55c387662960d82986a2a0205d3b8e451304db4b
extra : absorb_source : bd201f3bcf08f70480f19a22bfb7a8bd9cb015a1
extra : histedit_source : ec13a9b248801ab36baa275e566765734e6f3717
2018-12-16 16:03:00 -08:00
Margareta Eliza Balazs
9dda825205 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-18 12:31:59 +02:00
Ehsan Akhgari
06c3d29113 Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre
Summary: # ignore-this-changeset

Reviewers: sylvestre

Reviewed By: sylvestre

Subscribers: reviewbot, emilio, jandem, bbouvier, karlt, jya

Bug #: 1521000

Differential Revision: https://phabricator.services.mozilla.com/D16936

--HG--
extra : histedit_source : 4add583bfa729ccc1aef934629ed45ff095189b0
2019-01-18 10:12:56 +01:00
Dimi Lee
fb9287376a Bug 1501974 - Add keyed telemetry to know the download protection remote lookup result . r=francois
Add APPLICATION_REPUTATION_SERVER_VERDICT_2 telemetry with file extension as the key.
This can give us an idea about the current detecion rate for archived
files.

Differential Revision: https://phabricator.services.mozilla.com/D13249

--HG--
extra : moz-landing-system : lando
2019-01-17 20:39:53 +00:00
Dimi Lee
6e69465ce8 Bug 1435923 - Fix truncated logging of remote lookup protocol buffer. r=gcp
Fix the truncate issue when output the protocol buffer

Differential Revision: https://phabricator.services.mozilla.com/D16675

--HG--
extra : moz-landing-system : lando
2019-01-17 12:38:04 +00:00
Sylvestre Ledru
47a5dd1fb8 Bug 1519636 - Reformat everything to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D16388

--HG--
extra : moz-landing-system : lando
2019-01-16 08:50:07 +00:00
Dimi Lee
d620535216 Bug 1517704 - Add cpi to the list of executable extensions in download protection. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D15804

--HG--
extra : moz-landing-system : lando
2019-01-07 15:22:21 +00:00
Dimi Lee
bb6cc32d45 Bug 1510559 - Add .desktop to the list of executable extensions in download protection. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D14238

--HG--
extra : moz-landing-system : lando
2018-12-12 10:57:50 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
dlee
5cca87267f Bug 1500360 - P1. Add telemetry to record the reason download protection allow or block the download. r=francois
In this patch, we added a telemetry to record different reasons that
why download protection service decides to allow or block this download.

The |verdict| and |shouldBlock| parameters are moved inside
PendingLookup::OnComplete and now we used |Reason| in the query
reputation code path instead

Use enumerated Telemetry because it is easier to add more reasons in the
future.

Differential Revision: https://phabricator.services.mozilla.com/D10952

--HG--
extra : moz-landing-system : lando
2018-11-28 14:07:03 +00:00
Dimi Lee
651760fe36 Bug 1397546 - Allow Application Reputation lookups when the blacklist/whitelist is missing. r=francois
Before landing this patch, download protection doesn't trigger a remote lookup when
blocklist or allowlist is empty.

After landing this patch, download protection triggers a remote lookup
regardless if blocklist or allowlist is empty.

This is safer default behavior in download protection.

Differential Revision: https://phabricator.services.mozilla.com/D11621

--HG--
extra : moz-landing-system : lando
2018-11-21 19:43:06 +00:00