nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
911903 commits 1 branch 98 tags 6.4 GiB
Commit graph

87 commits

Author SHA1 Message Date
Dave Townsend
95ccf713ef Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202949
 2024-03-19 14:59:20 +00:00
Mike Conley
5b77060db6 Bug 1865382 - Remove legacy WebRTC indicator implementation. r=pbz,fluent-reviewers,desktop-theme-reviewers,bolsson,emilio 
Depends on D193933

Differential Revision: https://phabricator.services.mozilla.com/D193934
 2023-11-27 16:43:32 +00:00
Robert Mader
656ef8b2ef Bug 1668358 - Hide global webrtc privacy indicator on Wayland, r=emilio 
The indicator never worked well on Wayland as the protocol gives us
little control about window positioning, focus etc. by design, creating
a quite bad user experience.

At the same time Wayland puts constrains on recording the display,
requiring apps to go through a "portal" where they usually have to
actively select the screen or window to share. This, crucially, allows
system compositors to show indicators itself - which all major DEs do
or at least support.

Unfortunately we can't disable the indicator at build-time as our builds
support both Wayland and X11, thus make it runtime detectable.

Differential Revision: https://phabricator.services.mozilla.com/D184193
 2023-07-21 16:41:27 +00:00
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Stephen A Pohl
443ffe6f54 Bug 1806451: Remove superfluous and non-functional inwindowmenu attributes. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165280
 2022-12-21 13:33:33 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Eemeli Aro
2c47f765da Bug 1793572 - Convert webrtcIndicator.properties to Fluent. r=mconley,flod 
Differential Revision: https://phabricator.services.mozilla.com/D158760
 2022-10-08 07:35:28 +00:00
Mike Conley
a9fa6b98b9 Bug 1783918 - Part 4: Plumb trigger event through to calls to webrtcUI.showSharingDoorhanger and have it call openPopup directly. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D154130
 2022-08-10 15:05:33 +00:00
Mike Conley
47fbc25636 Bug 1783918 - Part 1: Remove redundant command event handlers. r=pbz 
There's already a command event handler on the whole webrtcIndicator window,
so we don't need to set additional ones on the menuitems, as the window handler
is doing the same thing.

Differential Revision: https://phabricator.services.mozilla.com/D154127
 2022-08-10 15:05:31 +00:00
Tooru Fujisawa
54623364da Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
8cd6ed7409 Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Tooru Fujisawa
823c668f50 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian 
Differential Revision: https://phabricator.services.mozilla.com/D148164
 2022-06-06 04:42:08 +00:00
Molnar Sandor
77402a5caa Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
5ff7b51845 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian 
Differential Revision: https://phabricator.services.mozilla.com/D148164
 2022-06-06 02:49:12 +00:00
Mike Conley
68b66ca6bd Bug 1672432 - Don't remove persistent device permissions when clicking 'Stop Sharing' in the WebRTC global indicator. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D94501
 2020-10-27 16:28:25 +00:00
Mike Conley
76bb38fdcb Bug 1669801 - Fix the shared device menupopup when sharing an application window over WebRTC. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D92994
 2020-10-13 01:13:04 +00:00
Mike Conley
a4bd411b41 Bug 1668838 - Make sure popuphiding event is only considered for device control menus in WebRTC indicator. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D92241
 2020-10-05 09:23:40 +00:00
Mike Conley
03bcb35aed Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz 
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
 2020-09-30 21:14:10 +00:00
Mike Conley
bef332377f Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod 
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
 2020-09-30 21:14:07 +00:00
Narcis Beleuzu
bb2bab98d0 Backed out 9 changesets (bug 1661474, bug 1668010, bug 1663784, bug 1665490) for bc failures on browser_all_files_referenced.js . CLOSED TREE 
Backed out changeset 9a5e08c77923 (bug 1668010)
Backed out changeset 9bcba802456e (bug 1665490)
Backed out changeset 82ba64e4e81f (bug 1661474)
Backed out changeset 9b5d89c13aa3 (bug 1661474)
Backed out changeset e812f197f225 (bug 1663784)
Backed out changeset ddfbe96735f3 (bug 1663784)
Backed out changeset 282d763360a2 (bug 1663784)
Backed out changeset 9e5267b83d94 (bug 1663784)
Backed out changeset 53a57a5b60d3 (bug 1663784)
 2020-10-01 00:08:50 +03:00
Mike Conley
7aa395aa21 Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz 
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
 2020-09-30 15:15:58 +00:00
Mike Conley
b0d894437a Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod 
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
 2020-09-30 15:13:14 +00:00
Razvan Maries
d3644bd0b8 Backed out 8 changesets (bug 1661474, bug 1663784, bug 1665490) for build bustages on IconLoaderHelperCocoa.h and nsMenuItemIconX.mm. CLOSED TREE 
Backed out changeset 4a035c0339f8 (bug 1665490)
Backed out changeset 573e8d8d1fc8 (bug 1661474)
Backed out changeset c2d5b0b0a1a3 (bug 1661474)
Backed out changeset 97be0dd0742d (bug 1663784)
Backed out changeset 428926be2268 (bug 1663784)
Backed out changeset a737df82383a (bug 1663784)
Backed out changeset d1faf309c9d0 (bug 1663784)
Backed out changeset 4ee61c4a6bc8 (bug 1663784)
 2020-09-30 02:16:00 +03:00
Mike Conley
9cdefe9bff Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz 
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
 2020-09-29 06:51:43 +00:00
Mike Conley
f60440cf37 Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod 
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
 2020-09-29 06:50:04 +00:00
Mike Conley
ebba4517a0 Bug 1643027 - Turn the microphone and camera icons in the WebRTC indicator into global mute toggles. r=pbz,fluent-reviewers,flod 
Depends on D86719

Differential Revision: https://phabricator.services.mozilla.com/D86619
 2020-08-27 17:03:43 +00:00
Bogdan Tara
f7dc3b755a Backed out 6 changesets (bug 1643027, bug 1658353) for browser_parsable_css.js failures CLOSED TREE 
Backed out changeset e50501b54674 (bug 1643027)
Backed out changeset aa5d33b0d0b5 (bug 1643027)
Backed out changeset 51c592eb4ebd (bug 1643027)
Backed out changeset fe37ed8ba008 (bug 1658353)
Backed out changeset acb933a440c7 (bug 1658353)
Backed out changeset 7aa764991e49 (bug 1658353)
 2020-08-27 18:39:49 +03:00
Mike Conley
695a4bd6e6 Bug 1643027 - Turn the microphone and camera icons in the WebRTC indicator into global mute toggles. r=pbz,fluent-reviewers,flod 
Depends on D86719

Differential Revision: https://phabricator.services.mozilla.com/D86619
 2020-08-26 21:31:29 +00:00
Mike Conley
5b14269be5 Bug 1657484 - Change default location of the WebRTC global sharing indicator. r=pbz 
Per UX, the new default location for the indicator upon opening is the the top
of the content viewport of the most recently used browser window.

Differential Revision: https://phabricator.services.mozilla.com/D86080
 2020-08-11 10:03:07 +00:00
Mike Conley
22de1f0d2a Bug 1655078 - Make the 'Stop Sharing' button in the WebRTC indicator stop all screen sharing streams. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D85414
 2020-08-05 03:38:19 +00:00
Bogdan Tara
c517528c86 Backed out changeset 33eb26623d7e (bug 1655078) for browser_stop_sharing_button.js failures CLOSED TREE 2020-08-05 01:00:42 +03:00
Mike Conley
ae15a943ed Bug 1655078 - Make the 'Stop Sharing' button in the WebRTC indicator stop all screen sharing streams. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D85414
 2020-08-04 20:50:19 +00:00
Mike Conley
caa4a47fad Bug 1654266 - Make sure the 'Stop Sharing' button in the WebRTC indicator only stops displays, and not mic/camera streams. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D84574
 2020-07-24 15:14:17 +00:00
Mike Conley
be5766d15a Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D82989
 2020-07-17 01:22:10 +00:00
Bogdan Tara
d115b9a6ea Backed out 2 changesets (bug 1649032) for leakcheck failures CLOSED TREE 
Backed out changeset ef80a597db37 (bug 1649032)
Backed out changeset a8462c37bef1 (bug 1649032)
 2020-07-16 00:37:06 +03:00
Mike Conley
944cd78509 Bug 1652466 - Add an about:config preference to hide the new global sharing indicator. r=pbz 
This works by hiding the window instead of skipping opening it. This seems safer, since
there are parts of webrtcUI that expect to call functions on the window.

Differential Revision: https://phabricator.services.mozilla.com/D83348
 2020-07-15 10:40:04 +00:00
Mike Conley
974f560325 Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D82989
 2020-07-15 10:22:12 +00:00
Mike Conley
f91c7b29a6 Bug 1650243 - Don't accidentally restore the WebRTC global sharing indicator if it is minimized when changing streams. r=pbz 
window.sizeToContent causes a minimized window to be restored, so we skip calling that if the
indicator is minimized. We call it instead once the indicator is restored.

Differential Revision: https://phabricator.services.mozilla.com/D82620
 2020-07-08 09:34:39 +00:00
Mike Conley
7f6dee8800 Bug 1645466 - Prevent the WebRTC indicator from being resized manually on Linux GTK. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D80019
 2020-06-17 17:04:51 +00:00
Mike Conley
74d6aaf5f3 Bug 1645481 - Open the WebRTC indicator on the same display as the most recent browser window. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D79544
 2020-06-16 13:19:16 +00:00
Mike Conley
c8fca8ef8c Bug 1644905 - Make the display sharing container a group, and set aria-labelledby when updating the displayed label. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D79357
 2020-06-16 11:20:57 +00:00
Mike Conley
7b3f111c7f Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D79343
 2020-06-12 18:59:59 +00:00
Narcis Beleuzu
fa98afc362 Backed out 4 changesets (bug 1643503) for bc failures on browser_parsable_css.js . CLOSED TREE 
Backed out changeset a890be633ec3 (bug 1643503)
Backed out changeset 1f8dcaafb864 (bug 1643503)
Backed out changeset b28d0c018553 (bug 1643503)
Backed out changeset 1bcaedf06fb9 (bug 1643503)
 2020-06-12 21:56:16 +03:00
Mike Conley
5c002a5922 Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D79343
 2020-06-12 15:39:01 +00:00
Mike Conley
9af48e3c6d Bug 1639337 - Factor out the macOS status bar WebRTC indicator into a reusable class. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D76388
 2020-05-26 18:00:36 +00:00