Commit graph

28049 commits

Author SHA1 Message Date
Anna Yeddi
d2e8f336d6 Bug 1869389 - Provide urlbar-search-mode-indicator-close button with an accessible name. r=Jamie,fluent-reviewers,adw,bolsson
Ensure the focusable and actionable control is also labeled, so an assistive technology user would know the purpose of this control. It should not only be announced as `Close` but also provide a context by referencing the search mode title text as well, so the "History" search would be announced as `Close History mode` or just `Close History` or similar.

Also, since there were a series of test cases failing the a11y-checks because of this unlabeled control, we remove the `fail-if` notations from their test manifests to allow for the accessibility tests to run and expect to pass, as they should be.

Differential Revision: https://phabricator.services.mozilla.com/D196095
2023-12-13 02:31:15 +00:00
Sammy Khamis
dc6400347b Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D194916
2023-12-11 21:53:53 +00:00
Sandor Molnar
53a6546034 Backed out 2 changesets (bug 1856415) for causing bc failures at browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
Backed out changeset f5e458c049b9 (bug 1856415)
Backed out changeset ffd79f9e0881 (bug 1856415)
2023-12-11 20:20:33 +02:00
Harshit Sohaney
8ba3757485 Bug 1856415 - (Part 2) Testing for new dialog UI. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193844
2023-12-11 16:50:57 +00:00
Harshit Sohaney
47cfad8fb4 Bug 1856415 - (Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
Differential Revision: https://phabricator.services.mozilla.com/D189947
2023-12-11 16:50:57 +00:00
Gijs Kruitbosch
7bef26f04e Bug 1869273 - update performance triage rotation file, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D196038
2023-12-11 15:34:13 +00:00
Johannes J. Schmidt
07bffda954 Bug 1867024 - Update String for Context Menu - Username and password fields - r=credential-management-reviewers,fluent-reviewers,kpatenio,bolsson,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195257
2023-12-11 11:47:14 +00:00
Abhishek Madan
f424e10c33 Bug 1864931 - Added check to see if a webpage is internal for strip on share. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D195035
2023-12-07 20:16:05 +00:00
Emilio Cobos Álvarez
6d78c0d72c Bug 1866984 - Don't artificially constrain select menupopup height. r=mconley
The test removed no longer holds on macOS because now more items show up
and the constraining logic kicks in, but that's the behavior of all
menulists (including e.g. the massive font name menulists in
about:preferences).

Differential Revision: https://phabricator.services.mozilla.com/D195488
2023-12-07 12:51:42 +00:00
Narcis Beleuzu
b473b42e01 Backed out changeset dd6cf452d972 (bug 1775713) because the failure is fixed in 1866105 2023-12-05 22:17:20 +02:00
Florian Quèze
2a13a8372f Bug 1828735 - temporarily allow loading Sqlite.sys.mjs before first paint until the bug can be fixed, r=Gijs.
Differential Revision: https://phabricator.services.mozilla.com/D195528
2023-12-05 09:58:06 +00:00
rinwaoluwa
d70dc44cd5 Bug 1837072 -[Browser Translations Engine] Modified TranslationsParent.isRestricted method to be aware of contentType and the scheme, also created a testing file.r=nordzilla,translations-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191824
2023-12-04 20:47:33 +00:00
Eemeli Aro
94b1ab321c Bug 1814969: Migrate ContextualIdentityService strings to Fluent r=geckoview-reviewers,fluent-reviewers,mconley,owlish,flod
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.

As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.

Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.

Differential Revision: https://phabricator.services.mozilla.com/D194510
2023-12-04 13:09:15 +00:00
Paul Zuehlcke
c5d605641a Bug 1865914 - Part 3, r=Gijs,edgar
Differential Revision: https://phabricator.services.mozilla.com/D194886
2023-12-01 21:22:41 +00:00
Benjamin VanderSloot
e72674d7b6 Bug 1525943 - Add associated to the identity UI - r=pbz,Gijs,nika,flod
Differential Revision: https://phabricator.services.mozilla.com/D193806
2023-11-30 18:32:48 +00:00
Benjamin VanderSloot
be347236a3 Bug 1525943 - Update the identity section from the content principal URI rather than gBrowser.currentURI. r=Gijs,nika
Differential Revision: https://phabricator.services.mozilla.com/D193803
2023-11-30 18:32:48 +00:00
CanadaHonk
b7cb7a41f5 Bug 1830909 - Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish
Updated HTML parser to allow <hr> in <select>.

Updated internal toolkit UI for <select> dropdown to create
menuseperators for hrs.

Updated WPT expectations:
 - HTML5Lib WebKit parsing for it now passes 100%

Also includes Android support, but Fenix does not support separators
in the menus used (single/multiple) yet so they are not rendered.

Differential Revision: https://phabricator.services.mozilla.com/D189065
2023-11-29 14:15:36 +00:00
Norisz Fay
be3e190621 Backed out changeset f56003f45cc6 (bug 1830909) for causing bc failures on browser_selectpopup_colors.js CLOSED TREE 2023-11-28 22:00:22 +02:00
CanadaHonk
a1eb267c1e Bug 1830909 - Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish
Updated HTML parser to allow <hr> in <select>.

Updated internal toolkit UI for <select> dropdown to create
menuseperators for hrs.

Updated WPT expectations:
 - HTML5Lib WebKit parsing for it now passes 100%

Also includes Android support, but Fenix does not support separators
in the menus used (single/multiple) yet so they are not rendered.

Differential Revision: https://phabricator.services.mozilla.com/D189065
2023-11-28 16:01:36 +00:00
Gijs Kruitbosch
a1b0be2200 Bug 1812314 - skip buildid tests on artifact builds because they fail almost all the time and clutter up frontend artifact trypushes, r=gerard-majax
Differential Revision: https://phabricator.services.mozilla.com/D194824
2023-11-28 09:29:32 +00:00
Luca Greco
e7c75ccf37 Bug 1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D194648
2023-11-27 22:03:16 +00:00
Greg Tatum
24775179e6 Bug 1863335 - Make the simd detection synchronous; r=nordzilla,geckoview-reviewers,owlish,translations-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192701
2023-11-27 18:02:17 +00:00
Itiel
867ac130fa Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r=Gijs,twisniewski,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D194416
2023-11-27 17:13:56 +00:00
Mike Conley
5b77060db6 Bug 1865382 - Remove legacy WebRTC indicator implementation. r=pbz,fluent-reviewers,desktop-theme-reviewers,bolsson,emilio
Depends on D193933

Differential Revision: https://phabricator.services.mozilla.com/D193934
2023-11-27 16:43:32 +00:00
Mike Conley
152e38ff67 Bug 1865382 - Get rid of legacy indicator variants of WebRTC UI tests. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193932
2023-11-27 16:43:31 +00:00
Marco Bonardo
2a82c49e13 Bug 1845035 - Invalid favicon causes the page to inherit favicon from the previously visited page. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194758
2023-11-27 14:17:14 +00:00
Dão Gottwald
8d63b9e356 Bug 1866613 - Convert XULBrowserWindow.hideOverLinkImmediately to a XULBrowserWindow.setOverLink parameter. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D194687
2023-11-27 10:35:25 +00:00
Cosmin Sabou
b89da6634b Bug 1775713 - Disable browser_toolbarKeyNav.js on macosx1015 !debug for permafailing. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D194682
2023-11-25 06:36:13 +00:00
Vinny Diehl
5012344966 Bug 1815556 - Add a separator before Manage Bookmarks in the bookmarks menu r=mak
Some housekeeping in the interim while we figure out what to do with bug
985024.

Differential Revision: https://phabricator.services.mozilla.com/D194179
2023-11-25 09:24:08 +00:00
Dão Gottwald
964e3d56b2 Bug 1850993 - Clear status panel when entering DOM Fullscreen. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D194538
2023-11-25 04:21:34 +00:00
Jonathan Watt
15c1a58822 Bug 1866011 p2. Rename nsIDocShell.contentViewer. r=emilio,credential-management-reviewers,devtools-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D194370
2023-11-24 09:10:52 +00:00
Gijs Kruitbosch
3afecc0629 Bug 1866080 - remove dead docShell accesses that should be no-ops under fission/e10s, r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194388
2023-11-23 23:13:22 +00:00
Jonathan Watt
43215ef984 Bug 1865995 p6. Rename createAboutBlankContentViewer to match nsIDocumentViewer's new name. r=emilio,webdriver-reviewers,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194340
2023-11-23 21:35:21 +00:00
Anna Yeddi
bf1aed276d Bug 1864962 - Update urlbar-go-button to be a button and pass a11y_checks in Search and Address Bar. r=Jamie,adw
We provide `role=button` to the image control that can be clicked (with a mouse or with an assistive technology as speech-to-text/voice control) as an alternative way of the urlbar search query submission, where other ways are accessible (and are tested here too).

Setting an environment to `focusableRule: false` allows us to flag to the AccessibilityUtils that this specific button is purposefully not made focusable and its keyboard focusability should not be tested.

The previously failing accessibility checks should now be passing, thus we are also removing the `fail-if` notations that were added by bug 1854660 before the investigation in the meta bug 1854661.

Differential Revision: https://phabricator.services.mozilla.com/D193703
2023-11-23 02:33:10 +00:00
Tarik Eshaq
4574d82b32 Bug 1855513: Move in-browser verification to open web content. r=markh,fluent-reviewers,settings-reviewers,Gijs,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D193678
2023-11-22 17:58:18 +00:00
Cosmin Sabou
2c8b794e01 Backed out changeset c95302b3df05 (bug 1863773) for not being needed anymore. CLOSED TREE 2023-11-21 09:16:41 +02:00
Emilio Cobos Álvarez
9320fd852b Bug 1865771 - Make tabdrop tests not leak windows on shutdown. r=Gijs
Use an URL that actually loads, and wait for it, rather than loading an
url that triggers a network error (which we can't wait for) and would
leak the page instead if closed prematurely.

Differential Revision: https://phabricator.services.mozilla.com/D194239
2023-11-22 01:01:25 +00:00
Dão Gottwald
64eabb32e4 Bug 1865360 - Move status panel styling to browser-shared.css. r=emilio,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193919
2023-11-21 07:39:23 +00:00
Dão Gottwald
9e14549a2b Bug 1856415 - make copies of sanitizeDialog files for the new dialog box. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193088
2023-11-20 14:34:12 +00:00
Thomas Wisniewski
6cb66d4ccd Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-20 01:50:36 +00:00
Cristian Tuns
c76093316c Backed out 3 changesets (bug 1852340) for causing frequent mochitest failures in docshell/test/chrome/ CLOSED TREE
Backed out changeset 61875987e62c (bug 1852340)
Backed out changeset 05320d6c0441 (bug 1852340)
Backed out changeset 411374d444d1 (bug 1852340)
2023-11-19 11:46:26 -05:00
Thomas Wisniewski
4c054b0ab4 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 15:34:40 +00:00
Natalia Csoregi
42acdc9cd5 Backed out 3 changesets (bug 1852340) for causing failures due to reportBrokenSite.ftl. CLOSED TREE
Backed out changeset 86f9e01f70d6 (bug 1852340)
Backed out changeset 0049d0494b17 (bug 1852340)
Backed out changeset 7851355d5c95 (bug 1852340)
2023-11-19 10:50:25 +02:00
Thomas Wisniewski
ad730e4654 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 07:31:31 +00:00
Cosmin Sabou
22f4002673 Bug 1862716 - Disable browser_audioTabIcon.js on mac opt due to permafailures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D193965
2023-11-17 19:57:38 +00:00
Thomas Wisniewski
6716d1eb87 Bug 1852340 - Strings for new broken website reporting component; r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D193963
2023-11-17 19:48:39 +00:00
Harshit Sohaney
ecbe118f3d Bug 1863773 - Added requestLongerTimout to browser_protectionsUI_subview_shim to fix intermittent. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193701
2023-11-17 16:28:27 +00:00
Natalia Csoregi
67ce438ab8 Backed out changeset 59a1d385ed2a (bug 1852340) for causing multiple failures e.g. browser_startup_images.js. CLOSED TREE 2023-11-17 15:59:18 +02:00
Thomas Wisniewski
ca1fea74be Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-17 12:34:52 +00:00
Tim Huang
119bcc146c Bug 1863280 - Part 4: Add tests. r=pbz
This patch addes tests to verify that suspicious fingerprinter gets
properly shown on protection panel.

Differential Revision: https://phabricator.services.mozilla.com/D193456
2023-11-16 00:22:47 +00:00