Commit graph

340 commits

Author SHA1 Message Date
Chris H-C
752e716bc5 Bug 1857324 - Remove old pocket_button ping r=thecount
Depends on D191341

Differential Revision: https://phabricator.services.mozilla.com/D191238
2023-10-26 07:20:43 +00:00
Chris H-C
e070f910cb Bug 1857324 - Add new "pocket-button" ping r=thecount
Depends on D190857

Differential Revision: https://phabricator.services.mozilla.com/D190858
2023-10-26 07:20:42 +00:00
Emilio Cobos Álvarez
113b9abfc1 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
2023-10-08 23:07:36 +00:00
Emilio Cobos Álvarez
f3e1e3ff01 Bug 1857522 - Reduce max nesting depth to 3. r=Gijs
That still doesn't trigger on the code in comment 2, so that is a bit
confusing and needs investigation.

Differential Revision: https://phabricator.services.mozilla.com/D190310
2023-10-08 22:33:39 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Emilio Cobos Álvarez
45ba4a4efb Bug 1853652 - Use image-set more in pocket. r=desktop-theme-reviewers,dao
Depends on D188453

Differential Revision: https://phabricator.services.mozilla.com/D188454
2023-09-18 12:57:26 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
scottdowne
a384a1b068 Bug 1849880 - Save to Pocket fixing eslint dependencies warning around useEffect. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D186975
2023-08-31 00:59:04 +00:00
Gavin Suntop
1beed48147 Bug 1845563 - Clean up client side Pocket API r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D184610
2023-07-31 16:47:09 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Gavin Suntop
69105a8a7a Bug 1838478 - Remove topics from STP r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D180966
2023-07-05 16:32:36 +00:00
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Gavin Suntop
3d25d65033 Bug 1837224 - Remove suggested articles from STP r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D180235
2023-06-13 18:04:46 +00:00
Gijs Kruitbosch
b4130b15da Bug 1832765 - start linting scss across the tree in our standard config, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D178532
2023-05-30 22:41:22 +00:00
Katherine Patenio
9dd38d03ab Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D177423
2023-05-24 15:52:34 +00:00
Mark Banner
2a53076d43 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
anwar
1dbd9bffb3 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu
Differential Revision: https://phabricator.services.mozilla.com/D176459
2023-05-02 16:13:24 +00:00
Bilal
5379509f30 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175700
2023-04-19 19:18:57 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Mark Banner
4ff8f9cf26 Bug 1823763 - Convert consumers of toolkit/components/reader/ to import ES modules directly. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173184
2023-03-23 12:11:44 +00:00
Francesco Lodolo (:flod)
962126e608 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Gavin Suntop
66a13a59ee Bug 1814724 - Use BFF For Recent Saves r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D170686
2023-03-15 00:10:05 +00:00
Emilio Cobos Álvarez
566f0c7a63 Bug 1821657 - Remove BrowserUIUtils.setToolbarButtonHeightProperty and related code. r=Gijs,desktop-theme-reviewers,dao
I don't see any visible issue on the reload / stop buttons without this.

Differential Revision: https://phabricator.services.mozilla.com/D172238
2023-03-13 11:56:55 +00:00
Chris H-C
928c69dab3 Bug 1814922 - Instrument PingCentre successes/failures by namespace r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D168842
2023-02-03 21:48:16 +00:00
Gavin Suntop
a9aee9ebad Bug 1813632 - Design tweaks for tagging r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D168708
2023-02-02 19:20:40 +00:00
Gijs Kruitbosch
c906d6f529 Bug 1795255 - manual fixes for tests that break after applying this lint rule, r=Standard8,necko-reviewers,extension-reviewers,credential-management-reviewers,sgalich,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D167802
2023-01-31 11:48:41 +00:00
Gavin Suntop
b31df24d19 Bug 1812097 - Re-enable save button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D167694
2023-01-24 17:55:05 +00:00
Gavin Suntop
0156ac232e Bug 1781836 - Adding recent tags r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D167189
2023-01-20 20:55:30 +00:00
Mark Banner
a94fe03b9d Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Gijs Kruitbosch
9946c4fcbb Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D167153
2023-01-19 20:16:42 +00:00
Emilio Cobos Álvarez
4f1f5e7314 Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao
Move most the event handling stuff to the DOM. I've left nsMenuBarFrame
for now, but I will be removing that in the future.

The basic set up is:

  * nsMenuParent becomes XULMenuParentElement (menubar or popup, manages
    the current active menu item)

  * nsMenuFrame -> XULButtonElements that return true for IsMenu().
    Can't use XULMenuElement because of <button type=menu>, which
    behaves like a, well, menu.

This makes the a11y events for menus (DOMMenuItem{Active,Inactive}) make
sense (before that we were firing duplicate Inactive events etc, and the
event order was rather suspicious).

Differential Revision: https://phabricator.services.mozilla.com/D164210
2023-01-04 19:01:13 +00:00
Csoregi Natalia
9807a6e6e8 Backed out changeset f11c529b2407 (bug 1805414) for failures on test_submenuClose.xhtml and nsMenuPopupFrame.cpp. CLOSED TREE 2023-01-04 01:48:30 +02:00
Emilio Cobos Álvarez
3d82727505 Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao
Move most the event handling stuff to the DOM. I've left nsMenuBarFrame
for now, but I will be removing that in the future.

The basic set up is:

  * nsMenuParent becomes XULMenuParentElement (menubar or popup, manages
    the current active menu item)

  * nsMenuFrame -> XULButtonElements that return true for IsMenu().
    Can't use XULMenuElement because of <button type=menu>, which
    behaves like a, well, menu.

This makes the a11y events for menus (DOMMenuItem{Active,Inactive}) make
sense (before that we were firing duplicate Inactive events etc, and the
event order was rather suspicious).

Differential Revision: https://phabricator.services.mozilla.com/D164210
2023-01-03 22:06:01 +00:00
Mark Banner
8730eec697 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D165002
2022-12-23 12:37:07 +00:00
scott
7c3973c06d Bug 1804533 - Save to Pocket and Pocket newtab pass rollout metadata to Pocket links r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D164125
2022-12-08 17:39:36 +00:00
scott
9195b53496 Bug 1803657 - Save to Pocket sort tag picket datalist by character input. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D163637
2022-12-06 18:12:15 +00:00
Mark Banner
c1837954be Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D161914
2022-11-17 12:00:30 +00:00
Zach Harris
9aa41d477e Bug 1788771 - Convert AboutPockets from JSM to ESM. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157033
2022-11-03 05:46:41 +00:00
scott
5de92f1759 Bug 1797595 - Pocket updating some copy in Pocket panels. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D160421
2022-10-27 21:52:56 +00:00
Mike Conley
850682a9ad Bug 1796275 - about:pocket pages should load in the privileged about content process. r=thecount,nika
Differential Revision: https://phabricator.services.mozilla.com/D159786
2022-10-20 16:17:38 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Eemeli Aro
f8f531d202 Bug 1760033 - Convert aboutReader.html to Fluent. r=Gijs,fluent-reviewers,geckoview-reviewers,flod,m_kato
The data included in the `Reader:AddButton` message used by SaveToPocket.jsm is slightly modified, as it now includes a localization identifier rather than a preformatted label.

Differential Revision: https://phabricator.services.mozilla.com/D158575
2022-10-13 16:28:31 +00:00