Commit graph

3361 commits

Author SHA1 Message Date
William Durand
ff7944d1e4 Bug 1789407 - Always anchor defaultsearch popup to the urlbar. r=rpl
Depends on D156960

Differential Revision: https://phabricator.services.mozilla.com/D156952
2022-09-09 18:50:32 +00:00
Alexandre Poirot
393e94ddf0 Bug 1789595 - [devtools] Convert devtools/server JSM to ES Modules. r=nchevobbe
This is the result of:
$ ./mach esmify devtools/server/

Differential Revision: https://phabricator.services.mozilla.com/D156826
2022-09-09 10:13:15 +00:00
Mark Banner
c9b0aa74c1 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 14:40:07 +00:00
Norisz Fay
1bb0960ae2 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
2022-09-08 17:14:00 +03:00
Mark Banner
5dca28c108 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 12:43:32 +00:00
Mathew Hodson
1f4593f091 Bug 1762444 - Replace setUp tasks with add_setup in browser mochitests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150330
2022-08-29 08:54:54 +00:00
Shane Caraveo
a247d704af Bug 1786587 Fix browser action panel when toolbar is overflowed r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D155527
2022-08-26 15:31:01 +00:00
Emilio Cobos Álvarez
02af3a8de9 Bug 1780876 - Try to deal with DOM/widget state mismatch on macOS. r=robwu
The patch that that regressed this started using the widget state rather
than the DOM state to return full-screen. It seems on macOS they
sometimes can get out of sync, in the failure from comment 0 the window
is really full-screen.

We seemed to account for some of this in:

  https://searchfox.org/mozilla-central/rev/00e504083572d47f2199168f0f79c75c0ddaefb3/browser/components/extensions/test/browser/browser_ext_windows_create.js#31-36

Make sure we exit full-screen as appropriate if DOM thinks we're
fullscreen. This passes verify and at worst it should be harmless.

Differential Revision: https://phabricator.services.mozilla.com/D155353
2022-08-23 22:13:19 +00:00
Luca Greco
a929203934 Bug 1760608 - Restrict actions API setPopup urls allowed for MV3 extensions. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D154547
2022-08-23 10:35:57 +00:00
Shane Caraveo
41e03a66c8 Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154179
2022-08-22 18:55:59 +00:00
Dão Gottwald
aed8fc030d Bug 1786011 - Show the "List all tabs" button unconditionally. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D155076
2022-08-22 14:48:49 +00:00
William Durand
936f3b219a Bug 1785988 - Display message when hovering/focusing the menu button in the unified extensions panel. r=rpl,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D155055
2022-08-19 18:52:19 +00:00
William Durand
e7b425384a Bug 1785204 - Separate primary and secondary buttons in the unified extensions panel. r=Itiel,Jamie,rpl,desktop-theme-reviewers
Depends on D154282

Differential Revision: https://phabricator.services.mozilla.com/D154873
2022-08-19 13:57:12 +00:00
William Durand
cb31c16d87 Bug 1784292 - Anchor extension popups to the unified extensions button. r=mconley,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D154408
2022-08-19 06:25:13 +00:00
William Durand
36de950878 Bug 1784118 - Activate scripts when clicking an extension item in the unified extensions panel. r=Jamie,rpl
Differential Revision: https://phabricator.services.mozilla.com/D154282
2022-08-18 12:22:43 +00:00
Rob Wu
a4f8ce604c Bug 1782816 - Introduce test.assertDeepEq r=rpl,webidl,smaug
Differential Revision: https://phabricator.services.mozilla.com/D153531
2022-08-16 20:06:37 +00:00
Mark Banner
f0ab56decf Bug 1784699 - Ignore ESLint no-undef warnings in xpcshell-tests where functions are processed in other scopes. r=arai,necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D154600
2022-08-15 16:50:30 +00:00
William Durand
45c7c1572f Bug 1783842 - Remove toolbaritem around the unified extensions button. r=rpl
This isn't needed anymore so that should make it more obvious that we
have a button only, outside the customization area because we don't want
it to be removed at the moment. That's also why the `overflows`
attribute has been added (the button should not go to the overflow on
window resize).

Differential Revision: https://phabricator.services.mozilla.com/D154089
2022-08-09 16:00:23 +00:00
William Durand
de6baba1b8 Bug 1782766 - Constraint the max height of the list of extensions in the unified extensions panel. r=Itiel,desktop-theme-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D153486
2022-08-06 13:55:22 +00:00
William Durand
c7d049842d Bug 1780746 - Add new Telemetry objects for manage/remove/report events in unified extensions context menu. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D153460
2022-08-05 13:58:15 +00:00
Shane Caraveo
3978bd8144 Bug 1783078 require web_accessible_resources for any extension loads from a content script r=robwu,ckerschb
Enforce requiring web accessible resources in MV3 and use a pref to turn on later for MV2.

Differential Revision: https://phabricator.services.mozilla.com/D153677
2022-08-05 04:36:30 +00:00
Luca Greco
2d3812606b Bug 1781512 - Fix browser_ext_getViews.js test_getViews_excludes_blocked_parsing_documents intermittent. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D153094
2022-08-04 15:36:30 +00:00
Luca Greco
0e66fcdb3a Bug 1782304 - Tweak test_report_extension to prevent browser_unified_extensions_context_menu.js intermittent. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D153742
2022-08-04 15:28:08 +00:00
William Durand
5b42f788fb Bug 1782138 - Add requestLongerTimeout to browser_unified_extensions_context_menu.js. r=rpl
This seems to fix the issue on MacOS.

Differential Revision: https://phabricator.services.mozilla.com/D153731
2022-08-04 10:05:41 +00:00
Dale Harvey
73aa521160 Bug 1778132 - Rename quickactions pref and fix tests. r=Standard8,extension-reviewers,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D153281
2022-08-03 00:26:29 +00:00
Shane Caraveo
d08731448a Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl,geckoview-reviewers,calu
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-08-02 17:08:58 +00:00
William Durand
72e2060739 Bug 1782456 - Move unified extensions context menu to main popupset. r=rpl,Gijs
I noticed some missing context menu style when loading the context menu
from our own viewcache, which explains the difference between primary
and secondary button click. Not sure ecavtly what was missing as the
styles are all over the place.

The menu item actually works, the actions are called and for
checkbox-like menu items, the `checked` attribute is correctly set in
the "HTML". Also it looked like sub-menus weren't affected (e.g. Tree
Style Tab didn't have any issue).

While investigating, I also noticed that most (if not all) `menupopup`
elements are declared in the main popupset, so I tried to move the
unified extensions context menu to this main popupset and lazy-load the
l10n strings (similar to the toolbar context menu [1]).

That fixed the bug.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1609556

Differential Revision: https://phabricator.services.mozilla.com/D153330
2022-08-02 13:24:28 +00:00
Joel Maher
bf4b875752 Bug 1781782 - Run frequent xpcshell parallel failing tests sequential by default. r=ahal,necko-reviewers,extension-reviewers,application-update-reviewers,bytesized,rpl,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D153081
2022-07-30 01:33:28 +00:00
William Durand
183b3ef354 Bug 1777483 - Part 4 - Add extension actions to the unified extensions context menu. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D153096
2022-07-29 20:32:16 +00:00
William Durand
1597f76d0f Bug 1780654 - Reuse the same window whenever possible in browser_unified_extensions.js. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D153163
2022-07-29 19:54:08 +00:00
Barret Rennie
4ac8dcb4d4 Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D148967
2022-07-28 20:21:55 +00:00
William Durand
5757ca23ad Bug 1777483 - Part 3 - Open context menu when clicking the menu button. r=mixedpuppy
This patch allows to open the context menu on (primary) button click,
and that also works with keyboard navigation.

Depends on D152755

Differential Revision: https://phabricator.services.mozilla.com/D152853
2022-07-28 20:13:49 +00:00
William Durand
c4822c2fc2 Bug 1777483 - Part 2 - Add origin controls to the unified extensions context menu. r=rpl
Depends on D152665

Differential Revision: https://phabricator.services.mozilla.com/D152755
2022-07-28 20:13:49 +00:00
William Durand
c1bebd5d14 Bug 1777483 - Part 1 - Add a new context menu for extensions in the unified extensions panel. r=mixedpuppy,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152665
2022-07-28 20:13:48 +00:00
William Durand
e10c07e3fe Bug 1780771 - Do not allow panel to be shown in customization mode. r=rpl
Depends on D152401

Differential Revision: https://phabricator.services.mozilla.com/D152508
2022-07-27 20:12:38 +00:00
William Durand
ca4e603ef2 Bug 1777484 - Allow to close unified extensions panel programmatically. r=rpl,Gijs
I also tried to defer the loading of the panel when it is about to be
open for the first time.

Differential Revision: https://phabricator.services.mozilla.com/D152401
2022-07-27 20:12:38 +00:00
Butkovits Atila
ae6f4c94fc Backed out 3 changesets (bug 1711168, bug 1773115) for causing failures at test_ext_web_accessible_resources.html. CLOSED TREE
Backed out changeset 703c909eb009 (bug 1773115)
Backed out changeset 902385a7ce60 (bug 1711168)
Backed out changeset 3d061ce03de7 (bug 1711168)
2022-07-27 00:13:26 +03:00
Shane Caraveo
eff848ce19 Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
2022-07-26 19:39:14 +00:00
Mark Banner
8a275d4d92 Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00
Emilio Cobos Álvarez
6eac3d4854 Bug 1780680 - More cleanly return "normal" state for closed windows. r=mixedpuppy
It bit me in the dependent bug because bug, see the comment in:

  https://hg.mozilla.org/integration/autoland/rev/8bbec265ab8c

Differential Revision: https://phabricator.services.mozilla.com/D152480
2022-07-26 12:02:46 +00:00
William Durand
ac9a38c8e9 Bug 1780782 - Open about:addons when clicking the unified extensions button and there is no visible extension. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D152623
2022-07-25 19:39:15 +00:00
smolnar
dc4f2d6a41 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
Mark Banner
539b5dac0d Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-25 12:46:48 +00:00
Emilio Cobos Álvarez
71ff4e1231 Bug 1780372 - Fix a failure in browser_ext_sessions_getRecentlyClosed.js.
MANUAL PUSH: Trivial fixup CLOSED TREE
2022-07-22 02:18:43 +02:00
Emilio Cobos Álvarez
988ced1559 Bug 1780372 - Make extension APIs deal with async window state changes. r=mixedpuppy
Before my previous patch, the widget code lied, and always returned the
requested window state before it had actually happened. Instead, teach
the extension code to wait if necessary for the window state to be
effective.

Differential Revision: https://phabricator.services.mozilla.com/D152394
2022-07-21 23:04:08 +00:00
Norisz Fay
bc693a67ca Backed out changeset c6db198ff02c (bug 1772943) for causing mochitest failures on browser_doorhanger_installs.js CLOSED TREE 2022-07-21 13:10:16 +03:00
Barret Rennie
ccc656a53b Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D148967
2022-07-21 04:44:40 +00:00
Mark Banner
4bfafd41fa Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
102b779608 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
William Durand
c00085558a Bug 1779381 - Fully enable browser_toolbar_prefers_color_scheme.js. r=mixedpuppy
I was super conservative in Bug 1779380 because, although I couldn't
reproduce actual failures locally, one of the leakcheck reports was
consistently failing.

I tested a few other things and it looks like some tests on MacOS often
have leaks [1]. I get leakcheck errors with many other test files so I
doubt it is this one specific test file.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1541628#c4

Differential Revision: https://phabricator.services.mozilla.com/D151914
2022-07-20 19:00:16 +00:00