Commit graph

51 commits

Author SHA1 Message Date
Kagami Sascha Rosylight
114b7eac32 Bug 1816075 - Add ReadableStream::SetUpByteNative r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D169439
2023-02-13 13:36:34 +00:00
Kagami Sascha Rosylight
857db85b03 Bug 1809408 - Part 3: Move TransformStream internal algorithms to internal namespace r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D167929
2023-02-07 11:56:06 +00:00
Marian-Vasile Laza
c81ee207b9 Backed out 3 changesets (bug 1809408) for bustages on ReadableStreamBYOBRequest.cpp. CLOSED TREE
Backed out changeset 7b9ab840dcf1 (bug 1809408)
Backed out changeset 38da95750e3f (bug 1809408)
Backed out changeset 7bc810a8e68a (bug 1809408)
2023-02-06 17:23:47 +02:00
Kagami Sascha Rosylight
522eb49150 Bug 1809408 - Part 3: Move TransformStream internal algorithms to internal namespace r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D167929
2023-02-06 13:12:54 +00:00
Kagami Sascha Rosylight
98c86fef45 Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 19:21:35 +00:00
Kagami Sascha Rosylight
ea0cb48ccd Bug 1811538 - Part 2: Use Promise::CreateInfallible in dom/streams r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D167697
2023-01-31 19:21:35 +00:00
Iulian Moraru
a8e5bce81b Backed out 3 changesets (bug 1811538) for causing build bustages on Promise.cpp. CLOSED TREE
Backed out changeset 0a665be7896a (bug 1811538)
Backed out changeset b949053bae31 (bug 1811538)
Backed out changeset 57d4dbe88611 (bug 1811538)
2023-01-31 19:00:59 +02:00
Kagami Sascha Rosylight
19a91ef6e4 Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 15:49:08 +00:00
Kagami Sascha Rosylight
2c64928874 Bug 1811538 - Part 2: Use Promise::CreateInfallible in dom/streams r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D167697
2023-01-31 15:49:07 +00:00
Kagami Sascha Rosylight
f717bd5938 Bug 1810152 - Remove internal-only stream headers from moz.build r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D166794
2023-01-13 17:05:18 +00:00
Kagami Sascha Rosylight
27249f0e93 Bug 1803371 - Part 4: Add UnderlyingSourceAlgorithmsBase::ReleaseObjects r=smaug
The existing ErrorCallback is now renamed as ReleaseObjects and is called for any type of frozen streams caused by close/cancel/error.

BodyStream::ErrorPropagation used to call ErrorCallback via calling ReadableStreamError. Now ReadableStreamError does not call ErrorCallback anymore, so ErrorPropagation now has a bit more cleanup steps.

The cleanup steps in BodyStream::CancelCallback is replaced by CloseInputAndReleaseObjects which will be called by new UnderlyingSourceAlgorithmsBase::ReleaseObjects.

Differential Revision: https://phabricator.services.mozilla.com/D163528
2022-12-06 18:37:29 +00:00
Jan Varga
72de9eab21 Bug 1799392 - Fix NS_INTERFACE_MAP_END_INHERITING usage; r=saschanaz,dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D161414
2022-11-08 00:32:38 +00:00
Kagami Sascha Rosylight
237dffb194 Bug 1486949 - Part 4: Implement TransformStream construction for GenericTransformStream r=smaug
Per the Streams spec, other specs that want to implement custom TransformStream should use [GenericTransformStream](https://streams.spec.whatwg.org/#other-specs-ts-wrapping) mixin and store a [new TransformStream](https://streams.spec.whatwg.org/#transformstream-set-up) in a slot. This implements the latter part.

Differential Revision: https://phabricator.services.mozilla.com/D153975
2022-08-12 15:59:04 +00:00
Kagami Sascha Rosylight
bb449a5649 Bug 1486949 - Part 3: Refactor TransformerAlgorithms to allow subclassing r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D153974
2022-08-12 15:59:04 +00:00
Kagami Sascha Rosylight
034516b498 Bug 1486949 - Part 2: Convert TransformStreamSetBackpressure to a method r=smaug
This way SetBackpressureChangePromise can be removed which is only exposed for that function.

Differential Revision: https://phabricator.services.mozilla.com/D153973
2022-08-12 15:59:03 +00:00
Kagami Sascha Rosylight
cb2f087593 Bug 1486949 - Part 1: Remove redundant GetReadable/Writable r=smaug
It was a part of the initial skeleton code where the getters threw NOT_IMPLEMENTED. The methods are wrong anyway since `.forget()` will unset the fields.

Differential Revision: https://phabricator.services.mozilla.com/D153972
2022-08-12 15:59:03 +00:00
Csoregi Natalia
3f2ae76b30 Backed out 6 changesets (bug 1486949) for causing hazard bustage on TextDecoderStream.cpp. CLOSED TREE
Backed out changeset e3dc48b94eef (bug 1486949)
Backed out changeset 57edeeebac29 (bug 1486949)
Backed out changeset f86c3b21e21c (bug 1486949)
Backed out changeset 862135f6c27f (bug 1486949)
Backed out changeset 8dd9f5b9e042 (bug 1486949)
Backed out changeset 7cb29e4feb27 (bug 1486949)
2022-08-12 06:36:41 +03:00
Kagami Sascha Rosylight
1efd07698e Bug 1486949 - Part 4: Implement TransformStream construction for GenericTransformStream r=smaug
Per the Streams spec, other specs that want to implement custom TransformStream should use [GenericTransformStream](https://streams.spec.whatwg.org/#other-specs-ts-wrapping) mixin and store a [new TransformStream](https://streams.spec.whatwg.org/#transformstream-set-up) in a slot. This implements the latter part.

Differential Revision: https://phabricator.services.mozilla.com/D153975
2022-08-11 21:16:17 +00:00
Kagami Sascha Rosylight
9f255d1c04 Bug 1486949 - Part 3: Refactor TransformerAlgorithms to allow subclassing r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D153974
2022-08-11 21:16:17 +00:00
Kagami Sascha Rosylight
f8a781d3fd Bug 1486949 - Part 2: Convert TransformStreamSetBackpressure to a method r=smaug
This way SetBackpressureChangePromise can be removed which is only exposed for that function.

Differential Revision: https://phabricator.services.mozilla.com/D153973
2022-08-11 21:16:17 +00:00
Kagami Sascha Rosylight
7403b48b51 Bug 1486949 - Part 1: Remove redundant GetReadable/Writable r=smaug
It was a part of the initial skeleton code where the getters threw NOT_IMPLEMENTED. The methods are wrong anyway since `.forget()` will unset the fields.

Differential Revision: https://phabricator.services.mozilla.com/D153972
2022-08-11 21:16:16 +00:00
Noemi Erli
a73776af50 Backed out 6 changesets (bug 1486949) for causing failures in test_serviceworker_interfaces.html CLOSED TREE
Backed out changeset 73cb8cf7a3f0 (bug 1486949)
Backed out changeset 91adc5cca2e6 (bug 1486949)
Backed out changeset 89137ad4e5c6 (bug 1486949)
Backed out changeset 74ca8f06eb06 (bug 1486949)
Backed out changeset 00f43009d419 (bug 1486949)
Backed out changeset 9c38a30397bd (bug 1486949)
2022-08-11 18:00:55 +03:00
Kagami Sascha Rosylight
ca191bd76e Bug 1486949 - Part 4: Implement TransformStream construction for GenericTransformStream r=smaug
Per the Streams spec, other specs that want to implement custom TransformStream should use [GenericTransformStream](https://streams.spec.whatwg.org/#other-specs-ts-wrapping) mixin and store a [new TransformStream](https://streams.spec.whatwg.org/#transformstream-set-up) in a slot. This implements the latter part.

Differential Revision: https://phabricator.services.mozilla.com/D153975
2022-08-11 13:54:15 +00:00
Kagami Sascha Rosylight
d785180b3c Bug 1486949 - Part 3: Refactor TransformerAlgorithms to allow subclassing r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D153974
2022-08-11 13:54:15 +00:00
Kagami Sascha Rosylight
c1e74f646e Bug 1486949 - Part 2: Convert TransformStreamSetBackpressure to a method r=smaug
This way SetBackpressureChangePromise can be removed which is only exposed for that function.

Differential Revision: https://phabricator.services.mozilla.com/D153973
2022-08-11 13:54:14 +00:00
Kagami Sascha Rosylight
c437b61b93 Bug 1486949 - Part 1: Remove redundant GetReadable/Writable r=smaug
It was a part of the initial skeleton code where the getters threw NOT_IMPLEMENTED. The methods are wrong anyway since `.forget()` will unset the fields.

Differential Revision: https://phabricator.services.mozilla.com/D153972
2022-08-11 13:54:14 +00:00
Kagami Sascha Rosylight
2b7f799d55 Bug 1659025 - Implement [Transferable] for ReadableStream r=smaug,sfink
Differential Revision: https://phabricator.services.mozilla.com/D139525
2022-05-19 11:54:31 +00:00
criss
53019d89e5 Backed out 2 changesets (bug 1659025) for causing wpt failures. CLOSED TREE
Backed out changeset 9442f1d617ea (bug 1659025)
Backed out changeset a7f050ab968d (bug 1659025)
2022-05-18 16:30:39 +03:00
Kagami Sascha Rosylight
e8a0067bcc Bug 1659025 - Implement [Transferable] for ReadableStream r=smaug,sfink
Differential Revision: https://phabricator.services.mozilla.com/D139525
2022-05-18 12:01:01 +00:00
Cristian Tuns
8bf701b255 Backed out 2 changesets (bug 1659025) for causing build bustages on Unified_cpp_netwerk_ipc0.obj CLOSED TREE
Backed out changeset cc94267daae1 (bug 1659025)
Backed out changeset 180af79082fb (bug 1659025)
2022-05-18 05:41:18 -04:00
Kagami Sascha Rosylight
f10d7d3cc7 Bug 1659025 - Implement [Transferable] for ReadableStream r=smaug,sfink
Differential Revision: https://phabricator.services.mozilla.com/D139525
2022-05-18 09:08:04 +00:00
Kagami Sascha Rosylight
5bf1db4f71 Bug 1769290 - Part 1: Apply mozilla-js-handle-rooted-typedef against dom/streams r=smaug
Changes done by `./mach static-analysis check --checks="-*,mozilla-js-handle-rooted-typedef" --fix --header-filter=dom dom/streams; ./mach clang-format --outgoing`.

Differential Revision: https://phabricator.services.mozilla.com/D146329
2022-05-18 08:43:08 +00:00
Kagami Sascha Rosylight
0dd4d4b972 Bug 1763142 - Implement transform sink/source algorithms r=mgaudet,emilio
Differential Revision: https://phabricator.services.mozilla.com/D142228
2022-04-06 18:01:28 +00:00
Iulian Moraru
a5c24d7dff Backed out changeset 2a6a62b9c73d (bug 1763142) for causing build bustages on TransformStream.cpp. CLOSED TREE 2022-04-06 19:36:40 +03:00
Kagami Sascha Rosylight
fc00d06eab Bug 1763142 - Implement transform sink/source algorithms r=mgaudet,emilio
Differential Revision: https://phabricator.services.mozilla.com/D142228
2022-04-06 13:09:54 +00:00
Kagami Sascha Rosylight
def205fdcd Bug 1734886 - Part 8: Implement TransformStreamDefaultController methods r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D142013
2022-03-30 06:31:58 +00:00
Kagami Sascha Rosylight
c87ce3dd2f Bug 1734886 - Part 5: Implement InitializeTransformStream r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D140377
2022-03-23 23:30:47 +00:00
Butkovits Atila
014927888b Backed out changeset 544d6892423d (bug 1734886) for causing failures attransform-stream.html. CLOSED TREE 2022-03-24 00:29:41 +02:00
Kagami Sascha Rosylight
17e9dc73de Bug 1734886 - Part 5: Implement InitializeTransformStream r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D140377
2022-03-23 20:58:49 +00:00
Butkovits Atila
3a16749123 Backed out changeset 32e1a02fdd2c (bug 1734886) for causing bustages. CLOSED TREE 2022-03-23 21:39:33 +02:00
Kagami Sascha Rosylight
08436968fa Bug 1734886 - Part 5: Implement InitializeTransformStream r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D140377
2022-03-23 19:05:09 +00:00
Kagami Sascha Rosylight
6f1148ff06 Bug 1734886 - Part 2: Initialize [[controller]] slot of TransformStream r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D138826
2022-02-17 01:40:08 +00:00
Kagami Sascha Rosylight
45d9dcc52b Bug 1734886 - Part 1: Throw when readably/writableType fields exist r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D138825
2022-02-17 01:40:08 +00:00
Butkovits Atila
03a020af3e Backed out 2 changesets (bug 1734886) for causing Hazard bustages at TransformStream.cpp. CLOSED TREE
Backed out changeset 874b3fe4de86 (bug 1734886)
Backed out changeset 9d43d0e3ba23 (bug 1734886)
2022-02-17 01:18:31 +02:00
Kagami Sascha Rosylight
a14deb0e24 Bug 1734886 - Part 2: Initialize [[controller]] slot of TransformStream r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D138826
2022-02-16 20:40:03 +00:00
Kagami Sascha Rosylight
e717ac6d07 Bug 1734886 - Part 1: Throw when readably/writableType fields exist r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D138825
2022-02-16 20:40:03 +00:00
Kagami Sascha Rosylight
a7a6e060cf Bug 1755335 - Add skeleton code for TransformStream{,DefaultController} r=mgaudet,emilio
Differential Revision: https://phabricator.services.mozilla.com/D138672
2022-02-15 01:43:00 +00:00
Noemi Erli
dde4c6d4c6 Backed out changeset c5467bc3fb5a (bug 1755335) for causing bustage in WritableStreamDefaultWriter.cpp CLOSED TREE 2022-02-15 02:28:30 +02:00
Kagami Sascha Rosylight
48750a127c Bug 1755335 - Add skeleton code for TransformStream{,DefaultController} r=mgaudet,emilio
Differential Revision: https://phabricator.services.mozilla.com/D138672
2022-02-14 23:35:53 +00:00
Cristian Tuns
de7fa4b360 Backed out changeset b2749184f16a (bug 1755335) for causing build bustages on TransformStream.webidl CLOSED TREE 2022-02-14 17:43:19 -05:00