Commit graph

187 commits

Author SHA1 Message Date
Chris H-C
0fcf073aa9 Bug 1868988 - Remove PingCentre instrumentation from Activity Stream r=nanj,thecount,perry.mcmanis
Had to add a few Glean tests to get coverage numbers back up.

Differential Revision: https://phabricator.services.mozilla.com/D196189
2023-12-18 16:56:22 +00:00
Mike Conley
b004285019 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-14 18:46:57 +00:00
Butkovits Atila
8582db0ea5 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
ff511df662 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-13 23:29:49 +00:00
Chris H-C
6bf60bf55d Bug 1868580 - Remove PingCentre from Contextual Services r=nanj,perry.mcmanis
As of 11amPT December 7, Contextual Services is now looking exclusively at
Glean-sent data for Firefox versions 116+. (See DSRE-1489)

Differential Revision: https://phabricator.services.mozilla.com/D195910
2023-12-11 19:21:37 +00:00
Mike Conley
15d11761c7 Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya,perftest-reviewers,sparky
Depends on D193855

Differential Revision: https://phabricator.services.mozilla.com/D193856
2023-12-06 16:15:16 +00:00
Mike Conley
674a57e18e Bug 1860668 - Convert ActivityStreamPrefs from a JSM to an ESM. r=thecount
Depends on D193489

Differential Revision: https://phabricator.services.mozilla.com/D193490
2023-11-27 16:42:20 +00:00
Sylvestre Ledru
82db67a6be Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow
Differential Revision: https://phabricator.services.mozilla.com/D191480
2023-10-19 20:52:10 +00:00
scottdowne
5f87d062a8 Bug 1858038 - Pocket newtab decouple Pocket sponsored content system pref from Discovery Stream JSON config. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D190521
2023-10-10 14:54:10 +00:00
scottdowne
952b9e3243 Bug 1847786 - Pocket newtab remove old remote layout switching code. r=gvn,mconley
Differential Revision: https://phabricator.services.mozilla.com/D185688
2023-10-03 18:53:02 +00:00
Mark Banner
bed6c05a75 Bug 1774888 - Remove XPCOMUtils.defineLazyModuleGetter. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189722
2023-10-02 09:48:01 +00:00
Mathew Hodson
aaaa5036bd Bug 1727387 - Fix links in New Tab documentation. r=emilio
Use better link to the browser chrome mochitests page.

Differential Revision: https://phabricator.services.mozilla.com/D186519
2023-08-23 15:27:07 +00:00
Iulian Moraru
3260deb1ae Backed out changeset 11d0cb525f1d (bug 1835212) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2023-06-13 00:34:23 +03:00
hanna alemu
80813356d3 Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D179839
2023-06-12 20:24:08 +00:00
Cristina Horotan
d8c5478bd7 Backed out changeset a79a0225de72 (bug 1835212) for causing bc failures at browser_feature_callout.js on a CLOSED TREE 2023-06-09 01:31:13 +03:00
hanna alemu
91fee18b36 Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D179839
2023-06-08 19:33:29 +00:00
Mathieu Leplatre
8d0b1b7d56 Bug 1832042 - Update URLs of new Remote Settings servers r=gbeckley,search-reviewers,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177471
2023-05-11 13:35:59 +00:00
Shane Hughes
9dc143a25a Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
2023-05-09 15:37:15 +00:00
Shane Hughes
b7ca905921 Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
2023-05-08 18:23:47 +00:00
scottdowne
42b6e74c81 Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174710
2023-04-25 16:49:25 +00:00
Mathieu Leplatre
4dffc91e74 Bug 1826289 - Update URLs of Remote Settings DEV server r=gbeckley
Differential Revision: https://phabricator.services.mozilla.com/D174581
2023-04-11 14:47:32 +00:00
Shane Hughes
5272e82bf7 Bug 1805177 - Make Escape key dismiss Feature Callouts. r=mviar
Set up event handlers so that pressing Escape dismisses Feature
Callouts. If an interactive element outside of the Callout is focused,
then the Escape key will not be consumed. Also consolidate all the event
handlers into a single switch statement so we won't need to continue
adding more callback bindings (they were only necessary before
encapsulation was implemented). Also change the names of a couple
formerly pseudo-private methods that we're now referencing externally.

Differential Revision: https://phabricator.services.mozilla.com/D168307
2023-02-01 17:52:12 +00:00
ogiorgis
5fa906d358 Bug 1749473 - fix all pygments warnings r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D167915
2023-01-27 13:41:10 +00:00
Emily McMinn
c196eb43ea Bug 1795184 - Update syntax highlighting for newtab docs r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D165316
2023-01-04 19:23:32 +00:00
Sylvestre Ledru
317aabf25e Bug 1750450 - Fix 'Non-consecutive header level increase' DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165655
2022-12-31 16:33:30 +00:00
Shane Hughes
af15930e73 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D163531
2022-12-01 16:42:18 +00:00
Shane Hughes
65a03000e9 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Shane Hughes
5b20ae82fd Bug 1787532 - Let Feature Callouts perform actions on page events. r=mviar
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
  {
    params: {
      type: string,
      selectors: string,
      options?: {
        capture?: boolean,
        once?: boolean,
        preventDefault?: boolean,
      },
    },
    action: {
      type?: string,
      data?: object,
      dismiss?: boolean,
      etc...
    },
  },
]
```

Differential Revision: https://phabricator.services.mozilla.com/D158899
2022-10-18 14:29:27 +00:00
Mark Banner
69a9e3e717 Bug 1792341 - Migrate most of the rest of toolkit/modules/ to be system ES modules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158451
2022-10-18 11:21:25 +00:00
Sylvestre Ledru
bab32ef66a Bug 1789204 - Import "avoiding intermittent oranges" from mdn r=marco DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156408
2022-09-05 12:49:51 +00:00
Sylvestre Ledru
56ca27d630 Bug 1785928 - doc: fix some 404 in v2-system-addon/mochitests.html DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156297
2022-09-03 16:42:22 +00:00
Sylvestre Ledru
128c74caac Bug 1785451 - Ride along: Fix some typos r=linter-reviewers,fluent-reviewers,geckoview-reviewers,extension-reviewers,keeler,rpl,calu,ahal,flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D154946
2022-08-18 07:29:08 +00:00
scott
9ca352bbca Bug 1779636 - Pocket newtab login state to events pings r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D152121
2022-07-29 20:46:40 +00:00
Nick Alexander
a67a0b63a4 Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D150073
2022-07-20 02:58:42 +00:00
scott
26d10a22a5 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151666
2022-07-19 17:32:56 +00:00
scott
8e4c10f871 Bug 1777539 - Pocket newtab remove load more button and last card features r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D150789
2022-07-05 19:57:22 +00:00
Chris H-C
b4496bb39d Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 20:21:49 +00:00
Cristian Tuns
3e81d4efd8 Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
2022-06-17 10:49:00 -04:00
Chris H-C
676bb157ca Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 13:47:04 +00:00
Scott
6ded43679d Bug 1771546 - Pocket newtab colletion/topics card. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D147548
2022-06-10 23:44:31 +00:00
Dana Keeler
658b880816 Bug 1769669 - require specifying the trusted root in content signature verifier r=jschanck,leplatrem,robwu,barret
Before this patch, the content signature verifier
(nsIContentSignatureVerifier/ContentSignatureVerifier) would identify the root
it trusted based on the value of a preference. This patch changes the
implementation to require a specified hard-coded root to trust as with add-on
signature verification.

Depends on D146644

Differential Revision: https://phabricator.services.mozilla.com/D146645
2022-06-03 23:26:28 +00:00
Mathieu Leplatre
0f8ea5f41e Bug 1702759 - Remove load_dump preference r=robwu
This is a breaking change. It is not possible to control the loading of dumps from a preference anymore.

Dumps are only loaded if server is pointed at PROD. The recommended way to prevent dumps loading in tests is to store a high timestamp in the local DB.

Differential Revision: https://phabricator.services.mozilla.com/D146049
2022-05-23 16:24:58 +00:00
Mathieu Leplatre
caf000e948 Bug 1702759 - Remove bucket name preference r=robwu
This introduces a breaking change: the buckets cannot be changed via preferences anymore.

Before landing this patch, we should have a released a new version of the Remote Settings DevTools that is compatible with this new API.

Differential Revision: https://phabricator.services.mozilla.com/D145455
2022-05-23 16:24:57 +00:00
Scott
63e62ea6a3 Bug 1767448 - Pocket newtab available screen height and width for card pings. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D145334
2022-05-10 21:03:36 +00:00
Sylvestre Ledru
caaedeee98 Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D137741
2022-02-03 18:34:58 +00:00
Mathieu Leplatre
acb2745374 Bug 1738284 - Update CFR docs to use the Remote Settings DEV server r=nanj DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D130186
2021-11-02 16:54:52 +00:00
Tooru Fujisawa
ff5309e67b Bug 1737424 - Markup inline code properly in newtab doc. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D129347
2021-10-24 16:15:02 +00:00
Tooru Fujisawa
a6b360f8de Bug 1737419 - Add note about mach npm test for newtab on Windows. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D129343
2021-10-24 16:15:01 +00:00
Andrei Oprea
f35336c2cc Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 19:45:17 +00:00
Alexandru Michis
224d4ba025 Backed out changeset 5d92bd37605f (bug 1732724) for causing xpcshell failures in test_targeting.js
CLOSED TREE
2021-10-07 21:16:39 +03:00