Commit graph

12 commits

Author SHA1 Message Date
Mike de Boer
882fa06e25 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j

--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
2017-09-29 13:51:51 +02:00
Gijs Kruitbosch
58d91186ae Bug 1393133 - wait for the overflow button to be visible before activating it in tests, r=jaws
MozReview-Commit-ID: 58GGrPVufZ3

--HG--
extra : rebase_source : 325709623de03b4fd7e1414fff5bb42474194551
2017-08-24 17:25:24 +01:00
Gijs Kruitbosch
beb6be4934 Bug 1354117 - Update various other customizableui tests for photon, r=adw
There are no more help/quit buttons in the panel that shows up in customize mode,
and there are no more hyphenation quirks in items in the panel, so those tests
have been removed. The remaining tests are updated to test the correct panels.

MozReview-Commit-ID: LiUWejjZC7c

--HG--
rename : browser/components/customizableui/test/browser_photon_customization_context_menus.js => browser/components/customizableui/test/browser_customization_context_menus.js
extra : rebase_source : 49cef6ebeee140aefdb7a90d64b48c0da8179dc1
2017-08-01 15:46:58 +01:00
Brian Grinstead
7133c66b38 Bug 1360282 - Remove the popup that opens from the sidebar toolbar button;r=Gijs
MozReview-Commit-ID: 4N841nISf3F

--HG--
rename : browser/components/customizableui/test/browser_988072_sidebar_events.js => browser/components/customizableui/test/browser_sidebar_toggle.js
extra : rebase_source : ac822ab6f4f64a32c51b5cd55ba7f87bee4f90f8
2017-06-13 08:14:58 -07:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs
f12b067e8a Bug 1354082 - rm space because it's 'async function()' but 'function* ()', rs=bustage on a CLOSED TREE 2017-05-10 14:17:50 -04:00
Gijs
233681e912 Bug 1354082 - part 0: set prefs in all the tests that need it, r=mikedeboer
MozReview-Commit-ID: D1YDY5NvdYJ

--HG--
extra : rebase_source : 06b2b1e31efdf77b9eced71db930b6e291175e3d
extra : histedit_source : 11449e9985fea4b5f0a51fd1c73a1c41a79d66e3
2017-05-10 06:54:44 -04:00
Jared Wein
3f6801477a Bug 1242137 - Fix eslint errors in /browser/components/customizableui. r=gijs
--HG--
extra : commitid : CTMv8KOMjRK
extra : rebase_source : 768fb80e4652c1f0e14eea9e32da8eff795f1659
extra : amend_source : bd695a57c00c8004b048ccd4673465d66bea22c6
extra : histedit_source : ca0c6fcb719d0e7f0895de1bd429fa9804833f65
2016-01-23 14:55:27 -05:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Birunthan Mohanathas
51ba75d135 Bug 1016240 - Exterminate CR+LF line endings. r=briansmith,cpearce,ehsan,gavin 2014-06-18 17:56:02 -07:00
Gijs Kruitbosch
002f5ec4d6 Bug 986808 - don't insert duplicate separators in sidebar widget, r=mconley 2014-03-27 22:07:42 +00:00
Gijs Kruitbosch
61faf71088 Bug 981305 - don't insert leading or duplicate separators, r=mconley 2014-03-21 17:02:41 +00:00