nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
800612 commits 1 branch 98 tags 6.4 GiB
Commit graph

961 commits

Author SHA1 Message Date
Ben Hearsum
d74bb5919c Bug 1758961: remove parenthesis from private browsing title strings to match new shortcut strings r=nalexander,fluent-reviewers,flod 
This is something that came up in QA on this bug -- an inconsistency between the hover text on a running Firefox's Private Browser shortcut, and the hover text when it was not running (but pinned), largely captured in https://bugzilla.mozilla.org/show_bug.cgi?id=1758961#c11

Differential Revision: https://phabricator.services.mozilla.com/D150800
 2022-07-05 17:31:01 +00:00
Barret Rennie
edfd11a38c Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya 
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
 2022-06-29 23:01:37 +00:00
Jason Prickett
2e44c5c642 Bug 1770067 - Adding link support to private browsing promo button r=pdahiya,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D149571
 2022-06-24 23:09:23 +00:00
Joel Maher
5bf232d7af Bug 1776212 - cleanup e10s in manifest conditions for bc/dt. r=aryx,necko-reviewers,extension-reviewers,preferences-reviewers,dragana,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D150127
 2022-06-23 17:49:07 +00:00
Dan Mosedale
6799a67305 Bug 1748214 - Remove private browsing Nimbus feature, r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D146474
 2022-06-15 16:03:17 +00:00
Punam Dahiya
42cd29cbeb Bug 1769085 - Fix PBM tests to handle opening Spotlight r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D147117
 2022-06-09 17:09:12 +00:00
Punam Dahiya
d2786c2cc9 Bug 1770872 - Intermittent fix for browser_privatebrowsing_focus_promo.js test r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D147357
 2022-05-25 21:20:30 +00:00
Punam Dahiya
f6bc444db3 Bug 1770061 - Enhance PBM Promo button to support all SpecialMessageActions r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D146751
 2022-05-23 22:35:07 +00:00
Punam Dahiya
58f2a36893 Bug 1765907 - PBM experiment message should override default promo message r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D144871
 2022-05-12 18:24:06 +00:00
Cristian Tuns
6c334e2b06 Backed out changeset eb12cdc5d1e8 (bug 1765907) for causing mochitest failures on browser_privatebrowsing_focus_promo.js CLOSED TREE 2022-05-10 14:38:02 -04:00
Punam Dahiya
815ffe3c32 Bug 1765907 - PBM experiment message should override default promo message r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D144871
 2022-05-10 17:12:05 +00:00
Neil Deakin
9a3eea6349 Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D138738
 2022-05-06 10:00:56 +00:00
Itiel
e137f3bbad Bug 1767167 - Style improvements for PBM r=desktop-theme-reviewers,sfoster 
This includes:
1. Fix "Download Firefox Focus" button :hover:active state
2. Make the fake caret visible in HCM
3. Fix the branding name to be visible in all HCM modes
4. Make the sections distinguishable from others in HCM
5. Fix the searchbox text to be visible when hovered, in HCM
6. Make the promo's X button look better and work in :hover:active state

Differential Revision: https://phabricator.services.mozilla.com/D145175
 2022-05-05 23:02:37 +00:00
Noemi Erli
295eab376a Backed out 14 changesets (bug 1746052) for causing build bustages in nsExternalHelperAppService.cpp CLOSED TREE 
Backed out changeset bf46b0add531 (bug 1746052)
Backed out changeset 684b2aca10bb (bug 1746052)
Backed out changeset d4796eeeaf64 (bug 1746052)
Backed out changeset 5cf2378f6eb4 (bug 1746052)
Backed out changeset 2055ec1e9a57 (bug 1746052)
Backed out changeset 1398fc0669d2 (bug 1746052)
Backed out changeset 1f979899c843 (bug 1746052)
Backed out changeset 561a24801d4d (bug 1746052)
Backed out changeset 73e4689120f0 (bug 1746052)
Backed out changeset 9891f3b0229b (bug 1746052)
Backed out changeset 4c1ab30de0bd (bug 1746052)
Backed out changeset 108e14122e53 (bug 1746052)
Backed out changeset 1ee59c52578a (bug 1746052)
Backed out changeset 41fe77c5f4b2 (bug 1746052)
 2022-05-05 23:13:33 +03:00
Neil Deakin
e16d23e70e Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D138738
 2022-05-05 19:46:49 +00:00
Meg Viar
db71ef0067 Bug 1767813 - Intermittent TV browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_default_promo.js r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D145505
 2022-05-05 19:29:04 +00:00
Meg Viar
f5f23cdb0a Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D145015
 2022-05-04 13:35:28 +00:00
Csoregi Natalia
7896e7e124 Backed out 13 changesets (bug 1746052) for causing failures on uriloader/exthandler/tests/. CLOSED TREE 
Backed out changeset d19cc58e3cab (bug 1746052)
Backed out changeset 229edc158a2b (bug 1746052)
Backed out changeset b0ef7c68abcf (bug 1746052)
Backed out changeset 30de4b77f242 (bug 1746052)
Backed out changeset ebc6720fdab3 (bug 1746052)
Backed out changeset daccb796a093 (bug 1746052)
Backed out changeset 5b76d8d76b2b (bug 1746052)
Backed out changeset a698068d078f (bug 1746052)
Backed out changeset 73d17535d8d1 (bug 1746052)
Backed out changeset 94c95f004221 (bug 1746052)
Backed out changeset 1a389759585a (bug 1746052)
Backed out changeset c91230a8ea90 (bug 1746052)
Backed out changeset 7665f02c114e (bug 1746052)
 2022-05-04 01:15:12 +03:00
Neil Deakin
660ff47e74 Bug 1746052, use validateFileNameForSaving in DownloadPaths.sanitize with flags to emulate something similar to the existing behaviour, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D138738
 2022-05-03 19:44:29 +00:00
Emily McMinn
7690f8d9cb Bug 1765431 - Increase weekly and lifetime frequency for the Private Browsing focus promo message r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D144065
 2022-04-28 21:39:17 +00:00
Norisz Fay
93b6ed4f4e Backed out changeset c1a5d86e2f7b (bug 1765431) for causing lint failure CLOSED TREE 2022-04-28 23:53:14 +03:00
Emily McMinn
92470deaa7 Bug 1765431 - Increase weekly and lifetime frequency for the Private Browsing focus promo message r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D144065
 2022-04-28 20:03:44 +00:00
Dan Mosedale
d2f1977bd8 Bug 1754536 - Fix intermittent failures in private browsing nimbus tests, r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D138834
 2022-04-26 21:54:33 +00:00
Punam Dahiya
8927f15042 Bug 1765422 - Update Firefox Focus promo text in PBM r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D144062
 2022-04-19 22:09:49 +00:00
Meg Viar
63384f65ab Bug 1764807 - Show "Firefox Klar" promo in PBM for CH and AT Regions r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D143746
 2022-04-18 20:14:41 +00:00
Emily McMinn
1f9a03af0c Bug 1759915 - Add aria-hidden to PBM search box to correct VoiceOver behaviour r=mviar 
This should prevent VoiceOver from getting "stuck" between the address bar and the fake search bar in Private Browsing Mode. I'm not sure why PBM is different to the behaviour on the newtab page (the newtab page doesn't have the aria-hidden property and the HTML is essentially the same) but adding "aria-hidden" in this case doesn't seem to break anything.

Differential Revision: https://phabricator.services.mozilla.com/D143784
 2022-04-18 19:49:04 +00:00
Meg Viar
8d7ec958ea Bug 1764330 - The QR code from the "PB_FOCUS_PROMO" modal wrongly redirects to the "Firefox Klar" app even if the region is set to "US" and a Firefox en-US locale build is used r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D143724
 2022-04-14 16:09:34 +00:00
Meg Viar
cc76621783 Bug 1763437 - Show 'Firefox Klar' for English locale in PB Focus Promo r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D143082
 2022-04-12 15:17:50 +00:00
Meg Viar
bd0fd127b6 Bug 1762477 - Add test coverage for resetMessageState in ASRouter.jsm r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D142890
 2022-04-07 18:26:13 +00:00
Emily McMinn
3c39a409d9 Bug 1762431 - Presentation fixes for a11y on PBM Fx100 r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D142893
 2022-04-05 16:02:37 +00:00
Emily McMinn
6b3183955e Bug 1761842 - Replace promo CTA link with a button for better a11y r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D142589
 2022-04-04 19:32:44 +00:00
Meg Viar
d8fd9d99de Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D142551
 2022-04-01 12:36:30 +00:00
Gijs Kruitbosch
8e67201171 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 16:16:42 +00:00
Norisz Fay
acdd6851cd Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
27039e2946 Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D141437
 2022-03-30 08:18:51 +00:00
Meg Viar
326a597833 Bug 1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D141781
 2022-03-23 19:56:59 +00:00
Meg Viar
9c23c0a018 Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D140739
 2022-03-23 14:03:18 +00:00
smolnar
876c137475 Backed out changeset f6577528fc15 (bug 1758028) for causing xpc failures in xpcshell/test_BrowserUtils.js CLOSED TREE 2022-03-22 21:54:22 +02:00
Meg Viar
2ae66744d6 Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D140739
 2022-03-22 19:19:02 +00:00
Punam Dahiya
a76c013839 Bug 1754832 - Update PBM to support opening spotlight tab modal r=Mardak,mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D140565
 2022-03-17 06:41:47 +00:00
Punam Dahiya
c4f92a5d3b Bug 1756860 - Add Firefox Focus promo image r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D140780
 2022-03-12 11:15:33 +00:00
Mark Banner
8bb4667fae Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
e89faa903f Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
fe937b78bd Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-10 09:25:28 +00:00
Dan Mosedale
dd68ed956f Bug 1754115 - switch pvt browsing promo close string, r=pdahiya,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D140279
 2022-03-04 20:09:46 +00:00
Punam Dahiya
548e1083fa Bug 1700527 - Fix test to check link opening in new tab r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D140149
 2022-03-03 02:16:29 +00:00
Punam Dahiya
f99fc8a551 Bug 1756178 - Open link from the private browsing page in a new tab r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D139900
 2022-03-01 18:38:23 +00:00
Dan Mosedale
f319e6a711 Bug 1749775 - Add user telemetry for 98 VPN promo, r=andreio,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D135874
 2022-02-11 16:31:06 +00:00
Andrei Oprea
78216df832 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D135058
 2022-02-04 02:35:30 +00:00
Cosmin Sabou
c1424ed185 Backed out changeset edbc8f7e808f (bug 1748240) for bc failures on browser_privatebrowsing_about_nimbus.js. CLOSED TREE 2022-02-01 05:40:15 +02:00