nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
917031 commits 1 branch 98 tags 6.4 GiB
Commit graph

50 commits

Author SHA1 Message Date
Botond Ballo
3ea51142fb Bug 1858446 - Document that classes representing HTML elements should live in the mozilla::dom namespace. r=peterv DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D210576
 2024-05-17 23:23:44 +00:00
ogiorgis
111705f5fd Bug 1840493 - doc/rst: fix some languages declaration r=firefox-source-docs-reviewers,webdriver-reviewers,necko-reviewers,geckoview-reviewers,devtools-reviewers,profiler-reviewers,championshuttler,whimboo,nchevobbe,julienw,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D196268
 2023-12-13 18:32:20 +00:00
Mike Hommey
619672a8e4 Bug 1867459 - Replace CPU_ARCH with TARGET_CPU. r=firefox-build-system-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D195157
 2023-12-08 10:43:59 +00:00
Sylvestre Ledru
d6cea3eede Bug 1519636 - Remove nbsp in the doc r=firefox-source-docs-reviewers,geckoview-reviewers,ahal,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D194782
 2023-12-03 11:01:53 +00:00
Sylvestre Ledru
82db67a6be Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D191480
 2023-10-19 20:52:10 +00:00
Emilio Cobos Álvarez
d8e189e0a0 Bug 1858711 - Refactor lwtheme attributes to account for missing colors. r=dao,desktop-theme-reviewers 
When a theme doesn't specify popup colors, it makes sense to follow the
system-preferred color scheme. Refactor theming attributes so that we
can distinguish this. Instead of a single [lwt-popup-brighttext], we get
lwt-popup="dark"/"light", and handle it appropriately.

Same for the other relevant attributes.

Refactor sidebar theming (which already did this tri-state thing via
lwt-sidebar and lwt-sidebar-brighttext) to do the same using a single
lwt-sidebar attribute, and update the docs.

Differential Revision: https://phabricator.services.mozilla.com/D190919
 2023-10-13 13:24:14 +00:00
Mike Hommey
53765a27b9 Bug 1851754 - Upgrade minimum supported Clang version to 8. r=firefox-build-system-reviewers,ahochheiden 
Differential Revision: https://phabricator.services.mozilla.com/D188898
 2023-09-22 02:34:51 +00:00
CanadaHonk
513aff8119 Bug 1841117 - Remove unused intl.uidirection pref r=gregp,sylvestre 
It was still in `about:config` and referenced in some docs after mostly
being removed in Bug 1676137.

Differential Revision: https://phabricator.services.mozilla.com/D182748
 2023-07-10 12:00:58 +00:00
Cristian Tuns
d58b87b9ba Backed out changeset 088b1611348a (bug 1841117) as requested by canadahonk CLOSED TREE 2023-07-04 18:39:27 -04:00
CanadaHonk
094b41d891 Bug 1841117 - Remove unused intl.uidirection pref r=gregp 
It was still in `about:config` and referenced in some docs after mostly
being removed in Bug 1676137.

Differential Revision: https://phabricator.services.mozilla.com/D182748
 2023-07-04 22:31:28 +00:00
Mike Hommey
e97e5246fd Bug 1834436 - Upgrade minimum supported GCC version to 8. r=firefox-build-system-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D178736
 2023-06-01 20:09:19 +00:00
Mike Hommey
fd126d15a5 Bug 1834955 - Upgrade minimum supported Clang-cl version to 9. r=firefox-build-system-reviewers,sergesanspaille 
We have less constraints on the minimum supported clang-cl version, and
it would unlock C++17 inline variables (which had a bug on Windows
targets in clang up-to 8.x).

Differential Revision: https://phabricator.services.mozilla.com/D179037
 2023-05-29 20:31:08 +00:00
Mike Hommey
2aac970b03 Bug 1833958 - Update clang version in C++ in Firefox doc. r=firefox-source-docs-reviewers,marco 
Differential Revision: https://phabricator.services.mozilla.com/D178891
 2023-05-25 06:50:43 +00:00
Andi-Bogdan Postelnicu
79e171fd9f Bug 1277372 - Remove unused "mozilla/TypeTraits.h" r=sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D174129
 2023-04-17 13:50:11 +00:00
Itiel
35ac645687 Bug 1825586 - Update RTL docs r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D174136
 2023-04-13 17:14:05 +00:00
Sylvestre Ledru
f616c106ea no bug - doc: fix some typos r=marco 
Differential Revision: https://phabricator.services.mozilla.com/D171688
 2023-03-06 11:53:54 +00:00
ogiorgis
5fa906d358 Bug 1749473 - fix all pygments warnings r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D167915
 2023-01-27 13:41:10 +00:00
Eemeli Aro
f08c01b802 Bug 1804404 - Update l10n documentation due to DTD & .inc removal. r=flod 
Differential Revision: https://phabricator.services.mozilla.com/D164047
 2022-12-07 11:50:39 +00:00
Greg Stoll
4c4a846ade no bug - fx doc: fix a few links to old pages r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D162421
 2022-11-18 21:20:18 +00:00
Greg Stoll
ae193de801 no bug - fx doc: fix link to moved string guide page r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D159705
 2022-10-19 19:51:27 +00:00
Sylvestre Ledru
213c96564a Bug 1787590 - Doc: Remove a 404 link r=jandem DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D157112
 2022-09-12 12:37:43 +00:00
Ray Kraesig
4fc7f7613e Bug 1772856 - Clean up formatting r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148417
 2022-06-15 07:12:02 +00:00
Ray Kraesig
24e0619a0d Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148416
 2022-06-15 07:12:02 +00:00
Bobby Holley
99677cea83 Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D148081
 2022-06-02 21:01:42 +00:00
Janvi Bajoria
c68c01937d Bug 1759754 - fix use the static preference API link in C++ coding style documentation r=KrisWright 
Differential Revision: https://phabricator.services.mozilla.com/D144191
 2022-05-10 17:26:31 +00:00
Mathew Hodson
05c78de712 Bug 1630027 - Migrate RTL Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142183
 2022-05-06 07:16:58 +00:00
Mathew Hodson
34e2ece16f Bug 1630027 - Migrate CSS Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142163
 2022-05-06 07:16:48 +00:00
Mathew Hodson
d83e906b06 Bug 1630027 - Migrate SVG Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142184
 2022-05-06 07:16:48 +00:00
Mike Conley
f29b80b95b Bug 1758753 - Migrate XPCOM hashtable documentation from MDN to Firefox Source Docs. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D140671
 2022-03-17 14:23:27 +00:00
Sylvestre Ledru
caaedeee98 Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D137741
 2022-02-03 18:34:58 +00:00
Bobby Holley
02e9792c14 Bug 1740616 - Modify the C++ style guide to prefer unsigned types and CheckedInt. r=glandium DONTBUILD 
This commit resolves the question posed in [1], largely on the basis of
the rationale put forth by emilio [2].

The reasons cited for using signed types boil down to (1) taking
advantage of UB optimizations, (2) more tractable dynamic overflow
analysis, and (3) increased chance of the surrounding logic identifying
and rejecting overflowed values.

Emilio points out that (1) is not a durable advantage. I see some value
in (2) and (3), but I see more value in consistency with existing code
and clear communication of semantic intent to the reader.

[1] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/
[2] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/m/NPdl2uIhAgAJ

Differential Revision: https://phabricator.services.mozilla.com/D130928
 2021-11-16 19:38:01 +00:00
Chris Peterson
339c7d8961 Bug 1729598 - Remove now-unused MustUseChecker and MOZ_MUST_USE_TYPE attribute. r=static-analysis-reviewers,andi 
Depends on D125504

Differential Revision: https://phabricator.services.mozilla.com/D125505
 2021-09-15 05:10:51 +00:00
Simon Giesecke
78c7565ba4 Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2021-09-08 12:56:01 +00:00
surajeet310
6ea83c8ef9 Bug 1714788 - Fixed more Sphinx warnings in 'mach doc' r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D117419
 2021-06-10 19:33:53 +00:00
Simon Giesecke
f4f7c593e0 Bug 1692835 - Remove nsJSThingHashtable. r=xpcom-reviewers,nika 
The only use of nsJSThingHashtable is replaced by a direct use of
nsBaseHashtable.

Differential Revision: https://phabricator.services.mozilla.com/D105971
 2021-03-02 09:02:19 +00:00
Mark Banner
787d4fd95d Bug 1686226 - Add references to the Matrix Lint & Formatting room in the coding style docs. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D101463
 2021-01-12 15:04:35 +00:00
Butkovits Atila
cd73ee5d0b Backed out changeset eb6cdd43ce2e (bug 1677549) as requested by Simon. CLOSED TREE 2020-12-14 17:32:44 +02:00
Simon Giesecke
ba0db06d63 Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=andi,sylvestre,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2020-12-11 10:35:54 +00:00
Sylvestre Ledru
31b3856da6 Bug 1667831 - doc: fix more pygments r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91868
 2020-09-30 07:03:41 +00:00
Markus Stange
9aa3b6a184 Bug 1667463 - Fix two typos in using_cxx_in_firefox_code.rst. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D91472
 2020-09-25 20:25:23 +00:00
Simon Giesecke
3abd6dca98 Bug 1648010 - Update coding style with respect to string literals. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D81503
 2020-07-21 11:24:06 +00:00
Bryce Seager van Dyk
0c45c50c1f Bug 1659726 - Fix mode line docs to use 2 space indents rather than 8. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D87448
 2020-08-19 07:51:42 +00:00
Simon Giesecke
ee62debaab Bug 1653532 - Improve reference of Google Coding Style for C++ Code. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D83923
 2020-08-04 08:31:17 +00:00
Sylvestre Ledru
d9d0eda42a no bug - python CS doc - point to our linters r=marco 
Differential Revision: https://phabricator.services.mozilla.com/D82897
 2020-07-10 12:50:25 +00:00
Sylvestre Ledru
df7f09424c Bug 1641848 - Import https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code in-tree r=nalexander 
I replaced the color by bold on "No".
It seems we can't have color in cells with rst :/

Differential Revision: https://phabricator.services.mozilla.com/D77444
 2020-05-29 19:28:52 +00:00
Tilden Windsor
a73234e7ec Bug 1614477 - Replaced deprecated dxr links with searchfox links. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D76621
 2020-05-24 13:46:30 +00:00
Chris Peterson
32270107d9 Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in some Servo Rust code. r=emilio 
Are there any Rust crates outside mozilla-central that include or emit Mozilla C++ code that should be updated to use [[nodiscard]] instead of MOZ_MUST_USE?

Depends on D68751

Differential Revision: https://phabricator.services.mozilla.com/D69319

--HG--
extra : moz-landing-system : lando
 2020-04-02 08:27:59 +00:00
Sylvestre Ledru
374863b8ad Bug 1605934 - Add nested namespaces in the C++ coding style r=sg 
Differential Revision: https://phabricator.services.mozilla.com/D64301

--HG--
extra : moz-landing-system : lando
 2020-02-26 09:31:44 +00:00
Sylvestre Ledru
101e156501 no bug - Recommends using instead of typedef r=sg 
Differential Revision: https://phabricator.services.mozilla.com/D63834

--HG--
extra : moz-landing-system : lando
 2020-02-24 13:13:19 +00:00
Sylvestre Ledru
f9328d2021 Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal 
This for a few reasons:
* The summary becomes the landing page for code quality:
  https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place

Differential Revision: https://phabricator.services.mozilla.com/D61767

--HG--
rename : tools/lint/docs/coding-style/coding_style_java.rst => docs/code-quality/coding-style/coding_style_java.rst
rename : tools/lint/docs/coding-style/coding_style_other.rst => docs/code-quality/coding-style/coding_style_other.rst
rename : tools/lint/docs/coding-style/coding_style_python.rst => docs/code-quality/coding-style/coding_style_python.rst
rename : tools/lint/docs/coding-style/format_cpp_code_with_clang-format.rst => docs/code-quality/coding-style/format_cpp_code_with_clang-format.rst
rename : tools/clang-tidy/docs/summary.rst => docs/code-quality/index.rst
rename : tools/lint/docs/create.rst => docs/code-quality/lint/create.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/index.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/lint.rst
rename : tools/lint/docs/linters/codespell.rst => docs/code-quality/lint/linters/codespell.rst
rename : tools/lint/docs/linters/cpp-virtual-final.rst => docs/code-quality/lint/linters/cpp-virtual-final.rst
rename : tools/lint/docs/linters/eslint-plugin-mozilla.rst => docs/code-quality/lint/linters/eslint-plugin-mozilla.rst
rename : tools/lint/docs/linters/eslint-plugin-spidermonkey-js.rst => docs/code-quality/lint/linters/eslint-plugin-spidermonkey-js.rst
rename : tools/lint/docs/linters/eslint.rst => docs/code-quality/lint/linters/eslint.rst
rename : tools/lint/docs/linters/file-perm.rst => docs/code-quality/lint/linters/file-perm.rst
rename : tools/lint/docs/linters/file-whitespace.rst => docs/code-quality/lint/linters/file-whitespace.rst
rename : tools/lint/docs/linters/flake8.rst => docs/code-quality/lint/linters/flake8.rst
rename : tools/lint/docs/linters/l10n.rst => docs/code-quality/lint/linters/l10n.rst
rename : tools/lint/docs/linters/license.rst => docs/code-quality/lint/linters/license.rst
rename : tools/lint/docs/linters/lintpref.rst => docs/code-quality/lint/linters/lintpref.rst
rename : tools/lint/docs/linters/mingw-capitalization.rst => docs/code-quality/lint/linters/mingw-capitalization.rst
rename : tools/lint/docs/linters/perfdocs.rst => docs/code-quality/lint/linters/perfdocs.rst
rename : tools/lint/docs/linters/rstlinter.rst => docs/code-quality/lint/linters/rstlinter.rst
rename : tools/lint/docs/linters/rustfmt.rst => docs/code-quality/lint/linters/rustfmt.rst
rename : tools/lint/docs/usage.rst => docs/code-quality/lint/usage.rst
rename : tools/clang-tidy/docs/index.rst => docs/code-quality/static-analysis.rst
extra : moz-landing-system : lando
 2020-02-11 09:11:44 +00:00