nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
833612 commits 1 branch 98 tags 6.4 GiB
Commit graph

127 commits

Author SHA1 Message Date
Niklas Baumgardner
d646763c9e Bug 1819306 - Set quickactions prefs for screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D171777
 2023-03-09 19:05:28 +00:00
Niklas Baumgardner
f4582ad433 Bug 1820234 - Add margin to screenshots panel buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172046
 2023-03-08 21:31:08 +00:00
Stanca Serban
cdaf1de237 Backed out changeset 47a62f76fe40 (bug 1813394) for causing mochitests failures in browser_screenshots_drag_test.js. 2023-03-08 17:37:43 +02:00
Niklas Baumgardner
0fd7834bac Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-07 21:25:10 +00:00
Noemi Erli
93ca893555 Backed out changeset a33c121cae89 (bug 1813394) for causing failures in browser_screenshots_test_downloads.js CLOSED TREE 2023-03-07 00:27:21 +02:00
Niklas Baumgardner
d57de84fe6 Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-06 21:23:27 +00:00
Neil Deakin
70cdb525f0 Bug 1815062, modify callers of DownloadPaths.sanitize so that some use the allowInvalidFilenames argument, r=Gijs 
Callers that use the filename to assign the default filename in a filepicker or save without a filepicker should use the default arguments, callers that validate a filename entered from a filepicker should supply false for compressWhitespaces, and true for allowInvalidFilenames

Differential Revision: https://phabricator.services.mozilla.com/D171002
 2023-02-28 18:57:24 +00:00
Niklas Baumgardner
c057486ca0 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-25 17:26:34 +00:00
Sam Foster
ecb9ef18d8 Bug 1799211 - Place focus on the first panel button when opening screenshots UI. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D168497
 2023-02-24 02:35:25 +00:00
Marian-Vasile Laza
5a3faecdb0 Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
26e4c6bc8a Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-23 17:37:01 +00:00
Butkovits Atila
f8a9ce74db Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
ab7aa855c8 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-21 19:59:09 +00:00
Niklas Baumgardner
f50ece2128 Bug 1799215 - Screenshots overlay buttons should have focus states. r=cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D167583
 2023-01-31 16:20:48 +00:00
Gijs Kruitbosch
efef52fc92 Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Csoregi Natalia
f58879060d Backed out changeset 13175567352f (bug 1811953) for failures on browser_screenshots_drag_scroll_test.js. CLOSED TREE 2023-01-26 19:21:30 +02:00
Niklas Baumgardner
fea63a2dbb Bug 1811953 - Scroll when resizing near the edge. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D167614
 2023-01-26 15:55:32 +00:00
Niklas Baumgardner
c8835ab0a7 Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D160565
 2023-01-24 23:51:33 +00:00
Neil Deakin
1d2e8169a6 Bug 1808918, use Untitled as the default filename when saving a file rather than index, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D167028
 2023-01-23 14:53:21 +00:00
Butkovits Atila
9268f063c3 Backed out changeset 39f3534179a7 (bug 1743887) for causing failures at browser_screenshots_test_screenshot_too_big.js. 2023-01-18 03:30:07 +02:00
Niklas Baumgardner
405651327c Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D160565
 2023-01-17 19:03:33 +00:00
Niklas Baumgardner
7a6e5d7f03 Bug 1799546 - Screenshots buttons have proper contrast on hover. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166567
 2023-01-12 14:41:18 +00:00
Niklas Baumgardner
febe5c1f27 Bug 1806590 - Downloading screenshot now shows panel in private windows. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166341
 2023-01-10 22:00:17 +00:00
Emilio Cobos Álvarez
a14c746228 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-15 03:11:55 +00:00
Cristian Tuns
b638ccfac9 Backed out 2 changesets (bug 1805415) for causing dt failures on browser_net_telemetry_throttle_changed.js CLOSED TREE 
Backed out changeset 5056d7df9f1e (bug 1805415)
Backed out changeset e13513500184 (bug 1805415)
 2022-12-14 08:52:21 -05:00
Emilio Cobos Álvarez
be1f057109 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-14 10:25:17 +00:00
Niklas Baumgardner
f75d08ab66 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-06 00:06:20 +00:00
Stanca Serban
7515134a78 Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-12-02 16:39:01 +02:00
Niklas Baumgardner
42e1023b26 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-02 13:45:57 +00:00
Niklas Baumgardner
8e924f4f3d Bug 1801193 - Focus panel buttons when screenshots UI is opened. r=sfoster,cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D162333
 2022-12-01 15:14:21 +00:00
Niklas Baumgardner
c7a9b55d2e Bug 1799212 - Escape screenshots when panel is focused. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162879
 2022-12-01 15:14:21 +00:00
Marian-Vasile Laza
5da98a3a05 Backed out changeset 1fdf3fc76d06 (bug 1785293) for causing bc failures on browser_screenshots_drag_test.js. CLOSED TREE 2022-11-30 22:53:47 +02:00
Niklas Baumgardner
8350b30596 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-30 15:00:33 +00:00
Stanca Serban
1fc6ac5d91 Backed out changeset 075348ac5873 (bug 1801193) for causing bc failures on browser_quickactions.js. CLOSED TREE 2022-11-23 00:48:13 +02:00
Niklas Baumgardner
416bdf0056 Bug 1801193 - Focus panel buttons when screenshots UI is opened. r=sfoster,cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D162333
 2022-11-22 21:02:29 +00:00
Stanca Serban
f3dacdc98b Backed out changeset 3d00ac0e9b4e (bug 1801193) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-11-22 22:34:14 +02:00
Niklas Baumgardner
9ceb71fc14 Bug 1801193 - Focus panel buttons when screenshots UI is opened. r=sfoster,cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D162333
 2022-11-22 19:41:12 +00:00
Cieara Meador
23f2900806 Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-17 22:50:18 +00:00
Cristian Tuns
52cb72774f Backed out changeset 57d19e70e34c (bug 1794142) for causing mochitest failures in browser_parsable_css.js CLOSED TREE 2022-11-16 16:11:06 -05:00
Cieara Meador
835634ecc4 Bug 1794142 - Screenshots module buttom HCM r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162044
 2022-11-16 19:31:49 +00:00
Marian-Vasile Laza
252c199704 Backed out changeset 7c0eb6e89712 (bug 1785293) for causing bc failures on browser_screenshots_test_downloads.js. CLOSED TREE 2022-11-11 02:36:29 +02:00
Niklas Baumgardner
eee2b35e37 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-11-10 22:21:11 +00:00
Mark Banner
18753bfe42 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Niklas Baumgardner
00b772a373 Bug 1748730 - The screenshots overlay and panel are now always in sync. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158868
 2022-10-28 19:05:18 +00:00
Niklas Baumgardner
813ecc17a7 Bug 1791624 - Fix Fluent errors in Screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158515
 2022-10-10 19:52:36 +00:00
Niklas Baumgardner
14b904f207 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 13:23:19 +00:00
Sandor Molnar
fcb74829f6 Backed out changeset 45ea391514c0 (bug 1790855) for causing bc failures in browser_contextmenu CLOSED TREE 2022-10-04 06:41:48 +03:00
Niklas Baumgardner
ffa2f8034a Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 02:09:08 +00:00
Sandor Molnar
6d6d17465d Backed out changeset d8835c4ab04f (bug 1790855) for causing bc failures in browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js CLOSED TREE 2022-10-04 04:12:42 +03:00
Niklas Baumgardner
5ffcda4977 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157355
 2022-10-04 00:03:56 +00:00