nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
854692 commits 1 branch 98 tags 6.4 GiB
Commit graph

639 commits

Author SHA1 Message Date
Mike Kaply
f35377c487 Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D187458
 2023-09-07 18:01:32 +00:00
Mike Kaply
cfa3f6f04f Bug 1850705 - Add loading screen for synced tabs. r=sclements,fluent-reviewers,fxview-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D187389
 2023-09-07 17:56:55 +00:00
Mike Kaply
8b1a6e539b Bug 1850385 - Handle cases where sync "worked" but we have no devices. r=sclements,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186957
 2023-09-07 10:44:01 +00:00
Mike Kaply
dc716ded74 Bug 1851830 - Move new Firefox View tests into their own subdir. r=fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D187557
 2023-09-06 17:08:22 +00:00
Mike Conley
8a18b44c43 Bug 1849124 - Make sure card-container calls MozLitElement's disconnectedCallback. r=fxview-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D187507
 2023-09-06 15:22:50 +00:00
Mike Conley
1582287747 Bug 1851684 - Make sure to call the MozLitElement disconnectedCallback in subclass overrides. r=fxview-reviewers,shopping-reviewers,kcochrane,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D187506
 2023-09-06 15:22:50 +00:00
Sandor Molnar
b893d167c6 Backed out changeset f5f15b313e48 (bug 1851525) for causing bc failures in browser/base/content/test/performance/browser_startup_images.js 2023-09-06 17:46:35 +03:00
Mike Kaply
dad34a6594 Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D187458
 2023-09-06 13:41:27 +00:00
Mike Kaply
86ede7b469 Bug 1851633 - Add connect another device button to synced tabs. r=kcochrane,fluent-reviewers,fxview-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D187491
 2023-09-06 12:38:58 +00:00
Iulian Moraru
e6b5e724b5 Backed out 3 changesets (bug 1851684, bug 1849124) for causing mochitest-chrome failures on test_login_filter.html. CLOSED TREE 
Backed out changeset b34280e9a087 (bug 1849124)
Backed out changeset 36630f215585 (bug 1851684)
Backed out changeset 159ff8cfdf58 (bug 1851684)
 2023-09-06 03:18:00 +03:00
Mike Conley
638ebb3abe Bug 1849124 - Make sure card-container calls MozLitElement's disconnectedCallback. r=fxview-reviewers,kcochrane 
Depends on D187506

Differential Revision: https://phabricator.services.mozilla.com/D187507
 2023-09-05 23:29:21 +00:00
Mike Conley
6340fb49af Bug 1851684 - Make sure to call the MozLitElement disconnectedCallback in subclass overrides. r=fxview-reviewers,shopping-reviewers,kcochrane,kpatenio 
Depends on D187505

Differential Revision: https://phabricator.services.mozilla.com/D187506
 2023-09-05 23:29:20 +00:00
Hanna Jones
85f3196134 Bug 1810890 - Part 5: remove Storybook CSS path rewrites from fx view elements r=kcochrane,fxview-reviewers 
Depends on D185093

Differential Revision: https://phabricator.services.mozilla.com/D185094
 2023-09-05 17:48:25 +00:00
Kelly Cochrane
fb90089531 Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D187123
 2023-09-05 15:39:05 +00:00
Stanca Serban
405e022d17 Backed out changeset 798de3f71896 (bug 1846255) for causing OSX mochitests failures in test_opentabs.html. CLOSED TREE 2023-09-05 18:20:21 +03:00
Kelly Cochrane
07e4af33f2 Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D187123
 2023-09-05 14:23:23 +00:00
Norisz Fay
8de372c468 Backed out changeset 1b06cdb33e3e (bug 1850385) for causing mochitest failures on browser_syncedtabs_errors_firefoxview_next.js CLOSED TREE 2023-09-05 04:22:30 +03:00
Mike Kaply
13bcb9bd6a Bug 1850385 - Handle cases where sync "worked" but ad have no devices. r=sclements,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186957
 2023-09-04 23:52:33 +00:00
Sarah Clements
b023aa4b2f Bug 1851453 - Disable notification dot in firefox view r=mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D187372
 2023-09-04 14:17:18 +00:00
Kelly Cochrane
e06615fe72 Bug 1846379 - Update states for light, dark and HCM in side navigation r=mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D187041
 2023-09-01 19:26:54 +00:00
Jonathan Sudiaman
7b495d4221 Bug 1842602 - Add observer handler functions to viewpage.mjs in about:firefoxview-next r=sfoster,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D187214
 2023-09-01 14:58:46 +00:00
Shane Hughes
70337c14e7 Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D183074
 2023-08-31 08:14:41 +00:00
Butkovits Atila
86090140b2 Backed out 2 changesets (bug 1842366) for causing Xpcshell failures at test_PanelTestProvider.js. CLOSED TREE 
Backed out changeset bcc147043981 (bug 1842366)
Backed out changeset c9e538ad8526 (bug 1842366)
 2023-08-31 07:43:26 +03:00
Shane Hughes
5202428d2e Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D183074
 2023-08-31 03:29:05 +00:00
Mike Kaply
0689b04be0 Bug 1846243 - Private windows should only have their own tabs in open tabs. r=jsudiaman,fxview-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D186370
 2023-08-30 20:52:54 +00:00
Mike Kaply
4b933c99cd Bug 1850365 - Cleanup UX for empty states. r=kcochrane,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186980
 2023-08-29 21:15:53 +00:00
Sarah Clements
20f8ed3dce Bug 1847981 - Flip pref to make firefoxview-next the default r=fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D186849
 2023-08-29 15:21:41 +00:00
Stuart Colville
e123b3d99b Bug 1844600 - Fix heading and card alignment r=sclements,desktop-theme-reviewers,fxview-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D186876
 2023-08-29 14:42:03 +00:00
Kelly Cochrane
c5ca126b8e Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D184970
 2023-08-29 12:40:52 +00:00
Cristian Tuns
d0d03369a4 Backed out changeset c35a3bb94b22 (bug 1845356) for causing bc failures in browser_feature_callout_position.js CLOSED TREE 2023-08-28 17:53:19 -04:00
Kelly Cochrane
750fa918eb Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D184970
 2023-08-28 19:52:09 +00:00
Sandor Molnar
1d305e9817 Backed out changeset a91b29868240 (bug 1845356) for causing bc failures in browser/components/firefoxview/tests/browser/browser_feature_callout.js CLOSED TREE 2023-08-28 21:48:52 +03:00
Kelly Cochrane
3c494ef8b2 Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D184970
 2023-08-28 15:04:58 +00:00
Mike Kaply
a5b69e26ce Bug 1847983 - Add outer container so we can align images. r=kcochrane,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186384
 2023-08-28 14:56:30 +00:00
Jonathan Sudiaman
60177d1345 Bug 1849219 - Multi-second parent process hangs in 'places::NotifyTitleObservers' calling into 'maybeCacheBaseUrlForVisit' r=mkaply,places-reviewers,mak 
Effectively, this undoes a lot of the work in Bug 1828669, and thus we will have to reopen that bug. This does preserve the de-duping for //exact// URL matches, but not base url + title.

One thing I noticed is that the `page-title-changed` handler operates at O(n) complexity, which probably explains the hangs that Daniel was seeing. We will have to rethink this in terms of de-duping, but for now, I have improved this complexity by maintaining a cache of url -> visit.

This also addresses some of the review comments left by @Standard8 on the [[ https://phabricator.services.mozilla.com/D185315 | original patch ]].

Differential Revision: https://phabricator.services.mozilla.com/D186580
 2023-08-23 20:14:02 +00:00
Sam Foster
7075d4e4c8 Bug 1845836 - Include closed tabs from closed windows in fxview-next's recently closed tabs list. r=kcochrane,dao,fxview-reviewers,sessionstore-reviewers,sclements 
* Add a browser.sessionstore.closedTabsFromClosedWindows pref and consult it when building recently-closed tab lists in firefoxview-next
* Add a _resolveClosedDataSource to SessionStore which allows us to find the window state and _closedTabs given a DOMWindow, a window closedId, or a window session store Id.
* Carry window closedId and source window Id into tab items when building recently-closed tab lists in firefoxview-next. This gives us the necessary context when we need to undoClose or forget a tab item in the list.
* Add a getClosed TabCount and TabData for Closed Windows method to SessionStore
* Modify undoCloseTab and forgetClosedTab to accept source params we can resolve to window state data using _resolveClosedDataSource

Differential Revision: https://phabricator.services.mozilla.com/D185108
 2023-08-22 20:42:57 +00:00
Mike Kaply
7d98e65195 Bug 1849195 - Use max-width/height to prevent extra scrollbars. r=dholbert,fxview-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D186503
 2023-08-19 16:46:40 +00:00
Mike Kaply
6718d67ce7 Bug 1848928 - Update class for sort by site. r=jsudiaman DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D186545
 2023-08-18 20:58:11 +00:00
Kelly Cochrane
93d1e7e4c7 Bug 1842616 - Add telemetry for Recently Closed tabs r=mkaply,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D186190
 2023-08-18 16:06:33 +00:00
Kelly Cochrane
0e6cfc7f80 Bug 1846572 - Adding role='application' to fix keyboard navigation in Firefox View with NVDA on Windows r=mkaply,fluent-reviewers,ayeddi,flod 
Differential Revision: https://phabricator.services.mozilla.com/D185339
 2023-08-17 16:22:30 +00:00
Mike Kaply
3576f7e659 Bug 1848707 - Use repeat insted of map so fluent IDs work correctly. r=kcochrane,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186179
 2023-08-16 21:08:31 +00:00
Cristina Horotan
9afcad675b Backed out changeset 7d891879797e (bug 1846572) for causing bc failures at browser_firefoxview_next.js CLOSED TREE 2023-08-16 02:55:34 +03:00
Kelly Cochrane
720c51f48d Bug 1846572 - Adding role='application' to fix keyboard navigation in Firefox View with NVDA on Windows r=mkaply,fluent-reviewers,ayeddi,flod 
Differential Revision: https://phabricator.services.mozilla.com/D185339
 2023-08-15 21:52:20 +00:00
Mike Kaply
31685a07c3 Bug 1848719 - Allow device names to overflow to next column. r=kcochrane,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D186183
 2023-08-15 13:38:08 +00:00
Mike Kaply
f942640d37 Bug 1845470 - Prevent the mousewheel from scrolling outside of tab list. r=kcochrane,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185953
 2023-08-15 13:37:05 +00:00
Jonathan Sudiaman
c764e564b8 Bug 1828669 - Dedupe URLs in the history view r=mkaply 
In Firefox View, remove duplicate history visits per container. When sorting by date, a container is a single day. When sorting by site, a container is a single host (which, in this case, effectively means that //every// single visit listed must have a unique URL).

We want to get a bit smarter about determining which visits are "duplicates". This is a bit more involved than simply comparing exact URLs. [This doc](https://docs.google.com/document/d/1t13dAW6yMyxKys2Emthe0tZE1Q9j-CTsjRb2fa-LNL0/edit?usp=sharing) explains in further detail, but the summary is that visits should be considered duplicates **if multiple documents have the same title, but have the same base URL (URL possibly without query (?) or fragment (#))**.

SQL is leveraged a bit to handle the straightforward case, i.e. matching exact URL. Frontend is used to further dedupe by "Base URL" + document title.

Some of the caching in `FirefoxViewPlacesQuery` was replaced in favor of getters which utilize existing caches from the base class. Perhaps there's no need for this extension class, will consider refactoring in the future.

https://treeherder.mozilla.org/jobs?repo=try&revision=d8f618ad7c16f3254e871b53725cf039f85d6bc3

Differential Revision: https://phabricator.services.mozilla.com/D185315
 2023-08-14 22:27:26 +00:00
Mike Kaply
d06bcbd086 Bug 1846302 - Remove unnecessary code to fix CSP error and add a null check. r=jsudiaman,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D185929
 2023-08-14 18:07:33 +00:00
Sarah Clements
624c9599b0 Bug 1831141 - Add more menu to open tabs r=fxview-reviewers,fluent-reviewers,flod,kcochrane 
* Add more menu with a subset of menu items, more to come
* Change fluent strings to include url on hover

Differential Revision: https://phabricator.services.mozilla.com/D184612
 2023-08-14 13:50:17 +00:00
Mike Kaply
1b238acfd1 Bug 1845476 - Add a minimum width for content in view. r=jsudiaman,desktop-theme-reviewers,dao,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185956
 2023-08-14 12:39:46 +00:00
Mike Kaply
1981bb9d4c Bug 1846597 - Use proper semantic styling for headers in view. r=jsudiaman,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185612
 2023-08-11 14:03:36 +00:00