Commit graph

40 commits

Author SHA1 Message Date
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Jared Wein
2ad00e3d21 Bug 1408135 - Copy URL confirmation message should appear where user selects it. r=mikedeboer
MozReview-Commit-ID: 99hEGe7Dtgf

--HG--
extra : rebase_source : c84918920ca2791940d4daeec12cf86c2c04c1c2
2017-10-19 11:58:53 -04:00
Henrik Adolfsson
9fec5a40e2 Bug 1392536 - Add last sync date as tooltip to send to device tab
MozReview-Commit-ID: BsCoBJXm10B
2017-10-10 13:50:28 -04:00
Drew Willcoxon
9100f68edc Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs
MozReview-Commit-ID: KQVOUJUOfrx

--HG--
extra : rebase_source : 07e77c7835286c78789fc6c6ff553ae475f26e5e
2017-10-05 13:03:44 -07:00
Drew Willcoxon
91dcf7e9cf Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs
MozReview-Commit-ID: H6BtvGNtMmQ

--HG--
extra : rebase_source : ac0bc23ebe47d9b5669036a56e0b6e39e7994ff7
2017-10-05 12:45:15 -07:00
Gijs Kruitbosch
8dea08a240 Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw

--HG--
extra : rebase_source : 0921854ff6d1110a35bb225d946cea3caa2ae3c1
2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
c6ffe22372 Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169
MozReview-Commit-ID: E52TGDLgjCC

--HG--
extra : rebase_source : 9a370490ec927bde37468295c1fb4415aa6e0212
2017-09-20 17:32:11 +01:00
Drew Willcoxon
2fa9f06a0b Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs
MozReview-Commit-ID: JMviXx5ov7F

--HG--
extra : rebase_source : b205b0ae9d0e4eb7ed34b912f62e28fb2e2f9467
2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
49a325326c Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw
MozReview-Commit-ID: 7QrhAB79yNw

--HG--
extra : rebase_source : 90c3715259271bf9cb34b635ca8348acd020c51c
2017-09-19 15:13:25 +01:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Drew Willcoxon
67fd8c9838 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs
MozReview-Commit-ID: 6pVlr9d0crn

--HG--
extra : rebase_source : 0f83a8ea8ada71bc6ce88859d09fc93460abafa3
2017-09-07 16:44:34 -07:00
Drew Willcoxon
7fb6175d88 Bug 1396053 - Page action urlbar button ordering can get messed up for new windows. r=Gijs
MozReview-Commit-ID: 1KwrS6tsnhO

--HG--
extra : rebase_source : 05f4a7e485757ca72fb56a1116e271ad3d6241bf
2017-09-04 23:58:27 -07:00
Drew Willcoxon
e8a1dadbb5 Bug 1395410 - Page action notifications should be anchored on relevant urlbar button, not main button, if present. r=jaws
MozReview-Commit-ID: iFM0cR7zFi

--HG--
extra : rebase_source : b8d30a126227a190723ff77021ae8eea3c2c22e3
2017-08-31 15:48:19 -07:00
Drew Willcoxon
d19cdf7b3d Bug 1395154 - If Send Page to Device pageAction is Pinned, it should dismiss when a user sends a tab. r=jaws
MozReview-Commit-ID: HkuzOOp8PDP

--HG--
extra : rebase_source : 48f4d06016129b21c0731b9cd751c57f38030161
2017-08-31 15:27:22 -07:00
Drew Willcoxon
ea66c1176b Bug 1395398 - Send to Device notification shouldn't appear after clicking "Sign in" and other non-device menu items. r=jaws
MozReview-Commit-ID: Gm35IfZCJPQ

--HG--
extra : rebase_source : c321d66c4cd903ff094f6bde3ad48535d33bf144
2017-08-31 09:38:37 -07:00
Drew Willcoxon
1f60dd6d1c Bug 1395178 - The new buttons that can be added to the toolbar don't announce themselves to screen readers as buttons. r=jaws
MozReview-Commit-ID: AvQD9Z9ySfu

--HG--
extra : rebase_source : 27b79ef79f6c2ecad8a8258245123b9dad94e7c5
2017-08-30 13:29:54 -07:00
Jared Wein
7764962be9 Bug 1395194 - Copy URL confirmation should fade out at timeout. r=adw
MozReview-Commit-ID: DTrzSOaft3N

--HG--
extra : rebase_source : 17ccd2d6a2f6861b6554be77b381aab60eabcfa0
2017-08-30 16:23:05 -04:00
Jared Wein
b67ac2b7fd Bug 1387042 - Add a toast notification that will be shown when the Copy Link or Send to Device page actions are used. r=adw,sfoster
MozReview-Commit-ID: CZZnLz84T4h

--HG--
extra : rebase_source : bee7806ee6886dbbeefc7bc7ed39cc075fca1590
2017-08-24 16:44:11 -04:00
Drew Willcoxon
73ad0ddaf3 Bug 1388835 - Hide page action urlbar buttons on about pages (about:preferences, etc.). r=Gijs
MozReview-Commit-ID: 9lid8VpPkJE

--HG--
extra : rebase_source : b57a37788f20345750d8daa5f73011bf6fac1ef8
2017-08-26 12:47:33 -07:00
Gijs Kruitbosch
0a10556def Bug 1391705 - don't show context menu except on toolbarbuttons on the main view, r=adw
MozReview-Commit-ID: GkGXAIrP15u

--HG--
extra : rebase_source : f089a365490238992f22db869cb19f3ccca2587c
2017-08-23 13:29:47 +01:00
Drew Willcoxon
ccec56a9ab Bug 1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X. r=Gijs
MozReview-Commit-ID: 6EdRRjsQLga

--HG--
extra : rebase_source : a6e4d080b0776e8b4c33d692ba9c3d99e3fc1c79
2017-08-18 12:48:01 -07:00
Drew Willcoxon
e3ddbef6f2 Bug 1391082 - Page action panel ordering can get messed up. r=Gijs
MozReview-Commit-ID: 3hQLTLF3RU8

--HG--
extra : rebase_source : 7ed94560c20882ac85114df80d50221eb0e2b172
2017-08-17 16:40:35 -07:00
Gijs Kruitbosch
f66567c39c Bug 1366327 - deal with about:reader, IDNA and non-exposable URIs better for copy/email link, r=adw
MozReview-Commit-ID: AnZa3mq2zMY

--HG--
extra : rebase_source : b35026f864c6d45856fb02b90e91b3a06b1a0ec0
2017-08-17 13:11:06 +01:00
Drew Willcoxon
3c27aee62b Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV

--HG--
extra : rebase_source : f87650ab8c09f7a313cda9b7ec73ee1e20d6fe34
2017-08-16 10:13:15 -07:00
Dão Gottwald
e2259fbc44 Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs
MozReview-Commit-ID: 980Rvv8mxtU
2017-08-14 16:45:17 +02:00
Sebastian Hengst
57f655f77a Backed out changeset c73631b194bb (bug 1389740) for failing Firefox-UI's test_windows.py and test_about_private_browsing.py. r=backout 2017-08-12 18:42:57 +02:00
Dão Gottwald
ad2ba7b0b1 Bug 1389740 - Consolidate URL bar history dropmarker styling. r=Gijs
The dropmarker gets the urlbar-icon class for consistency with the other URL bar icons. On this occasion, I increased the urlbar-icon padding and removed the margin to match the photon spec. Also added a rudimentary hover effect.

#urlbar-icons is renamed to #page-action-buttons to better reflect its meaning, and because .urlbar-icon is now used outside of this container.

#urlbar-wrapper wrapper isn't needed anymore -- we can just set the switchingtabs attribute directly on #urlbar.

MozReview-Commit-ID: EiuUW71IKgU

--HG--
extra : rebase_source : dcc7753e92073e06278d714a0b5b976d073e75c8
2017-08-12 17:49:35 +02:00
Jared Wein
baaaed0eec Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : e862c01c1d71165ccd5d0932299c7f1fbdebe659
2017-08-08 11:56:49 -04:00
Wes Kocher
3c7cc8f012 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout
MozReview-Commit-ID: kEMoucDCJY
2017-08-10 15:46:38 -07:00
Jared Wein
8880224f6b Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : bef396788013f8ed60d72b01bf59e34e01d36209
2017-08-08 11:56:49 -04:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Fischer.json
d6ba3d20ff Bug 1382579 - Part 1: Update the BrowserPageActions API for the UITour's usage, r=adw,Gijs
- adds `showPanel` so UITour could call it to open the page action panel

- makes clicking page action button on the urlbar would toggle the panel. This is for the case, when UITour opens the page action panel to highlight a button it would set "noautohide" to let the panel persistently opened. But we still need a way to let user able to close the panel so made this change. The PanelUI is doing the same thing [1]. UITour wuold remove "noautohide" on the panelHidden event [2].

[1] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/browser/components/customizableui/content/panelUI.js#246
[2] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/browser/components/uitour/UITour.jsm#1483

MozReview-Commit-ID: FtJZZ0bfy61

--HG--
extra : rebase_source : e986dc4cb50a4a72fdebb69a5182f029d7f327bb
2017-08-01 12:09:25 +08:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Drew Willcoxon
8626ed5a44 Bug 1363188 - Add an add/remove context menu to page actions in the urlbar. r=Gijs
MozReview-Commit-ID: 5rJWvID5OPd

--HG--
extra : rebase_source : 6074725a6136dcc674b2d09abed461dc7134536a
2017-08-02 09:31:07 -07:00
Drew Willcoxon
be54613bde Bug 1386337 - Disable Photon page actions when Photon is not enabled. r=Gijs
MozReview-Commit-ID: 3GrsscIxeyW

--HG--
extra : rebase_source : c227aa7c300d533b07d5776bb9cef758ee605c07
2017-08-01 20:37:22 -07:00
Drew Willcoxon
bafcf94652 Bug 1374477 - Add a new test for Photon page actions, along with some related code changes. r=Gijs
MozReview-Commit-ID: ADaEnEiGFvX

--HG--
extra : rebase_source : 0c7e8b3d5244eb9c3def5dac0c9a2bf3b830f4f7
2017-07-29 20:25:14 -07:00
Drew Willcoxon
6f9f704b57 Bug 1374477 - Add browser-pageActions.js for Photon page actions. r=Gijs
MozReview-Commit-ID: DUl7WlSnk4k

--HG--
extra : rebase_source : 2f7f39fc30216f330a1488c574cad856189fbe8d
2017-07-29 20:24:58 -07:00