Commit graph

41 commits

Author SHA1 Message Date
Johann Hofmann
5343085d4c Bug 1522565 - Add sub-panels for cryptominers and fingerprinters in the identity popup. r=nhnt11
This is mostly a lot of boilerplate based off the trackers category/subpanels.

I would like to do some code-de-duplication, especially in browser-contentblocking,
but I figured it would be a good idea to leave that to a different bug to not obstruct
the feature from landing :)

Differential Revision: https://phabricator.services.mozilla.com/D18826

--HG--
extra : rebase_source : d0fb21c5a42cf16dfe6b185806575f09e9a9f1a5
2019-02-06 14:11:39 +01:00
ui.manish
040b50d17f Bug 1497827 - Do not display EV labels instead of domains in site identity header r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D18013

--HG--
extra : moz-landing-system : lando
2019-02-05 09:29:50 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Dorel Luca
cc75d50ac9 Backed out 2 changesets (bug 1520436) for browser-chrome failures in browser/base/content/test/permissions/browser_permissions.js
Backed out changeset 031aee32565c (bug 1520436)
Backed out changeset 1428560105ca (bug 1520436)
2019-01-23 19:35:50 +02:00
alwu
b15aaa43f8 Bug 1520436 - part1 : add another tooltip text for non-promptable permission. r=flod,johannh
As non-promptable permission won't prompt user to ask for their approval, we should use different texts for the cancel button of promptable permissions.

Differential Revision: https://phabricator.services.mozilla.com/D16770

--HG--
extra : moz-landing-system : lando
2019-01-23 16:21:48 +00:00
Ehsan Akhgari
2494d88b1d Bug 1521598 - Part 2: Only update the identity panel for permissions that are visible inside it; r=johannh
Profiles show that we do a lot of needless work in response to notifications for
other permissions such as "storageAccessAPI".

Depends on D17362

Differential Revision: https://phabricator.services.mozilla.com/D17155

--HG--
extra : moz-landing-system : lando
2019-01-23 15:57:10 +00:00
shindli
42595cea0a Backed out 2 changesets (bug 1520436) for TV failures in browser/base/content/test/permissions/browser_permissions.js CLOSED TREE
Backed out changeset 4752a33b4c3a (bug 1520436)
Backed out changeset 10716b2122dc (bug 1520436)
2019-01-23 03:20:13 +02:00
alwu
db9dcd21c8 Bug 1520436 - part1 : add another tooltip text for non-promptable permission. r=flod,johannh
As non-promptable permission won't prompt user to ask for their approval, we should use different texts for the cancel button of promptable permissions.

Differential Revision: https://phabricator.services.mozilla.com/D16770

--HG--
extra : moz-landing-system : lando
2019-01-18 18:54:54 +00:00
Dale Harvey
d13fedb2c6 Bug 1517526 - Let user allow blocked autoplay. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D17130

--HG--
extra : moz-landing-system : lando
2019-01-22 21:48:24 +00:00
Razvan Maries
fa4b84c9fe Backed out changeset 1e7c60e83b86 (bug 1497827) for perma failing at testing/firefox-ui/tests/functional/security/test_ev_certificate.py. CLOSED TREE
--HG--
extra : amend_source : 1ba59ecab75f0caf4fbf0edeae049cc487e8a631
2019-01-16 11:56:11 +02:00
ui.manish
0ebacc9129 Bug 1497827 Do not display EV labels instead of domains in site identity header r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16508

--HG--
extra : moz-landing-system : lando
2019-01-15 10:12:50 +00:00
Dale Harvey
d9d954478b Bug 1488946 - Remove about:searchreset. r=mkaply, r=flod
Tags: #secure-revision

Differential Revision: https://phabricator.services.mozilla.com/D14416
2018-12-14 10:01:51 +00:00
Ehsan Akhgari
cc714b7adc Bug 1490811 - Part 1: Add a permission doorhanger for the storage access API r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D12467

--HG--
extra : moz-landing-system : lando
2018-11-26 21:23:16 +00:00
Dão Gottwald
12feb645b8 Bug 1508963 - Load browser-siteIdentity.js lazily. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D12521

--HG--
extra : moz-landing-system : lando
2018-11-21 17:09:23 +00:00
Ehsan Akhgari
b7c63fa061 Bug 1507353 - Convert the accesses to security.insecure_connection_*.* prefs into lazy getters r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D11968

--HG--
extra : moz-landing-system : lando
2018-11-20 20:04:14 +00:00
James Teh
382c02eef0 Bug 1506503: PanelMultiView: Automatically focus the first item if a panel is opened via the keyboard. r=johannh,paolo
Previously, we had specific code to do this for the "View site information" button (#identity-box) when activated via the keyboard.
To work well for keyboard and screen reader users, all such popups (e.g. Firefox menu, Page Actions, etc.) should do this.
These are all based on panelMultiView.
The arguments passed to PanelMultiView.openPopup can include the event which triggered the popup.
We now use this to detect keypress events and focus the first item in the panel in that case.

Differential Revision: https://phabricator.services.mozilla.com/D11605

--HG--
extra : moz-landing-system : lando
2018-11-16 22:51:59 +00:00
Johann Hofmann
260c7f5bf4 Bug 1484251 - Part 3 - Use Telemetry events to record interactions in the identity popup. r=Gijs
This removes the old TRACKING_PROTECTION_EVENTS probe and replaces it with new
Telemetry events that record basic user interaction in the identity popup.

We are now measuring interaction with more elements than before, not just block/unblock.

We're also dropping the old way of measuring updates to onSecurityChange,
since with the recent changes to content blocking it would just record most page loads.

Differential Revision: https://phabricator.services.mozilla.com/D6895

--HG--
extra : moz-landing-system : lando
2018-10-11 13:13:58 +00:00
Johann Hofmann
3b6d09a99f Bug 1476220 - Show a "site information" header in the identity popup. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D7090

--HG--
extra : moz-landing-system : lando
2018-10-09 13:47:13 +00:00
Narcis Beleuzu
e824cdada7 Backed out changeset 015250ccee42 (bug 1476220) for causing en-US failures on identity-popup-host 2018-10-09 13:07:09 +03:00
Johann Hofmann
79c5839764 Bug 1476220 - Show a "site information" header in the identity popup. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D7090

--HG--
extra : moz-landing-system : lando
2018-10-09 09:11:01 +00:00
Dipen Patel
aeed887ff8 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704

--HG--
extra : moz-landing-system : lando
2018-09-11 00:07:30 +00:00
Csoregi Natalia
0400fe7b57 Backed out changeset bd8baf88f373 (bug 1468222) for test_security-info-parser.js failures. CLOSED TREE 2018-09-08 03:16:25 +03:00
Dipen Patel
0679e09a9a Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704

--HG--
extra : moz-landing-system : lando
2018-09-07 22:50:17 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Dale Harvey
59e904f6cd Bug 1476555 - Show notification when autoplay blocked globally. r=cpearce,johannh
MozReview-Commit-ID: EI0GiaoBNqX

--HG--
extra : rebase_source : 0c6fb98047913fc50423532cc4c433c4627c5b06
2018-07-23 16:43:08 +01:00
Paolo Amadini
c140ab38d1 Bug 1480082 - Remove broadcasters from the identity panel. r=johannh
MozReview-Commit-ID: DOBK86SAs3q

--HG--
extra : rebase_source : 8ce16ff641f77e25d91e196a02a1ea26c5cb2717
2018-08-01 13:51:39 +01:00
Dave Townsend
389a969138 Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489

--HG--
extra : moz-landing-system : lando
2018-07-31 19:13:38 +00:00
Paolo Amadini
7328341032 Bug 1473748 - Part 1 - Use the type of element instead of the "subviewbutton" and "subviewkeynav" classes to initialize the list of navigable elements. r=johannh
MozReview-Commit-ID: IgxwGRNLsct

--HG--
extra : rebase_source : edc897a0c0ac7a8b7b551759a8d69b7c3d3659d5
2018-07-26 14:58:43 +01:00
Dipen Patel
7641beb1f8 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : 9c400bed3c9d29a186fc987c9bd0ffceb37bfd94
2018-07-13 11:48:55 -07:00
Andreea Pavel
d0f6470c17 Backed out changeset c235d6f86c22 (bug 1475647) for breaking firefox ui at testing/firefox-ui/tests/puppeteer/test_tabbar.py on a CLOSED TREE 2018-07-25 19:34:58 +03:00
Dipen Patel
8670057dd5 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : fbfbcf7608efbfb35c9be4018ff0f4e70b2768d2
2018-07-13 11:48:55 -07:00
shindli
70ab23ecd2 Backed out changeset d126a6593e8f (bug 1475647) for mozmake.exe bustage on a CLOSED TREE 2018-07-24 02:55:53 +03:00
Dipen Patel
b0259a189f Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : b15f75e39d04c8485b4eb63416fd1f1e4175fafe
2018-07-13 11:48:55 -07:00
Johann Hofmann
e7b9853987 Bug 1467385 - Use PanelMultiView APIs for keyboard navigation in the identity popup. r=Paolo
PanelMultiView has its own concept of "selected", so we should use this rather than move focus
using advanceFocusIntoSubTree.

MozReview-Commit-ID: DW2JqqggLl1

--HG--
extra : rebase_source : ec7a6f83fdda176f3286cf4395dc72de6cad2466
2018-07-02 14:34:25 +02:00
James Teh
33c82e5cba Bug 1473200: Provide accessibility context for permission controls in the identity popup. r=johannh
The containers are given an ARIA role of group and labels are associated using aria-labelledby.
For example, this allows screen reader users to know which permission each control is associated with.
Otherwise, they might hear only "Clear this permission and ask again  button", with no knowledge of what the permission is.

MozReview-Commit-ID: LeiOmz6go9l

--HG--
extra : rebase_source : 66920efd9d0f72375561c5b10d4bbd765306abf1
2018-07-04 12:13:51 +10:00
James Teh
4a18ee1601 Bug 1473199: Make permission controls tabbable again in the identity popup. r=johannh
Now that the PanelMultiView keyboard navigation code is being used for the identity popup, these need a class of subviewkeynav in order to be tabbable.

MozReview-Commit-ID: 47drdy78s4F

--HG--
extra : rebase_source : 963eca07939e5f0ce808f72262bc8f2dbe353f18
2018-07-04 12:24:40 +10:00
Dale Harvey
4696947f19 Bug 1461656 - Ask permission when site wants to autoplay media. r=flod,johannh
MozReview-Commit-ID: Fc2IUZK90eu

--HG--
extra : rebase_source : 197ea2f48d6ad07cf1cf3c0b572121bbb3d69252
2018-05-18 12:54:33 +01:00
Johann Hofmann
d34f805778 Bug 1462471 - Link to permission preferences from the identity popup permissions section. r=prathiksha
MozReview-Commit-ID: 4XNBfztgWOG

--HG--
extra : rebase_source : 713003dcc2e35aba0283797e96fe13559990d744
2018-06-01 23:17:52 +02:00
Johann Hofmann
f277f6146c Bug 1462469 - Add a "Clear Cookies and Site Data" footer button to the identity popup. r=nhnt11
This implements a new button in the identity popup that allows users to quickly
remove cookies and site data from the sites they're visiting.

This uses the SiteDataManager behind the scenes and is similar to the changes
we made for PageInfo already.

There's a major drawback to this approach in that SiteDataManager needs to
refresh its entire data set everytime we want information about a single site
or want to remove anything (it's not trivial to get rid of that limitation while
dealing with all the quirks of our storage APIs). I will work around this by
implementing a way for SiteDataManager to incrementally update itself in bug 1460768.

MozReview-Commit-ID: Iy7ia0KllFq

--HG--
extra : rebase_source : a36e0e7049c5892464d91ad42c3bf523dd5013f9
2018-05-18 11:36:15 +02:00
Andrew Swan
68d8f5e967 Bug 1331521 Remove about:newaddon r=kmag
MozReview-Commit-ID: 6OFXGYEmSmy

--HG--
extra : rebase_source : 80ee72c190a2b2d06b895ad5bda22cc9b5849b01
2018-04-16 14:11:10 -07:00
Prathiksha
37f7945106 Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js). r=johannh
MozReview-Commit-ID: CsOzYthmrgl

--HG--
rename : browser/base/content/browser.js => browser/base/content/browser-siteIdentity.js
extra : rebase_source : c531999d7713e7b6731a725ab909b707578488e2
2018-03-29 19:21:50 +05:30