Commit graph

14 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Brendan Dahl
9f9ae1e187 Bug 1443971 - Remove allDownloadsViewOverlay.xul. r=Paolo
This overlay was used in two places: places.xul and
contentAreaDownloadsView.xul. Move the commandset, menuppop and
downloadsRichListBox into include files. Inline the scripts and
DTDs.

MozReview-Commit-ID: LroiQlRTE2T

--HG--
rename : browser/components/downloads/content/allDownloadsViewOverlay.js => browser/components/downloads/content/allDownloadsView.js
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsCommands.inc.xul
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsContextMenu.inc.xul
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsRichListBox.inc.xul
rename : browser/themes/linux/downloads/allDownloadsViewOverlay.css => browser/themes/linux/downloads/allDownloadsView.css
rename : browser/themes/osx/downloads/allDownloadsViewOverlay.css => browser/themes/osx/downloads/allDownloadsView.css
rename : browser/themes/shared/downloads/allDownloadsViewOverlay.inc.css => browser/themes/shared/downloads/allDownloadsView.inc.css
rename : browser/themes/windows/downloads/allDownloadsViewOverlay.css => browser/themes/windows/downloads/allDownloadsView.css
extra : rebase_source : 978d2ddd1e177374b0fc354ca46f11bfc447fe59
2018-03-19 16:21:50 -07:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Yiren Wang
5f88f7294a Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
Nicholas Parmar
619d5103d0 Bug 842356 - Set focus to downloads list box in about:downloads page on page load if list not empty, and made background and focus ring transparent if list empty. r=mak 2015-11-11 21:18:00 +01:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Ehsan Akhgari
157be033a5 Bug 1192120 - Fix warnings that show up when opening the downloads window in private browsing mode; r=mconley 2015-08-07 18:32:10 -04:00
Paolo Amadini
d4c5c8ca0b Bug 1115364 - Downloads Panel code style refresh. r=jaws 2014-12-29 12:35:27 +00:00
Ehsan Akhgari
59f4bde62f Bug 825295 - Do not display the Places downloads in the in-content download views opened in private windows; r=Mano 2012-12-29 15:23:48 -05:00
Asaf Romano
4ac27e8335 Bug 815352 (Part 2) - Add a stub view to implement in-content downloads.
r=mak
2012-12-20 21:20:18 +01:00