Commit graph

5733 commits

Author SHA1 Message Date
John Schanck
53e2e3ea9b Bug 1831392 - add an excluded WebAuthn credential prompt. r=keeler
Depends on D177944

Differential Revision: https://phabricator.services.mozilla.com/D178113
2023-05-15 23:26:24 +00:00
John Schanck
ecfd04a749 Bug 1828206 - clarify WebAuthn user presence prompts. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D177944
2023-05-15 23:26:24 +00:00
Eemeli Aro
feea556fc5 Bug 1832186 - Migrate popup warning strings to Fluent. r=mconley,fluent-reviewers,flod
The Fluent migration will show a diff for two en-US messages:

- `popup-warning-message` singular variant does not include `{ $popupCount }`, so is more appropriately using `1` rather than `one` as its key.
- `popup-warning-exceeded-message` has only one variant in English, but using the plural selector forces its use for new locales.

Differential Revision: https://phabricator.services.mozilla.com/D177666
2023-05-15 10:52:25 +00:00
Karandeep
3efcb85a15 Bug 1824609 convert consumers of toolkit/components/thumbnails/ to import ES modules directly. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D177197
2023-05-10 20:00:58 +00:00
Brice Laurencin
1c8c333cb5 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-10 10:08:24 +00:00
Stanca Serban
692d727b5e Backed out changeset 50c9a0bea4c6 (bug 1418462) for causing mochitests failures in browser_middleClick.js. CLOSED TREE 2023-05-10 02:50:36 +03:00
John Schanck
8b761c0a6d Bug 1831394 - omit the retries left counter from the invalid PIN prompt when it is large. r=keeler,fluent-reviewers,flod
The PIN for a user's security key will be temporarily blocked after three
failed PIN entry attempts, but the "retries left" counter in the invalid PIN
prompt is the (typically larger) number of attempts left before the PIN is
permanently blocked. This patch makes it so that the retries left counter is
only shown when it is equal to 1, 2, or 3.

Differential Revision: https://phabricator.services.mozilla.com/D177294
2023-05-09 21:29:37 +00:00
Jonathan Sudiaman
a911f374bc Bug 1820979 - Remove instant apply bookmarks panels code r=mak
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
2023-05-09 21:03:19 +00:00
Brice Laurencin
3bdbccf607 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-09 20:50:04 +00:00
Katherine Patenio
485f34bf93 Bug 1830421 - convert CustomizableWidgets, CustomizeMode, DragPositionManager and SearchWidgetTracker in browser/components/customizableui to ESMs r=Standard8,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D176825
2023-05-03 18:05:26 +00:00
John Schanck
92fb6d7ad4 Bug 1830944 - vendor authenticator-rs v0.4.0-alpha14. r=keeler,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176938
2023-05-03 16:37:45 +00:00
Alexandre Lissy
2f64b53c68 Bug 1830251 - Remove unused leftover PluginCrashReporter reference r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D175858
2023-04-27 10:07:59 +00:00
Dão Gottwald
bee9890293 Bug 1828935 - Bump up conformation hint duration to improve a11y. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D175909
2023-04-20 11:58:39 +00:00
Bilal
5379509f30 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175700
2023-04-19 19:18:57 +00:00
Abhishek Tiwari
a0830c7eed Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu
Differential Revision: https://phabricator.services.mozilla.com/D172245
2023-04-12 17:32:30 +00:00
Greg Tatum
2d5cb34041 Bug 1826437 - Implement the full page translations panel; r=nordzilla,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174682
2023-04-12 16:13:24 +00:00
Ebilite Uchenna
8c931cb313 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D174446
2023-04-11 19:06:24 +00:00
Ed Lee
583cdaf897 Bug 1826920 - Remove/graduate experimentation capability for about:welcome skipFocus r=pdahiya
Experimentation confirmed years ago that about:welcome shoudln't be treated as blank for urlbar focus, and no need for additional experimentation. Also fix a bug where about:welcome was treated as a blank/empty page resulting in about:preferences incorrectly replacing it.

Differential Revision: https://phabricator.services.mozilla.com/D174940
2023-04-07 14:28:09 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
Bilal
3a0a9908fa Bug 1816994 - ESMified UITour JSMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D173571
2023-03-29 17:32:27 +00:00
Greg Tatum
944d80a008 Bug 1820229 - Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel
This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.

Differential Revision: https://phabricator.services.mozilla.com/D173196
2023-03-24 18:27:30 +00:00
Butkovits Atila
137691f3bf Backed out 12 changesets (bug 1813781, bug 1815343, bug 1820229, bug 1823925, bug 1813779, bug 1823702) for causing failures at browser_full_page.js. CLOSED TREE
Backed out changeset 841d7b8b856b (bug 1823925)
Backed out changeset a62d77bfac0b (bug 1823925)
Backed out changeset 2590940e3b67 (bug 1815343)
Backed out changeset 807a38bb5ad4 (bug 1813781)
Backed out changeset b1d2cbba17a2 (bug 1813781)
Backed out changeset e83c3f386ef1 (bug 1813781)
Backed out changeset 18cf612336be (bug 1820229)
Backed out changeset d3ae326dcdf7 (bug 1820229)
Backed out changeset 793ba36c54b5 (bug 1813779)
Backed out changeset bbf9177668dc (bug 1823702)
Backed out changeset 1cc80a5cbcdb (bug 1823702)
Backed out changeset 22a87b7171d4 (bug 1823702)
2023-03-24 06:36:15 +02:00
Greg Tatum
5fbf34f20b Bug 1820229 - Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel
This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.

Differential Revision: https://phabricator.services.mozilla.com/D173196
2023-03-23 22:00:36 +00:00
Mark Banner
4ff8f9cf26 Bug 1823763 - Convert consumers of toolkit/components/reader/ to import ES modules directly. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173184
2023-03-23 12:11:44 +00:00
Niklas Baumgardner
39d1882677 Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D170899
2023-03-22 19:22:44 +00:00
James Teow
34cbd31c4c Bug 1815971 - Count number of times persisted search is viewed and reverted due to Popups - r=adw
Differential Revision: https://phabricator.services.mozilla.com/D172690
2023-03-22 13:59:06 +00:00
Csoregi Natalia
07dc85057a Backed out changeset 31492838d6cb (bug 1811318) for failures on browser_urlbar_toggle.js. CLOSED TREE 2023-03-22 12:26:32 +02:00
Niklas Baumgardner
afd2db475b Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D170899
2023-03-21 16:26:05 +00:00
Cristina Horotan
dd2fe65d79 Backed out changeset 1eee1fa2d9dd (bug 1811318) for causing bc failures at browser_preferences_usage.js CLOSED TREE 2023-03-21 16:31:56 +02:00
Niklas Baumgardner
d7b26c11fa Bug 1811318 - Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D170899
2023-03-21 12:55:18 +00:00
Barret Rennie
f004218156 Bug 1818738 - Make the feature update event API more ergonomic r=aminomancer,settings-reviewers,search-reviewers,Gijs,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D172035
2023-03-16 22:20:14 +00:00
John Schanck
f40aea4a99 Bug 1813982 - XPCOM interface to authenticator-rs. r=keeler,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D171269
2023-03-16 21:42:21 +00:00
William Durand
266814d72f Bug 1821288 - Remove "addon-install-complete" event. r=rpl
This is not used anymore.

Differential Revision: https://phabricator.services.mozilla.com/D172102
2023-03-15 17:37:42 +00:00
Francesco Lodolo (:flod)
962126e608 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Mark Banner
4b26aa84d7 Bug 1821898 - Remove RFPHelper definition from the browser window, import where used. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D172374
2023-03-14 15:45:55 +00:00
James Teow
4feaf446ef Bug 1815769 - Add optional anchor lookup to PopupNotifications - r=Gijs,adw
Differential Revision: https://phabricator.services.mozilla.com/D169814
2023-03-14 14:29:58 +00:00
Gijs Kruitbosch
c20f7ae2a1 Bug 1718082 - make updating apptab and usercontext information solely tabbrowser's responsibility, r=mconley
I'm removing the apptab bits completely in one of the later commits,
but trying to keep this modular so it's easy to figure out regressions,
should there be any.

Differential Revision: https://phabricator.services.mozilla.com/D171411
2023-03-13 17:32:07 +00:00
Gijs Kruitbosch
65dba4bcc4 Bug 1718082 - move listening to initial paint in a browser content window into the parent process, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D171409
2023-03-13 17:32:06 +00:00
Emilio Cobos Álvarez
566f0c7a63 Bug 1821657 - Remove BrowserUIUtils.setToolbarButtonHeightProperty and related code. r=Gijs,desktop-theme-reviewers,dao
I don't see any visible issue on the reload / stop buttons without this.

Differential Revision: https://phabricator.services.mozilla.com/D172238
2023-03-13 11:56:55 +00:00
DJ
f08805f5f4 Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172158
2023-03-10 14:24:32 +00:00
Iulian Moraru
983c039377 Backed out changeset eed7574265d1 (bug 1816980) for causing bc failures on browser_sma_enable_cbh.js. CLOSED TREE 2023-03-09 23:18:28 +02:00
DJ
0b9f64694e Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172158
2023-03-09 18:58:28 +00:00
Mike Conley
a8027d5fb7 Bug 1423125 - Restore previous session if undoCloseTab is called with no more tabs to restore. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D171377
2023-03-03 14:06:43 +00:00
Gijs Kruitbosch
7d2645b5a6 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D170544
2023-02-24 21:09:36 +00:00
Cristian Tuns
55c2060892 Backed out 4 changesets (bug 1818026) for causing build bustages on Loader.cpp CLOSED TREE
Backed out changeset 31e30c051015 (bug 1818026)
Backed out changeset 1fbedd7a8a26 (bug 1818026)
Backed out changeset a5be1aaa8f65 (bug 1818026)
Backed out changeset 1976d91a52b2 (bug 1818026)
2023-02-24 14:32:44 -05:00
Gijs Kruitbosch
d7287b5cd7 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D170544
2023-02-24 17:57:04 +00:00
Cosmin Sabou
fd67d5ee44 Backed out 3 changesets (bug 1818026) for causing mochitest plain failures on test_SVGStyleElement.xhtml.
Backed out changeset 808a73bbb614 (bug 1818026)
Backed out changeset 9b7dbaeb6deb (bug 1818026)
Backed out changeset 62e5f2fd2775 (bug 1818026)
2023-02-24 16:08:12 +02:00
Gijs Kruitbosch
e36520f140 Bug 1818026 - move gPageStyleMenu to its own file, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D170544
2023-02-24 09:07:46 +00:00
Gijs Kruitbosch
3e5d710873 Bug 1817443 - move url loading method implementations from utilityOverlay.js into their own helper module, r=mossop
openLinkIn would really benefit from being split up a bit, and adding more
globals to the browser window is icky. Also, the story for opening new tabs if
you're not inside a window is a nightmare right now. Moving this code
to a module is a first step to making that story nicer.

I kept wrappers for all the functions I'm moving, and added the `window` as the
first argument. In the future we can update these functions to support being
called without a `window` ref. The one exception is getTopWin, where I updated
the callers in this patch.

I had to tweak the parameter detection of the different arguments supported by
openUILinkIn because forwarding calls means arguments.length is always larger
than 3... but then also removed it in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D170210
2023-02-23 17:02:43 +00:00
Cristina Horotan
45de4f594f Backed out 5 changesets (bug 1817443) for newtab failure CLOSED TREE
Backed out changeset ba33c510d008 (bug 1817443)
Backed out changeset 07e3bccaeb6d (bug 1817443)
Backed out changeset 2b39dee42948 (bug 1817443)
Backed out changeset a74a52e93af4 (bug 1817443)
Backed out changeset 827855beb033 (bug 1817443)
2023-02-23 17:30:23 +02:00