There have been changes to our Windows infrastructure that cause the
window to be maximized when running tests so the maximize.svg/restore.svg
combination will show restore instead of maximize, though maximize is
still loaded. I think it could be prevented by trying to set the sizemode
attribute a little earlier or not defaulting to maximize in the stylesheet,
but I don't think that's a necessary optimization at this point. We can
just whitelist it.
I also set the intermittentShown flag in case the Windows machines go back
to non-maximized windows.
MozReview-Commit-ID: Gwi0jRBBtGg
--HG--
extra : rebase_source : b92cbd14b873bf8aa0d70e27b140cb0f1a946b74
Also adds a warning that the test should only be used in debug mode.
MozReview-Commit-ID: 6X8jSz5O2ue
--HG--
extra : rebase_source : 30a52bcceeb19648e59c10ad29e1c71ca2e4e427
Also adds a warning that the test should only be used in debug mode.
MozReview-Commit-ID: 6X8jSz5O2ue
--HG--
extra : rebase_source : 67bc022906470695041e37ac1852af1df5b87c90
The dropmarker gets the urlbar-icon class for consistency with the other URL bar icons. On this occasion, I increased the urlbar-icon padding and removed the margin to match the photon spec. Also added a rudimentary hover effect.
#urlbar-icons is renamed to #page-action-buttons to better reflect its meaning, and because .urlbar-icon is now used outside of this container.
#urlbar-wrapper wrapper isn't needed anymore -- we can just set the switchingtabs attribute directly on #urlbar.
MozReview-Commit-ID: EiuUW71IKgU
--HG--
extra : rebase_source : dcc7753e92073e06278d714a0b5b976d073e75c8
This change in markup was necessary to implement bug 1352063. I have audited all other CSS to make sure other selectors looking for this icon still apply. This was the only one found that needed to be updated.
The change to browser_startup_images.js is not actually a new image that is loaded at startup, but a revert of 767224f031ac (bug 1352063) which removed that section (the test failing due to that section no longer applying should have called out what was necessary to fix this bug).
MozReview-Commit-ID: 6O1iUUjJ0dh
--HG--
extra : rebase_source : a3d41391bda3464fa4c6d4f06638dcfbe8daff3f
This was originally removed from the whitelist when bug 1372689 landed. With
Photon enabled, this image doesn't load at all. Instead of trying to debug
the non-Photon case, we're whitelisting this again because Photon is going
out the door in the next release anyways.
MozReview-Commit-ID: DdN38s3oqST
--HG--
extra : rebase_source : 986c338fb8448f26719ecefd7c4a72db19614622
This patch enables startupRecorder.js to collect data on
loaded and shown raster and SVG images on startup via events
from native code. It also adds a test that uses this data
to find images that are unnecessarily loaded.
I've not fixed any of the affected images yet, there's a
fairly comprehensive whitelist that I want to gradually
decrease by opening bugs in the respective components.
MozReview-Commit-ID: 9KqQvKLtZhu
--HG--
extra : rebase_source : 5f75fcd1152f569a5b48e21d4e4821a24f768ecd
This patch enables startupRecorder.js to collect data on
loaded and shown raster and SVG images on startup via events
from native code. It also adds a test that uses this data
to find images that are unnecessarily loaded.
I've not fixed any of the affected images yet, there's a
fairly comprehensive whitelist that I want to gradually
decrease by opening bugs in the respective components.
MozReview-Commit-ID: 9KqQvKLtZhu
--HG--
extra : rebase_source : 856f06320c78ed88c4578fce985b2a526566e825
This patch enables startupRecorder.js to collect data on
loaded and shown raster and SVG images on startup via events
from native code. It also adds a test that uses this data
to find images that are unnecessarily loaded.
I've not fixed any of the affected images yet, there's a
fairly comprehensive whitelist that I want to gradually
decrease by opening bugs in the respective components.
MozReview-Commit-ID: 9KqQvKLtZhu
--HG--
extra : rebase_source : 345066e07855bc49975393ec401553981e1138b3
This patch enables startupRecorder.js to collect data on
loaded and shown raster and SVG images on startup via events
from native code. It also adds a test that uses this data
to find images that are unnecessarily loaded.
I've not fixed any of the affected images yet, there's a
fairly comprehensive whitelist that I want to gradually
decrease by opening bugs in the respective components.
MozReview-Commit-ID: 9KqQvKLtZhu
--HG--
extra : rebase_source : fb118db362259a1ff32488868e8238b03638f40f
