Commit graph

128 commits

Author SHA1 Message Date
Christoph Kerschbaumer
54df1cb98c Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Jonathan Kingston
3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Kris Maglione
eb14dd1d2c Bug 1478124: Part 8b - Update DocShell module to use a static component manifest. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D15040

--HG--
extra : rebase_source : d89ac470241cb6f6a43c29c6e90b1c0e4fc78028
extra : source : b0444e0bc801f828b49f9953a73498cf5ff5024b
2018-12-16 17:27:58 -08:00
arthur.iakab
c1fae83952 Backed out 16 changesets (bug 1478124) for failing android geckoview-junit CLOSED TREE
Backed out changeset fce62c77a56b (bug 1478124)
Backed out changeset eb2fa3b5edf7 (bug 1478124)
Backed out changeset 8dacce59fcc0 (bug 1478124)
Backed out changeset 012fd0107204 (bug 1478124)
Backed out changeset 496aaf774697 (bug 1478124)
Backed out changeset 21f4fda03159 (bug 1478124)
Backed out changeset b0444e0bc801 (bug 1478124)
Backed out changeset d94039b19943 (bug 1478124)
Backed out changeset 5d85deac61c2 (bug 1478124)
Backed out changeset 929fd654c9df (bug 1478124)
Backed out changeset 1ddd80d9e91a (bug 1478124)
Backed out changeset b8d2dfdfc324 (bug 1478124)
Backed out changeset f500020a273a (bug 1478124)
Backed out changeset dd00365ebb55 (bug 1478124)
Backed out changeset 538e40c5ee13 (bug 1478124)
Backed out changeset bedaa9c437ad (bug 1478124)
2019-01-29 10:03:06 +02:00
Kris Maglione
586d1722ec Bug 1478124: Part 8b - Update DocShell module to use a static component manifest. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D15040

--HG--
extra : rebase_source : 4de6207229742168f534f618fe4881f19e3135c9
extra : absorb_source : 63106bea2b2a9c9a90e2d8cd08429b5de0f2cd09
extra : histedit_source : 02a263131b092b1d1ac4901f1a37a1b842b3103f
2018-12-16 17:27:58 -08:00
Frederik Braun
9dc1f493de Bug 1519817 - iterate over allowList when logging ExpandedPrincipal for debugging r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D16458

--HG--
extra : moz-landing-system : lando
2019-01-14 14:24:44 +00:00
Ciure Andrei
7a748ae68f Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-01-04 01:03:06 +02:00
Boris Zbarsky
058f83508f Bug 1517434 part 2. Convert existing callers of GetIsSystemPrincipal() to IsSystemPrincipal(). r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D15673

--HG--
extra : moz-landing-system : lando
2019-01-03 20:55:38 +00:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Kyle Machulis
c241567f0f Bug 1505601 - Turn nsIDocShell XPIDL const lists into cenums; r=bzbarsky
Turn all const lists and related attributes into cenums, to provide a
vague sense of type safety.

Depends on D11715

Differential Revision: https://phabricator.services.mozilla.com/D11716

--HG--
extra : moz-landing-system : lando
2018-11-28 03:30:56 +00:00
Brad Werth
42992765b4 Bug 1496505: Use the triggering principal rather than the loading principal for CORS checks. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D9881

--HG--
extra : moz-landing-system : lando
2018-10-31 18:02:46 +00:00
Frederik Braun
0788132d62 Bug 1499384: add debug logging for expandedprincipals r=ckerschb
Extending the MOZ_LOGging for content security checks to provide a proper serialization of expanded principals

Differential Revision: https://phabricator.services.mozilla.com/D8958

--HG--
extra : moz-landing-system : lando
2018-10-22 12:49:10 +00:00
Frederik Braun
4f7300a921 Bug 1491825: add MOZ_LOG for content security checks r=ckerschb
Summary:
This patch adds a new log module 'CSMLog' for checks in nsContentSecurityManager::doContentSecurityCheck.

With log level 4 (debug) only HTTP URLs will be logged. Level 5 (verbose) logs for all loads.

The logger shows the following information: - channel URI - loadingPrincipal - triggeringPrincipal - principal to be inherited - load flags from loadinfo

Test Plan: n/a

Reviewers: jkt, ckerschb

Reviewed By: jkt, ckerschb

Bug #: 1491825

Differential Revision: https://phabricator.services.mozilla.com/D6125

--HG--
extra : rebase_source : 673df7f627da05ff60a6d55fb86b1cf31e94ccf4
extra : histedit_source : 56d1880a1f34e09b37d5115eba2c6659824faa1b
2018-09-28 16:06:29 +03:00
Sylvestre Ledru
aa37bde79b Bug 1489454 - Remove all trailing whitespaces (again) r=Ehsan
This also includes moving some files to the regular format.

Differential Revision: https://phabricator.services.mozilla.com/D5249

--HG--
extra : moz-landing-system : lando
2018-09-07 14:47:51 +00:00
Tom Schuster
58828f18c8 Bug 1470295 - Allow save-as download of FTP files on HTTP pages. r=ckerschb
--HG--
extra : rebase_source : 0254446f8d477d0214b602b1e7ab2cc8b762d115
2018-06-21 23:31:13 +02:00
Tom Schuster
df59deb701 Bug 1469536 - Allow the system principal to load FTP subresources. r=ckerschb
--HG--
extra : rebase_source : 3b972ef960559af148f934cb95b03cf8cac87948
extra : histedit_source : 2f6e91be2722274bbdc2c2e60dddbe8b3270cf6b
2018-06-19 13:58:41 +02:00
Kate McKinley
fa06a45b28 Bug 1328695 - Use protocol flags to determine if a URI is potentially trustworthy r=ckerschb, r=dveditz, r=mcmanus, r=bz
Before this change, the trusted URI schemes, based on a string whitelist, were:
https, file, resource, app, moz-extension and wss.

This change removes "app" from the list (since we don't implement it),
and adds "about" to the list (because we control the delivery of that).
2018-05-31 07:51:42 +02:00
Andrea Marchesini
9023e7c7b4 Bug 1446937 - Have ContextForTopLevelLoad return already_AddRefed<nsISupports> within LoadInfo, r=qdot 2018-05-30 21:21:18 +02:00
Tom Schuster
5a642e8bf6 Bug 1458449 - Allow FTP subresource in FTP documents. r=ckerschb
--HG--
extra : rebase_source : 035bd3782abb6deeff4aaf1d227ce7197f9234a6
2018-05-02 13:32:08 +02:00
Ben Kelly
be5f3caad5 Bug 1422710 Block opaque tainted requests that do not follow redirects. r=ckerschb 2018-04-23 09:43:36 -07:00
Tom Schuster
b0dadb57b5 Bug 1452701 - Add pref to allow FTP subresources. r=ckerschb
--HG--
extra : rebase_source : 571060a866cc46ab253b0718d33dcbbd0f7e0a87
2018-04-09 21:07:01 +02:00
Tom Schuster
b12501054b Bug 1404744 - Check for FTP subresource after applying CSP. r=ckerschb
--HG--
extra : rebase_source : 642ba0d40d6b1d2e7ef85fdc52dffa72b5a24f5b
extra : histedit_source : 117afa5310977211fd18007e5ed7d2991a8b8837
2018-04-06 00:27:02 +02:00
Tom Schuster
8e3324212f Bug 1404744 - Block loading FTP as a subresource everywhere. r=ckerschb
--HG--
extra : rebase_source : 479f1b7f55c3133c7f46c1a343a394fef15e9f59
2018-03-26 21:05:08 +02:00
Dave Townsend
e2dffad4ac Bug 1448500: Add speculative request content policy type. r=bz, r=kmag
Adds a new TYPE_SPECULATIVE to nsIContentPolicy uses it as the type for
speculative connection channels from the IO service. I believe I've added it to
all the content policies in tree to make sure it behaves the same as TYPE_OTHER
used to.

The webextension test shows that the webextension proxy API sees speculative
lookups requested through the IO service.

MozReview-Commit-ID: DQ4Kq0xdUOD

--HG--
extra : rebase_source : d9460fdac118bc68f0db79749a16f181b580f2e7
2018-03-23 15:27:08 -07:00
Christoph Kerschbaumer
a929955d1f Bug 1439713 - Change nsIContentPolicy shouldLoad to take an <uri, loadInfo> pair instead of the various args. r=bz 2018-03-29 12:16:23 +02:00
Georg Koppen
dd4fb3ba9f Bug 1382359: Treat .onion as a secure context
Websites which collect passwords but don't use HTTPS start showing scary
warnings from Firefox 51 onwards and mixed context blocking has been
available even longer.

.onion sites without HTTPS support are affected as well, although their
traffic is encrypted and authenticated. This patch addresses this
shortcoming by making sure .onion sites are treated as potentially
trustworthy origins.

The secure context specification
(https://w3c.github.io/webappsec-secure-contexts/) is pretty much focused
on tying security and trustworthiness to the protocol over which domains
are accessed. However, it is not obvious why .onion sites should not be
treated as potentially trustworthy given:

"A potentially trustworthy origin is one which a user agent can
generally trust as delivering data securely.

This algorithms [sic] considers certain hosts, scheme, and origins as
potentially trustworthy, even though they might not be authenticated and
encrypted in the traditional sense."
(https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy)

We use step 8 in the algorithm to establish trustworthiness of .onion
sites by whitelisting them given the encrypted and authenticated nature
of their traffic.
2018-03-01 09:44:30 +01:00
Christoph Kerschbaumer
a6c1ffb498 Bug 1434357: Exempt Web Extensions from insecure redirects to data: URIs. r=kmag,mayhemer 2018-02-18 19:52:52 +01:00
Boris Zbarsky
f60fd673d6 Bug 1432186 part 19. Remove the nsIDOMNode::*_NODE constants. r=mccr8
MozReview-Commit-ID: KvKjeKIOB9K
2018-01-29 23:10:53 -05:00
Christoph Kerschbaumer
47e37d6df2 Bug 1428793: Block insecure redirects to data: URIs. r=smaug 2018-01-23 09:57:47 +01:00
Kate McKinley
e97980a95e Bug 1424917 - Remove support for HSTS Priming. r=mayhemer, r=ckerschb
This patch removes support and tests for HSTS priming from the tree.
2018-01-10 11:07:00 -05:00
Andrea Marchesini
97baa05333 Bug 1398229 - Save-link-as feature should use the loading principal - part 3 - implementation of nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb, r=tanvi 2017-11-16 12:27:01 +01:00
Sebastian Hengst
6c1d6be6fb Backed out 3 changesets (bug 1398229) for failing own browser-chrome browser/components/contextualidentity/test/browser/browser_saveLink.js. r=backout on a CLOSED TREE
Backed out changeset 5b3b0a38b2d1 (bug 1398229)
Backed out changeset a726fc7506ca (bug 1398229)
Backed out changeset 53dae7764e58 (bug 1398229)
2017-11-15 20:49:09 +02:00
Andrea Marchesini
11eefa61bb Bug 1398229 - Save-link-as feature should use the loading principal - part 3 - implementation of nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb 2017-11-15 18:16:29 +01:00
Christoph Kerschbaumer
c848c91be9 Bug 1415612: Allow all plain text types when navigating top-level data URIs. r=bz 2017-11-13 21:25:02 +01:00
Christoph Kerschbaumer
6584da597b Bug 1407891: Allow view-image to open a data: URI by setting a flag on the loadinfo. r=bz 2017-11-08 20:01:41 +01:00
Christoph Kerschbaumer
078474c979 Bug 1403870: Allow toplevel data URI navigation data:application/json. r=smaug 2017-11-03 13:26:28 +01:00
Christoph Kerschbaumer
3d0a1f002e Bug 1403814 - Block toplevel data: URI navigations only if openend in the browser. r=smaug 2017-11-03 13:23:11 +01:00
Andrew McCreight
1d0acbdb9b Bug 1412125, part 1 - Manually add mode lines and MPL to files that were missing them entirely. r=qdot
These were detected by the script used to generate part 2.

MozReview-Commit-ID: VMcT154f6f

--HG--
extra : rebase_source : 2f5fc8a314302fcacac840a8dbe0ff874d518e51
2017-10-26 14:54:59 -07:00
Christoph Kerschbaumer
ebfa77072c Bug 1408451: Log to web console when blocking toplevel data: URI navigations. r=bz 2017-10-16 14:18:52 +02:00
Kris Maglione
5fdcb5a5d2 Bug 1407056: Part 1 - Provide more consistent principal/origin URL to content policies. r=bz,ckerschb
We're currently fairly vague and inconsistent about the values we provide to
content policy implementations for requestOrigin and requestPrincipal. In some
cases they're the triggering principal, sometimes the loading principal,
sometimes the channel principal.

Our existing content policy implementations which require or expect a loading
principal currently retrieve it from the context node. Since no current
callers require the principal to be the loading principal, and some already
expect it to be the triggering principal (which there's currently no other way
to retrieve), I chose to pass the triggering principal whenever possible, but
use the loading principal to determine the origin URL.

As a follow-up, I'd like to change the nsIContentPolicy interface to
explicitly receive loading and triggering principals, or possibly just
LoadInfo instances, rather than poorly-defined request
origin/principal/context args. But since that may cause trouble for
comm-central, I'd rather not do it as part of this bug.

MozReview-Commit-ID: LqD9GxdzMte

--HG--
extra : rebase_source : 41ce439912ae7b895e0a3b0e660fa6ba571eb50f
2017-10-12 15:43:55 -07:00
Christoph Kerschbaumer
04a3ca2e32 Bug 1403641: Allow data: URI downloads even if data: URI navigations are blocked. r=bz 2017-10-04 08:43:56 +02:00
Xidorn Quan
e69b3c7976 Bug 1403024 part 1 - Add nsContentUtils::SchemeIs helper function. r=bholley
MozReview-Commit-ID: 2NVc5QJSjl

--HG--
extra : rebase_source : 5d25c9c507eaa2a08d68c331a8ba9d304c97f305
2017-09-26 10:21:01 +10:00
Chris Peterson
a0c8081df4 Bug 870698 - Part 4: Replace Equals("") with EqualsLiteral(""). r=erahm
MozReview-Commit-ID: G1GhyvD29WK

--HG--
extra : rebase_source : 115842c37a40041bdca7b4e1ff0a5680b02ced15
extra : source : 90bfff9c01d80086cdc17637f310e898fea295ea
2017-09-06 01:13:45 -07:00
Christoph Kerschbaumer
929390bec4 Bug 1398692: Allow toplevel navigation to a data:application/pdf. r=bz 2017-09-14 07:34:41 +02:00
Christoph Kerschbaumer
2cbe4b9466 Bug 1398691 - Unescape data: URI for console message when blocking toplevel data: URI navigations. r=smaug 2017-09-12 07:06:38 +02:00
Christoph Kerschbaumer
1e7caa84a1 Bug 1396798: Do not block toplevel data: navigation to image (except svgs). r=smaug 2017-09-06 16:27:05 +02:00
Christoph Kerschbaumer
9522e28631 Bug 1394554: Block toplevel data: URI navigations after redirect. r=smaug 2017-09-06 09:33:10 +02:00
Christoph Kerschbaumer
1b8c06e845 Bug 1331740: Pass correct context for TYPE_DOCUMENT loads within docshell. r=smaug 2017-09-05 18:01:07 +02:00
Nicholas Nethercote
72c884bf74 Bug 1384835 (part 3, attempt 2) - Remove the Preferences::Get*CString() variants that return nsAdoptingCString. r=froydnj.
--HG--
extra : rebase_source : d317b25be2ec21d1a60d25da3689e46cdce0b649
2017-07-31 14:28:48 +10:00