The new side component `fxview-category-navigation` required tests after being implemented in [[https://bugzilla.mozilla.org/show_bug.cgi?id=1832668 | Bug 1832668]]
- added tests to verify clicking each `fxview-category-button` navigates to the correct view/page
- added tests to verify keyboard navigation to each `fxview-category-button` navigates to the correct view/page
- added tests to verify direct navigation updates the category from the hash accordibly
Differential Revision: https://phabricator.services.mozilla.com/D193579
* Add a type=page to the top-level ViewPage instances
* Rename viewTabVisibleCallback and viewTabHiddenCallback to view*Callback and call each when selectedness or visiblity changes
* Ensure active view/pages are always properly initialized during page load and category switching
* Add a test to verify no mutations happen when tabs change while firefox view is inactive
* Fix tests to better account for loading and readiness sequence when activating firefox view
Differential Revision: https://phabricator.services.mozilla.com/D193744
Linear search through the list of recently closed tabs, and some light refactoring for the sake of upcoming search enhancements.
Differential Revision: https://phabricator.services.mozilla.com/D193692
There are two equals signs when there should be just one. This was made more obvious after applying Prettier v3's auto formatting.
Differential Revision: https://phabricator.services.mozilla.com/D190411
There are 2 failing test cases for the `div`/`img` with class name `brand-logo` that appear to test not user-facing behavior: the test cases are sending clicks to brand-logo as a container. This test target appears to be to confirm the feature tour pref change after a custom FEATURE_CALLOUT messages are dismissed by these clicks on a non-actionable element, while there are other ways to dismiss/pass the tour messages that are accessible.
This is not expected or does not have to be done by a user of an assistive technology and it does not have to confirm the accessibility of this element.
Thus, we are excluding these click events from accessibility checks and removing the `fail-if` annotation from the test manifest that was added by bug 1854625 and meta bug 1858037 before the investigation in the meta bug 1854233.
Differential Revision: https://phabricator.services.mozilla.com/D191686
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.
Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D190890
Adds an additional event under the `firefoxview_next` category whenever a link is opened in a new tab, window, etc.
Not being able to access the "trigger node" is a somewhat limiting factor. I raised [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1855743 | Bug 1855743 ]] to address this. Because of this, I could not exactly capture "what type of tab data you're dealing with (Recently closed tabs, Open tabs, Synced tabs, etc)". So I opted to capture the page hash instead as a workaround.
Differential Revision: https://phabricator.services.mozilla.com/D189520
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.
This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Firefox View-specific meta bug 1854626
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188927
Differential Revision: https://phabricator.services.mozilla.com/D188990
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Firefox View-specific meta bug 1854626
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D188990
* Modify panel-list and panel-item to support submenu list items
* Add submenu items for Move Tabs and Send Tabs to Devices to open tabs
* Add test coverage for submenu items in open tabs
Differential Revision: https://phabricator.services.mozilla.com/D186471
