Commit graph

27713 commits

Author SHA1 Message Date
Gijs Kruitbosch
2d8e80d2ae Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 23:16:56 +00:00
Andrei Oprea
f6d99002c8 Bug 1676241 - Fix usage of ExperimentAPI in TelemetryFeed r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D96460
2020-11-09 20:15:25 +00:00
Harry Twyford
57181de5e9 Bug 1675976 - Stop recording bogus data for some urlbar.picked.searchmode.* probes. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96321
2020-11-09 19:18:51 +00:00
Harry Twyford
9f2041a14b Bug 1675627 - Do not show alias engines in search mode. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96256
2020-11-09 17:59:35 +00:00
Mike Conley
c7295a552a Bug 1673716 - Try to make sure the about:home startup cache worker construction Promise always resolves. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96269
2020-11-09 17:14:58 +00:00
Csoregi Natalia
66c2c6c5d5 Backed out changeset ca520bfdc084 (bug 1674515) for failures on browser_autoshow_bookmarks_toolbar.js. CLOSED TREE 2020-11-09 19:32:08 +02:00
Dão Gottwald
1a9cbfb983 Bug 1676169 - Completely disallow dropping on sponsored tiles. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D96433
2020-11-09 16:26:30 +00:00
Erica Wright
097ee80074 Bug 1672476 - Add a pref to permanently show the firefox logo on the newtab page. r=prathiksha,thecount
This is preffed off for now.

Differential Revision: https://phabricator.services.mozilla.com/D94385
2020-11-06 18:36:24 +00:00
Gijs Kruitbosch
8cb1e9b0d4 Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 16:00:29 +00:00
Gijs Kruitbosch
5180644f12 Bug 1675775 - fix browser_default_bookmark_location.js for beta, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96429
2020-11-09 16:01:50 +00:00
Nihanth Subramanya
8982a96b46 Bug 1672986 - Set the right cookie behavior before state partitioning MVP UI test. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95526
2020-11-09 14:00:05 +00:00
Dão Gottwald
a92199cbca Bug 1674414 - Don't do partner link attribution when merely switching tabs. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D96178
2020-11-09 10:04:50 +00:00
Nihanth Subramanya
4e142d3196 Bug 1643191 - Show storage access permissions in the identity panel. r=pbz,fluent-reviewers,johannh,flod
This patch adds storage access permission items in the identity panel. This is a new
class of permission - multiple permission items might exist for the category i.e.
one for each third-party that has been granted access. To achieve this, we add support
for an "anchorfor" attribute in the permission list markup, which when present will
signal to the code that the element is to be the container for permission items of type
matching the value of the attribute. This hence adds support generally for categorical
permission types.

Differential Revision: https://phabricator.services.mozilla.com/D94703
2020-11-09 00:21:13 +00:00
Daisuke Akatsuka
2f199393c2 Bug 1673299: Change the timing that moves the focus to the browser. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D95830
2020-11-08 23:51:44 +00:00
Daisuke Akatsuka
14d7da43af Bug 1661000: Avoid urlbar search string canonization if ctrl key comes from a previous action. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D93920
2020-11-08 23:34:48 +00:00
Mike Conley
41a5e5c57f Bug 1673109 - Reintroduce tests that got lost as part of the ASRouter rearchitecture work. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95795
2020-11-06 20:46:23 +00:00
Mike Conley
9815be6005 Bug 1673109 - Remove unused ASRouter.renderWNMessages method. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D96231
2020-11-06 21:40:15 +00:00
Mike Conley
386033f1e1 Bug 1673109 - Remove dead code that calls a non-existing function. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95794
2020-11-06 20:46:09 +00:00
Mike Conley
2490e149e1 Bug 1673109 - Make sure ASRouter.updateTargetingParameters returns the correct Trailhead parameter. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95793
2020-11-06 20:46:00 +00:00
Mike Conley
f0bb48e1de Bug 1673109 - Get rid of unused dismissById function on ASRouterUtils. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95792
2020-11-06 20:45:52 +00:00
Mike Conley
bf827a4624 Bug 1673109 - Make sure we properly enter "snippets preview mode" when using a preview endpoint. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95791
2020-11-06 18:43:12 +00:00
Mike Conley
7cc616e57f Bug 1675062 - Re-add capability to notify content about cleared ASRouter providers. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95901
2020-11-06 18:43:06 +00:00
Tom Schuster
bf6253f556 Bug 1675643. Fix browsingData.removeLocalStorage when next-gen storage is disabled. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D96173
2020-11-06 16:14:16 +00:00
Gavin Lazar Suntop
91279d4359 Bug 1674241 - Update popular topics r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D96095
2020-11-06 19:27:38 +00:00
Neil Deakin
c5eff66205 Bug 1649843, remove now unused legacy actor code, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D95206
2020-11-06 15:46:11 +00:00
Sebastian Hengst
0407d5cb3d Bug 1511273 - disable browser/components/search/test/browser/browser_google_behavior.js on Linux ccov. r=jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D96174
2020-11-06 15:15:08 +00:00
Harry Twyford
162add7d39 Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D96114
2020-11-06 09:46:35 +00:00
Harry Twyford
087a9c5df4 Bug 1674874 - Record telemetry for results picked in search mode. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D95796
2020-11-06 00:13:00 +00:00
Gijs Kruitbosch
7d0a4e99b9 Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-05 21:08:10 +00:00
Gijs Kruitbosch
c4136e1973 Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D95231
2020-11-06 00:37:09 +00:00
Gijs Kruitbosch
bbab3fdc92 Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94879
2020-11-05 21:08:09 +00:00
Gijs Kruitbosch
543bac450b Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
2020-11-05 21:08:40 +00:00
Harry Twyford
6af06ad706 Bug 1674485 - Restore URL heuristic icon after unselecting a one-off. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D95537
2020-11-05 22:17:20 +00:00
Jared Wein
7465d643ed Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 23:00:47 +00:00
Narcis Beleuzu
f4d84dca33 Backed out changeset 1c37a165ba43 (bug 1674874) for bc failure on browser_UsageTelemetry_urlbar_searchmode.js CLOSED TREE 2020-11-06 00:38:24 +02:00
Narcis Beleuzu
d2c8150d6f Backed out changeset 8b153da7c0d0 (bug 1674241) for Lint failure on DiscoveryStreamFeed.jsm 2020-11-06 00:08:00 +02:00
Andrew Halberstadt
331bc892dd Bug 1675319 - [manifestparser] Properly support multiline skip-if statements, r=jmaher,extension-reviewers,zombie
This supports one manifestparser expression per line in the 'skip-if',
'fail-if' and 'run-if' keys. As a side effect the:

    skip-if = foo ||
        bar

syntax is no longer supported. Instead it can be:

    skip-if =
        foo  # bug 123
        bar  # bug 456

Differential Revision: https://phabricator.services.mozilla.com/D95927
2020-11-05 19:55:08 +00:00
Gavin Lazar Suntop
f1c2e8e669 Bug 1674241 - Update popular topics r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D96095
2020-11-05 20:56:27 +00:00
Harry Twyford
caecbc9874 Bug 1674874 - Record telemetry for results picked in search mode. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D95796
2020-11-05 20:26:00 +00:00
Narcis Beleuzu
3a271628c8 Backed out 4 changesets (bug 1425290, bug 1432604, bug 1665389) for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js . CLOSED TREE
Backed out changeset 455ff5647429 (bug 1432604)
Backed out changeset cf70da964b70 (bug 1425290)
Backed out changeset e6b38d403cc3 (bug 1425290)
Backed out changeset 09f049232773 (bug 1665389)
2020-11-05 23:01:31 +02:00
Narcis Beleuzu
61b409c94c Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Gijs Kruitbosch
b3a0da4cd9 Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-04 23:43:05 +00:00
Gijs Kruitbosch
bacc1af05c Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D95231
2020-11-05 18:56:06 +00:00
Gijs Kruitbosch
cf659a25dc Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94879
2020-11-04 23:24:35 +00:00
Gijs Kruitbosch
59ae1791ae Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
2020-11-04 23:24:27 +00:00
emcminn
34f6104c95 Bug 1673733 - Fixes and improvements to WNPanel devtools, plus tests r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D95081
2020-11-05 19:24:03 +00:00
Jared Wein
d3a8c969bc Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 19:09:18 +00:00
Dão Gottwald
439a4c104d Bug 1673429 - Fix drag & drop of and around sponsored tiles. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D95863
2020-11-05 18:01:48 +00:00
Marco Bonardo
a2f405c9b9 Bug 1675537 - Switch browser.urlbar.update2.emptySearchBehavior to 0. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D96063
2020-11-05 17:06:08 +00:00
Harry Twyford
6f560081d3 Bug 1674493 - Record number of tab-to-search onboarding impressions. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D95547
2020-11-05 11:28:47 +00:00