Commit graph

26 commits

Author SHA1 Message Date
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Jared Wein
b33bfba51a Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: 2MhpvzUDgtK

--HG--
extra : rebase_source : 1df2b81badfe556928f6424c8990e4b3fde7056f
2017-01-06 12:09:28 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mark Banner
09ab00a94f Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11

--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Alessio Placitelli
cf73009777 Bug 1234522 - Remove services/datareporting. r=gfritzsche
--HG--
rename : services/datareporting/datareporting-prefs.js => toolkit/components/telemetry/datareporting-prefs.js
2016-01-05 02:01:00 +01:00
Felipe Gomes
909d49249d Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Giovanny Andres Gongora Granada
1adc493a26 Bug 1126738 - Use arrow functions in browser-data-submission-info-bar.js. r=dao 2015-01-28 23:18:14 +01:00
Alexander Dimitrov
8bc958ce39 Bug 1126259 - Removal of the unload event handler in browser-data-submission-info-bar.js is broken and can go away. r=dao
--HG--
extra : rebase_source : 373c4b2381c71d5b36338ab789cd7696f84bc717
2015-01-27 17:09:04 +01:00
Georg Fritzsche
db980a370f Bug 862563 - Remove implicit acceptance for data reporting notification and notify on first run. r=gps
The data reporting notification was over-complicated. It wasn't
displayed for +24hr after first run and it had a weird, non-required
policy around what constituted acceptance of the policy.

The notification is now shown shortly after first startup.

The logic around "notification accepted" has been greatly simplified by
rolling it into "notification shown." Where we once were checking
whether the notification has been "accepted," we now check whether it
has been displayed. The overly complicated logic around the implicit
acceptance of the policy has also been removed.

The end result is the code for managing the state of the notification is
greatly simplified.
2014-07-09 14:32:29 -07:00
Wes Kocher
12b6391129 Backed out changeset 8673477f5fc2 (bug 862563) for Windows mochitest-5 failures 2014-07-11 17:00:08 -07:00
Georg Fritzsche
36ae1e497a Bug 862563 - Remove implicit acceptance for data reporting notification and notify on first run; r=gps
The data reporting notification was over-complicated. It wasn't
displayed for +24hr after first run and it had a weird, non-required
policy around what constituted acceptance of the policy.

The notification is now shown shortly after first startup.

The logic around "notification accepted" has been greatly simplified by
rolling it into "notification shown." Where we once were checking
whether the notification has been "accepted," we now check whether it
has been displayed. The overly complicated logic around the implicit
acceptance of the policy has also been removed.

The end result is the code for managing the state of the notification is
greatly simplified.

--HG--
extra : rebase_source : 808efdf1edd103552f6aa10b5c4309b64e514773
extra : amend_source : e4252e6a850a348d1b5aca733121dd07cbc6a70a
extra : histedit_source : 10ec20a07677674a8c9a705a3ffb4dc46a22b890%2Ca9442934d5964f16e9ad1101b786b4d094ac228d
2014-07-09 14:32:29 -07:00
Blair McBride
89d1cbef27 Bug 451283 - Move log4moz.js to Toolkit as Log.jsm. r=gps,Mossop
--HG--
rename : services/common/log4moz.js => toolkit/modules/Log.jsm
rename : services/common/tests/unit/test_log4moz.js => toolkit/modules/tests/xpcshell/test_Log.js
2013-08-26 11:55:58 -07:00
Gregory Szorc
8ebc7e5f30 Bug 830408 - Tests for data reporting notification bar; r=gavin 2013-03-15 10:07:39 -07:00
Dão Gottwald
11938869df Bug 837638 - Don't set persistence = -1 on the data-reporting notification, since it's not transient anyway. r=gavin 2013-02-07 04:03:42 +01:00
Dão Gottwald
286aae4699 Bug 837637 - data-reporting notification shouldn't create its own notification box. r=gavin 2013-02-05 10:29:44 +01:00
Dão Gottwald
f7367ac07a Bug 836448 - Make browser-data-submission-info-bar.js not pollute the global window scope. r=gavin 2013-01-30 21:56:49 +01:00
Gregory Szorc
ad9d143963 Bug 829881 - Remove references to replaced Telemetry notification bar; r=tchevalier 2013-01-15 12:38:01 -08:00
Mike Connor
0b668841f6 bug 830090 - Access key for Choose What I Share button in info bar is broken, r=gps 2013-01-14 20:30:49 -05:00
Richard Newman
d1741cb0c9 Bug 804745 - Part c: fix error in notification name handling. r=simple 2013-01-12 22:50:21 -08:00
Gregory Szorc
8c05627291 Bug 804745 - Part b: Fix bustage due to apparent preprocessor limitation; r=rnewman
This is a temporary fix until the variable in question is removed in bug
829881.
2013-01-11 21:42:47 -08:00
Mike Connor
e46ce230b0 Bug 804745 - Unified notification for application data reporting; r=gavin 2013-01-11 19:05:35 -08:00