nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
821061 commits 1 branch 98 tags 6.4 GiB
Commit graph

151 commits

Author SHA1 Message Date
Mike Conley
62b8b0976b Bug 1801678 - Refactor OverflowableToolbar to turn #webExtList into a memoizing getter. r=Gijs 
The WebExtension overflow list is created lazily because the panel itself is lazy, and only gets
inserted the first time it is needed. Originally, I had written a separate function `#getWebExtList()`
to do the work of forcing the WebExtension overflow list to de-lazify, and then hold a reference
to it in #webExtList.

It turns out, that's a bit of a footgun. More than once, I've used #webExtList directly, forgetting
that the value might turn out to be `null` because the list hasn't delazified yet.

In order to smooth out that rough edge, this patch makes `#webExtList` a memoizing (evalutes once,
caches the return value for subsequent calls) getter so that anything that uses it doesn't have
to worry about the lazification. The reference member is now called #webExtListRef, and I've
added documentation about how it's probably best not to use it directly.

Differential Revision: https://phabricator.services.mozilla.com/D162585
 2022-11-24 18:51:19 +00:00
Mike Conley
2938f20372 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Depends on D160292

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-11-01 21:50:56 +00:00
Butkovits Atila
a5fa6f4b4b Backed out 3 changesets (bug 1797155) for causing failures at browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset 67f5e4af25b6 (bug 1797155)
Backed out changeset b8a8bd646606 (bug 1797155)
Backed out changeset ec7cdd68c414 (bug 1797155)
 2022-11-01 19:33:25 +02:00
Mike Conley
b41c17430f Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-11-01 16:44:33 +00:00
Marian-Vasile Laza
18bb50b232 Backed out 3 changesets (bug 1797155) for causing bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset ee3f27f43bc5 (bug 1797155)
Backed out changeset 863603ed770a (bug 1797155)
Backed out changeset 3fbfc3d94e5a (bug 1797155)
 2022-10-31 21:29:22 +02:00
Mike Conley
1d297656a0 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-10-31 18:05:20 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Tooru Fujisawa
6b0608c9bd Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 04:42:09 +00:00
Molnar Sandor
77402a5caa Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b200384ddb Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 02:49:13 +00:00
Mark Banner
2d563feacc Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-17 22:13:08 +00:00
Cristian Tuns
e8374bd569 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
0ce30e3008 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-14 10:19:40 +00:00
Mike Conley
eea2cb73ef Bug 1746670 - Make it possible to register CUI areas with overflowable: false. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D134196
 2021-12-17 21:52:46 +00:00
Hardik Sharma
e0db37de5a Bug 1716996 - Replace waitForCondition use in customizableui tests with TestUtils.waitForCondition r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D119509
 2021-07-14 15:31:12 +00:00
Emma Malysz
6a9860ff3b Bug 1692176, add restore previous session to history panel r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D110178
 2021-03-31 16:22:52 +00:00
Tim Nguyen
5a254f3623 Bug 1632092 - Rename all XUL namespace variables to XUL_NS. r=Gijs,marionette-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D71913
 2020-04-24 09:23:52 +00:00
Dão Gottwald
f07d464f9d Bug 1610497 - Increase browser window min-width so the address bar can be focused by mouse. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D60960

--HG--
extra : moz-landing-system : lando
 2020-01-30 15:59:29 +00:00
Dão Gottwald
bca8987c92 Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D58763

--HG--
extra : moz-landing-system : lando
 2020-01-16 11:41:36 +00:00
Masayuki Nakano
0a74bf0038 Bug 1605918 - Get rid of synthesizeDragStart() in EventUtils.js r=smaug 
All usage of `synthesizeDragStart()` is, starting drag, cancel `dragstart`,
and finally compares `dataTransfer` items and given expected data.  So,
we can make the users use `synthesizePlainDragAndDrop()` instead.  It's
better API because it computes position of mouse operations at runtime and
checks whether the drag start was succeeded with optional logging feature
(i.e., it's easier to debug of intermittent failures).

This patch creates `synthesizePlainDragAndCancel()` for convenience.  It
handles `dragstart` instead of the callers.

Differential Revision: https://phabricator.services.mozilla.com/D58214

--HG--
extra : moz-landing-system : lando
 2019-12-27 16:25:24 +00:00
Dão Gottwald
fe21327223 Bug 1582797 - OverflowableToolbar should respond to resize events immediately. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D46624

--HG--
extra : moz-landing-system : lando
 2019-09-25 12:09:32 +00:00
harry
9219af6886 Bug 1578485 - Re-enable browser_918049_skipintoolbarset_dnd.js. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D45031

--HG--
extra : moz-landing-system : lando
 2019-09-06 17:17:07 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
 2019-07-05 09:53:32 +02:00
Andrew Swan
a745ec6099 Bug 1519577 Convert toolbarbutton to a custom element r=surkov 
Differential Revision: https://phabricator.services.mozilla.com/D31941

--HG--
extra : rebase_source : 3709ef713f1a7dc9fbc2d0ac97f16bea757fcd2b
 2019-05-20 10:01:02 -07:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
 2019-01-30 17:26:25 +00:00
Mark Banner
15b881a65f Bug 1521707 - Move promisePopupEvent to BrowserTestUtils.jsm. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D17259

--HG--
extra : moz-landing-system : lando
 2019-01-23 14:04:46 +00:00
Brian Grinstead
08b08080f8 Bug 1505734 - Remove logic from CustomizableUI toolbar XBL constructor;r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D11665

--HG--
extra : moz-landing-system : lando
 2018-11-14 00:46:20 +00:00
Olli Pettay
34fa9d52b1 Bug 1498379 - browser_homeDrop.js and head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs 
--HG--
extra : rebase_source : d167e5cc78ba9e027ceefcb4cd81dad272853ec1
 2018-10-15 22:33:05 -04:00
Gurzau Raul
fd63f0c02c Backed out 2 changesets (bug 1498379, bug 1498381) for permafailing at /test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js a=backout 
Backed out changeset 0178681fab81 (bug 1498379)
Backed out changeset 962c7631d98c (bug 1498381)
 2018-10-15 01:14:40 +03:00
Olli Pettay
dce761f6fc Bug 1498379 - browser_homeDrop.js and customizableui/test/head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs 2018-10-13 13:10:15 +03:00
Brendan Dahl
e3f9c55a17 Bug 1492619 - Use children instead of childNodes in customizable ui tests. r=bgrins 
Fixes browser_customization_context_menus.js

MozReview-Commit-ID: KtRIFGu5ILA

Differential Revision: https://phabricator.services.mozilla.com/D6335

--HG--
extra : moz-landing-system : lando
 2018-09-19 22:43:04 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop 
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
 2018-08-31 05:59:17 +00:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Gijs Kruitbosch
0809c549f1 Bug 962248 - rewrite zoom test to be less terrible, r=dthayer 
MozReview-Commit-ID: ByUM61fsOgh

--HG--
extra : rebase_source : e81915fbf2ecf35a90ef6a0c4be5b6fa4bf01d51
 2018-05-09 09:07:37 +01:00
Paolo Amadini
ea3963afc9 Bug 1444392 - Part 1 - Add test-only helpers to open and close the main menu. r=Gijs 
MozReview-Commit-ID: 9kvUdw2TeHB

--HG--
extra : rebase_source : 0b0a007ad517c0256fe67256391d87065bf645ef
extra : amend_source : c2c56528f12e38852e913e42e9e7f9e78e8623d9
extra : source : ec2f47133979d085739d383cc50358d6e9417979
 2018-04-04 11:34:16 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
1f11d6af6f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws 
MozReview-Commit-ID: IglKedBqrWQ

--HG--
extra : rebase_source : a388f02b8d5e00f7e670f41d049518be1de370dc
extra : histedit_source : 8f79f40d24f5456e22787a169cc9f6ae21c03c1e
 2018-01-05 21:35:27 +00:00
Tim Nguyen
e1b673bf04 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs 
MozReview-Commit-ID: 1ppfxI7yYJW

--HG--
extra : rebase_source : b4a2c44dd5e244c81e479e6b43e9669cc031f349
 2018-01-11 16:35:17 +00:00
Tooru Fujisawa
034f9f1ec4 Bug 1424877 - Wait for the next event tick in promisePanelElementHidden in browser/components/customizableui/test/head.js. r=Gijs 2017-12-14 14:49:32 -06:00
Bill McCloskey
9f4d083047 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap) 
MozReview-Commit-ID: 2nQPOSGTr1s
 2017-12-07 12:55:24 -08:00
Andreea Pavel
89531e8dc3 Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE 
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
 2017-12-07 12:20:21 +02:00
Bill McCloskey
bef7c122df Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap) 
MozReview-Commit-ID: 2nQPOSGTr1s
 2017-12-06 21:17:05 -08:00
Dorel Luca
eb65c24c7b Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE 
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
 2017-12-07 07:09:33 +02:00
Bill McCloskey
be77cf4a01 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap) 
MozReview-Commit-ID: 2nQPOSGTr1s
 2017-12-06 20:46:58 -08:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws 
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
 2017-11-07 12:15:18 +00:00
Felipe Gomes
43ee76c5ed Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer 
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY

--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
 2017-10-17 13:39:50 -02:00