Commit graph

2412 commits

Author SHA1 Message Date
Butkovits Atila
996e816c65 Backed out changeset e71e10688704 (bug 1634030) for failure at browser_shim_disable_devtools.js CLOSED TREE 2020-08-08 03:46:14 +03:00
Emma Malysz
77f8ca0ed1 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-07 22:02:32 +00:00
Emma Malysz
18fe337c0c Bug 1657161, enable print.tab_modal.enabled for EARLY_BETA_OR_EARLIER and hide page range section r=mstriemer,fluent-reviewers,preferences-reviewers,flod
We want this to be turned on for nightly users by default. The page range is still a WIP,
so we should hide that section for now.
This also adds the pref to the "Nightly Experiment" panel, turned on by default.

Differential Revision: https://phabricator.services.mozilla.com/D85907
2020-08-06 23:02:13 +00:00
James Teh
4d72cfea5c Bug 1549932: browser_PanelMultiView_keyboard.js: Use the correct event when waiting for a browser to load. r=Gijs
Also, handle the case where readyState is "complete" but the URL is wrong.

Differential Revision: https://phabricator.services.mozilla.com/D85709
2020-08-03 13:19:17 +00:00
James Teh
41dccd5b35 Bug 1572608: browser_PanelMultiView_keyboard.js: If embedded documents aren't loaded yet, wait for them to load before trying to interact with them. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84937
2020-07-29 12:10:35 +00:00
Dorel Luca
3bb90f375c Backed out changeset c093db737948 (bug 1572608) for Browser-chrome failures in customizableui/test/browser_PanelMultiView_keyboard.js. CLOSED TREE 2020-07-29 03:13:32 +03:00
James Teh
62055031fe Bug 1572608: browser_PanelMultiView_keyboard.js: If embedded documents aren't loaded yet, wait for them to load before trying to interact with them. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84937
2020-07-28 21:42:03 +00:00
Joel Maher
2f2dc70492 Bug 1654553 - fix browser chrome tests to support Object.is instead of ==. r=gbrown,preferences-reviewers,Gijs,rpl
fix browser chrome tests to support Object.is instead of ==

Differential Revision: https://phabricator.services.mozilla.com/D84539
2020-07-27 17:02:35 +00:00
Emma Malysz
fbe0b5e6ba Bug 1648637, remove fxa panel from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81637
2020-07-17 20:17:32 +00:00
Emma Malysz
43d4ef1907 Bug 1648636, remove remote tabs panel from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81938
2020-07-14 13:55:29 +00:00
Emma Malysz
3f20c8dc72 Bug 1650404, rely on panelUI to add "PanelUI-subView" attribute r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D82808
2020-07-09 14:30:27 +00:00
Emma Malysz
cb57528ee2 Bug 1648640, remove character encoding panel view, panic view, SSB view, more view, and what's new panel view from main panel and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81621
2020-07-09 00:35:30 +00:00
Dão Gottwald
f9607f7c7d Bug 1503678 - Respect prefers-reduced-motion when reordering items in customize mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D82541
2020-07-08 08:33:47 +00:00
Emma Malysz
596d4bd960 Bug 1648638, remove profiler panel from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81413
2020-07-02 16:42:46 +00:00
Emma Malysz
9cc79d5e0c Bug 1648613, remove bookmark and bookmarking tools panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81235
2020-07-01 15:14:18 +00:00
Emma Malysz
aa836962ab Bug 1648639, remove containers, help view, and developer panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81257
2020-06-30 22:40:15 +00:00
Butkovits Atila
277ed87531 Backed out changeset 3c400bb0cd01 (bug 1648639) for bc failures on browser_panel_keyboard_navigation.js. 2020-06-30 21:35:06 +03:00
Emma Malysz
7726722698 Bug 1648639, remove containers, help view, and developer panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81257
2020-06-30 15:11:00 +00:00
Emma Malysz
8d5ec61edd Bug 1648198: Remove recently closed tabs and windows panels from main view and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80717
2020-06-30 03:44:56 +00:00
Emma Malysz
392c9ed354 Bug 1648175, remove history and library panel views from the main panel and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80306
2020-06-29 15:41:43 +00:00
Mark Smith
a7683d117e Bug 1642404 - add an option to show that an update is being downloaded r=bytesized,fluent-reviewers,flod
Add support for a hidden preference named app.update.notifyDuringDownload
that, when set to true, causes a "Downloading update" message to appear
in the app menu during a MAR download. Clicking the message opens the
about box so the user can see detailed progress information.

Differential Revision: https://phabricator.services.mozilla.com/D77688
2020-06-22 20:24:46 +00:00
Gijs Kruitbosch
d523471eac Bug 1644863 - fix trailing whitespace in browser/toolkit/devtools/mobile frontend code files, r=mossop,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79201
2020-06-17 22:40:53 +00:00
Dave Townsend
e07f989e6c Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00
Henri Sivonen
d5b9be12ce Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
Johann Hofmann
20b1b77919 Bug 1515073 - Part 5 - Disable browser.navigation.requireUserInteraction in tests. r=Gijs
Depends on D27588

Differential Revision: https://phabricator.services.mozilla.com/D31604
2020-06-09 14:51:06 +00:00
emcminn
de56c3d325 Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel & updated fluent strings r=andreio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D76162
2020-06-03 18:25:02 +00:00
Narcis Beleuzu
d99c47cbe4 Backed out changeset a76116eb180c (bug 1637617) for assertion failure: !Failed() . CLOSED TREE 2020-06-03 03:34:23 +03:00
emcminn
a0c89255b5 Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D76162
2020-06-02 16:50:30 +00:00
Artem
30dba11bdd Bug 1609556 - Migrate toolbar-context-menu to Fluent r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D76016
2020-05-27 18:09:40 +00:00
Andrei Oprea
bbbb5ad518 Bug 1639177 - Align checkbox in What's New panel to start r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75943
2020-05-21 09:45:37 +00:00
Erica Wright
eceee2c37c Bug 1635218 - Update Protections Dashboard entry points. r=prathiksha,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D74940
2020-05-19 16:58:51 +00:00
Greg Tatum
2b35eaf09a Bug 1634542 - Teach the profiler popup about private browsing; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D75601
2020-05-18 14:35:15 +00:00
Andrei Oprea
5c98d5c058 Bug 1638274 - Error thrown when accessing What's New panel message r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75495
2020-05-15 12:52:46 +00:00
Gijs Kruitbosch
d6e7c731e7 Bug 1558635 - use an html:template for the customize mode palette to avoid instantiating items in the palette, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D74097
2020-05-13 23:31:05 +00:00
Emma Malysz
f26d917593 Bug 1634033: lazify menus and panels used within customize mode by placing in template. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D74576
2020-05-11 18:13:57 +00:00
Emma Malysz
f1842454d9 Bug 1634031, lazy load appmenu and extension notification panel by using a template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73389
2020-05-08 16:53:45 +00:00
Itiel
ceaa636d49 Bug 1634247 - Fix separators in the Web Developer menu r=dao
Differential Revision: https://phabricator.services.mozilla.com/D73906
2020-05-08 15:33:18 +00:00
emcminn
f4f25ff97b Bug 1599138 - UI update and pref toggle for Whats New Panel r=andreio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D71341
2020-05-07 16:42:15 +00:00
Dão Gottwald
7df9930846 Bug 1635095 - Obey prefers-reduced-motion in CustomizeMode.jsm. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73648
2020-05-04 21:19:26 +00:00
Greg Tatum
d09e7cedb5 Bug 1623594 - Add recording state UI to the profiling popup; r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D73332
2020-05-04 15:05:23 +00:00
Emma Malysz
b7c5fd62b7 Bug 1634026, lazy load panic button panel by storing in HTML template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73106
2020-04-30 20:34:35 +00:00
Itiel
e6d04b60d8 Bug 1532172 - Fix separators in the context menu for downloaded files in the Library r=dao
Differential Revision: https://phabricator.services.mozilla.com/D72048
2020-04-29 15:47:03 +00:00
Jean-Yves Avenard
07d72f57f6 Bug 1630192 - Wait for the page to load before attempting to retrieve element. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72506
2020-04-26 10:42:24 +00:00
Mihai Alexandru Michis
bd67a54949 Backed out changeset aa46487d3145 (bug 1599138) for causing failures in ToolbarPanelHub.jsm
CLOSED TREE
2020-04-25 02:43:50 +03:00
emcminn
1c22ae465d Bug 1599138 - UI update and pref toggle for Whats New Panel r=andreio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D71341
2020-04-24 19:48:43 +00:00
Tim Nguyen
5a254f3623 Bug 1632092 - Rename all XUL namespace variables to XUL_NS. r=Gijs,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D71913
2020-04-24 09:23:52 +00:00
Emilio Cobos Álvarez
e05d3b513e Bug 1612427 - Fix flaky browser_947914_button_zoomReset.js. r=Gijs
This is what I see when running the test:

console.log: Changing zoom for browser from 1 to 0.5
	set fullZoom@chrome://global/content/elements/browser-custom-element.js:812:19
	set fullZoom@chrome://browser/content/tabbrowser.js:526:7
	ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
	set zoom@chrome://global/content/viewZoomOverlay.js:49:10
	@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:26:5
	Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1039:34
	Tester_execTest@chrome://mochikit/content/browser-test.js:1074:11
	nextTest/<@chrome://mochikit/content/browser-test.js:904:14
	SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23

"FullZoomChange for browser"

PASS Zoom reset button exists in Panel Menu -

console.log: Changing zoom for browser from 0.5 to 1
	console.log: set fullZoom@chrome://global/content/elements/browser-custom-element.js:817:19
	ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
	FullZoom__applyPrefToZoom@chrome://browser/content/browser-fullZoom.js:479:19
	FullZoom_onLocationChange@chrome://browser/content/browser-fullZoom.js:247:14
	XWB_onUpdateCurrentBrowser@chrome://browser/content/browser.js:5419:16
	callListeners@chrome://browser/content/tabbrowser.js:820:31
	_callProgressListeners@chrome://browser/content/tabbrowser.js:834:22
	_callProgressListeners@chrome://browser/content/tabbrowser.js:5776:46
	onStateChange@chrome://browser/content/tabbrowser.js:6039:14
	_callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:75:31
	onStateChange@resource://gre/modules/RemoteWebProgress.jsm:88:10

Which is pretty broken (the zoom is reset way earlier than clicking the reset
button, by FullZoom.onLocationChange).

This seems to me was mostly passing by chance, but with my Fission changes
which made FullZoomChange events more async (and actually, not notify twice) it
started failing.

Wait to load a page before changing the zoom level so that the browser doesn't
reset it when navigating.

Differential Revision: https://phabricator.services.mozilla.com/D72208
2020-04-24 08:13:37 +00:00
Dão Gottwald
c8d56c1ef5 Bug 1577029 - Remove bogus max-height from Firefox Account menu header. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72025
2020-04-23 21:56:02 +00:00
Gijs Kruitbosch
b14bbb1d75 Bug 1627685 - do not wipe out widths if the search bar only overflows temporarily, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71343
2020-04-22 09:18:49 +00:00
aarushivij
8101730a74 Bug 908954 - Remove try…catch comment inside wrapWidgetEventHandler once bug 503244 is fixed r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D71268
2020-04-17 05:50:56 +00:00
Gijs Kruitbosch
4890e67e21 Bug 1616881 - get rid of uses-unsafe-cpows, r=mconley
This removes the annotation from the following tests:

browser/base/content/test/general:
- browser_bug735471.js by removing the test
- browser_clipboard.js which seems like it's not using CPOWs anyway
- browser_blockHPKP.js which is disabled and isn't using CPOWs anyway

browser/components/customizableui/test:
- browser_934951_zoom_in_toolbar.js as CPOW usage was removed in bug 962248

toolkit/components/reader/test:
- browser_readerMode_with_anchor.js as CPOW usage was already removed in bug 1492482

toolkit/content/tests/browser:
- browser_datetime_datepicker.js as CPOW usage was removed in bug 1492482
- browser_saveImageURL.js which used deprecated CPOW-only APIs that I removed in an earlier cset

It also removes all the test framework code relying on this annotation.

Depends on D70685

Differential Revision: https://phabricator.services.mozilla.com/D70686

--HG--
extra : moz-landing-system : lando
2020-04-13 18:05:00 +00:00
Emilio Cobos Álvarez
142b7d3c57 Bug 1629096 - Always honor scroll-margin / scroll-padding from nsFocusManager. r=masayuki
We should always do this, otherwise stuff may not end up being visible which is
not acceptable for focus navigation.

Differential Revision: https://phabricator.services.mozilla.com/D70541

--HG--
extra : moz-landing-system : lando
2020-04-13 11:34:48 +00:00
Emma Malysz
1932ea0454 Bug 1590573 - Followup: Revert changes on elements that don't use MozXULElement. CLOSED TREE
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D70261

--HG--
extra : histedit_source : 02e207270852df2de6e07100aa7632c179a6e5dc
2020-04-08 21:38:56 +00:00
Dave Townsend
37684e9720 Bug 1627803: Rename SSB menu items (again). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D70061

--HG--
extra : moz-landing-system : lando
2020-04-08 19:21:18 +00:00
Emma Malysz
a7282ce447 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-08 16:17:50 +00:00
Razvan Maries
072b678c5a Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE 2020-04-08 07:43:49 +03:00
Emma Malysz
b657384896 Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866

--HG--
extra : moz-landing-system : lando
2020-04-07 23:56:45 +00:00
Edgar Chen
0409345a7c Bug 1615732 - Don't dispatch xul command event on Mac if it is from mouse event with ctrl key is pressed; r=Gijs,NeilDeakin
Depends on D68775

Differential Revision: https://phabricator.services.mozilla.com/D68735

--HG--
extra : moz-landing-system : lando
2020-04-06 23:59:53 +00:00
Edgar Chen
3daf62b4fb Bug 1615732 - Don't show menu panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66397

--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:23 +00:00
Artem
c7560c016c Bug 1625480 - convert remaining notifications strings from browser.dtd to fluent r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D69307

--HG--
extra : moz-landing-system : lando
2020-04-03 21:10:49 +00:00
Cosmin Sabou
3b3f1af25e Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)

--HG--
extra : histedit_source : 16a05a43f3a9666c4fcf244062c28a5dc81061fd
2020-04-06 23:49:58 +03:00
Edgar Chen
f8e3c1a6a9 Bug 1615732 - Don't dispatch xul command event on Mac if it is from mouse event with ctrl key is pressed; r=Gijs,NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D68735

--HG--
extra : moz-landing-system : lando
2020-04-06 13:15:30 +00:00
Edgar Chen
9e5dc0120e Bug 1615732 - Don't show menu panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66397

--HG--
extra : moz-landing-system : lando
2020-03-17 00:55:04 +00:00
Sylvestre Ledru
be18fd4dba Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D67319

--HG--
extra : moz-landing-system : lando
2020-03-19 13:47:51 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Vlad Filippov
b2e173a799 Bug 1590946 - Remove service=sync from account management links. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D63737

--HG--
extra : moz-landing-system : lando
2020-03-13 20:53:12 +00:00
Dão Gottwald
e938695219 Bug 1620536 - Move "Import from Another Browser" to the Help menu. r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D66551

--HG--
extra : moz-landing-system : lando
2020-03-13 17:29:15 +00:00
Emma Malysz
039ee11a9d Bug 1600228, lazy load the edit bookmark panel by storing in an HTML template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66143

--HG--
extra : moz-landing-system : lando
2020-03-13 02:22:42 +00:00
Cosmin Sabou
571c1e5045 Backed out changeset 2befc9d57826 (bug 1600228) for bc failures on browser_asrouter_bookmarkpanel.
CLOSED TREE
2020-03-13 02:47:45 +02:00
Emma Malysz
91c78bd4a6 Bug 1600228, lazy load the edit bookmark panel by storing in an HTML template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66143

--HG--
extra : moz-landing-system : lando
2020-03-12 22:01:01 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Ed Lee
24153cdf6f Bug 1618346 - Add browser import to Firefox menu r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D65420

--HG--
extra : moz-landing-system : lando
2020-03-05 06:07:08 +00:00
Greg Tatum
16a5f282e3 Bug 1597378 - Create new UI for the profiler popup; r=julienw
This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.

The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.

This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.

Differential Revision: https://phabricator.services.mozilla.com/D62914

--HG--
extra : moz-landing-system : lando
2020-03-02 16:40:38 +00:00
Marco Bonardo
8e3ea27643 Bug 1612653 - Update 'Bookmark This Page' menuitems when the star state changes. r=Standard8
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.

Differential Revision: https://phabricator.services.mozilla.com/D64399

--HG--
extra : moz-landing-system : lando
2020-02-27 12:04:15 +00:00
Dave Townsend
54615a06b1 Bug 1617679: Reword the SSB menus and add a page action icon. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D63920

--HG--
extra : moz-landing-system : lando
2020-02-26 22:15:19 +00:00
Arthur Iakab
2f1c972d30 Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing devtools failures on browser_all_files_referenced.js
Backed out changeset eef173a3678d (bug 1617208)
Backed out changeset cc21fa09b88d (bug 1597378)
Backed out changeset b802ce66aa59 (bug 1597378)
Backed out changeset c65103d7bf0b (bug 1597378)
Backed out changeset 35da034acf03 (bug 1597378)
Backed out changeset 4e152220ad14 (bug 1144438)

--HG--
rename : devtools/client/performance-new/test/browser/browser_popup-record-capture.js => devtools/client/performance-new/test/browser/browser_popup-end-to-end-click.js
rename : devtools/client/performance-new/test/browser/browser_aboutprofiling-env-restart-button.js => devtools/client/performance-new/test/browser/browser_popup-env-restart-button.js
rename : devtools/client/performance-new/test/browser/browser_aboutprofiling-features-disabled.js => devtools/client/performance-new/test/browser/browser_popup-features-disabled.js
2020-02-26 03:22:40 +02:00
Greg Tatum
f34a461b3d Bug 1597378 - Create new UI for the profiler popup; r=julienw
This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.

The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.

This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.

Differential Revision: https://phabricator.services.mozilla.com/D62914

--HG--
extra : moz-landing-system : lando
2020-02-25 20:39:27 +00:00
Arthur Iakab
854fd7a3b4 Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on test_perf-settings-entries.html.
Backed out changeset 2181d8a99229 (bug 1617208)
Backed out changeset 38c8db44b398 (bug 1597378)
Backed out changeset b2f0cf9a387e (bug 1597378)
Backed out changeset 4d1ff8bd4e64 (bug 1597378)
Backed out changeset 9b760d8fc1dc (bug 1597378)
Backed out changeset bc5727185383 (bug 1144438)

--HG--
rename : devtools/client/performance-new/test/browser/browser_popup-record-capture.js => devtools/client/performance-new/test/browser/browser_popup-end-to-end-click.js
rename : devtools/client/performance-new/test/browser/browser_aboutprofiling-env-restart-button.js => devtools/client/performance-new/test/browser/browser_popup-env-restart-button.js
rename : devtools/client/performance-new/test/browser/browser_aboutprofiling-features-disabled.js => devtools/client/performance-new/test/browser/browser_popup-features-disabled.js
2020-02-25 20:51:07 +02:00
Greg Tatum
10b5ed8b35 Bug 1597378 - Create new UI for the profiler popup; r=julienw
This commit implements the actual UI changes. A follow-up commit adds the
tests for the changes. The CSS is a little bit awkard since it uses lots of
ID selectors rather than class selectors. I wanted to be able to write quick
selects, since it's selecting across the entire browser document. I feel
a little conflicted with the approach, as I would prefer to use classes in
general.

The panel.jsm.js file collects all of the UI handling changes rather than
having everything in menu-button.jsm.js, as the latter can get loaded
at startup. I'm not sure if it's completely worth the trouble of having
two files, as most of it should be pretty light.

This commit does not handle localization for the panel, as we should be moving
to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774.

Differential Revision: https://phabricator.services.mozilla.com/D62914

--HG--
extra : moz-landing-system : lando
2020-02-25 16:47:19 +00:00
Gijs Kruitbosch
5169d79e96 Bug 1518500 - ensure we don't end up without a flexible space if moving items directly to toolbars, r=dao
Before this patch, we change aDraggedItemId somewhat late in the _applyDrop method -
significantly, we do this after the aTargetNode == areaCustomizationTarget check. So
we end up bailing out before adjusting aDraggedItemId, and we add the specific dummy
item from the palette into the toolbar, rather than adding a new spring to the
toolbar, and leaving the existing palette item alone.

Simply moving this adjustment to aDraggedItemId earlier into the method is sufficient
to fix the issue at hand.

Differential Revision: https://phabricator.services.mozilla.com/D62948

--HG--
extra : moz-landing-system : lando
2020-02-17 15:43:32 +00:00
Kousuke Takaki
cb722fa6db Bug 1542975 - Radio buttons in Forget panel are not keyboard navigable r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D61820

--HG--
extra : moz-landing-system : lando
2020-02-07 03:44:09 +00:00
Dão Gottwald
f07d464f9d Bug 1610497 - Increase browser window min-width so the address bar can be focused by mouse. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D60960

--HG--
extra : moz-landing-system : lando
2020-01-30 15:59:29 +00:00
Brian Grinstead
3d2d2d0ea7 Bug 1608281 - Automated rewrite away from reading properties on the global this in JSM files - round 1 r=mossop
This patch was generated with a script. It doesn't include all files:

- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)

It was generated with the following command using d855222aa2/no-this-property-read.js:

```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```

Differential Revision: https://phabricator.services.mozilla.com/D60187

--HG--
extra : moz-landing-system : lando
2020-01-29 21:50:04 +00:00
Dão Gottwald
5bf3f1776c Bug 1611689 - Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D61181

--HG--
extra : moz-landing-system : lando
2020-01-28 15:55:50 +00:00
Dão Gottwald
446563f92e Bug 1609938 - Enable tab animation when closing the customize tab via ESC key or Done button. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60248

--HG--
extra : moz-landing-system : lando
2020-01-17 23:22:49 +00:00
Dão Gottwald
3774eb8a9a Bug 1609932 - Make depopulatePalette synchronous and remove the customize tab immediately in CustomizeMode::exit. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60243

--HG--
extra : moz-landing-system : lando
2020-01-17 23:31:43 +00:00
Zibi Braniecki
4fb4f2f900 Bug 1609585 - Migrate all possible uses from AppLocalesAsLangTag(s) to AppLocale(s)AsBCP47. r=marionette-reviewers,jfkthame,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D60096

--HG--
extra : moz-landing-system : lando
2020-01-17 19:29:09 +00:00
Dão Gottwald
063ff0ea9e Bug 883397 - Remove redundant about:blank check from CustomizeMode.exit. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60146

--HG--
extra : moz-landing-system : lando
2020-01-16 17:20:11 +00:00
Dão Gottwald
bca8987c92 Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D58763

--HG--
extra : moz-landing-system : lando
2020-01-16 11:41:36 +00:00
Shane Caraveo
7fa8b283f6 Bug 1544975 remove private window extension change notification r=robwu,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D57716

--HG--
extra : moz-landing-system : lando
2020-01-03 23:01:54 +00:00
Harry Twyford
ed874ca75f Bug 1601334 - Increase Urlbar min-width. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D55835

--HG--
extra : moz-landing-system : lando
2020-01-10 20:02:35 +00:00
Erica Wright
a273e05e06 Bug 1603545 - Add telemetry for app menu protections button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D58044

--HG--
extra : moz-landing-system : lando
2020-01-09 17:50:11 +00:00
Dão Gottwald
cfeb15e21a Bug 1607160 - Skip positioned elements when calculating whether a toolbar overflows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59299

--HG--
extra : moz-landing-system : lando
2020-01-09 17:07:38 +00:00
Noemi Erli
c01a50c28c Backed out changeset bc55dd49ef82 (bug 1603545) for causing build bustages CLOSED TREE 2020-01-09 18:25:18 +02:00
Erica Wright
1966f381fa Bug 1603545 - Add telemetry for app menu protections button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D58044

--HG--
extra : moz-landing-system : lando
2020-01-09 15:57:02 +00:00
Coroiu Cristina
a11955a5ba Backed out changeset e2a0b2626fe8 (bug 1560348) for frequently failing browser-chrome at browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js 2020-01-08 10:13:51 +02:00
Dão Gottwald
dd16ec0252 Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D58763

--HG--
extra : moz-landing-system : lando
2020-01-07 11:28:13 +00:00
Brindusan Cristian
74bfffec0d Backed out changeset c716cc9f2a70 (bug 1560348) for bc failures at browser_lwt_telemetry.js. CLOSED TREE 2020-01-07 13:08:00 +02:00
Dão Gottwald
75e1b2d43f Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D58763

--HG--
extra : moz-landing-system : lando
2020-01-06 17:45:27 +00:00
Masayuki Nakano
0a74bf0038 Bug 1605918 - Get rid of synthesizeDragStart() in EventUtils.js r=smaug
All usage of `synthesizeDragStart()` is, starting drag, cancel `dragstart`,
and finally compares `dataTransfer` items and given expected data.  So,
we can make the users use `synthesizePlainDragAndDrop()` instead.  It's
better API because it computes position of mouse operations at runtime and
checks whether the drag start was succeeded with optional logging feature
(i.e., it's easier to debug of intermittent failures).

This patch creates `synthesizePlainDragAndCancel()` for convenience.  It
handles `dragstart` instead of the callers.

Differential Revision: https://phabricator.services.mozilla.com/D58214

--HG--
extra : moz-landing-system : lando
2019-12-27 16:25:24 +00:00
Morgan Reschenberg
6274ebbf20 Bug 1590485: Add UI/UX and global zoom functionality. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D50845

--HG--
extra : moz-landing-system : lando
2019-12-24 01:56:32 +00:00
Dave Townsend
06456f883d Bug 1603272: List installed site specific browsers in the app menu. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D57015

--HG--
extra : moz-landing-system : lando
2019-12-23 18:58:03 +00:00
Vijay Budhram
69c06d53ba Bug 1597994 - Update FxA menu manage account labels r=markh,flod
Differential Revision: https://phabricator.services.mozilla.com/D57548

--HG--
extra : moz-landing-system : lando
2019-12-23 14:42:09 +00:00
Masayuki Nakano
87ca855ece Bug 1603074 - part 1: Make synthesizePlainDragAndDrop() synthesize drag events without DataTransfer object r=smaug
`synthesizePlainDragAndDrop()` synthesizes drag events with `DataTransfer`
object which is set to `DragEvent.dataTransfer` of `dragstart` after starting
drag session explicitly.  However, this causes
`EventStateManager::DoDefaltDragStart()` does not initialize `nsIDragService`
instance.  Therefore, synthesized drag events cannot work with editor because
`DragEvent::GetMozSourceNode()` returns `nullptr` due to
`nsIDragSession::GetSourceNode()` returning `nullptr`.

On the other hand, synthesized drag events cannot use
`nsIDragService::InvodeDragSession()` normally because of hitting an assertion.
https://searchfox.org/mozilla-central/rev/690e903ef689a4eca335b96bd903580394864a1c/widget/nsBaseDragService.cpp#230-233

This patch does:
- mark drag events caused by synthesized mouse events as "synthesized for tests"
- make `synthesizePlainDragAndDrop()` stop using
  `nsIDragService.startDragSession()`
- make `nsBaseDragService` initialize and start session even for synthesized
  `dragstart` event
- make `synthesizePlainDragAndDrop()` stop synthesizing drag events with
  `DataTransfer` object since it's normal behavior and it'll be initialized
  with `nsIDragService::GetDataTransfer()`
- make `nsBaseDragService` store `effectAllowed` for the session only when
  it's synthesized session because it's required at initializing synthesized
  default `dropEffect` value of `dragenter`, `dragover`, `dragexit` and `drop`
  events' `dataTransfer`
- make all tests which use `nsIDragService.startDragSession()` use new
  API, `nsIDragService.startDragSessionForTests()` to initialize session's
  `effectAllowed` value
- make `EventStateManager::PostHandleEvent()` set drag end point of the test
  session to `eDrop` event's screen point
- make `synthesizePlainDragAndDrop()` set drag end point of the session if
  it does not synthesize `drop` event because following `endDragSession()`
  use it at dispatching `dragend` event on the source element

Additionally, this adds `dumpFunc` new param to `synthesizePlainDragAndDrop()`
because it's really useful to investigate the reason why requesting DnD isn't
performed as expected.

Differential Revision: https://phabricator.services.mozilla.com/D57425

--HG--
extra : moz-landing-system : lando
2019-12-21 12:27:06 +00:00
Noemi Erli
cc63a32cca Backed out changeset c8040f57cb4a (bug 1590485) fot failures in browser_default_zoom_multitab.js 2019-12-20 09:51:31 +02:00
Morgan Reschenberg
2895fb8739 Bug 1590485: Add UI/UX and global zoom functionality. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D50845

--HG--
extra : moz-landing-system : lando
2019-12-20 05:09:43 +00:00
Zibi Braniecki
bb46639778 Bug 1600528 - Migrate browser-context.inc to Fluent. r=Gijs,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D55396

--HG--
extra : moz-landing-system : lando
2019-12-18 06:26:58 +00:00
Henri Sivonen
cb595530fa Bug 1604158 - Hide the encoding detector submenu in hamburger/toolbar cases when chardetng is enabled. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D57305

--HG--
extra : moz-landing-system : lando
2019-12-16 13:43:15 +00:00
Kris Maglione
94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:16 +00:00
Noemi Erli
c220488775 Backed out changeset a8e371771008 (bug 1590485) for failing in browser_default_zoom.js 2019-12-13 00:11:08 +02:00
Morgan Reschenberg
be77302b4e Bug 1590485: Add UI/UX and global zoom functionality. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D50845

--HG--
extra : moz-landing-system : lando
2019-12-12 17:24:12 +00:00
Mark Hammond
5a897829db Bug 1598979 - make the device name in the sync-tabs menu visible to screen readers. r=Gijs,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D56677

--HG--
extra : moz-landing-system : lando
2019-12-11 23:45:55 +00:00
shindli
91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione
16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:13 +00:00
Noemi Erli
82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-07 19:11:58 +00:00
Daniel Varga
84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-06 22:14:14 +00:00
Julian Descottes
81e34d9437 Bug 1600333 - Remove all tags = clipboard from the codebase r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D55305

--HG--
extra : moz-landing-system : lando
2019-12-05 11:07:10 +00:00
Mike Conley
958abb2af9 Bug 1594227 - Add Fission testing menu items to the File menu. r=NeilDeakin
These menu items are only visible in Nightly when Fission is enabled,
and they're only for testing, which is why I've opted to not use Fluent
for localization, and just hard-coded the strings and accesskeys. These
menu items will never ride to release.

Differential Revision: https://phabricator.services.mozilla.com/D55004

--HG--
extra : moz-landing-system : lando
2019-11-27 19:23:08 +00:00
Brian Grinstead
d497e5fd20 Bug 1596591 - Rename inc.xul files to inc.xhtml r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53843

--HG--
rename : browser/base/content/browser-allTabsMenu.inc.xul => browser/base/content/browser-allTabsMenu.inc.xhtml
rename : browser/base/content/macWindow.inc.xul => browser/base/content/macWindow.inc.xhtml
rename : browser/components/controlcenter/content/identityPanel.inc.xul => browser/components/controlcenter/content/identityPanel.inc.xhtml
rename : browser/components/controlcenter/content/protectionsPanel.inc.xul => browser/components/controlcenter/content/protectionsPanel.inc.xhtml
rename : browser/components/customizableui/content/customizeMode.inc.xul => browser/components/customizableui/content/customizeMode.inc.xhtml
rename : browser/components/customizableui/content/panelUI.inc.xul => browser/components/customizableui/content/panelUI.inc.xhtml
rename : browser/components/downloads/content/downloadsCommands.inc.xul => browser/components/downloads/content/downloadsCommands.inc.xhtml
rename : browser/components/downloads/content/downloadsContextMenu.inc.xul => browser/components/downloads/content/downloadsContextMenu.inc.xhtml
rename : browser/components/downloads/content/downloadsPanel.inc.xul => browser/components/downloads/content/downloadsPanel.inc.xhtml
rename : browser/components/downloads/content/downloadsStrings.inc.xul => browser/components/downloads/content/downloadsStrings.inc.xhtml
rename : browser/components/places/content/bookmarksHistoryTooltip.inc.xul => browser/components/places/content/bookmarksHistoryTooltip.inc.xhtml
rename : browser/components/places/content/editBookmarkPanel.inc.xul => browser/components/places/content/editBookmarkPanel.inc.xhtml
rename : browser/components/places/content/placesCommands.inc.xul => browser/components/places/content/placesCommands.inc.xhtml
rename : browser/components/places/content/placesContextMenu.inc.xul => browser/components/places/content/placesContextMenu.inc.xhtml
extra : moz-landing-system : lando
2019-11-21 09:46:01 +00:00
Gijs Kruitbosch
5b1dbc026d Bug 1595772 - make overflow panel arrow position in customize mode more reliably correct, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D52934

--HG--
extra : moz-landing-system : lando
2019-11-15 10:25:06 +00:00
Edouard Oger
6e3d62fb87 Bug 1593065 - Remove XBL workaround for setting deck index. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D51319

--HG--
extra : moz-landing-system : lando
2019-10-31 22:10:51 +00:00
Morgan Reschenberg
3860fd55bf Bug 1592719: Label zoom buttons (+/-) and full-screen button in hamburger menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D51153

--HG--
extra : moz-landing-system : lando
2019-10-31 16:57:26 +00:00
gfmcknight
79bcb52abe Bug 1405031 - Add middle-click and click modifiers to browserAction r=robwu,Gijs
and pageActions.

Before this change, browserActions and pageActions did not trigger
onClick events when middle-clicked, and no information on the button or
any modifiers were passed in the onClick event. With this change, middle
clicking triggers an event, and a clickData object is passed in the
onClick event, with the button and a list of modifiers.

Differential Revision: https://phabricator.services.mozilla.com/D41492

--HG--
extra : moz-landing-system : lando
2019-10-28 15:33:11 +00:00
Gijs Kruitbosch
d778638ac3 Bug 1490745 - ensure we wait for the actual test page to finish loading, r=mconley
The browserLoaded() promise can be resolved by about:blank loads, it seems.
Being explicit about the load we're waiting for fixes this issue.

Differential Revision: https://phabricator.services.mozilla.com/D50818

--HG--
extra : moz-landing-system : lando
2019-10-28 15:58:50 +00:00
Edouard Oger
f6c6575b00 Bug 1588793 - Load Sync Now string at startup. r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D49296

--HG--
extra : moz-landing-system : lando
2019-10-15 17:17:52 +00:00
Dorel Luca
fafb51f01d Backed out changeset 7f353853da83 (bug 1588793) as requsted by the dev. CLOSED TREE 2019-10-15 18:43:25 +03:00
Edouard Oger
8b32e670f0 Bug 1588793 - Load Sync Now string at startup. r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D49296

--HG--
extra : moz-landing-system : lando
2019-10-15 15:26:24 +00:00
Edouard Oger
25eb2d60df Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
Andreea Pavel
eb350d4f6b Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE 2019-10-11 00:53:42 +03:00
Edouard Oger
136a86deed Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
Tim Nguyen
822add064c Bug 1513325 - Remove textbox binding. r=emilio,dao
Differential Revision: https://phabricator.services.mozilla.com/D38955

--HG--
extra : moz-landing-system : lando
2019-10-09 09:27:28 +00:00
Vijay Budhram
3245b0b0a8 Bug 1587143 - Updated the Fxa toolbar devices button link r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D48589

--HG--
extra : moz-landing-system : lando
2019-10-08 18:42:46 +00:00
Greg Tatum
3d718557fc Bug 1580469 - Create end to end profile capture tests; r=julienw
This patch creates the first full mochitest that exercises the profiler
popup's mechanisms of capturing profiles. The test tries to use user-focused
mechanisms–clicking buttons to fully capture a profile.

In addition, it fixes two leaks that were uncovered by the leaktest check.
The first has to do with the iframe src creating an about:blank page when
set to an empty string. The next was the Services.obs.addObserver call
in the perfFrontInterface not being removed when the page was unloaded.

Differential Revision: https://phabricator.services.mozilla.com/D45530

--HG--
extra : source : f44e632769d75b428d0a84a3274bdf45095b91fc
2019-10-04 18:23:48 +00:00
Daniel Varga
038d80fc3b Backed out 2 changesets (bug 1580469, bug 1581975) for devtools failure at browser/browser_aboutdebugging_serviceworker_timeout.js
Backed out changeset f44e632769d7 (bug 1580469)
Backed out changeset 5a3661caf52f (bug 1581975)

--HG--
extra : rebase_source : 4ab13ee495ce0709daaaed4e3cec53d11bd3042a
2019-10-05 01:17:45 +03:00
Greg Tatum
bdf72887ea Bug 1580469 - Create end to end profile capture tests; r=julienw
This patch creates the first full mochitest that exercises the profiler
popup's mechanisms of capturing profiles. The test tries to use user-focused
mechanisms–clicking buttons to fully capture a profile.

In addition, it fixes two leaks that were uncovered by the leaktest check.
The first has to do with the iframe src creating an about:blank page when
set to an empty string. The next was the Services.obs.addObserver call
in the perfFrontInterface not being removed when the page was unloaded.

Differential Revision: https://phabricator.services.mozilla.com/D45530

--HG--
extra : moz-landing-system : lando
2019-10-04 18:23:48 +00:00
Gijs Kruitbosch
249fb2707b Bug 1586136 - enable browser_customization_context_menus.js for fission r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D48160

--HG--
extra : moz-landing-system : lando
2019-10-04 09:36:16 +00:00
Tim Nguyen
eec7bc66fd Bug 1586141 - Remove document.createXULElement("textbox") usages from tests. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D48138

--HG--
extra : moz-landing-system : lando
2019-10-04 00:56:28 +00:00
Vijay Budhram
5af8c9966d Bug 1570568 - Update Fxa menu to reflect decoupling r=eoger,markh
Differential Revision: https://phabricator.services.mozilla.com/D46891

--HG--
extra : moz-landing-system : lando
2019-10-03 18:04:56 +00:00
Mark Hammond
42b1e658e0 Bug 1584076 - Hide the 'Firefox Services' label when there are no services. r=vbudhram
Differential Revision: https://phabricator.services.mozilla.com/D47720

--HG--
extra : moz-landing-system : lando
2019-10-01 14:33:01 +00:00
Andrei Oprea
b47a6216fe Bug 1583231 - Fix indentation, tooltip use, and CSS of what's new panel and toolbarbutton r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46931

--HG--
extra : moz-landing-system : lando
2019-09-26 11:06:30 +00:00
Dão Gottwald
fe21327223 Bug 1582797 - OverflowableToolbar should respond to resize events immediately. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46624

--HG--
extra : moz-landing-system : lando
2019-09-25 12:09:32 +00:00
Harry Twyford
27384ce378 Bug 1536312 - Reenable browser/components/customizableui/test/browser_884402_customize_from_overflow.js on Mac and Windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45886

--HG--
extra : moz-landing-system : lando
2019-09-23 14:44:49 +00:00
Dão Gottwald
28a3dbf885 Bug 1583148 - Stop subtracting border widths from clientWidth since it doesn't include borders in the first place. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46926

--HG--
extra : moz-landing-system : lando
2019-09-24 11:36:58 +00:00
Vijay Budhram
9ebe6010d5 Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Differential Revision: https://phabricator.services.mozilla.com/D45725

--HG--
extra : moz-landing-system : lando
2019-09-20 17:00:51 +00:00
Tim Nguyen
278a0d3de7 Bug 1582316 - Fix CSS broken by un-blockification of display: -moz-box - round 2. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D46497

--HG--
extra : moz-landing-system : lando
2019-09-20 18:13:45 +00:00
Dão Gottwald
9fb99cae94 Bug 1580538 - Make OverflowableToolbar work without overflow:hidden. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D46297

--HG--
extra : moz-landing-system : lando
2019-09-20 13:11:23 +00:00
Gurzau Raul
5589deded8 Backed out changeset 4ce6c9d4041a (bug 1575706) for failing at browser_duplicateIDs.js on a CLOSED TREE. 2019-09-20 00:54:38 +03:00
Vijay Budhram
35c8f2a5ea Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Differential Revision: https://phabricator.services.mozilla.com/D45725

--HG--
extra : moz-landing-system : lando
2019-09-19 19:27:02 +00:00
Gijs Kruitbosch
0077e210fe Bug 1561581 - listen for key events in panels 'later' than the builtin menu handling code, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D44679

--HG--
extra : moz-landing-system : lando
2019-09-18 22:48:15 +00:00
Gijs Kruitbosch
6a3d84c2f8 Bug 1580949 - avoid re-entry when showing extension subviews in the overflow panel, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46078

--HG--
extra : moz-landing-system : lando
2019-09-17 14:57:52 +00:00
Erica Wright
8b7d823b40 Bug 1561184 - Show tooltip text for protection report in app menu r=fluent-reviewers,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D45583

--HG--
extra : moz-landing-system : lando
2019-09-17 12:56:43 +00:00
Tim Nguyen
e043df8d78 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 06:22:42 +00:00
Mihai Alexandru Michis
f9580519b8 Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul
--HG--
rename : toolkit/content/widgets/autocomplete-input.js => toolkit/content/widgets/autocomplete.xml
2019-09-17 07:51:36 +03:00
Tim Nguyen
5d8a3da397 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 01:35:25 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Cosmin Sabou
68efd2f8f7 Backed out changeset 21ee43d26d0f (bug 1536312) for turning bug 1536312 into permafail. 2019-09-14 02:14:18 +03:00
Harry Twyford
a6bf2bfd9e Bug 1536312 - Reenable browser/components/customizableui/test/browser_884402_customize_from_overflow.js on Mac and Windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45886

--HG--
extra : moz-landing-system : lando
2019-09-13 21:39:06 +00:00
Gijs Kruitbosch
7e42abb897 Bug 1571236 - add logging to overflow toolbar code, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D45655

--HG--
extra : moz-landing-system : lando
2019-09-12 17:44:53 +00:00
Mark Striemer
b1093cbed5 Bug 1575208 - Fix partially hidden buttons in extension notification panels r=dao
Differential Revision: https://phabricator.services.mozilla.com/D45684

--HG--
extra : moz-landing-system : lando
2019-09-12 19:16:47 +00:00
Edouard Oger
926c5d067c Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
Differential Revision: https://phabricator.services.mozilla.com/D44484

--HG--
extra : moz-landing-system : lando
2019-09-11 01:17:46 +00:00
Brian Grinstead
080cc34472 Bug 1579470 - Remove goOfflineCmd.label and replace with menu-file-go-offline from ftl r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D45033

--HG--
extra : moz-landing-system : lando
2019-09-06 20:18:11 +00:00
harry
9219af6886 Bug 1578485 - Re-enable browser_918049_skipintoolbarset_dnd.js. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D45031

--HG--
extra : moz-landing-system : lando
2019-09-06 17:17:07 +00:00
Coroiu Cristina
19d1a50744 Bug 1536312 - disabled browser_884402_customize_from_overflow.js on windows and mac for frequest failures r=egao
Differential Revision: https://phabricator.services.mozilla.com/D44805

--HG--
extra : moz-landing-system : lando
2019-09-05 09:56:36 +00:00
harry
60ef93e2ce Bug 1577000 - Fix Megabar breakout width on window resize. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D43674

--HG--
extra : moz-landing-system : lando
2019-09-03 22:28:39 +00:00
Edouard Oger
b176311275 Bug 1575704 - Redirect to Sync preferences in Send Tab sign-in button. r=vbudhram
Differential Revision: https://phabricator.services.mozilla.com/D44251

--HG--
extra : moz-landing-system : lando
2019-09-03 15:40:29 +00:00
Coroiu Cristina
79d4e12a44 Backed out changeset 18705df33e23 (bug 1577000) for browser-chrome failures at browser/components/customizableui/test/browser_918049_skipintoolbarset_dnd.js 2019-09-03 04:05:35 +03:00
harry
6772173be2 Bug 1577000 - Fix Megabar breakout width on window resize. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D43674

--HG--
extra : moz-landing-system : lando
2019-09-02 18:12:22 +00:00
Gijs Kruitbosch
f931d77fe5 Bug 1573485 - put developer tools button back on the right/end of the toolbar in devedition, r=pbro,jaws
Differential Revision: https://phabricator.services.mozilla.com/D43599

--HG--
extra : moz-landing-system : lando
2019-08-27 14:35:52 +00:00
Nihanth Subramanya
f0c4c53fc9 Bug 1574196 - Properly wrap long subview header text in identity and protections panels. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43335

--HG--
extra : moz-landing-system : lando
2019-08-26 20:13:38 +00:00
Sylvestre Ledru
7759b614e2 Bug 1575249 - Ride along: remove +x permissions on source files r=Ehsan
Depends on D42672

Differential Revision: https://phabricator.services.mozilla.com/D42673

--HG--
extra : moz-landing-system : lando
2019-08-21 09:57:03 +00:00
Sebastian Hengst
235498bb68 Bug 1572955 - Remove devtools toolbar button in browser_984455_bookmarks_items_reparenting.js to get same available toolbar space across branches. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D42483

--HG--
extra : moz-landing-system : lando
2019-08-19 15:54:56 +00:00
Razvan Maries
54381141f5 Bug 1468890 - Disabled browser_967000_button_charEncoding.js on Linux. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D42458

--HG--
extra : moz-landing-system : lando
2019-08-19 09:25:05 +00:00
meghaaa
709224c55c Bug 1530781 - Replaced waitForCondition in browser_901207_searchbar_in_panel.js with TestUtils.waitForCondition. r=johannh
Differential Revision: https://phabricator.services.mozilla.com//D42085
2019-08-15 11:57:38 +03:00
Nihanth Subramanya
07a625aea2 Bug 1572528 - [Protections Panel] Update category item subviews. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41271

--HG--
extra : moz-landing-system : lando
2019-08-12 20:09:13 +00:00
Nihanth Subramanya
4e879f584b Bug 1563093 - Set an attribute on PanelMultiView popups when the main view is showing, and use it to style the Protections Panel anchor arrow. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41204

--HG--
extra : moz-landing-system : lando
2019-08-09 12:43:27 +00:00
Nihanth Subramanya
8e95b4661d Bug 1572416 - PanelMultiView: remove the min-height on the view container when navigating to the main view. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41202

--HG--
extra : moz-landing-system : lando
2019-08-09 12:43:15 +00:00
Vijay Budhram
8ea39bd830 Bug 1569620 - Update Fxa toolbar menu to latest skyline ux designs r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40103

--HG--
extra : moz-landing-system : lando
2019-08-07 18:07:23 +00:00
Jared Wein
776e7c17fb Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:49 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
bfdcad7ada Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:50 +00:00
Vijay Budhram
50c76e25ad Bug 1568866 - Update send to device panel for skyline r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40049

--HG--
extra : moz-landing-system : lando
2019-08-07 18:07:06 +00:00
Andreea Pavel
201f06b0bd Backed out 2 changesets (bug 1568866) bc failures at browser_misused_characters_in_strings.js on a CLOSED TREE
Backed out changeset d87d16fa1fa5 (bug 1568866)
Backed out changeset 75fb52a6d1f8 (bug 1568866)
2019-08-06 22:29:49 +03:00
Vijay Budhram
88444d1f53 Bug 1568866 - Update send to device panel for skyline r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40049

--HG--
extra : moz-landing-system : lando
2019-08-06 15:00:30 +00:00
Vijay Budhram
d9c1062c1c Bug 1562006 - Update FxA toolbar menu for skyline r=eoger,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D37961

--HG--
extra : moz-landing-system : lando
2019-08-02 13:55:19 +00:00
Tim Nguyen
b6d8cc41ad Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39594

--HG--
extra : moz-landing-system : lando
2019-07-31 15:22:08 +00:00
Marco Zehe
8f478ee1ea Bug 1569931 - Make the What's New contents panel a document for easier browsing for screen readers, r=andreio
This way, screen reader users can more easily browse all content provided by the What's New sections. Otherwise, only the buttons would be read, and screen reader users would have to use cumbersome navigation techniques to get to the rest of the contents.

This patch adds an WAI-ARIA role "document" to the container, which only changes screen reader behavior, but has otherwise no effect on styling or browser behavior.

Differential Revision: https://phabricator.services.mozilla.com/D39887

--HG--
extra : moz-landing-system : lando
2019-07-30 16:14:42 +00:00
Mihai Alexandru Michis
27acd9ae77 Backed out changeset f2b7c868c0a7 (bug 1562006) for browser chrome failures. CLOSED TREE 2019-07-29 23:37:58 +03:00
Vijay Budhram
d99505ac96 Bug 1562006 - Update FxA toolbar menu for skyline r=eoger,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D37961

--HG--
extra : moz-landing-system : lando
2019-07-29 16:21:22 +00:00
Erica Wright
f403d7852a Bug 1563547 - Update app menu to lead to the protection report. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D39549

--HG--
extra : moz-landing-system : lando
2019-07-29 19:15:11 +00:00
Kris Maglione
4bd4d680d4 Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D38725

--HG--
extra : rebase_source : 3e8b32b86b12b22d038baa770070a5c8095043c9
2019-07-17 13:37:48 -07:00
Boris Zbarsky
a818800ec5 Bug 1568278. Remove various unnecessary QIs to nsIDOMWindow. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D39065

--HG--
extra : moz-landing-system : lando
2019-07-24 01:26:07 +00:00
Gijs Kruitbosch
67a95099e3 Bug 1469113 - fix intermittent issues in browser_884402_customize_from_overflow.js, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D39002

--HG--
extra : moz-landing-system : lando
2019-07-23 17:17:00 +00:00
Tim Nguyen
eddd2fd9aa Bug 1567420 - Fix interactive element check in CustomizableUI.jsm. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D38728

--HG--
extra : moz-landing-system : lando
2019-07-19 20:15:33 +00:00
James Teh
f6179ac757 Bug 1561517: PanelMultiView: Don't override the tab key when an open menulist has focus. r=johannh
Tab in an open menulist should close the menulist.
Previously, we were overriding the tab key in this case, which meant that the menulist remained open while focus moved elsewhere.

Differential Revision: https://phabricator.services.mozilla.com/D37835

--HG--
extra : moz-landing-system : lando
2019-07-18 04:55:51 +00:00
Johann Hofmann
e0669dc2c5 Bug 1562575 - Part 2 - Move content blocking section into the protections panel. r=ewright
This is a pretty big change on paper, but most of the lines are copy-pasted, with some small
adjustments to get the content blocking code comfortable in browser-siteProtections.js.

Differential Revision: https://phabricator.services.mozilla.com/D37556

--HG--
extra : moz-landing-system : lando
2019-07-12 21:36:58 +00:00
Gijs Kruitbosch
b5b5d6a0ab Bug 1560178 - fix miscellaneous tests to allow them to keep working when disallowing remote content in the parent process, r=aswan,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D36310

--HG--
extra : moz-landing-system : lando
2019-07-12 16:27:58 +00:00
Dorel Luca
da86b02dc2 Backed out 3 changesets (bug 1562575) for Mochitest failures in browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js. CLOSED TREE
Backed out changeset fce18a9477b0 (bug 1562575)
Backed out changeset c9b01b908020 (bug 1562575)
Backed out changeset de006229ba8f (bug 1562575)
2019-07-12 18:42:19 +03:00