Commit graph

200 commits

Author SHA1 Message Date
Tim Giles
973bb4dad6 Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
Depends on D89078

Differential Revision: https://phabricator.services.mozilla.com/D91198
2020-11-17 21:38:33 +00:00
Mihai Alexandru Michis
e2ec982790 Backed out 2 changesets (bug 1613620, bug 1675557) for causing bc failures in browser_removeAllDialog.js
CLOSED TREE

Backed out changeset 46f96d192bbd (bug 1675557)
Backed out changeset 20a2fcd59084 (bug 1613620)
2020-11-17 18:40:20 +02:00
Tim Giles
8e6c2d4b17 Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
Depends on D89078

Differential Revision: https://phabricator.services.mozilla.com/D91198
2020-11-17 15:02:42 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Gijs Kruitbosch
79cf5eb5d9 Bug 1665442 - cleanup in browser migration code while passing by, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93617
2020-10-20 13:04:40 +00:00
Gijs Kruitbosch
1eb312de26 Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D94030
2020-10-19 16:16:21 +00:00
Jared Wein
21ab31bac4 Bug 1670810 - Don't create the 'From BrowserX' wrapper folder after import if the 2h2020 pref is enabled. r=Gijs
The value of this wrapper folder diminishes quickly over time and its presence is just a reminder of a users former browser.

Differential Revision: https://phabricator.services.mozilla.com/D93278
2020-10-13 10:00:38 +00:00
Jared Wein
fa53a5752f Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-28 15:21:57 +00:00
Butkovits Atila
dd5480d8da Backed out changeset f263318ebce4 (bug 1659736) for failure at test_Safari_bookmarks.js. CLOSED TREE 2020-08-28 01:49:31 +03:00
Jared Wein
f2e65e077b Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-27 20:45:23 +00:00
Razvan Maries
f916ec87b2 Backed out changeset 538c51598420 (bug 1659736) for perma failures on test_IE_bookmarks.js. CLOSED TREE 2020-08-25 21:04:59 +03:00
Jared Wein
df99f886f1 Bug 1659741 - Fix typo in Telemetry reporting of Safari migrator and add automated test. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88072
2020-08-25 16:38:53 +00:00
Jared Wein
b72b308558 Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88059
2020-08-25 16:35:43 +00:00
Jared Wein
32685b1f6e Bug 1659847 - Explicitly set the showBookmarksToolbarAfterMigration pref so tests will continue to run after the feature is disabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D87980
2020-08-24 10:32:27 +00:00
Jared Wein
972dd7e8cd Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 15:56:36 +00:00
Mihai Alexandru Michis
ff85a31698 Backed out changeset 8b917683232d (bug 1656277) for causing xpcshell failures in test_IE_bookmarks.js
CLOSED TREE
2020-08-14 08:36:35 +03:00
Jared Wein
2f679b3933 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 03:27:22 +00:00
Csoregi Natalia
324be7e980 Backed out changeset 4fc26e678c18 (bug 1656277) for failures on test_Edge_db_migration.js. CLOSED TREE 2020-08-14 04:21:35 +03:00
Jared Wein
3cce4b4e65 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Noemi Erli
fd115ffc27 Backed out changeset c2c4b8d6b915 (bug 1656277) for causing build bustages in nsDocShell.cpp CLOSED TREE 2020-08-14 01:13:41 +03:00
Jared Wein
d0ce281442 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Riley Byrd
ad82a96dad Bug 1518234 - Migrate migration wizard to Fluent r=flod,Gijs,fluent-reviewers
Based on a patch originally written by Ian Kirkpatrick <kirkpa47@msu.edu>

Differential Revision: https://phabricator.services.mozilla.com/D17393
2020-06-02 06:46:09 +00:00
Ed Lee
d556b5b824 Bug 1613337 - Support importing Windows Chrome/Edge logins with v10 AEAD format r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D64713

--HG--
extra : moz-landing-system : lando
2020-02-29 19:26:18 +00:00
Daniel Varga
888e5ef471 Backed out changeset 5e048feda16f (bug 1613337) mac and linux opt all_files_referenced failures 2020-02-29 21:12:33 +02:00
Ed Lee
5920b6c292 Bug 1613337 - Support importing Windows Chrome/Edge logins with v10 AEAD format r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D64713

--HG--
extra : moz-landing-system : lando
2020-02-29 16:19:18 +00:00
Matthew Noorenberghe
d81e89c89a Bug 1582738 - ChromeProfileMigrator: Don't initialize crypto if there are no rows. r=Gijs
Initializing OSCrypto can lead to a useless macOS Keychain prompt when there are no logins to import.

Differential Revision: https://phabricator.services.mozilla.com/D46616

--HG--
rename : browser/components/migration/tests/unit/AppData/Local/Google/Chrome/User Data/Default/Login Data => browser/components/migration/tests/unit/AppData/LocalWithNoData/Google/Chrome/User Data/Default/Login Data
rename : browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Default/Login Data => browser/components/migration/tests/unit/LibraryWithNoData/Application Support/Google/Chrome/Default/Login Data
rename : browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Local State => browser/components/migration/tests/unit/LibraryWithNoData/Application Support/Google/Chrome/Local State
rename : browser/components/migration/tests/unit/test_Chrome_passwords.js => browser/components/migration/tests/unit/test_Chrome_passwords_emptySource.js
extra : moz-landing-system : lando
2020-01-28 10:50:10 +00:00
Matthew Noorenberghe
f5aec46ab3 Bug 1216186 - Use the actual browser name for imported bookmark folders from Chromium. r=Gijs
Using _getLocalePropertyForBrowser isn't ideal but ideally this patch would get uplifted so I didn't want to do a larger refactoring to fix this.

Differential Revision: https://phabricator.services.mozilla.com/D61104

--HG--
extra : moz-landing-system : lando
2020-01-28 12:27:25 +00:00
Andreea Pavel
de61d02293 Bug 1558330 - disable test_MigrationUtils_timedRetry.js on mac shippable r=egao
Differential Revision: https://phabricator.services.mozilla.com/D54888

--HG--
extra : moz-landing-system : lando
2019-11-27 07:11:51 +00:00
Ehsan Akhgari
d0732b6e03 Bug 1591813 - Make nsICookieManager.getCookiesFromHost() return an Array<nsICookie>; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50750

--HG--
extra : moz-landing-system : lando
2019-10-28 12:08:09 +00:00
Matthew Noorenberghe
9fefa39499 Bug 1423714 - Import logins from Chrome/Chromium on macOS. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45155

--HG--
rename : browser/components/migration/tests/unit/AppData/Local/Google/Chrome/User Data/Default/Login Data => browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Default/Login Data
extra : moz-landing-system : lando
2019-09-18 04:47:34 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Ciure Andrei
9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Matthew Noorenberghe
4501fe3c9e Bug 1569414 - Don't hardcode a too old history visit date in test_Chrome_history.js.
Differential Revision: https://phabricator.services.mozilla.com/D39606

--HG--
extra : moz-landing-system : lando
2019-07-27 15:57:53 +00:00
Gijs Kruitbosch
2b449941ae Bug 1557960 - cope with 0 values in Chrome's date/time columns when importing, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D37810

--HG--
extra : moz-landing-system : lando
2019-07-15 21:52:56 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Matthew Noorenberghe
a74f1ce836 Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in browser/. r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D33346

--HG--
extra : moz-landing-system : lando
2019-06-05 05:33:24 +00:00
Andrea Marchesini
b1b122fb20 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Boris Zbarsky
fd4dae89f0 Bug 1551657 part 1. Stop using [array] in getAllLogins. r=MattN
I audited all the callsites
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BGg%5DetAllLogins%5B%5EA-Za-z_%5D&case=true&regexp=true&path=
brings up.

Differential Revision: https://phabricator.services.mozilla.com/D31117

--HG--
extra : moz-landing-system : lando
2019-05-14 19:28:51 +00:00
Matthew Noorenberghe
3675e85c1a Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster
Save it with the wildcard "" value so it works with any form action.

Differential Revision: https://phabricator.services.mozilla.com/D30332

--HG--
extra : moz-landing-system : lando
2019-05-09 22:59:18 +00:00
Sylvestre Ledru
ef0bfc3822 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D24168

--HG--
extra : moz-landing-system : lando
2019-03-31 15:12:55 +00:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Matthew Noorenberghe
6532cbeb1f Bug 1533288 - Test import of Internet Explorer history. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D22845

--HG--
extra : moz-landing-system : lando
2019-03-13 03:12:15 +00:00
Matthew Noorenberghe
60aedcf69e Bug 1533288 - Add an executable to insert IE history on test machines. r=jaws,firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D22844

--HG--
extra : moz-landing-system : lando
2019-03-13 03:12:08 +00:00
Jared Wein
e81fbc39e8 Bug 1529495 - Remove unused third argument to OSCrypto.decryptData and OSCrypto.encryptData. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D20628

--HG--
extra : moz-landing-system : lando
2019-02-21 15:35:27 +00:00
Jared Wein
f777b77069 Bug 1520949 - Use TextEncoder/TextDecoder to handle multibyte characters in passwords. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D20625

--HG--
extra : moz-landing-system : lando
2019-02-21 15:34:57 +00:00