nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
750732 commits 1 branch 98 tags 6.4 GiB
Commit graph

52 commits

Author SHA1 Message Date
Jan Varga
7d3ef83b0f Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers 
This patch:
- adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros
- adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros
- adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros
- replaces non-propagating uses of NS_WARNING with redundant messages by
  QM_WARNONLY_TRY
- replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...))
- replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY
- replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY.
- replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY
- replaces uses of QM_TRY with additional Maybe wrapping for doing a
  fallback with QM_TRY(QM_OR_ELSE_WARN(...))

Differential Revision: https://phabricator.services.mozilla.com/D108424
 2021-03-24 12:27:53 +00:00
Butkovits Atila
9fc0210ad3 Backed out changeset 2a3316bd2409 (bug 1686191) for causing bustages on QuotaCommon.h. CLOSED TREE 2021-03-24 07:12:55 +02:00
Jan Varga
6edcf204fd Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers 
This patch:
- adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros
- adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros
- adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros
- replaces non-propagating uses of NS_WARNING with redundant messages by
  QM_WARNONLY_TRY
- replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...))
- replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY
- replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY.
- replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY
- replaces uses of QM_TRY with additional Maybe wrapping for doing a
  fallback with QM_TRY(QM_OR_ELSE_WARN(...))

Differential Revision: https://phabricator.services.mozilla.com/D108424
 2021-03-24 04:40:10 +00:00
Simon Giesecke
d2bc5eec44 Bug 1686191 - Add support for warnings integrated with QM_TRY. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D102770
 2021-03-12 15:07:57 +00:00
Simon Giesecke
fbf7a1dad4 Bug 1686191 - Remove module argument from LogError. r=dom-workers-and-storage-reviewers,janv 
The module argument in LogError is redundant: the module information can
already be determined from the source file path. Indeed, reporting the module
separately in the telemetry events seems unnecessary. Instead, the relative
path is now reported. This is what the analysis of the telemetry data did
reconstruct anyway.

As a consequence, it's no longer necessary to define module-specific
HandleError functions, and therefore it's also unnecessary to define
module-specific TRY macros. These are retained as simple aliases for now,
but can be removed in a later patch entirely.

This also avoids misuses of a TRY macros in the wrong module, which were
happening a few times before, resulting in confusing output or telemetry
events.

Since Bug 1686191 will add some more TRY macro variants that warn, so
simplifying the module-specific aspects will simplify that task. Furthermore,
this is in preparation of moving the TRY macro extensions to MFBT.

Differential Revision: https://phabricator.services.mozilla.com/D102767
 2021-03-12 15:01:21 +00:00
Simon Giesecke
31f5386fe5 Bug 1686191 - Added a comment on the sequence number. r=dom-workers-and-storage-reviewers,janv DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D102768
 2021-03-04 09:13:21 +00:00
Simon Giesecke
989362a57a Bug 1690234 - Treat ERROR_FILE_CORRUPT errors like non-existent files in GetDirEntryKind. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D103762
 2021-02-04 12:14:45 +00:00
Simon Giesecke
78f8e0b696 Bug 1688164 - Synthesize name for WIN32 error codes. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D102702
 2021-01-22 08:39:17 +00:00
Simon Giesecke
d2ae46de32 Bug 1687254 - Add GetDirEntryKind utility function. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D102203
 2021-01-21 14:38:30 +00:00
Simon Giesecke
68f581dcca Bug 1685498 - Include sequence numbers in dom.quota.try telemetry event. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D101022
 2021-01-07 16:18:32 +00:00
Simon Giesecke
33fc668a0e Bug 1683132 - Include nsresult value in telemetry events. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D100089
 2020-12-21 09:32:12 +00:00
Jan Varga
67036b4b0f Bug 1665088 - QM: Extend LogError to report failures in telemetry. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D93759
 2020-12-09 20:01:07 +00:00
Mihai Alexandru Michis
0f41ae6c2d Backed out changeset 0d86551ac93b (bug 1665088) for causing multiple failures in dom quota. 
CLOSED TREE
 2020-12-09 20:19:24 +02:00
Jan Varga
70c1159f82 Bug 1665088 - QM: Extend LogError to report failures in telemetry. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D93759
 2020-12-09 17:39:50 +00:00
Simon Giesecke
0acc527c9e Bug 1678030 - Generalize CreateAndExecuteSingleStepStatement to accept an optional bind functor. r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D97462
 2020-12-04 15:15:31 +00:00
Simon Giesecke
1ff0e248eb Bug 1678030 - Support multiple variants of hasResult expectations in CreateAndExecuteSingleStepStatement. r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D97461
 2020-12-04 15:10:07 +00:00
Simon Giesecke
e6b749fc81 Bug 1678030 - Move CreateAndExecuteSingleStepStatement to QuotaCommon and use in all quota clients. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D97460
 2020-12-04 14:56:18 +00:00
Simon Giesecke
c4e55d7fd7 Bug 1671369 - Change QM_NewLocalFile to use QM_TRY. r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D94038
 2020-11-17 11:37:15 +00:00
Simon Giesecke
58611a371f Bug 1667015 - Output full path of source code files with NS_DebugBreak. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D91240
 2020-10-23 00:57:07 +00:00
Sylvestre Ledru
fde06f6d21 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 17:04:01 +00:00
Butkovits Atila
964cca3198 Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru
5f29324f60 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 08:29:00 +00:00
Simon Giesecke
1571adc7b0 Bug 1671369 - Move CloneFileAndAppend to QuotaCommon. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D93765
 2020-10-26 14:51:32 +00:00
Simon Giesecke
2282fb5a6a Bug 1626555 - Make dom/quota buildable outside of unified-build environment. r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D94011
 2020-10-21 13:16:19 +00:00
Simon Giesecke
d5b79ad8da Bug 1667957 - Use new IntTo(C)String functions in dom/quota and its clients. r=dom-workers-and-storage-reviewers,ttung 
Differential Revision: https://phabricator.services.mozilla.com/D91717
 2020-10-14 15:45:50 +00:00
Simon Giesecke
67084ddd9b Bug 1666216 - Enable ScopedLogExtraInfo logging. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D90877
 2020-09-30 08:24:18 +00:00
Simon Giesecke
f05dba1711 Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D90112
 2020-09-21 10:32:55 +00:00
Csoregi Natalia
2306d2079a Backed out 11 changesets (bug 1663924, bug 1664844) for multiple failures. CLOSED TREE 
Backed out changeset 2da9fde7a109 (bug 1663924)
Backed out changeset 9353759cc783 (bug 1663924)
Backed out changeset 309354891d60 (bug 1663924)
Backed out changeset 4e51461c369c (bug 1663924)
Backed out changeset e3196b68932c (bug 1663924)
Backed out changeset 25b16cbae152 (bug 1664844)
Backed out changeset e02961ac5ee7 (bug 1663924)
Backed out changeset dde2058c20ef (bug 1663924)
Backed out changeset a80f52551e3a (bug 1663924)
Backed out changeset 0c37ce712c2c (bug 1663924)
Backed out changeset 8cc5dcc86f40 (bug 1663924)
 2020-09-18 04:52:32 +03:00
Simon Giesecke
4f1ba76c89 Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D90112
 2020-09-17 09:38:12 +00:00
Razvan Maries
559e163f24 Backed out 9 changesets (bug 1663924, bug 1664844) for Linux Mochitests leaks. CLOSED TREE 
Backed out changeset 8d28611ac9b2 (bug 1663924)
Backed out changeset e0b0b3a19544 (bug 1663924)
Backed out changeset 884e286909f9 (bug 1663924)
Backed out changeset ffed28f0b547 (bug 1664844)
Backed out changeset 4c22c3c8aa28 (bug 1663924)
Backed out changeset fcaed021597c (bug 1663924)
Backed out changeset 30394cbcaaf6 (bug 1663924)
Backed out changeset 014bcf5d13b9 (bug 1663924)
Backed out changeset ccf09dfa817a (bug 1663924)
 2020-09-16 19:16:21 +03:00
Simon Giesecke
228c508686 Bug 1663924 - Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D90112
 2020-09-16 14:56:20 +00:00
Simon Giesecke
b26988fef6 Bug 1664412 - Mark some error handling functions as MOZ_COLD. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D89885
 2020-09-14 12:14:17 +00:00
Simon Giesecke
ec62d45a35 Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv 
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.

Differential Revision: https://phabricator.services.mozilla.com/D89148
 2020-09-08 07:40:30 +00:00
Jan Varga
ebcfb83228 Bug 1660751 - QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D88004
 2020-09-08 07:40:46 +00:00
Jan Varga
7ae4b87c84 Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg 
Differential Revision: https://phabricator.services.mozilla.com/D83927
 2020-07-24 07:11:24 +00:00
Andreea Pavel
fe64f78ef1 Backed out changeset c5a8759b3f85 (bug 1651016) for build bustages at gtest.h on a CLOSED TREE 2020-07-24 09:59:44 +03:00
Jan Varga
89a2c67112 Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg 
Differential Revision: https://phabricator.services.mozilla.com/D83927
 2020-07-24 06:35:07 +00:00
Mihai Alexandru Michis
74e45489fa Backed out 9 changesets (bug 1651016) for causing hazard failures in TestQuotaCommon.cpp 
CLOSED TREE

Backed out changeset 5e566996d34e (bug 1651016)
Backed out changeset 002ddedb37dc (bug 1651016)
Backed out changeset aed04f32eb91 (bug 1651016)
Backed out changeset 2f4529e62cd3 (bug 1651016)
Backed out changeset 8f2aa854a083 (bug 1651016)
Backed out changeset 7f6eb1658a16 (bug 1651016)
Backed out changeset 5d5b249ca664 (bug 1651016)
Backed out changeset 9142d4249c29 (bug 1651016)
Backed out changeset 8d2cc761e5ba (bug 1651016)
 2020-07-24 00:00:55 +03:00
Jan Varga
a14d13c5e0 Bug 1651016 - Introduce QM_TRY and QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,ttung,sg 
Differential Revision: https://phabricator.services.mozilla.com/D83927
 2020-07-23 09:17:00 +00:00
Simon Giesecke
9364b353d4 Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80631
 2020-07-01 08:42:31 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80860
 2020-07-01 08:29:29 +00:00
Jan Varga
f7200a696c Bug 1621920 - Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg 
Differential Revision: https://phabricator.services.mozilla.com/D80166
 2020-06-25 07:16:47 +00:00
Narcis Beleuzu
0084f5d032 Backed out 3 changesets (bug 1621920) for bustages on ActorsParent.cpp . CLOSED TREE 
Backed out changeset 6d94049a8f9e (bug 1621920)
Backed out changeset b85b0e346dee (bug 1621920)
Backed out changeset e3e3a090ee96 (bug 1621920)
 2020-06-25 10:08:13 +03:00
Jan Varga
5dac5d306c Bug 1621920 - Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg 
Differential Revision: https://phabricator.services.mozilla.com/D80166
 2020-06-25 06:27:01 +00:00
Tom Tung
718c6d81f9 Bug 1633326 - Add an additional warning message that shows the file path when it fails to create a file; r=janv,dom-workers-and-storage-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D72591
 2020-04-27 08:38:55 +00:00
Tom Tung
02b4a20039 Bug 1626846 - Disable useDOSDevicePathSyntax for QuotaStorage on Windows; r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D69318

--HG--
extra : moz-landing-system : lando
 2020-04-06 09:28:35 +00:00
Tom Tung
4debe01abb Bug 1536796 - P1 - Introduce a flag (useDOSDevicePathSyntax) to nsILocalFileWin and a method (QM_NewLocalFile) to QuotaCommon; r=janv,dom-workers-and-storage-reviewers,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D67873

--HG--
extra : moz-landing-system : lando
 2020-04-01 07:26:27 +00:00
Jan Varga
ae7651951f Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D47341

--HG--
extra : moz-landing-system : lando
 2019-10-02 04:28:23 +00:00
Byron Campen [:bwc]
13d7ab645a Bug 1566445: Rename a couple of macros to avoid conflicts. r=ttung 
Differential Revision: https://phabricator.services.mozilla.com/D38226

--HG--
extra : moz-landing-system : lando
 2019-07-20 15:56:31 +00:00
Jan Varga
82fad8077a Bug 1542572 - Add more temporary logging to LocalStorageShutdownTimeout crash annotation; r=asuth dr=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D34295
 2019-06-09 21:46:34 +02:00