- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
Several `show-all-link` controls lack interactive role - this would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc. Being focusable with keyboard does not guarantee that assistive technology could guess that this programmatically static text is, in fact, interactive.
While providing an explicit ARIA `role` to the element is going [against the First Rule of ARIA](https://www.w3.org/TR/using-aria/#rule1) while semantically appropriate HTML elements exist - `<a>` anchor (for the visual appearance of this control) or `<button>` (for the actual functionality that this control performs) - this patch would at least remove the barrier for assistive technology to be able to set interactivity expectations to this control appropriately.
No test manifests are being updated, because there are other elements in the updated test files that are failing a11y-checks, besides these `show-all-link` controls.
Differential Revision: https://phabricator.services.mozilla.com/D197349
Slightly different from the previous search revisions. In this case, rather than having their own search boxes, the recent browsing components share a single search box located within the parent element. Thus, `fxview-search-textbox-query` event listeners are added/removed from the //parent// component rather than the components themselves.
Differential Revision: https://phabricator.services.mozilla.com/D195596
- Moved "footer" to within sticky container above cards and renamed to "header".
- Update "Connect another device" button to use the `.small-button` styling
- Conditionally display `Recently closed tabs` `h2` on the corresponding view only (an existing bug revealed in this patch)
- Update `.sticky-container` to reflect upcoming styling with the inclusion of search and other secondary headers.
Please see link to bug for screenshot of intended appearance.
Differential Revision: https://phabricator.services.mozilla.com/D193930
Amending the `getRecentTabs` function eliminates one of the duplicate calls to `getTabClients`. I opted for this approach as opposed
to getting tabs from clients or vice versa because that involved a larger refactor that ended up adding unnecessary noise to the
`getRecentTabs` and `getTabClients` return values. Combined with a patch by @sfoster, we have reduced the number of calls from 9 to 1.
Differential Revision: https://phabricator.services.mozilla.com/D194656
Amending the `getRecentTabs` function eliminates one of the duplicate calls to `getTabClients`. I opted for this approach as opposed
to getting tabs from clients or vice versa because that involved a larger refactor that ended up adding unnecessary noise to the
`getRecentTabs` and `getTabClients` return values. Combined with a patch by @sfoster, we have reduced the number of calls from 9 to 1.
Differential Revision: https://phabricator.services.mozilla.com/D194656
* Add a type=page to the top-level ViewPage instances
* Rename viewTabVisibleCallback and viewTabHiddenCallback to view*Callback and call each when selectedness or visiblity changes
* Ensure active view/pages are always properly initialized during page load and category switching
* Add a test to verify no mutations happen when tabs change while firefox view is inactive
* Fix tests to better account for loading and readiness sequence when activating firefox view
Differential Revision: https://phabricator.services.mozilla.com/D193744
