Commit graph

388 commits

Author SHA1 Message Date
Perry McManis
eafc50638a Bug 1868441 - Update docs to reflect pingcentre being removed from messaging system r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D196493
2023-12-29 22:57:15 +00:00
Chris H-C
3a958a1442 Bug 1868988 - Remove PingCentre. Its watch has ended. r=nanj,thecount,perry.mcmanis
Differential Revision: https://phabricator.services.mozilla.com/D196227
2023-12-18 16:56:22 +00:00
Mike Conley
b004285019 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-14 18:46:57 +00:00
Butkovits Atila
8582db0ea5 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
ff511df662 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-13 23:29:49 +00:00
Paul Bone
9503eb0aca Bug 1863867 - Add support for targeting experiments based on memory r=barret
Differential Revision: https://phabricator.services.mozilla.com/D193160
2023-12-12 11:18:23 +00:00
Paul Bone
62b5d500fd Bug 1863867 - Add expriment targeting based on archiecture bits r=barret
Differential Revision: https://phabricator.services.mozilla.com/D193159
2023-12-12 11:18:23 +00:00
Nipun Shukla
b6b703dee7 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-12 00:22:08 +00:00
Mike Conley
6c38cdf414 Bug 1869327 - Fix typo / broken link in ASRouter targeting attributes source documentation. r=negin
Differential Revision: https://phabricator.services.mozilla.com/D196055
2023-12-11 15:25:51 +00:00
Mike Conley
15d11761c7 Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya,perftest-reviewers,sparky
Depends on D193855

Differential Revision: https://phabricator.services.mozilla.com/D193856
2023-12-06 16:15:16 +00:00
Mike Conley
da108723df Bug 1715158 - Remove ASRouterUISurface, snippet templates, and associated tests. r=pdahiya
Depends on D193853

Differential Revision: https://phabricator.services.mozilla.com/D193854
2023-12-06 16:15:15 +00:00
Amy Churchwell
352b5f7900 Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-22 00:14:26 +00:00
Cristian Tuns
709e423bb2 Backed out changeset d4424163a8bf (bug 1827969) for causing bc failures in browser_all_files_referenced.js 2023-11-21 14:06:46 -05:00
Amy Churchwell
f903c3fcf0 Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-21 17:55:45 +00:00
Iulian Moraru
d87f4291f2 Backed out changeset 51a922bf4c7e (bug 1827969) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2023-11-14 21:49:20 +02:00
Amy Churchwell
6c6634cd07 Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-14 16:42:39 +00:00
hanna alemu
6229b6aba7 Bug 1860892 - Remove Firefox View CFR message r=fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D192374
2023-11-07 18:09:39 +00:00
Shane Hughes
82eccc0225 Bug 1830715 - ASRouter devtools for editing and resetting impressions. r=omc-reviewers,emcminn
Adds some new ASRouter methods for resetting impressions of all 3 types,
message impressions, group impressions, and screen impressions, and
exposes them through some new buttons and textboxes in a new Impressions
tab in the ASRouter devtools.

Differential Revision: https://phabricator.services.mozilla.com/D178261
2023-10-25 20:52:29 +00:00
Sylvestre Ledru
82db67a6be Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow
Differential Revision: https://phabricator.services.mozilla.com/D191480
2023-10-19 20:52:10 +00:00
Jason Prickett
7c7249fa04 Bug 1857036 - create asrouter targeting for primary monitor resolution r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D190615
2023-10-12 05:36:26 +00:00
Emilio Cobos Álvarez
113b9abfc1 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
2023-10-08 23:07:36 +00:00
Gijs Kruitbosch
1e67277c8f Bug 1851544 - use clearer media queries in new tab styling, r=Standard8,omc-reviewers,thecount,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D188836
2023-09-27 14:45:18 +00:00
Dan Mosedale
59a4efbc78 Bug 1847977 - doc basic state of current PingCentre/Glean telemetry, r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D186181
2023-08-16 22:04:27 +00:00
Yoen Zhang
8b265aa184 Bug 1845388 - Update Experimenter Link to Messaging surfaces used in source doc. r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D184624
2023-07-31 19:50:17 +00:00
Yoen Zhang
e311e9822f Bug 1831211 - Add more detailed documentation for FxMS templates, overall message structure r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178895
2023-07-18 19:30:07 +00:00
Nick Alexander
006d8a8e09 Bug 1805514 - Part 1: Support launch_action in Windows native toast notifications. r=barret
`launch_action` is both top-level (when the toast is clicked) and
per-action (when a button is clicked).

Differential Revision: https://phabricator.services.mozilla.com/D182312
2023-07-15 02:34:05 +00:00
Cristina Horotan
d111bd326e Backed out changeset c22d4f75d4fe (bug 1831211) for causing generate failure 2023-07-08 01:36:33 +03:00
Yoen Zhang
00ab53a286 Bug 1831211 - Add more detailed documentation for FxMS templates, overall message structure r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178895
2023-07-07 22:07:18 +00:00
Mike Conley
c8f966abac Bug 1838926 - Add ASRouter targeting for whether or not the user has ever used the migration wizard to import passwords from a CSV file. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D181287
2023-06-23 14:14:26 +00:00
Iulian Moraru
3260deb1ae Backed out changeset 11d0cb525f1d (bug 1835212) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2023-06-13 00:34:23 +03:00
hanna alemu
80813356d3 Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D179839
2023-06-12 20:24:08 +00:00
Cristina Horotan
d8c5478bd7 Backed out changeset a79a0225de72 (bug 1835212) for causing bc failures at browser_feature_callout.js on a CLOSED TREE 2023-06-09 01:31:13 +03:00
hanna alemu
91fee18b36 Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D179839
2023-06-08 19:33:29 +00:00
Shane Hughes
cf053cf43d Bug 1832715 - Allow multistage spotlight OPEN_URL actions to include UTM params. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D177848
2023-06-08 19:20:07 +00:00
Katherine Patenio
0c1a6fdd6a Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D178568
2023-05-30 22:44:42 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Shane Hughes
e26b558dc1 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
2023-05-18 16:26:49 +00:00
Barret Rennie
b5843637dd Bug 1832827 - Improve Experimenter error messages for FxMS schemas r=aminomancer
Previously, when a `TemplatedMessage` was missing a required field, the error
on Experimenter would be that the message's template field was expected to be
`multi`. This happens because the `oneOf` doesn't match `TemplatedMessage` due
to required fields missing, so it infers it must be a `MultiMessage`.

Now instead of using a `oneOf` to match against either a `MultiMessage` or a
`TemplatedMessage`, we use an `if`/`then`/`else`, predicated by the `template`
key so that if `template != "multi"`, the errors will come form the
`TemplatedMessage` definition.

Differential Revision: https://phabricator.services.mozilla.com/D177914
2023-05-12 15:20:47 +00:00
Mark Banner
c2dd8e3266 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
Shane Hughes
9dc143a25a Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
2023-05-09 15:37:15 +00:00
hanna alemu
03c32cf3be Bug 1816511 - Allow messaging about:welcome users by screen usage r=omc-reviewers,pdahiya,jprickett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172836
2023-05-02 13:53:07 +00:00
Mike Conley
db83dfef1b Bug 1828117 - Add a convenient ASRouterTargeting attribute for clients installed via guided device migration from SUMO. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176185
2023-04-24 15:38:41 +00:00
Mike Conley
525e997fbb Bug 1820640 - Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r=pdahiya,omc-reviewers
This adds a card to the about:welcome defaults that embeds the new Migration Wizard
if  browser.migrate.content-modal.about-welcome-behavior is set to "embedded".

This requires adding a useEmbeddedMigrationWizard targeting attribute to
ASRouterTargeting.

Differential Revision: https://phabricator.services.mozilla.com/D175945
2023-04-21 03:18:12 +00:00
Dão Gottwald
3856cbf2e5 Bug 1828440 - BuiltInThemes cleanup: remove obsolete findActiveColorwayCollection, isColorwayFromCurrentCollection, isMonochromaticTheme, monochromaticSortIndices. r=amy,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D175647
2023-04-19 11:05:28 +00:00
hanna alemu
8d27d5d408 Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-14 15:36:39 +00:00
William Durand
6c776017c8 Bug 1828074 - Add new targeting attribute for RTAMO in ASRouter. r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D175463
2023-04-14 14:11:36 +00:00
Noemi Erli
b52f7d79af Backed out changeset e054b7d5f984 (bug 1825658) for causing newtab failures CLOSED TREE 2023-04-13 18:36:23 +03:00
hanna alemu
1cac2d773f Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-13 15:03:33 +00:00
Mike Conley
abc2c861ca Bug 1794617 - Add ASRouter targeting for whether or not the user has ever migrated bookmarks, history, or passwords. r=dmose,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D173579
2023-04-03 20:47:12 +00:00