nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
868908 commits 1 branch 98 tags 6.4 GiB
Commit graph

544 commits

Author SHA1 Message Date
Marco Bonardo
eb67cd98f8 Bug 1865087 - Add optional logging to PlacesTransactions. r=places-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D193814
 2023-11-20 19:09:12 +00:00
Marco Bonardo
bd25fec825 Bug 1852079 - Remove unused options from nsINavHistoryQuery and nsINavHistoryQueryOptions. r=daisuke,places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D187759
 2023-09-11 10:14:59 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Marco Bonardo
6d23aad6ea Bug 1818461 - Remove the synchronous PlacesUtils.getChildCountForFolder().r=daisuke,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175532
 2023-05-19 12:17:17 +00:00
Eemeli Aro
8798fa8e10 Bug 1830042 - Migrate placesContext_delete_history and placesContext_createBookmark to Fluent. r=mak,fluent-reviewers,flod 
Depends on D176641

Differential Revision: https://phabricator.services.mozilla.com/D176642
 2023-05-02 18:34:41 +00:00
Marco Bonardo
79a8867cf7 Bug 1820332 - Dragging URL from address bar results in bookmark with the URL instead of the page title. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D173689
 2023-03-27 14:44:50 +00:00
Abhishek Tiwari
3a7bf0c2e8 Bug 1821620 - Convert toolkit/components/forgetaboutsite to ES modules r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172230
 2023-03-14 21:36:38 +00:00
Kelly Cochrane
1e1ec80c65 Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak 
Differential Revision: https://phabricator.services.mozilla.com/D171253
 2023-03-14 10:29:57 +00:00
Kelly Cochrane
8451394735 Bug 1818800 - Only pass library telemetry function in controller.js if opening multiple tabs from Library r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D171024
 2023-02-26 19:51:10 +00:00
Kelly Cochrane
0e530cbeb2 Bug 1815906 - Add telemetry for History in Library window r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D169710
 2023-02-22 19:25:52 +00:00
Neil Deakin
9c2e7458ba Bug 1776879, replace text/unicode for clipboard and drag and drop and use text/plain directly, r=edgar,mak,stransky,geckoview-reviewers,extension-reviewers,zombie,m_kato 
Most usage is a straight replacement but gtk needs extra changes as it transfers plain text in UTF8 natively and needs to be converted into UTF16, and Windows uses single-byte characters for RTF and CF_HTML formats so we preserve this.

Differential Revision: https://phabricator.services.mozilla.com/D158587
 2023-02-01 23:30:55 +00:00
Mark Banner
a94fe03b9d Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Marco Bonardo
8804aadd9a Bug 1457131 - Remove itemId (aka parentId) from PlacesInsertionPoint. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165767
 2023-01-04 13:16:08 +00:00
Marco Bonardo
783c896621 Bug 1382992 - Remove the synchronous getFolderIdForItem() bookmarks API. r=Standard8 
Unfortunately the dragover behavior is not trivial to test, thus this relies on
manual testing. The data safety is covered by the undelrying bookmarking API
anyway, so this is just about the UI visual drag indicator.

Differential Revision: https://phabricator.services.mozilla.com/D165766
 2023-01-04 13:16:08 +00:00
Marco Bonardo
74f9ed119f Bug 1805889 - Stop abusing the options object in the Panel View. r=Gijs 
Make Places views constructors arguments more coherent, passing the root
and view elements up to the super class explicitly.
Remove the options argument, that was not strictly necessary, the same info can
be obtained directly.
Rename the "builder" attribute to "afterplacescontent" to clarify what it is
and make panel use it, instead of passing an insertionPoint option.

Additional cleanups:
Make chevron and BMB menus use coherent popupshowing observers.
Remove useless .viewElt accessor, .associatedElement can be used instead.
Avoid an access to the private _rootElt property from the controller.

Differential Revision: https://phabricator.services.mozilla.com/D164827
 2022-12-19 10:18:22 +00:00
Sergey Galich
af4a87427f Bug 702925 - stop deleting saved passwords when user runs History > Forget this site command r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163903
 2022-12-14 19:18:24 +00:00
Francis McKenzie
29291afd59 Bug 1795070 - Speed up deleting from history by 7,000%. r=mak 
Initial investigation revealed that when the user deletes 2,000 items from a history search, treeView.js invalidateContainer() is invoked 2,000 times (in batches of 300 at a time). However, this is not the primary cause of the poor performance.

Yes, one of the nsNavHistoryQueryResultNode observers is being refreshed for every Page_removed event, resulting in repeated calls to treeView.js invalidateContainer(). This definitely has a performance impact.

However, even worse is that another of the nsNavHistoryQueryResultNode observers is being incrementally updated for every Page_removed event. This is causing the majority of the slowdown.

This patch provides a simple solution: when handling a PlacesEvent containing 50 or more Page_removed events and no other events, just refresh all the history observers once and return.

With this change, it takes about 1 second to delete 2,000 items from a history query, representing a performance improvement of approximately 7,000%.

Differential Revision: https://phabricator.services.mozilla.com/D159286
 2022-11-04 19:30:55 +00:00
trickypr
9e1b731098 Bug 1510561 - Part 2: Apply plugin:mozilla/valid-jsdoc to browser/components/places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D158562
 2022-10-13 10:55:28 +00:00
Shane Hughes
f0a33c9d81 Bug 1783207 - Add ellipsis to some menu label strings. r=flod 
The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!

Differential Revision: https://phabricator.services.mozilla.com/D154320
 2022-08-11 17:48:11 +00:00
Mark Banner
4bfafd41fa Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
Mark Banner
078a07d922 Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 22:34:20 +00:00
smolnar
102b779608 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
23086da9b9 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Mark Banner
50f4bbf0ae Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 15:50:39 +00:00
Iulian Moraru
1108246986 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
e84aaa1b85 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Mark Banner
47cd6c5eb6 Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 10:36:49 +00:00
Kagami Sascha Rosylight
764ef75de5 Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148939
 2022-06-27 20:31:34 +00:00
Masatoshi Kimura
1c05049b5f Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 15:51:59 +00:00
Norisz Fay
e745ba9d5a Backed out changeset bcc49b21bd0e (bug 1754805) for causing multiple failures CLOSED TREE 2022-03-31 17:01:58 +03:00
Masatoshi Kimura
619fe7ec67 Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 13:27:52 +00:00
Lebar
2c13fcc3c6 Bug 1741603 - Fix Show in Folder context menu item in app menu to open in sidebar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139230
 2022-03-15 17:35:22 +00:00
Evgenia Kotovich
f93f6f7711 Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-28 07:46:06 +00:00
Evgenia Kotovich
4cfb841fea Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-28 07:46:06 +00:00
Lebar
67bbc3e1af Bug 1747200 - Added call to ensureRowIsVisible to make sure that selected node is in view after showInFolder. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D135672
 2022-01-27 14:53:43 +00:00
Mark Banner
4f4dd2fbae Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D136368
 2022-01-20 14:15:34 +00:00
Cristian Tuns
f93b09eb34 Backed out 2 changesets (bug 1725487) for causing mochitest failures on browser_toolbar_drop_bookmarklet.js CLOSED TREE 
Backed out changeset 1564124c0309 (bug 1725487)
Backed out changeset ae5ab5c447c3 (bug 1725487)
 2022-01-13 07:23:29 -05:00
Evgenia Kotovich
cc5315b51f Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-13 11:05:59 +00:00
Evgenia Kotovich
960d138fc9 Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-13 11:05:59 +00:00
Paul Zuehlcke
086539a031 Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D128089
 2021-10-15 15:07:06 +00:00
Lebar
9fe6a1b369 Bug 469441 - Added 'Show in Folder' context menu item for bookmark library searches and bookmarks sidebar. r=Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D121040
 2021-10-04 21:07:09 +00:00
Mark Banner
14aedbb785 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 12:09:49 +00:00
Noemi Erli
e0f4b9b5fe Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE 
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
 2021-09-10 13:14:12 +03:00
Mark Banner
3cfdb5c41a Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 09:38:42 +00:00
Stefan Zabka
873a6170d3 Bug 1711759 - Ask user for confirmation in Forget about this site. r=pbz,Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D120363
 2021-09-02 11:55:52 +00:00
Gijs Kruitbosch
a8db92c057 Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D124045
 2021-09-01 16:08:50 +00:00
Nicholas Fason
0c0043f901 Bug 1702708 - Hyphenate places context menu attributes r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D121583
 2021-08-03 14:03:03 +00:00
Paul Zuehlcke
cb8ac7af93 Bug 1705028 - Update places forget-this-site to clear storage by base domain. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D113495
 2021-05-26 13:49:36 +00:00
Mark Banner
e05a30a57b Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D115233
 2021-05-18 16:27:44 +00:00