Commit graph

1303 commits

Author SHA1 Message Date
Norisz Fay
0d4fc02631 Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones
f9347014c4 Bug 1845150 - Update notificationbox usage for process hang notification r=reusable-components-reviewers,tgiles
Can be tested locally using this snippet (which I think I took from a test...):

```js
let addonId = "test";
let policy = new WebExtensionPolicy({
    name: "Scapegoat",
    id: addonId,
    mozExtensionHostname: Services.uuid.generateUUID().number.slice(1, -1),
    baseURL: "file:///",
    allowedOrigins: new MatchPatternSet([]),
    localizeCallback() {},
});
policy.active = true;
ProcessHangMonitor.showNotification(window, { addonId, scriptBrowser: { browsingContext: { watchedByDevTools: false }} });
```

Differential Revision: https://phabricator.services.mozilla.com/D194316
2024-01-05 15:04:20 +00:00
Hanna Jones
13a6df64c9 Bug 1845150 - Update notificationbox usage for crash notifications r=reusable-components-reviewers,tgiles
I've been testing locally with these snippets in the browser toolbox:

```js
const { TabCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
TabCrashHandler.showSubFrameNotification(gBrowser.selectedBrowser, "foo", "bar");
```

```js
const { UnsubmittedCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
UnsubmittedCrashHandler.show({ notificationId: "foo", reportIDs: [], onAction: () => {}});
```

Differential Revision: https://phabricator.services.mozilla.com/D194315
2024-01-05 15:04:20 +00:00
Cosmin Sabou
45ad585956 Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
2024-01-04 18:53:25 +02:00
Hanna Jones
d2de50d679 Bug 1845150 - Update notificationbox usage for process hang notification r=reusable-components-reviewers,tgiles
Can be tested locally using this snippet (which I think I took from a test...):

```js
let addonId = "test";
let policy = new WebExtensionPolicy({
    name: "Scapegoat",
    id: addonId,
    mozExtensionHostname: Services.uuid.generateUUID().number.slice(1, -1),
    baseURL: "file:///",
    allowedOrigins: new MatchPatternSet([]),
    localizeCallback() {},
});
policy.active = true;
ProcessHangMonitor.showNotification(window, { addonId, scriptBrowser: { browsingContext: { watchedByDevTools: false }} });
```

Differential Revision: https://phabricator.services.mozilla.com/D194316
2024-01-04 15:31:14 +00:00
Hanna Jones
2a3fe3bdb4 Bug 1845150 - Update notificationbox usage for crash notifications r=reusable-components-reviewers,tgiles
I've been testing locally with these snippets in the browser toolbox:

```js
const { TabCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
TabCrashHandler.showSubFrameNotification(gBrowser.selectedBrowser, "foo", "bar");
```

```js
const { UnsubmittedCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
UnsubmittedCrashHandler.show({ notificationId: "foo", reportIDs: [], onAction: () => {}});
```

Differential Revision: https://phabricator.services.mozilla.com/D194315
2024-01-04 15:31:13 +00:00
Karandeep
0dccdeeb70 Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D194895
2024-01-04 09:11:22 +00:00
Mark Banner
58b6716fce Bug 1870644 - Pass a preferred width rather than width and height when getting search engine icon urls. r=search-reviewers,mcheang
This also renames the function, in preparation for iconURI being merged into it.

Differential Revision: https://phabricator.services.mozilla.com/D196733
2023-12-20 13:28:24 +00:00
Chris H-C
3a958a1442 Bug 1868988 - Remove PingCentre. Its watch has ended. r=nanj,thecount,perry.mcmanis
Differential Revision: https://phabricator.services.mozilla.com/D196227
2023-12-18 16:56:22 +00:00
Mark Banner
00a8658fd9 Bug 1868749 - Remove search engine send attribution request. r=search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D195758
2023-12-18 12:01:34 +00:00
Chris H-C
6bf60bf55d Bug 1868580 - Remove PingCentre from Contextual Services r=nanj,perry.mcmanis
As of 11amPT December 7, Contextual Services is now looking exclusively at
Glean-sent data for Firefox versions 116+. (See DSRE-1489)

Differential Revision: https://phabricator.services.mozilla.com/D195910
2023-12-11 19:21:37 +00:00
Perry McManis
ee063b7b37 Bug 1867048 - Remove temporary GVSV data collections r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D194882
2023-12-11 15:10:40 +00:00
Anna Yeddi
db6ce5a2e7 Bug 1864576 - Add exceptions from a11y_checks for 3 clicks on disabled controls in browser_UsageTelemetry_interaction.js r=mossop
We intentionally turn off a11y_checks for these click events, because the test is checking the telemetry functionality and the following 3 clicks are targeting disabled controls to test the changes in scalars (for more refer to the bug 1864576 comment 2 and bug 1854999 comment 4).

Also, we are adding the test `label` to the custom widget `12foo` to satisfy the a11y_check expecting to click on a control with an accessible name.

Since the test file is now passing, we are removing the `fail-if` notation that was added by the bug 1854506 before the investigation in the meta bug 1854507.

Differential Revision: https://phabricator.services.mozilla.com/D195595
2023-12-06 13:52:32 +00:00
Joel Maher
2cae29b76e Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Karandeep
6f3e7cf56d Bug 1852044 - Remove the Search Bar section. r=dao,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192722
2023-11-21 05:09:08 +00:00
Perry McManis
d91169cb8a Bug 1858954 - Add some metrics for validating geckoview streaming collection against direct glean collection r=chutten,gfx-reviewers,media-playback-reviewers,jrmuizel,padenot
In an effort to understand if data collected via the Geckoview Streaming
API differs materially from that collected in Glean, we will implement
some temporary data collections that cover the existing use cases of the
former.

Differential Revision: https://phabricator.services.mozilla.com/D191119
2023-10-26 12:35:55 +00:00
Anna Yeddi
6cb2eb924e Bug 1854506 - Temporarily fail-if some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.

This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Tabbed Browser-specific meta bug 1854507
- Explore capturing click events for a11y_checks: bug 1692110

Depends on D188914

Differential Revision: https://phabricator.services.mozilla.com/D188915
2023-10-09 18:20:15 +00:00
Cristian Tuns
6b9650b822 Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi
f924c7985d Bug 1854506 - Temporarily disable some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Tabbed Browser-specific meta bug 1854507
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D188915
2023-10-06 18:11:33 +00:00
Robin Steuber
2ac0a7eee5 Bug 1855604 - Back out putting provenance attribution in installation.first_seen r=nalexander
Backs out Bug 1821189's patch: https://hg.mozilla.org/mozilla-central/rev/c4f8098f81bb

Differential Revision: https://phabricator.services.mozilla.com/D189591
2023-10-03 23:40:24 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Masatoshi Kimura
bcd7d268c4 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
26e0b0be0a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
7ad48d61dd Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Paul Zuehlcke
0c249b591f Bug 1839918 - Update tests for nsICookieNotification. r=cookie-reviewers,sessionstore-reviewers,bvandersloot,valentin
Depends on D185301

Differential Revision: https://phabricator.services.mozilla.com/D185302
2023-09-18 11:55:09 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Cosmin Sabou
28bc51699a Backed out 9 changesets (bug 1839918) for causing a top crash as in Bug 1852357. a=backout
Backed out changeset 1c438df525c7 (bug 1839918)
Backed out changeset 6e3d7fdfda3f (bug 1839918)
Backed out changeset 087b27593538 (bug 1839918)
Backed out changeset 302d12c12083 (bug 1839918)
Backed out changeset 750e0796c1ad (bug 1839918)
Backed out changeset 3949d9b400d4 (bug 1839918)
Backed out changeset 707021ebfd23 (bug 1839918)
Backed out changeset fa9a6af80526 (bug 1839918)
Backed out changeset 5aa3b2f1b5ec (bug 1839918)
2023-09-11 16:42:08 +03:00
Paul Zuehlcke
c50bea95cc Bug 1839918 - Update tests for nsICookieNotification. r=cookie-reviewers,sessionstore-reviewers,bvandersloot,valentin
Differential Revision: https://phabricator.services.mozilla.com/D185302
2023-09-07 08:25:55 +00:00
Mark Banner
0b2d2afdea Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Mark Banner
182b6db303 Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
2023-07-12 08:07:23 +00:00
Benjamin VanderSloot
1dfc74c9fc Bug 1836792, part 3 - Adopt permissions UI to just show the same old prompt for 3rdPartyFrameAccess requests, r=anti-tracking-reviewers,timhuang,pbz
Differential Revision: https://phabricator.services.mozilla.com/D180217
2023-06-23 12:14:18 +00:00
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Marco Castelluccio
21a2f56033 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
37e0c3eb20 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
c85e65e2e0 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Karandeep
7cb8d5c951 Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D180229
2023-06-12 18:03:52 +00:00
Gijs Kruitbosch
75d012d803 Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-06-06 12:16:38 +00:00
Butkovits Atila
87ba454e5c Backed out changeset c34f2e337a31 (bug 1831259) for causing Bug 1836325 and Bug 1836332. a=backout 2023-06-01 21:44:15 +03:00
Gijs Kruitbosch
59070c7a5d Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-05-31 22:24:26 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Cristian Tuns
2a18c8252e Backed out changeset af6ffefb5572 (bug 1831259) for causing bc failures in browser_aboutPrefs_fc_check_cantApply.js CLOSED TREE 2023-05-30 23:53:55 -04:00
Gijs Kruitbosch
aa7c4e888e Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-05-30 22:15:27 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00