Commit graph

161 commits

Author SHA1 Message Date
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Andrew McCreight
8340e0d293 Bug 1371042 - Fix destructuring assignment in sanitize.js. r=Gijs
MozReview-Commit-ID: 4farchkzM60

--HG--
extra : rebase_source : c2b32ffd874e438c591f222312c7194708f31fe1
2017-06-07 14:23:47 -07:00
Andrew McCreight
a614ce747d Bug 1370732 - Define Cc and Ci in sanitize.js. r=Gijs
These are referred to, but never explicitly defined. Under some
circumstances with shared JSM globals, this will cause an error.

MozReview-Commit-ID: 5DP2NSRoNML

--HG--
extra : rebase_source : 008b9ece57b4f93a2b86fd53a2c0e209da1b2975
2017-05-31 14:24:52 -07:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner
1087fc1884 Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR

--HG--
extra : rebase_source : 482bdc039362347f35aec9fd15e07a143dccb860
2017-02-22 17:02:59 +00:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Marco Bonardo
21fb0f14bb Bug 1345075 - Remove FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH. r=Felipe
MozReview-Commit-ID: 1WoxWh3OkL4

--HG--
extra : rebase_source : 66a0de288fd3066e034394f30ffa990c1e4aaf57
2017-03-07 14:13:07 +01:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Aman Dwivedi
6cbcc32370 Bug 1323685 - Remove workarounds for bug 449811. r=mak 2016-12-22 16:33:28 +05:30
Bob Silverberg
526630bfba Bug 1324760 - Expose a function that clears plugin data in sanitize.js, r=mak
MozReview-Commit-ID: A8AxhyzyEwk

--HG--
extra : rebase_source : 6c3c2c09fa011f36f38549d442bd6c85c880b281
2016-12-20 09:24:06 -05:00
Dão Gottwald
a4f102118b Bug 1323807 - Make sanitize.js handle the search bar having moved to the overflow or menu panel. r=mak
--HG--
extra : rebase_source : 9b166413b396a718d08c24737aa6715e2f369bb4
2016-12-16 19:57:08 +01:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Matthew Noorenberghe
3803d21cec Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations. r=liuche,markh
Bug 1058438 moved disabled hosts to the permission manager which are already cleared by these modules.

MozReview-Commit-ID: InprrYLvjMR

--HG--
extra : rebase_source : 806c2542cbab953b74ad82611501ecac32400930
2016-08-24 17:41:10 -07:00
Marco Bonardo
dc56c93a8c Bug 1287428 - Fix expiration of the FX_SANITIZE_ probes expiring in v50.r=adw
MozReview-Commit-ID: IckqRR0RBbd

--HG--
extra : rebase_source : 401f807dcfa94460547e660a3f0ea7dbfb9d4026
extra : amend_source : ea0c1c6f3145a944a5e1966f325b7262a0246acf
2016-07-26 17:27:17 +02:00
Kit Cambridge
7500315560 Bug 1275436 - Remove push subscriptions from the server after clearing permissions and site data. r=mt
Previously, we removed records locally, but didn't notify the server.
We can be nice and avoid making the server buffer messages for
subscriptions that the client will never use again.

MozReview-Commit-ID: 5iohGQPHXuz

--HG--
extra : rebase_source : 00639fe1016ffd241c18643049f4b061740025f1
2016-05-20 09:38:26 -07:00
Marco Bonardo
e399ecf5b8 Bug 1258354 - Sanitize on shutdown adds 2 blockers, when only one is really needed. r=yoric
MozReview-Commit-ID: BbtZMIwT54N

--HG--
extra : rebase_source : a7cc3fff75707bab57f41008734ea558193080a4
2016-04-13 14:08:18 +02:00
Andrea Marchesini
83a08cd72e Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-10 05:46:07 +01:00
Ryan VanderMeulen
1c7872d0af Backed out changeset 7d5f1e9ce04c (bug 1259169) for various cookie-related crashes and test failures. 2016-04-09 15:36:07 -04:00
Andrea Marchesini
d09d8959fe Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-09 19:09:49 +01:00
Dave Townsend
4bf4f02ce7 Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM

--HG--
extra : rebase_source : 07ba1d14655f5d761624b105ef025ec88323d4d5
extra : histedit_source : 9e5ab54ce1b1a5ee1f0fb143f8d1450522455e3b
2016-04-05 11:33:33 -07:00
David Rajchenbach-Teller
09394a58f8 Bug 1253204 - Don't abort shutdown on plugins sanitization;r=mak
MozReview-Commit-ID: 5bub8n8cCsZ

--HG--
extra : rebase_source : 46b3591bfc0dae866eeb95644ede659b8a37a202
2016-03-04 16:11:21 +01:00
Marco Bonardo
f946230755 Bug 1252089 - Report the in-progress sanitization in shutdown abort metadata. r=yoric
MozReview-Commit-ID: KjmRVLpBLJx

--HG--
extra : rebase_source : 273c3ce71f62d04fe6adbcd12fb2c0dd8838faae
extra : amend_source : ef237bd823a425603f00253495653e245f976a47
2016-02-29 17:26:12 +01:00
Marco Bonardo
42d7d55a85 Bug 1251469 - Add telemetry probes for the time needed to sanitize a loaded or unloaded Flash. r=yoric
MozReview-Commit-ID: 8j9teGzMSV2

--HG--
extra : rebase_source : 57fac49ccce20d013fbfe20e28c98dfe3048a56c
extra : amend_source : e25c7975283782e6b705958ea6d060edfcf84d67
2016-02-26 14:50:41 +01:00
Andrea Marchesini
ed31fee8d4 Bug 1245184 - nsICookieManager.remove should use the OriginAttributes, r=sicking 2016-02-25 16:41:13 +01:00
Marco Bonardo
e0ce819ccc Bug 1250362 - don't flush prefs on startup unless it's really needed. r=yoric
MozReview-Commit-ID: FLrlrF4A1Om

--HG--
extra : rebase_source : 9fe9e1cee72c3466884ffee9eb5064482969439f
2016-02-23 23:29:43 +01:00
Marco Bonardo
99f799e4c7 Bug 1249786 - fix typo. r=me on a CLOSED TREE
MozReview-Commit-ID: 3AeOpRsNd23
2016-02-22 16:52:06 +01:00
Marco Bonardo
b4d417454e Bug 1249786 - Sanitize on startup prefs are broken. r=yoric
MozReview-Commit-ID: LDmK7G1BhGP

--HG--
extra : rebase_source : f6005e1cfb2e14b0ce5c3b7e9a370170604e8a77
2016-02-19 23:22:24 +01:00
Carsten "Tomcat" Book
f2a98554ec Backed out changeset 27f3968ae8b2 (bug 1245184) 2016-02-19 15:55:23 +01:00
Andrea Marchesini
0a72c5e9e3 Bug 1245184 - CookieManager should remove cookies only if they match the userContextId, r=sicking 2016-02-19 14:49:50 +01:00
Marco Bonardo
77808a4218 Bug 1244650 - Failure to clear Forms and Search Data on exit. r=yoric
The problem is due to sanitization happening too late in the shutdown cycle.
The Sanitizer depends on Places shutdown, that recently moved to async shutdown.
That change caused shutdown to happen completely at profile-before-change, unfortunately
during that phase it's impossible to predict which services are already shutdown.
The patch restores the previous Places shutdown procedure, thus clients are notified
earlier, during profile-change-teardown.

Additional meaningful changes:
* Fixes FX_SANITIZE_TOTAL telemetry to properly count total time taken by sanitize.
* Makes each cleanup operation isolated from other errors to try cleaning up as most as possible.
* In case of multiple sanitization sub steps, each step is isolated by a try/catch, the last seen exception is reported upstream.
* Makes FX_SANITIZE_HISTORY actually measure history, not other random stuff.
* Removes TOPIC_SIMULATE_PLACES_MUST_CLOSE_1 since we can now just use profile-change-teardown for shutdown phase 1.

MozReview-Commit-ID: HroLvbi25IC

--HG--
extra : rebase_source : 5cd01a803fbc1f72dc5174dd0c5a5b5aea473fc2
2016-02-04 13:51:34 +01:00
Marco Bonardo
0bffcc3559 Bug 1243549 - Add missing bits. r=post-facto
MozReview-Commit-ID: BTRUMtNsSeQ
2016-02-11 16:09:17 +01:00
David Rajchenbach-Teller
5ad17c3a22 Bug 1243549 - Make sure that startup sanitization doesn't throw because it can't find a tabbrowser. r=mak 2016-02-04 09:40:40 -05:00
Matthew Noorenberghe
66c73b5940 Bug 1244908 - Remove privacy.clearOnShutdown.passwords migration code. r=dolske
--HG--
extra : commitid : 2HnKfq3jUZK
extra : rebase_source : 4cca79b260a18b95758bed5fbd2518b3d84d430a
2016-02-03 15:26:14 -08:00
Matthew Noorenberghe
6f76f345ba Bug 1242176 - Don't migrate privacy.clearOnShutdown.passwords if privacy.sanitize.sanitizeOnShutdown is false. r=dolske 2016-01-28 10:49:00 -08:00
Mélanie Chauvel (ariasuni)
24691fcfc3 bug 1211849 - Remove canClear support from the Sanitizer. r=mak
Modifications by Patrick <nwokop@uni.coventry.ac.uk>

--HG--
extra : commitid : 4sPxOcyS2qv
2015-10-07 19:46:35 +02:00
Kit Cambridge
2aac6b9fea Bug 1189998, Part 2 - Migrate Push service callers. r=mt
--HG--
extra : commitid : Irrl5pvEqC
extra : rebase_source : 11c261c95820225bcc50976956000f34a79f9578
2015-12-08 15:41:48 -05:00
Felipe Gomes
2df6ae44b6 Bug 1229603 - Make most of browser/base lintable by removing non-standard syntax. r=Mossop
--HG--
extra : commitid : 5Dg6Q0MzXTN
2015-12-02 17:51:26 -02:00
Bill McCloskey
4f99faeaed Bug 967873 - Proxy nsDocumentViewer::PermitUnload to the child process (r=Gijs) 2015-11-11 18:04:21 -08:00
Tooru Fujisawa
8ed7719ea4 Bug 1216775 - Remove for-each from browser/. r=Gijs
--HG--
extra : commitid : 5KlVHJwTU1Q
extra : rebase_source : 6526234004427109c826cb63f42c9def8ca31281
2015-10-19 01:27:39 +09:00