Commit graph

65 commits

Author SHA1 Message Date
Shane Hughes
6295d1777c Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208941
2024-05-02 20:54:51 +00:00
Tamas Szentpeteri
eac9a44e3f Backed out changeset 1187f4d67bf7 (bug 1893671) for causing newtab failures in asrouter:CFRMessageProvider. CLOSED TREE 2024-05-02 21:34:33 +03:00
Shane Hughes
a9b2ecff48 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208941
2024-05-02 17:44:25 +00:00
Shane Hughes
81b755329b Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
2024-04-24 20:54:02 +00:00
Barret Rennie
677b4036a4 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-24 20:15:19 +00:00
Nipun Shukla
d043179aa7 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207595
2024-04-23 14:08:52 +00:00
Iulian Moraru
7b76404e84 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
ceaa247170 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-22 17:57:31 +00:00
dschomburg
e63de59f5c Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Shane Hughes
80a3e841d0 Bug 1863384 - Implement offset_x and offset_y for panel feature callout. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207075
2024-04-15 16:40:50 +00:00
Nicholas Rishel
768e4d436c Bug 1890066 - Show notification when users need to finish setting Firefox as the default in Windows Settings. r=nalexander,omc-reviewers,fluent-reviewers,flod,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D206828
2024-04-11 17:13:02 +00:00
Emily McMinn
079ff41016 Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
1bb7ccda05 Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Mark Banner
d1d1eca18d Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
2024-03-19 17:01:37 +00:00
Jason Prickett
0656e54e74 Bug 1882662 - Add checkDefaultBrowser pref check to fox doodle message targeting r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204268
2024-03-11 19:42:05 +00:00
Mark Banner
9fe8bde13c Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
hanna alemu
27955f6b8b Bug 1877788 - Record reach for all messaging experiment features r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203829
2024-03-08 16:51:20 +00:00
Dave Townsend
1fe4db4a69 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Natalia Csoregi
96b1b25a39 Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
c7318b4cf2 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
97fd2dad96 Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
f4705b2208 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Nick Alexander
2814902b49 Bug 1868676 - Part 1: Allow snapshots of multiple contexts. r=barret,omc-reviewers,aminomancer
`ASRouterTargeting` does _not_ include the experiment details that
supply `activeExperiments`, `activeRollouts`, etc.  Those are combined
from additional contexts.  This patch makes it easy to do that
combination.

N.b.: the use of `Proxy` instances makes iteration tricky, so we avoid
it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D200124
2024-02-14 21:31:19 +00:00
Jason Prickett
5535557e05 Bug 1879390 - Add screen ID to fox doodle r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201750
2024-02-14 01:13:23 +00:00
Mike Conley
24da9bffd2 Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D201138
2024-02-12 18:49:38 +00:00
Mike Conley
5ab28b68b9 Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201134
2024-02-12 18:49:37 +00:00
Mike Conley
3e82da1fda Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D201133
2024-02-12 18:49:37 +00:00
Mike Conley
78b1c85ec9 Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201129
2024-02-12 18:49:36 +00:00
Mike Conley
24defeb8da Bug 1878731 - Convert ASRouterDefaultConfig to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201128
2024-02-12 18:49:36 +00:00
Mike Conley
3a56bf9f14 Bug 1878731 - Convert ASRouterParentProcessMessageHandler to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201127
2024-02-12 18:49:36 +00:00
Mike Conley
3b42177c8a Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201126
2024-02-12 18:49:35 +00:00
Mike Conley
7ede6945db Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201125
2024-02-12 18:49:35 +00:00
Mike Conley
34e17ab7c2 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Mike Conley
3624c8f09d Bug 1878731 - Convert ToolbarBadgeHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201123
2024-02-12 18:49:34 +00:00
Shane Hughes
6336c4bb8b Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers
Fix feature callout teardown while a tour is still ongoing.
Add an option to space out the CTA buttons.
Add dynamic disabling of secondary_button.
Add randomization for the MultiSelect component, mainly for surveys.
Improve test coverage.
Add documentation for the above changes plus some missing things.

Differential Revision: https://phabricator.services.mozilla.com/D201027
2024-02-08 22:48:27 +00:00
pstanciu
943a8b838d Backed out changeset 7aee47be18bf (bug 1879220) for causing node newtab failures at aboutwelcome. CLOSED TREE 2024-02-08 17:55:42 +02:00
Shane Hughes
8c2406bedc Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201027
2024-02-08 12:30:25 +00:00
Mike Conley
a23ecbe7e9 Bug 1877196 - Move PageEventManager.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200515
2024-02-05 22:03:16 +00:00
Mike Conley
c8b2bacff2 Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200514
2024-02-05 22:03:16 +00:00
Mike Conley
c65fe995c1 Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
2024-02-05 22:03:15 +00:00
Mike Conley
e552f54072 Bug 1877196 - Move InfoBar.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200084
2024-02-05 22:03:14 +00:00
Mike Conley
fb2ce4bd02 Bug 1877196 - Move MomentsPageHub.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200083
2024-02-05 22:03:14 +00:00
Mike Conley
88baec62ec Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Mike Conley
682fee1d69 Bug 1877196 - Move ToolbarBadgeHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200081
2024-02-05 22:03:13 +00:00
Mike Conley
f16eb43f3d Bug 1877196 - Move ToastNotification.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200080
2024-02-05 22:03:13 +00:00
Mike Conley
e94a50522c Bug 1877196 - Move Spotlight.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200079
2024-02-05 22:03:12 +00:00
Mike Conley
5538f3cf2b Bug 1876104 - Convert ToastNotification.jsm to an ESM. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D199424
2024-02-02 00:53:21 +00:00
Mike Conley
07e3c2c2c3 Bug 1876104 - Convert Spotlight.jsm to an ESM. r=amy,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D199421
2024-02-02 00:53:20 +00:00
Mike Conley
9a493ab8b7 Bug 1876104 - Convert MomentsPageHub.jsm to an ESM. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D199413
2024-02-02 00:53:17 +00:00
Mike Conley
257ec228a5 Bug 1876104 - Convert InfoBar.jsm to an ESM. r=thecount,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D199411
2024-02-02 00:53:16 +00:00