Commit graph

199 commits

Author SHA1 Message Date
Manuel Bucher
25837aaf2e Bug 1787729 - Move NS_HasRootDomain, CheckForBrokenChromeURL, IsCoepCredentiallessEnabled to mozilla::net namespace r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D155992
2022-08-31 11:19:14 +00:00
Bryan Thrall
89d1e07b8b Bug 1768679 - Add 'Alt Data size' column to about:cache r=necko-reviewers,dragana
In CacheFileIOManager::GetEntryInfo(), there is only a problem if the Alt Data
element is present but we can't parse a reasonable value out of it (a value
smaller than the metadata offset).

Differential Revision: https://phabricator.services.mozilla.com/D146467
2022-08-04 16:20:17 +00:00
Bryan Thrall
f9c451035e Bug 1768679 - Expose cache fetch count as uint32_t r=dragana,necko-reviewers
The value is stored as uint32_t, and there doesn't seem to be a need to convert
it to int.

Differential Revision: https://phabricator.services.mozilla.com/D147888
2022-08-04 16:20:17 +00:00
Randell Jesup
6ef1621b21 Bug 1747439: netwerk/cache2 cleanup r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D135167
2022-01-12 20:38:37 +00:00
Marian-Vasile Laza
205e4f70a7 Backed out changeset 7c1a1109d729 (bug 1747439) for causing build bustages on CacheEntry.cpp. CLOSED TREE 2022-01-12 16:52:24 +02:00
Randell Jesup
4037dc1397 Bug 1747439: netwerk/cache2 cleanup r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D135167
2022-01-12 13:54:01 +00:00
Randell Jesup
3a919a88f1 Bug 1746875: netwerk/cache memory reporter cleanup r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D134294
2021-12-21 22:52:17 +00:00
Valentin Gosu
0cbc1f290d Bug 1312057 - Fix prefetch telmetry r=mayhemer,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D11518
2021-10-12 15:41:15 +00:00
Valentin Gosu
0504488366 Bug 1731054 - Reenable bug1708673 without perf regression r=necko-reviewers,kershaw
Depends on D126360

Differential Revision: https://phabricator.services.mozilla.com/D126361
2021-09-28 07:08:28 +00:00
Valentin Gosu
e41b7a871b Bug 1732095 - Remove unused nsICacheStorageService.synthesizedCacheStorage r=necko-reviewers,kershaw
Depends on D126357

Differential Revision: https://phabricator.services.mozilla.com/D126360
2021-09-23 09:14:19 +00:00
Valentin Gosu
d99d6259ee Bug 1732095 - Clean up CacheStorageService r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D126357
2021-09-23 09:14:19 +00:00
Valentin Gosu
a80ffb44aa Bug 1729717 - Remove unused nsDeleteDir helpers r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D124925
2021-09-13 12:07:38 +00:00
Valentin Gosu
e209403593 Bug 1729717 - Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
This was used previously when switching between cache backend versions.

Differential Revision: https://phabricator.services.mozilla.com/D124922
2021-09-13 12:07:37 +00:00
Csoregi Natalia
2ecacd2e2d Backed out 2 changesets (bug 1729717) for causing assertion failures on CacheObserver.cpp. CLOSED TREE
Backed out changeset 7123efe825f0 (bug 1729717)
Backed out changeset 92e06bd625c9 (bug 1729717)
2021-09-13 12:40:11 +03:00
Valentin Gosu
4ee56c10e6 Bug 1729717 - Remove unused nsDeleteDir helpers r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D124925
2021-09-13 09:12:35 +00:00
Valentin Gosu
fc6cd46e34 Bug 1729717 - Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
This was used previously when switching between cache backend versions.

Differential Revision: https://phabricator.services.mozilla.com/D124922
2021-09-13 09:12:34 +00:00
Paul Zuehlcke
6eb0d4fb20 Bug 1714608 - Cleaned up partitionKey base domain helpers. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D118724
2021-07-07 16:05:06 +00:00
Paul Zuehlcke
2e06ca7e1c Bug 1705030 - Added NetworkCacheCleaner deleteByBaseDomain. r=necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113128
2021-06-24 09:13:30 +00:00
Valentin Gosu
35bfc0713b Bug 1708673 - Do not recreate CacheEntry when OPEN_READONLY flag is passed r=necko-reviewers,dragana
This bug is caused by two cache visitors working in parallel:
Visitor1: calls asyncDoomURI
Visitor2: calls asyncOpenURI

This causes CacheStorageService::AddStorageEntry to create a new entry and add
it to the hashtable:
https://searchfox.org/mozilla-central/rev/308ea44d0d60b391b031ccee695920bd543f7d2f/netwerk/cache2/CacheStorageService.cpp#1566,1574,1576

Visitor3: will then go through the hashtable and see the newly added entry.

Differential Revision: https://phabricator.services.mozilla.com/D118344
2021-06-22 08:23:36 +00:00
Valentin Gosu
d595491cc7 Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
Butkovits Atila
692bda1ca1 Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE 2021-06-04 13:53:37 +03:00
Valentin Gosu
98146ae90b Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
Valentin Gosu
9e4bdb9c25 Bug 1694662 - Remove old cache implementation r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106456
2021-04-30 07:20:24 +00:00
Valentin Gosu
5afdc02366 Bug 1694662 - Remove Appcachestorage & oldwrappers r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106455
2021-04-30 07:20:24 +00:00
Valentin Gosu
e99e05a205 Bug 1694662 - Remove appcache storage attribute r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106454
2021-04-30 07:20:23 +00:00
Simon Giesecke
613e20d136 Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
Simon Giesecke
15d3d060cf Bug 1184468 - Use nsTHashtable::Keys where possible in netwerk. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D106950
2021-03-24 17:51:12 +00:00
Csoregi Natalia
f54ee076ae Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
Simon Giesecke
8aaa3daac8 Bug 1184468 - Use nsTHashtable::Keys where possible in netwerk. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D106950
2021-03-24 16:58:57 +00:00
Simon Giesecke
b9621d6376 Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D108585
2021-03-17 15:49:46 +00:00
Simon Giesecke
9af107a839 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Simon Giesecke
4f75368dcb Bug 1691913 - Rename nsBaseHashtable::GetOrInsert(With) to LookupOrInsert(With). r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
The functions should be called "Lookup" rather than "Get" because they return
a DataType& (rather than UserDataType).

Differential Revision: https://phabricator.services.mozilla.com/D105472
2021-02-26 09:11:45 +00:00
Simon Giesecke
661e25bf09 Bug 1692880 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-16 15:53:33 +00:00
Simon Giesecke
780a1636a9 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 15:12:17 +00:00
smolnar
1afbbe67e1 Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
Simon Giesecke
3c29a68440 Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-15 10:04:46 +00:00
Simon Giesecke
8973094ec1 Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D104849
2021-02-15 10:04:45 +00:00
Alexis Beingessner
316b5113e0 Bug 1633239 - make the bitfields on CacheStorageService atomic. r=valentin,necko-reviewers
this is only a hypothetical fix to the underlying issue since we don't have a clean trace.

Differential Revision: https://phabricator.services.mozilla.com/D103057
2021-01-28 11:05:02 +00:00
David Major
bc943f076f Bug 1688292 - Fix non-unified build errors in netwerk/cache2/ r=necko-reviewers,valentin
This is a drive-by fix while I was looking into something else.

Differential Revision: https://phabricator.services.mozilla.com/D102795
2021-01-25 12:23:13 +00:00
Alexis Beingessner
70c9b7ef2c Bug 1681546 - rename MOZ_ATOMIC_BITFIELDS methods to Load/Store. r=valentin,necko-reviewers
I was running into issues where these names would conflict with the type's own Get/Set methods
and these names have the added benefit of indicating a bit more that atomic stuff is going on.

Differential Revision: https://phabricator.services.mozilla.com/D99268
2020-12-09 18:14:55 +00:00
Alexis Beingessner
137f4e977f Bug 1670982 - Make the bitflags in CacheStorageService actually atomic. r=decoder,necko-reviewers,dragana,valentin
TSan found races on these flags that are ostensibly benign but this way there's no UB.

This code is a bit weird. These bitfields are seemingly pointless as
they're squeezed between a uint64_t and an Atomic<bool>. There's plenty
of space for 2 more bools there.

Also the Atomic<bool> could theoretically be merged into the flags. For
now, here's the version of this patch that preserves the semantics of
this code as closely as possible, for review by the code owners.

Differential Revision: https://phabricator.services.mozilla.com/D93416
2020-12-08 16:56:23 +00:00
Bogdan Tara
f121ad11ea Backed out 2 changesets (bug 1670982) for tsan xpc shell failures CLOSED TREE
Backed out changeset 3ce1e8c65cbc (bug 1670982)
Backed out changeset e7211a44d968 (bug 1670982)
2020-12-08 01:59:32 +02:00
Alexis Beingessner
d9f9c2427e Bug 1670982 - Make the bitflags in CacheStorageService actually atomic. r=decoder,necko-reviewers,dragana,valentin
TSan found races on these flags that are ostensibly benign but this way there's no UB.

This code is a bit weird. These bitfields are seemingly pointless as
they're squeezed between a uint64_t and an Atomic<bool>. There's plenty
of space for 2 more bools there.

Also the Atomic<bool> could theoretically be merged into the flags. For
now, here's the version of this patch that preserves the semantics of
this code as closely as possible, for review by the code owners.

Differential Revision: https://phabricator.services.mozilla.com/D93416
2020-12-07 18:32:51 +00:00
Simon Giesecke
de7bab0f06 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Honza Bambas
a14447a33a Bug 1642602 - Make about:cache show all entries, remove the no longer usable context switch UI, r=michal,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D81885
2020-07-03 11:41:53 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Honza Bambas
0aefd3e956 Bug 1487101 - Do not interrupt purging of HTTP cache entries from memory by frecency until the pool containts at most 2000 entries, r=michal,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80180
2020-06-19 05:43:42 +00:00
Honza Bambas
4f360112b6 Bug 1626809 - Sanitize HTTP disk cache storage context key to prevent leak of private data like URLs, r=njn
Differential Revision: https://phabricator.services.mozilla.com/D69625

--HG--
extra : moz-landing-system : lando
2020-04-09 12:38:09 +00:00
Simon Giesecke
aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Michal Novotny
5cd74804aa Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D62550

--HG--
extra : moz-landing-system : lando
2020-02-17 18:44:21 +00:00